summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-01-06loplugin:unusedfieldsNoel
Change-Id: I0599f33ef4c0070e6ce61b0041db074cce217349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-06elementary: tdf#139056 update GREEN color to follow upstream brandRizal Muttaqin
Change-Id: I077509af72c16b08be836baba6855ac1fd7ba070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108734 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2021-01-06elementary: tdf#138526 Add Formats Only paste iconRizal Muttaqin
Change-Id: I0fcb001e61a7ef68e4b502cb4ddcf8bfa56ce510 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108825 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2021-01-06uitest: sd: test rotate objectXisco Fauli
Change-Id: I3b4e8c4a0cfb29a42350de00b0086e407ac70946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108811 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-06ofz#29251 AbrtCaolán McNamara
Change-Id: Icf21642f61a3095b7f3dcb9392274e727e036956 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-05Update git submodulesBalaharipreetha Muthu
* Update helpcontent2 from branch 'master' to 225876e1e8422e640c8ac8439d040376e058a097 - tdf#86525 - Add 'Data Bar' section in conditional formatting Change-Id: Ia5baaa064a49ae80732399cc93e73f8c32e4bc8c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108697 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-05tdf#106380 sw AutoCorrect: track deletion at capitalizationLászló Németh
Deletion of the original lowercase character wasn't tracked during sentence capitalization, resulting broken change tracking data. Note: for similar potential problems, see FIXME at the end of DocumentContentOperationsManager::Overwrite(). Change-Id: If6ddbb77675d87eb126f7d3bf554b529892b88d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108670 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-01-05Fix duplicates in French autocorrectJulien Nabet
"oeil" was a duplicate for key and value, so one entry has been removed The other were key dups. For these I checked value appeared to know what key to keep and what key to change so there's no regression. Change-Id: Ic88d0034718bb21e4cab1cddf6cd07d26aca99e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108801 Reviewed-by: Sophie Gautier <sophi@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-01-05BASCTL : remove useless impl patternArnaud Versini
Change-Id: Ib3a3bfe8677a6eec56f6f1d799fd484f65ab6b73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-05tdf#139339 : Unify protect/unprotect cases for document protectionAnshu
Change-Id: I4bd3851d50a6215fef1f3ab722102adf6f44f10b Restored accidently missed lines for document protection in https: //gerrit.libreoffice.org/c/core/+/107041 Change-Id: I4bd3851d50a6215fef1f3ab722102adf6f44f10b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108541 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-05lok: add interaction handler "macro security" confirmationHenry Castro
When a client side request to load document with macros embedded, it will show the "Macro Security Warning" message dialog. Change-Id: Id848980a4fd3a5138bc98c43e57044f7d5ce3189 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108292 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-01-05jsdialog: use the "WindowShow/WindowHide" to notifyHenry Castro
If the "Macro Security Warning" message dialog is disabled the idle notifier, then it is used, the "WindowShow/Window Hide" events to notify client side. Change-Id: I48281cf5b76285a86f951eb057454610e266b85f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108290 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-01-05tdf#96678 Add accelerators to Font Effects tab pageGabor Kelemen
and remove some unnecessary mnemonic_widget associations Change-Id: I7bb8060598d4b76d0de6fef9a5dd8bf3d293bf89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-05drop unused suppressionsCaolán McNamara
Change-Id: I05bcaaf92586c36b7a3e70558a9ab7f35894eaa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-05ofz#29234 Integer-overflowCaolán McNamara
sc/source/core/tool/interpr1.cxx:9578:39: runtime error: signed integer overflow: 1 + 2147483647 cannot be represented in type 'int' Change-Id: I2975ae1daab826f10f0e52e7d7421ac8dcc9fffc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-05tdf#139394 XLSX export: remove extra quotation marksTibor Nagy
This fixes commit 583e2bfba2d72ac8afe7261c23f380daf5486889 (tdf#139021 XLSX export: fix "contains" conditional formatting). Change-Id: Idae3190b5f87dac551251da19c511f501bdaaa21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108452 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2021-01-05Fix typoTor Lillqvist
Change-Id: Ifd2c86564edd68d05d101899e0812bc0fcae7731 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108795 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-05lok: disable java interaction handlerHenry Castro
Unfortunately, when the client side shows the "Macro Selector" dialog, it tries to show a java interaction message box to locate the files of the JVM, even if the code explicitly option to not enable "DontEnableJava" Change-Id: I2ef4373f58c3ba23a5b86c5dc984caf6c10821ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108421 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-01-05Revert "NotifyClients no more"Stephan Bergmann
This reverts commit 96bafa464ebdbce3ef04bec9beae5e745bb37794. It started to cause an ASan heap-use-after-free during CppunitTest_sw_uiwriter, see the comments starting at <https://gerrit.libreoffice.org/c/core/+/108604/ 5#message-681a6100cff11cb51d20e5a2b2fb38da1f92ab32> "NotifyClients no more". Change-Id: Id0eef2e75ea047d4b337c51df929eea81fb69f5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108717 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-05lok: add global notifier to the "Macro Security Warning"Henry Castro
dialog. This message dialog is especial, because it is shown before loading the document so no way to get access to view shell notifier when the model/view/controller were not created. Change-Id: I5da3ca9d1009f174f2d96c1302770f4509a807cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108291 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-01-05lok: add missing global notifierHenry Castro
Occurs when server shows the "Macro Security Warning" before load the document if enable/disable macros, but there are no instances for document/view/controller yet. So it is required to use the global notifier so it can be sent messages to the client side using the JSDialog framework. Change-Id: I67f15b21cbaf21906b88145f3c5835cf0e1ff79d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108288 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-01-05tdf#138987 pyuno: PyEval_InitThreads is a no-op in Python 3.9David Ostrovsky
Change-Id: I220eecfa6aaf4d5cb12e3b4eacadf25843b41452 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108403 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-05cleanup: add warnings for unhandled cases for the SwTextBoxHelperRegényi Balázs
Change-Id: Idc62a8872cef89c5b3b45e9027718c1e61c5a910 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108076 Tested-by: Jenkins Tested-by: Balazs Varga <varga.balazs3@nisz.hu> Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu>
2021-01-05ofz#29219 Direct-leakCaolán McNamara
Change-Id: I190256bc9502d742ce182c0bef0698847fa77070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108673 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-05Simplify a Unicode string constructionStephan Bergmann
Change-Id: Iba8ecae2397a5de200e959f05f3f68ab0a7b4fd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108738 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-05tdf#129423: Make export tests export-only where applicableumutbayramoglu
Change-Id: I6bf5a62a0f2a8dd6852b59d26066d3169b0616b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107317 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-05jsdialog: direct updates for treeviewSzymon Kłos
We should use only weld:: interfaces methods to detect moment of control's updates as all the modifications goes through weld:: API. Let's use higher abstraction layer and not use vcl implementation details. this reverts partially: 32bfa0e1c7e859aedc3988d5bfdf86f5d7bab98a Change-Id: I2dd25c08dae3f5a95d077e2715788d636be47fe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108433 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-05notebookbar: add named ranges managementSzymon Kłos
Change-Id: I63c2589cd9ab7bfa3a10ea7f2d4729e1f715c92f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107531 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108657 Tested-by: Jenkins
2021-01-05fix typoXisco Fauli
Since 54f0ae24173a69d145e2ffc3aaa2f6bd29e39611 Change-Id: I556bea5e62819f6b6f375e868d212e45c6786064 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108669 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-01-05sw doc model xml dump: improve keep-with-next outputMiklos Vajna
From: <SfxBoolItem whichId="110" value="TRUE"/> To: <SvxFormatKeepItem><SfxBoolItem whichId="110" value="TRUE"/> Change-Id: I08f45e3481a5beebb4c1b8fcf0919741ad185e79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108687 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-05tdf#96505 : Get rid of cargo cult long integer literalsumutbayramoglu
Change-Id: I7b269fb5bafceba071ebe649a696ef61301c4018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107366 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-05SwClientNotifyCall no moreBjoern Michaelsen
- SwClientNotify calls really shouldnt happen from outside the class in the future - the few remaining legacy exceptions have been marked as friend -- admittedly ugly, but it reduces the scope of call being triggered from anywhere to a welldefined set. Change-Id: I46d5f755b0cf5de013a4c345a04e2c67447a99aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108651 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-01-05CGLayerHolder::getScale() can be constTor Lillqvist
Change-Id: I727b2b5f1035ae70d62d3c5339a814161e3ec92a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108663 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-05tdf#131427 Remove button "Texture, Shadow and Color" in 3D Effects dialogshubham656
Change-Id: I72146e7f3aac9b02c6fca2ae984e70e01d1c07fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108102 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-05Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 19c16ab2f12ea315fe96951023baab7c66495cbb - tdf#138301 - clarification of Data Validity example Change-Id: I20035ef3fad94c83ce06c8380f8c691cd85c7f83 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108714 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-01-05svx: pragma once in sdrgrafprimitive2d.hxxTomaž Vajngerl
Change-Id: I1288582aa751cc887f3fd3dcbcdc22bf3f188215 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108653 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-05tdf#138879: sw_odfimport: Add unittestXisco Fauli
Change-Id: Idbe6775dd00f985fbbf6d102e88e768edf2ad525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108667 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-04Don't use m prefix for a local variableTor Lillqvist
Change-Id: I73e106923d463215078a465f9ff933ea3c89255f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108665 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-04Removed duplicated includeAndrea Gelmini
Change-Id: I42aa81e60d9db8252428ec26999bcb1840b2c9e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108660 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-01-04Fix typosAndrea Gelmini
Change-Id: I1c43f0704dd7636f414ed7697b48f5092dc531c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108422 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-04sw: prefix members of SwCharRange, SwEmbedObjectLink, SwHolePortion and ...Miklos Vajna
... SwLineInfo See tdf#94879 for motivation. Change-Id: I6d397ea717161ad435af903cc236c87731f8a419 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108654 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-04lok: add lo_sendDialogEvent to post dialog eventsHenry Castro
When the "Macro Security Warning" is shown in client side, the model/view/controller are not created yet. It is necessary to create a function to posts a dialog event. Change-Id: I2bfc9edecc708dc79da575ea515e3144e78c10e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108293 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-01-04mbstowcs failure check is only relevant for non-_WIN32 nowStephan Bergmann
...after cbe9a0a815e4a73bf8db425a7c5c651e67b2ed65 "Use Unicode paths on Windows for pyuno" Change-Id: I898ee8ebbc1dfb215c55940c6336756ae7b5ccc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108658 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-04drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for cui part b including removal of strange empty "align12" which shared cell of "shadows" in borderpage.ui Change-Id: I9ed043367a0e3474a215b5dc0af3dd1bd296e54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-04Fix comment: Division, not multiplicationTor Lillqvist
Change-Id: I901721f18f5e536bcf7c59e08b0a0f66ccfc6190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108672 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-04loplugin:stringviewparam: operator +=Stephan Bergmann
Change-Id: I30ce1b5bd8fb168da7067c1967c5af2569df2653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108512 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-04lok: don't log warningsSzymon Kłos
Change-Id: If0ecee7d01eb0efc8b1096a9097c7d0d7ef0fd27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106129 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108655 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-04notebookbar: add pivot table section to tab dataSzymon Kłos
Change-Id: If770155d5246c8697bb72db957b2b13e1501263f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107193 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108656 Tested-by: Jenkins
2021-01-04Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to 9c9690285ccb3e2116626b84f6747f9f71d35b20 - "page fields" in pivot table have been renamed to "filters" Change-Id: I4b13bdbb91e5953833a518a5068b7db45147a3ea Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108447 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-04tdf#120171 editeng: don't reduce nBreakPosMark Hung
even if it is greater then nMaxBreakPos. The only situation that happens is when there is a hanging punctuation. Reducing nBreakPos to nMaxBreakPos always break that punctuation to the next line. Change-Id: Ie4b61d21f4d8f6f874e2a969260c13a3bca2a049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108594 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>