summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-02-15Add a FIXME noteTor Lillqvist
Change-Id: Iedda7ca9cff1bda763845e665e0e21656b253793
2019-02-15Interpret the parameter of WordBasic.FileClose() more correctlyTor Lillqvist
In particular, the value 2 means "do not save". Change-Id: I9788d201f8ecfcc016a12aa2088552ee994e1c17
2019-02-15loplugin:flatten in sd/source/ui/frameworkNoel Grandin
Change-Id: Id1da25f6ee6ee867e93e0b4c58b6429e07b12429 Reviewed-on: https://gerrit.libreoffice.org/67834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/funcNoel Grandin
Change-Id: I1d5d3ea51d012ade653aef70a17f2c173d31d3b9 Reviewed-on: https://gerrit.libreoffice.org/67833 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15CppunitTest_sw_layoutwriter: disable testBtlrCell() on Windows, tooMiklos Vajna
Till it's clear why it has unexpected values. Report from mailing list: > Test name: SwLayoutWriter::testBtlrCell > equality assertion failed > - Expected: 2707 > - Actual : 2710 > - In <>, attribute 'y' of '//textarray[1]' incorrect value. Change-Id: Ic914f513df544dcf472b0870a3936f87d876c76b Reviewed-on: https://gerrit.libreoffice.org/67856 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-15xmloff: create XMLImpressStylesExportOasis instances with an uno constructorMiklos Vajna
Change-Id: I831321bcce241bc180e22b20364137f776fee0f9 Reviewed-on: https://gerrit.libreoffice.org/67847 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-15loplugin:flatten in sd/source/ui/slidesorterNoel Grandin
Change-Id: I001e0957dafee168bb997a0673be64b2e92cb658 Reviewed-on: https://gerrit.libreoffice.org/67830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15Format anchor.cxx with clang-formatSamuel Mehrbrodt
It has nearly correct formatting already, lets keep that. Change-Id: I0b3b7baf69655cb3241ba039b181b0d8262a3f55 Reviewed-on: https://gerrit.libreoffice.org/67845 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-15tdf#122982 Remove image from cell when cutting the cellSamuel Mehrbrodt
Change-Id: Idd73dcc88a8cd76eb4011bb26efdd5c712d16e5e Reviewed-on: https://gerrit.libreoffice.org/67844 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-15loplugin:flatten in sd/source/ui/sidebarNoel Grandin
Change-Id: I1a636fdfc505e7927b8833ad55110f6ed8fe360d Reviewed-on: https://gerrit.libreoffice.org/67832 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/slideshowNoel Grandin
Change-Id: Id820f0f7ac51928ba1a783615c3e9d6c268affdd Reviewed-on: https://gerrit.libreoffice.org/67831 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/[t-u]*Noel Grandin
Change-Id: I6db7c26c9534b249a38cec96f3875f808702a598 Reviewed-on: https://gerrit.libreoffice.org/67829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/viewNoel Grandin
Change-Id: I28e75ec162cde89fe1aa7d85aecce7ce80878d88 Reviewed-on: https://gerrit.libreoffice.org/67828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15tdf#97575 Chart OOXML: Export ShapeProps of Error BarsBalazs Varga
Export the shapeProps (fillstyle, linestyle, linewidth, linecolor etc.) of the Error Bars to OOXML. Change-Id: Iff74fa463fdd0fb6ed95e4d1bf0d3e906349860c Reviewed-on: https://gerrit.libreoffice.org/67825 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-02-15Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I81d83b9053329a19af4f478d21f8c452dcf39538 Reviewed-on: https://gerrit.libreoffice.org/67849 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-14weld ScDPNumGroupDlgCaolán McNamara
Change-Id: I5f5861a1f39307133f4c87e4d5ca50ced24409ba Reviewed-on: https://gerrit.libreoffice.org/67813 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14Resolves: tdf#123426 don't reformat tabstop pos while editingCaolán McNamara
we want to know what it would format as, but we don't want to do the formatting during typing Change-Id: I817798adf5b3f9325682f43b92fe107659803b4f Reviewed-on: https://gerrit.libreoffice.org/67819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14buttons are at the wrong endCaolán McNamara
Change-Id: Ie4c2c017d2e4426f5b4ad06e4318b439d1aac1a4 Reviewed-on: https://gerrit.libreoffice.org/67839 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14cleanup of PngImageReaderTomaž Vajngerl
Change-Id: Ifa5efe5fab644f1c684ada3f6cd46e19c002d7ca Reviewed-on: https://gerrit.libreoffice.org/67842 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-14uitest for bug tdf#122398Zdeněk Crhonek
Change-Id: I47e7df381d7bb03c27833b37234471a746212f12 Reviewed-on: https://gerrit.libreoffice.org/67826 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-02-14sw btlr writing mode layout: fix baseline offsetMiklos Vajna
The problem was that the x position of the btlr text had a 159 twips difference (it was too close to the cell border), since the text portion height -> baseline offset calculation worked with the descent, not with the ascent. The position of the text now matches exactly what Word does. As a side-effect this means that multiple portions in a line and also multiple lines in a text frame now work correctly. Change-Id: Ic139db328e2a913e5cae4026886c3410cdab357d Reviewed-on: https://gerrit.libreoffice.org/67823 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-14don't need a special function to get the BlueOrIndex colorTomaž Vajngerl
Change-Id: Idee5a82f8b69a25afa603ce8743d071d0093d617 Reviewed-on: https://gerrit.libreoffice.org/67824 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-14move pngwrite/pngread to vcl/filter/pngTomaž Vajngerl
Change-Id: Ib6bf092854208eea5257c357850213815639968c Reviewed-on: https://gerrit.libreoffice.org/67821 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-14impress remote provides a dialog, so add ellipsisCaolán McNamara
Change-Id: Ied8f72a8d53e44cd216e4d9792826fbf2c5cff12 Reviewed-on: https://gerrit.libreoffice.org/67827 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14weld MoreOptionsDialogCaolán McNamara
Change-Id: I2fd6ffcbd03e1b797634bdb4646f1951cd665a1c Reviewed-on: https://gerrit.libreoffice.org/67810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Mute l10n for python uncomented code lines Change-Id: Ia5bc3debed55813c9481acf360b96731266e7000 Reviewed-on: https://gerrit.libreoffice.org/67822 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-14drop unneeded vcl includes, update pchCaolán McNamara
Change-Id: Idd2c4a812a9415c816427f8566d9e7159b4dd2a6 Reviewed-on: https://gerrit.libreoffice.org/67806 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14weld MacroSecurity clusterCaolán McNamara
MacroSecurity, MacroSecurityLevelTP and MacroSecurityTrustedSourcesTP Change-Id: I0c3494a051cdac2723710484d5e00146d3f3dfe7 Reviewed-on: https://gerrit.libreoffice.org/67797 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14weld DigitalSignaturesDialogCaolán McNamara
Change-Id: I197f4805558b07aeb9e66734d0fb5c250c41ad3e Reviewed-on: https://gerrit.libreoffice.org/67796 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14sw btlr writing mode: add odf spec proposal URLMiklos Vajna
Change-Id: I7848677cf4c8246fc7a1833bec809945fb541b29 Reviewed-on: https://gerrit.libreoffice.org/67814 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-14no usable KDE5 on gandalfMarkus Mohrhard
Change-Id: I3a9b2ff1fa24ea4d28b29644d6bf6519fdb1909c
2019-02-14tdf#42949 Fix IWYU warnings in cppuhelper/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I0eebd82b96d630da0597166cf87d398072607c13 Reviewed-on: https://gerrit.libreoffice.org/67473 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Python: improve navigation between Help pages add links between python pages add links from Contents section Change-Id: Ifc6704862c8213008eeb5d6e6baf86aa7c7be50b Reviewed-on: https://gerrit.libreoffice.org/67778 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-14Update git submodules--author=Alain Romedenne
* Update helpcontent2 from branch 'master' - Python: Help page for module import Change-Id: I35ce948bbd0abcb2daeb272fe4d436cd05bb24ed Reviewed-on: https://gerrit.libreoffice.org/67773 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-14weld ScDataBarSettingsDlgCaolán McNamara
Change-Id: I491975a5e222625fdabb6b6ffc9ea98e7a04a718 Reviewed-on: https://gerrit.libreoffice.org/67811 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14weld CertificateChooserCaolán McNamara
Change-Id: I46087a58d5cff7ea8ac86ef8ee670cc4a59d0120 Reviewed-on: https://gerrit.libreoffice.org/67795 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14VisualStudioIntegrationGenerator: put CXXFLAGS to AdditionalOptionsMike Kaganski
Adding AdditionalOptions to nmake project settings allows IntelliSense to know about used compiler switches; specifically, passing std switch (currently -std:c++17) defines _MSVC_LANG macro [1] to proper value to avoid false IntelliSense errors (e.g., for string_view). [1] https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros Change-Id: I90309e6bf2a87257a0c81b1406e678af962eb587 Reviewed-on: https://gerrit.libreoffice.org/67805 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-14tdf#123439 Assert wrt PointerStyle fails when moving cursor over toolbarNoel Grandin
regression from commit a2b687a88feedfae0087bfc999b3cf49b9d3d24b Date: Tue Feb 12 10:12:03 2019 +0200 Pointer is pointless Change-Id: I727e68c71f4ebacb9adae83f1f9b43ce999d5374 Reviewed-on: https://gerrit.libreoffice.org/67803 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-14vcl: test rendering of bitmaps with alphaTomaž Vajngerl
Change-Id: I6fde9581793fe85fc30d0660de3d62f0ddbfe9fd Reviewed-on: https://gerrit.libreoffice.org/67807 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-14Update git submodulesMiklos Vajna
* Update helpcontent2 from branch 'master' - sw btlr writing mode: add documentation for this And also update the bookmark after core.git commit 081b753d4cb4f4a25073ca7de12a7bdaa9fc2be4 (sw btlr writing mode: add UI for this, 2019-02-13). Change-Id: I130f1ddcd6e4f37cea38b8adddf7b60f953382ca Reviewed-on: https://gerrit.libreoffice.org/67809 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-14[API CHANGE] add setParentWindow to XDocumentDigitalSignaturesCaolán McNamara
so we can specify which window modal dialogs are modal to Change-Id: I7cd7348b5cd0f55d698553f313f745d5e0d6389d Reviewed-on: https://gerrit.libreoffice.org/67765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14CppunitTest_drawinglayer_border: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: I73f00a0cc052173167a539be02a42c47da34dd98 Reviewed-on: https://gerrit.libreoffice.org/67793 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-14Sifr icon theme sc_ icon updateandreas kainz
Change-Id: Ic3bb6bdd3294ed532a72166490ba255a29c96e40 Reviewed-on: https://gerrit.libreoffice.org/67798 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-02-14getToken() already returns an empty string if index is negativeMatteo Casalin
Change-Id: Ibb9e866cc0a84973ee950630273f229362cb1bb6 Reviewed-on: https://gerrit.libreoffice.org/67635 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-14No need to downcast integer type hereMatteo Casalin
Change-Id: I99ed9bf6443c8b3c08d9ee45d171751d603c1125 Reviewed-on: https://gerrit.libreoffice.org/67633 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-14Use indexed getToken()Matteo Casalin
Change-Id: Iee411b9f8af7f123d0b13051ba6266d65ebb10ac Reviewed-on: https://gerrit.libreoffice.org/67622 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-14Use indexed getToken()Matteo Casalin
Change-Id: Ibf8a644c1d61516caa67e0ce22b33a41380d9911 Reviewed-on: https://gerrit.libreoffice.org/67621 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-14Removed executable permission on docx fileAndrea Gelmini
Change-Id: I9908b65280ae4e468a73932e9e560e8a4b0f01f4 Reviewed-on: https://gerrit.libreoffice.org/67799 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-13remove GetLuminance from BitmapReadAccessTomaž Vajngerl
It's not really that important shortcut function as the function is used only twice in the whole code base. Change-Id: Idf25ded6320f766bc66beec0ee272a62765303ba Reviewed-on: https://gerrit.libreoffice.org/67792 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-13Improve the algorithm of disabled image creationTomaž Vajngerl
Main change is to not change alpha channel at all. For RGB channels, calculate the luma value and map the value into 160-224 range. Much simpler and better result. Change-Id: Ied108c2135f98d78f230a2c0b305bd3396d9ccfd Reviewed-on: https://gerrit.libreoffice.org/67791 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>