summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-10-27Bump version to 22.05.20.1cp-22.05.20-1Andras Timar
Change-Id: I5bf4cf9b14f2b54cd61f8de20d350973b5f483dc
2023-10-18sc: ui: fix cell bidi layout stringsHenry Castro
The default constructor OutputDevice set the layout text to "vcl::text::ComplexTextLayoutFlags::BiDiRtl" for all strings, however the each cell string can be mixed LTR and RTL. Set the defaults to auto detect the correct text layout mode. . Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I0c451e8014fd13490db4213adca3d83ea4572819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157831 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit f63e02b99691a0d8c8addba2518ecdf6b4319c52) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157952
2023-09-25lok: add broken package interaction handlerSzymon Kłos
in case of repair don't use template flag to not make file readonly so we can overwrite it and upload to storage updated version Change-Id: Ia460009fc3b77582dde06dd6f94a85aef3aee11b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157168 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157240
2023-09-18Schedule conditional formating repaint after filtering is completedcp-22.05.19-1Szymon Kłos
When we have sheet with lots of data with applied conditional formatting and that data is used with autofilter feature - filtering is very slow. That was caused by repaints synchronously called on every row show/hide. ScConditionalFormat::DoRepaint() called by ScFormulaListener callback ... ScDocument::Broadcast ScColumn::BroadcastRows ScTable::SetRowHidden ScTable::DBShowRows This patch schedules repaint in the Idle so we do that after all changes are already applied. Change-Id: If0876ada0f336a41b69560db6a581d6e24d7ac16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156897 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit c838c24a7e1eee9709789aab99b242f0a0c8c419) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156969
2023-09-17Bump version to 22.05.19.1co-22.05.19-1Andras Timar
Change-Id: I14db135059e397878556a7214c21a439ac175078
2023-09-14tdf#157231 CVE-2023-4863 upgrade to libwebp-1.3.2.tar.gzCaolán McNamara
Change-Id: Ib60466a59069b59fa884654167f33ccc58e59330 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156907 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-09-11lok: save to xlsx changes column sizeSzymon Kłos
When xlsx spreadsheet was opened in LOK on every save default column width was decreased. This doesn't happen in non-LOK case. Column width in Excel are defined by double value which specifies number of '0' characters which fit into the column. On export we use mnCharWidth from XclRootData to convert Calc twips size to number of characters. In LOK case it was 102 while in non-lok case 101. It was caused by different Reference Device used in ScDocument::GetRefDevice() because in LOK case we are in WYSWIG mode as introduced in ScModelObj::initializeForTiledRendering in commit c25062f: sc tiled rendering: Don't adjust the text width according to printer. Let's use for export purpose the GetVirtualDevice_100th_mm() Change-Id: I6709194d7924e8c7e0aaa75ff3901afbcc1f8c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156576 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156750 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-09-11tdf#157136: apply top context properties to the text input fieldMike Kaganski
Change-Id: Ie3877811e482c1ec395a00ec6bf67155220b2b64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156675 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156729 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-23crashtesting: keep a reference to the passed in LibXSLTTransformerCaolán McNamara
otherwise, as seen with: soffice --headless --convert-to docx forum-mso-de-42789.docx and error will notify the other thread that the load has ended and the other thread will destroy the passed in LibXSLTTransformer early while this thread assumes it continues to exist Change-Id: Ieea9ecc3439ea73cd0433e5e12b87811906c49aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137819 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit fafe00bb7d72d6d4bec663b40a4cd92e50f33f0f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156013 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-08-14lok: use constant keys enumerationHenry Castro
Useful to better readability code. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I335d010c3b1ddf3f8052b7ed6cb0f94ad20045f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155495 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155633
2023-08-14tdf#155799: sc: qa: add unit test "testMouseMergeRef"Henry Castro
Change-Id: I2e46a014a3a66fe41b06a07a68c75e52ae5530f6 Signed-off-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155005 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155632
2023-08-14tdf#155799: sc: qa: add unit test "testKeyboardMergeRef"Henry Castro
Change-Id: I4d80ad5d9e5fe2c131f9397ec59c6c16ef92c094 Signed-off-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155004 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155631
2023-08-14tdf#155799: sc: add getter function "GetEditString"Henry Castro
Useful for QA test queries. .. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ibd3c902405f478032447b10286a788cd0769c855 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155001 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155630
2023-08-13Bump version to 22.05.18.1cp-22.05.18-1Aron Budea
Change-Id: Ibf1268c93fb83561e3e87ef5899c908ef8a9f59e
2023-08-12tdf#155799: sc: fix input formula referenceHenry Castro
If the start point reference mark is selected with mouse direction up, it should extend to show the correct input formula reference. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I41f2ea52bf7de341eccadfba80e91fd76a6fd2de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155618 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155593 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-08-11tdf#155799: sc: fix formula reference "key up"Henry Castro
When the formula reference mode is active and it process the keyboard event UP, it should decrease -1 according the merge attribute row, col span. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I278bcd9d52caeb09e4a47336af8c8e9b522397c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154999 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155628
2023-08-11tdf#155799: sc: abstraction "moveRefByCell"Henry Castro
... Change-Id: Ib00e3cddcd4a5dc4ef3d74d3939cdf278f2cb44d Signed-off-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154998 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155565 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-08-11tdf#155799: lok: sc: fix extend reference markHenry Castro
In the tiled rendering case, the server sends a reference coordinates to client side, so extend the range end point reference if merged cells. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ie9611aea3f6645a6cf45514939ae6364afac0b1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155564 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit edbf070a6bb6aacfb277140457cf21036b5239e9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155590 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-08-10tdf#155799: sc: fix paint the reference markHenry Castro
If a reference mark is initiated with the first click, the initial range points are the same and extended if merged cells, but if the user drag&drop more cells the Range end has to extend if merged cells Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ife7c4514a9303226b73bff61bd0df689f81af42f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155533 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit ebd1a4d6fc3f9ba533a29fa54acf7b3b41c398d5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155485 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-08-10tdf#155799: sc: fix "UpdateRef"" to update extended merged cellsHenry Castro
Extend the merged cell if the current has the attribute "Merged". ... Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ia2d5983d89b8661abb683d10d4de8bd0c5adea7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154993 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153406 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-08-04lok: sc: fire "hyperlink clicked" eventHenry Castro
The client side has changed the behaviour when the HYPERLINK formula is clicked, usually in desktop is fired with Ctrl + Mouse Click, now it is fired with Mouse Click. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I08d41170714588d9ee84475991757d8be9b01f07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155270 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155352
2023-07-17tdf#156287: don't try to move objects to pages other than their anchorMike Kaganski
Objects may have offset moving them outside of the current page, where their anchor is. This doesn't mean that they would move to another page, just that they will be clipped. Without this taken into account, objects which rectangle would be on another page, would trigger infinite loop because of their position invalidation in SwLayAction::FormatContent's cleanup code, where they will move to their correct page; and then their off-page rectangle would move them to another page again. Change-Id: I2b818403163041a49a3bc1640b1af9a1705fd671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154444 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 8fc1162d3e7f894adf225fa65ec09bbb83bb17fb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154451 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 25feffa49576564d7fe70fb20597855d33ac8492) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154465
2023-07-12Bump version to 22.05.17.1cp-22.05.17-1Aron Budea
Change-Id: I3e7103abfd2f54bc6be120d64a37e521fa876f39
2023-07-10lok: copy simple selection even when filteredSzymon Kłos
when selected cells contain data filtered with autofilter and regular cells after that - we get different type of selection called SC_MARK_SIMPLE_FILTERED allow copying that too Change-Id: I69f91a674f427a7b956fd87b8dc56937b3b55e86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154250 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com>
2023-07-10Update pdfium to 5778Miklos Vajna
- external/pdfium/abseil-trivial.patch is no longer needed, upstream does what we did previously - external/pdfium/build.patch.1: re-generate with 'patch -p1' + 'git diff' - external/pdfium/include.patch is no longer needed, upstream does what we did previously Change-Id: I39a6f721e436aa53914bbf43b78ac7d86e5eac59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152244 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit dc69e7c52f12f57197f26b56c968139186d4ed5b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153653 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154143 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-07-10Update pdfium to 5636Miklos Vajna
Some changes in the bundled libtiff, but it seems that would be for XFA which we disable, so it doesn't affect us. Change-Id: Ibadeecf20daec342fbfef6d1e89bd17f5f0095e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148652 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 47afcad0d599009c38b4597c27558ec2af58b7f8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153651 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154142 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-07-10Update pdfium to 5522Miklos Vajna
The internal libpng 1.6 is now dropped, but that doesn't really affect us. Change-Id: I777c024c76c17689c20bbe6453467ba5fb22baba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145417 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 04fd7d0f53faa08c608034707ca4a459a162712d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153650 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154141 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-07-10Update pdfium to 5408Miklos Vajna
- drop cg-instead-of-carbon.patch.1, no longer needed after https://pdfium-review.googlesource.com/c/pdfium/+/99753 - drop AndroidNDK19.patch.1, no longer needed after https://pdfium-review.googlesource.com/c/pdfium/+/96530 - drop gcc-c++20-comparison.patch, no longer needed after <https://pdfium.googlesource.com/pdfium/+/065698acf82962a3168a0d56bb1d5964bc593d00> "Fix interaction between RetainPtr<T> and transparent comparisons" since chromium/5321 Change-Id: I1f861dd8a3d490400bb39c108bd4e767a2f45d30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142474 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 5a69fd3052bb638857f30a4cfd5913634275d23d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154140 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-07-07sfx2: disable setting password on text documentsAshod Nakashian
Since we can't preserve the password in a plain-text file, we should disable the ability to set/change it. Otherwise, it's misleading to users. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: I3176243ddd2826eb07def1ff5ab251e33cb7125e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153918 Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-07-07-Werror,-Wunused-but-set-variableStephan Bergmann
...since 376cc3ea0fc2e0f209763a2a27c5852136332c86 "dbaccess: delete old paste autoincrement logic" Change-Id: I4ffa3ffbcc1b80091a4a3449362766334b31c5af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132229 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-07-07-Werror,-Wunused-but-set-variableStephan Bergmann
...since 0b6d0ac41afc72a0043e6ccdc6cdfd8648a5efdc "m_pRowMarker is unused" Change-Id: I68d23a11e4be814a23e8ede87723b9aba208b774 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132228 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-07-07-Werror,-Wunused-but-set-variableStephan Bergmann
...since 9e87a00e11486a2be64b0dc2799e3efca4b000cc "oox: replace PUT_PROP macro with comphelper::makePropertyValue() calls" Change-Id: Ic90e6e579e0d546454d2acd8c3fb5b5ac50f9f5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132223 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-07-07-Werror,-Wunused-but-set-variableStephan Bergmann
...since its uses got commented out with a9cc0100645deea53f27e35c7e754c9f062680d8 "chart2: Weld ChartTypePanel" Change-Id: I5296ba7ed746df13e8174063f148ff2ce970756c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132224 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-07-07-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter" Change-Id: Ia01b618c57318657976372257ea37ed2b1b354b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132212 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-07-07-Werror,-Wunused-but-set-variableStephan Bergmann
...since 35dce7a06088386f13636bc355bc35e93be6ba5d "INTEGRATION: CWS warnings01" Change-Id: Iaae91d7792348d0bf61173c5839295c8aa1b938f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132225 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-07-07-Werror,-Wunused-but-set-variableStephan Bergmann
...since 8e73111faeb9620117801fee89a838a407f0b7e5 "CWS-TOOLING: integrate CWS ab72" Change-Id: Ib2fdccc36090d366ca2288b31bd1948832366c95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132210 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-07-07-Werror,-Wunused-but-set-variableStephan Bergmann
...since fb6c99f21e03afb85d00459ca1e1abb07e71d126 "loplugin:unuseddefaultparam in svtools" Change-Id: I08da150389bfe8dad09ca293a8f445020c3a51ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132208 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-07-07tdf#155796 sc: fix select with merged cellsJaume Pujantell
When selecting multiple cells or modifying a selection with shift+arrow make sure that a merge group is never partially selected. This also fixes tdf#128678 Change-Id: Ida00939cec11240c0d06375feb21afa82a6876da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154048 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
2023-07-04external/libnumbertext: Silence -Werror,-Wdeprecated-declarationsStephan Bergmann
...as seen now with LLVM 15 trunk libc++, which marks the std::codecvt_utf8 and std::wstring_convert functionality, deprecated since C++17, as such (<https://github.com/llvm/llvm-project/commit/3ee9a50a146c585fc92f79e742c538261f98bd4e> "[libc++] Implement P0618R0 (Deprecating <codecvt>)") Change-Id: Id34e3fea540b76591ead8ba3df4c31a71d7b4aaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136776 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit e37e1a7d2007bd6896027b69271774da2568e6f8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153935 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-07-04Fix buildAron Budea
sc/source/ui/app/inputwin.cxx: In member function ‘virtual bool ScTextWnd::Command(const CommandEvent&)’: sc/source/ui/app/inputwin.cxx:1739:22: error: unused variable ‘pParaPoint’ [-Werror=unused-variable] 1739 | const Point* pParaPoint = static_cast<const Point*>(rCEvt.GetEventData()); | ^~~~~~~~~~ sc/source/ui/app/inputwin.cxx:1740:15: error: unused variable ‘aSelectionStartEnd’ [-Werror=unused-variable] 1740 | Point aSelectionStartEnd = rCEvt.GetMousePosPixel(); | ^~~~~~~~~~~~~~~~~~ After ea846af14bffc9f48862c39e6232f188df4bbe62. Change-Id: Ica1a1a8985a3fdfc2fbd38652f687bf0d8c5fc36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153934 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-07-03lok: formulabar: use IME also on desktopSzymon Kłos
this makes selection always on the end of content so we can remove not matching last X chars and append new content easily Change-Id: I75cbf59f2a536f0e7969409325ac6d549046ef06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153718 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-06-30-Werror=dangling-referenceStephan Bergmann
In <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=d2249cd9adf5ae638577139177a50f7e62d8abd9> "c++: Implement -Wdangling-reference [PR106393]" grew a new warning, included in -Wall, and based on some more-or-less shaky heuristics, that warns about "possibly dangling reference to a temporary". It produces quite a number of false positives, but for these uses of SfxItemSet::Get it does look plausible that the returned item references could, at least in theory, point at data that is destroyed along with the temporary SfxItemSet. Change-Id: I11afc4512db488f73170c6cfa706e9e094209550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142217 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit e0121b2478526d803681d57d59af0cbf9cf602b4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153583 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-06-29sc: filter: oox: fix crash delete ScDatabarFormatDataHenry Castro
Unfortunately, the instance of "ScDatabarFormatData" is deleted before finalizeImport is called. The "maEntries" is not usable, the global format buffer is required to hold the reference. #1 0x7f2ef19081c0 in oox::xls::CondFormatBuffer::finalizeImport() co-23.05-asan/sc/source/filter/oox/condformatbuffer.cxx:1322:23 #2 0x7f2ef1b9999a in oox::xls::WorksheetGlobals::finalizeWorksheetImport() co-23.05-asan/sc/source/filter/oox/worksheethelper.cxx:942:22 #3 0x7f2ef58d030e in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) co-23.05-asan/sax/source/fastparser/fastparser.cxx:910:36 #4 0x7f2ef23f0e46 in oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource const&, bool) co-23.05-asan/oox/source/core/fastparser.cxx:121:15 #5 0x7f2ef23f1544 in Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ieb3840cc10372867d5462a19d9efa9771f633437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153622 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-06-28Bump version to 22.05.16.1cp-22.05.16-1Aron Budea
Change-Id: Ib1b7b82830a8d99056c6044557555c306976aeb4
2023-06-28avoid some UNO queryingNoel Grandin
Change-Id: I5fa793ab979221252f66bdd38e6950c06a66b00a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152601 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153587 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-28sort row-range-stylesNoel Grandin
which reduces the amount of data-movement we do in the following loop when inserting into the sorted_vector. Shaves 2% off the load time of a large document with lots of styles. Change-Id: I8df4cc35edcc212613068af108b136c2d5acd219 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152600 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153586 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-28remove unnecessary ScPatternAttr copyNoel Grandin
slightly speeds up loading document with large number of patterns Change-Id: I1b82145fb0f8a62da0d5a46a43594f7085ce2c22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit c01fa7ff3bcd3447ea190bcc1833beb7c48a8803) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152535 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153585 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-28ofz#49713 Heap-use-after-freeCaolán McNamara
the dtor of ScAttrArray where the std::vector<ScAttrEntry> ends up will call ScDocumentPool::Remove on each entries pPattern, assuming that a matching ScDocumentPool::Put was called on each, something that is elided if we just do a simply copy here. probably a problem since: commit dddee125cc32f1ad5228e598a7de04e9654e65c1 Date: Thu Mar 10 15:03:25 2022 +0100 load ods/xlsx with full row attributes without allocating all columns Change-Id: I3a5e2e3fa4d40343f30f9eefbabd1579d8a97e02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6c81a09e3ef239a2d7a991d00fe3620a67298b99) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153584 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-28sc: perf: speedup sheets with lots of repetitive...Dennis Francis
row styles using a small cache of already allocated patterns that are tied to extended format id and number format id. Change-Id: I3136aef9a034635924f7b7b6d2432f9ae5c2bd15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152692 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153588 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-28tdf#153466 PPTX import: fix "Custom position/size" background imageTibor Nagy
Custom sized background with the value "tile" was imported as "stretched", losing the preset size. Restore also the exported preset positions, and map the other values to the preset positions supported by OpenDocument/Impress. Follow-up to commit 11451781d4c562f506a3aae3732e35b92387b4db (tdf#153105 PPTX export: fix "Custom position/size" background image) Change-Id: Ibf9b487ecd31b3ad7b06bda668c51e6b7a98c4af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148482 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153581 Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
generated by cgit (git 2.34.1) at 2024-06-30 20:19:24 +0000