summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-10-13Fix typoAndrea Gelmini
Change-Id: Ia4d7dd731e24c89c3228fdaf18cc0558a9c5ee66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141311 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-13Fix typoAndrea Gelmini
Change-Id: Ie04728548d82e6eb5b0d46e65c279dcda5442bf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141309 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-13Fix typoAndrea Gelmini
Change-Id: Iff1adef6278239436bbaabd619ed12648d0819df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141305 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-13Fix typoAndrea Gelmini
Change-Id: Ib12fdce5b4a46ec98828aeba6a293ca3a3e1c766 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141312 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-13CppunitTest_sc_macros_test: improve setup/teardownXisco Fauli
Similar to 8b4ac8c35d5e4efe3c0b83e15543a35213e786f2 "improve setup/teardown handling in VBAMacrosTest" Change-Id: I34b64a72f6cab1f85e6e2628b6fd07f408f62cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141302 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-13tdf#124098: sc, ods import: do not recalculate row heightsBalazs Varga
if we have already optimal heights in the xml, because it is not necessary and it takes a lot of time loading a file. Citing here for completeness: a) if there is no height attribute and the "use_optimal-row-height" attribute is set then calculate the row height b) if there is a height attribute just use it and do not recalculate. Maybe TODO for later: optimize row height calculation more in sc Change-Id: I9d964aad744970e5d36f239c0ce39ce98c00f273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141204 Tested-by: Jenkins Tested-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2022-10-13tdf#151417: sd_uiimpress: Add unittestXisco Fauli
Change-Id: I8f5f957557612ce78036d962968a3e9fef113cf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141291 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-13tdf#120326: properly prevent Windows from entering power savingMike Kaganski
The previous call to SystemParametersInfoW with SPI_SETSCREENSAVEACTIVE only prevented screen saver from running (which is not often used these days), but screen was still turned off (and power saving was started). Despite SetThreadExecutionState documentation [1] claims that it does not stop the screen saver from executing, my experiments show that it does (on my Windows 10). So just use it, because it is designed exactly for this task (documentation discusses the presentation applications). [1] https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-setthreadexecutionstate Change-Id: I6eced8f0a7c17211a0b68851a40227eed9a22b1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141289 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-13crashtesting: uncaught exception on export of forum-fr-20226.sxi to pptxCaolán McNamara
due to not-found wav file linked to from presentation Change-Id: I48c7b4615d660a2a292feea36e228237235ab04f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141294 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-13tdf#143123 port DocumentHandling examples to PythonChenxiong Qi
This port keeps the similarity with Java ones as much as possible. examples.html is also updated by adding the Python examples. Signed-off-by: Chenxiong Qi <qcxhome@gmail.com> Change-Id: I2af26aaf42f5408bf254a4e0507442200f843661 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139887 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-10-13Adapt CompilerTest_compilerplugins_clang to recent ClangStephan Bergmann
...where at least my recent Clang 16 trunk build now started to fail after af2879e434fa0dc6b2a626617ed865e4f66eb5ad "Deduplicate stringconcat more" with > error: 'error' diagnostics expected but not seen: > File compilerplugins/clang/test/stringview.cxx Line 171 (directive at compilerplugins/clang/test/stringview.cxx:170): instead of an '{{(rtl::)?}}OString' constructed from a 'OStringConcat<rtl::OString, rtl::OString>' (aka 'StringConcat<char, rtl::OString, rtl::OString>'), pass a 'std::string_view' via 'rtl::Concat2View' [loplugin:stringview] > File compilerplugins/clang/test/stringview.cxx Line 196 (directive at compilerplugins/clang/test/stringview.cxx:195): instead of an '{{(rtl::)?}}OUString' constructed from a 'OUStringConcat<rtl::OUString, rtl::OUString>' (aka 'StringConcat<char16_t, rtl::OUString, rtl::OUString>'), pass a 'std::u16string_view' via 'rtl::Concat2View' [loplugin:stringview] > error: 'error' diagnostics seen but not expected: > File compilerplugins/clang/test/stringview.cxx Line 171: instead of an 'OString' constructed from a 'OStringConcat<OString, OString>' (aka 'StringConcat<char, rtl::OString, rtl::OString>'), pass a 'std::string_view' via 'rtl::Concat2View' [loplugin:stringview] > File compilerplugins/clang/test/stringview.cxx Line 196: instead of an 'OUString' constructed from a 'OUStringConcat<OUString, OUString>' (aka 'StringConcat<char16_t, rtl::OUString, rtl::OUString>'), pass a 'std::u16string_view' via 'rtl::Concat2View' [loplugin:stringview] > 4 errors generated. > make[1]: *** [solenv/gbuild/LinkTarget.mk:337: workdir/CxxObject/compilerplugins/clang/test/stringview.o] Error 1 Change-Id: I0b8c7d4a012c40c2c2c3cc8a9e55c52f45e8cfc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141295 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-13sw: improve duplicated bookmarks in copied header/footer textMiklos Vajna
Bookmarks in copied text were renamed in a way that made it hard to differentiate between the original bookmark and the copy, e.g. "Bookmark 1" was renamed to "Bookmark 11". Bookmarks are supposed to have a unique name, so renaming makes sense, and it's probably better to do that compared to what commit 3ec224dcb15e0e663ba85077b8ea0e632f8f03f8 (DOCX import: avoid duplicated bookmarks in copied header/footer text, 2022-09-08) did to just omit them during copy. That solved the duplicated bookmarks, but if one had bookmarks around images to find them, now it doesn't work to find all such images. Fix the problem by going back to copying bookmarks, but copy "Bookmark 1" as "Bookmark 1 Copy 1" (and "Bookmark 1 Copy 2", etc), so API users can identify the original and the copied bookmarks. A similar problem is there for images as well, but that's not yet addressed here. Change-Id: Ic0689b05f790a99ff06523ff4836b1dd412af896 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141293 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-10-13tdf#150664 Initialize input line correctlySamuel Mehrbrodt
Initialize code was not called when xlsx file was loaded (line count is only stored in ods format). Change-Id: I5b01f6079921af77ffd6da09ae5d5388b8beff1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141281 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-10-13tdf#150622 use high contrast selection fg/bg colors for text selectionCaolán McNamara
with SettingsForSelection SettingsText -> HighlightTextColor SettingsFill -> HighlightColor SettingsLine -> HighlightColor Change-Id: Iaac5834ce0f8b3f1b89376711b564773cfd0bfe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-13use OutputDevice clipping if its just a set of rectanglesCaolán McNamara
Change-Id: I249866d1aef29d256439c0437835a173d8a4c633 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141286 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-13tdf#145871: sw_odfexport2: Add unittestXisco Fauli
Change-Id: Ic473fa92b37ea1024ed5021ed6b59079d455c87c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141285 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-13tdf#125363, tdf#123095 - Use CaseTransliteration for autofilterAndreas Heinisch
Change-Id: Ib6f1edebe26a69d3316a901e00d2bc6e0c66695f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141047 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-10-13tdf#151375: sw_odfimport: Add unittestXisco Fauli
Change-Id: I702059fcfc8e99b11412f959bc924af73780d351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141284 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-13tdf#151502 Sifr: Wrap in image propertiesRizal Muttaqin
Change-Id: Id33a3293349ca3dba6263b2d626acdf9748987bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141282 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-10-13rearrange node logic hereNoel Grandin
so we don't have to touch SwPosition.nContent. Part of the process of hiding the internals of SwPosition Change-Id: I02fed4998b68edaca4ef3014bc64cca85af7fcdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141279 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-13tdf#151424: chart2_xshape: Add unittestXisco Fauli
Change-Id: I2570815857fd170d9511ad507b17b102ca8ddabf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141283 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-13tdf#150622 allow use of selection color for frame in HighContrast modeCaolán McNamara
Change-Id: I0a45051c9ba8bbfe785689103c6af6285a282345 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141261 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-13split frame into a separate overlay objectCaolán McNamara
Change-Id: If07591ba27cb8ebfdf9c737e7a2416702e4feb1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141260 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-13drop newly unused StyleSettings::GetFontColorCaolán McNamara
Change-Id: Icd20283207e9ac0392d11d74553d7c607330dbe1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140895 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-13a11y: Add char attr a11y check for entire paragraphofftkp
Accessibility check would not work if the entire paragraph had character attributes, because then it wouldn't have individual text hints Now check if there's a SwAttrSet and if it has the a11y char attributes that an issue should be generated for Also add test for this specific case Change-Id: Iee035eecd25ed130e78ed27041c3e56ea988ecc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141078 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-10-13pdfium: replace annot-alternate-name.patch.1 with upstreamed versionMiklos Vajna
Also backport an other patch that will allow testing date form widgets. Change-Id: I622c847a6139c69ec36a6d40e05b272d11f0119d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141270 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-13sw vba: tie WordBasic to VBAGlobalsJustin Luth
This allows WordBasic to also be run directly, instead of only working with Application.WordBasic.*. Change-Id: I60c3beaa1fce9a8bf25786cc0b2ed6ef6deda2f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141200 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-13sw vba: move SwWordBasic to its own fileJustin Luth
We had implemented Application.WordBasic.*, but it can also run as a global WordBasic.*. This patch just separates it from vbaapplication. It was just a copy/paste, and then I ran opt/lo/bin/clang-format -i on the new files and did some minor cleanup. I just guessed at the includes I needed, and then commented the remaining ones out one by one to verifiy they were needed to compile. Not very scientific, but I don't know any other way. (running \bin\find-unneedded-includes afterwards didn't show anything - perhaps that would have helped.) A followup patch will add the VBAGlobal connection. Change-Id: Id29ee582a5ed6186150bb41a1ab98d6c466676e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141199 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-13tdf#149840 Use actual outer size for SmartArt in WriterRegina Henschel
SmartArt import needs the outer size of the diagram for to define a background shape in the correct size and calculate the size of the diagram shapes relative to the outer size. The patch passes the values read from wp:extent in writerfilter to DiagramGraphicDataContext in oox. Change-Id: Ib39227bc645ac353336bab2c558d041974188f6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141223 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-13tdf#151385 Only trigger mnemonics in dialogs when alt key is pressedSamuel Mehrbrodt
Change-Id: I884afad38c64bd53fe4917418ed627f9c0674554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141022 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-10-13Deduplicate stringconcat moreMike Kaganski
In the process, drop ToStringHelper::allowO(U)StringConcat, because we can deduce this information from ToStringHelper's addData itself. To do that, addData was converted to ToStringHelper::operator(), which allows to use std::is_invocable_v on the helper class. Change-Id: Ic77878ca0ff65ada8c0a942191bc11de15b9ad2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141254 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-13tdf#151087 elementary:Grouped n Ungrouped Columns/RowsRizal Muttaqin
Change-Id: I25ada781c5308a8ea89ba98d2e021f7b50c13c67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141190 Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-10-13tdf#151087 Sifr:+Grouped n Ungrouped Columns/Rows, Breeze: Revise itRizal Muttaqin
Change-Id: I6f1e72ec38414961cf5e3d41baf6b1448ab0aa95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141276 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-10-12sc: remove duplicated testXisco Fauli
This is already well covered by Test::testAutoFill in sc/qa/unit/ucalc.cxx Change-Id: I5d539de101e1b4dcd19191ac40d2bc0734475889 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141272 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-12sc: move UItest to CppUnittestXisco Fauli
Change-Id: I6543994abe337041de5a1aab16a5a49105aacfbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141271 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-12tdf#151460: sc_ucalc: Add unittestXisco Fauli
Change-Id: Ib0c8d09da50a09b2715a946a1955eb5a09d83d62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141269 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-12sc: qa: avoid OUStringChar for better readabilityXisco Fauli
Change-Id: Idf730e05d2ebec9003a2a4700b43b8658d858b03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141265 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-12tdf#147021 REVERT Use std::size() instead of SAL_N_ELEMENTS() macrojsala
Reverting this changes made by error. See https://gerrit.libreoffice.org/c/core/+/136263/6/compilerplugins/clang/test/constvars.cxx#25 Change-Id: Ica49759682adf55a1f0cef2a842acab603c62dac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141259 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-10-12tdf#60673: sc_subsequent_filters_test2: Add unittestXisco Fauli
Change-Id: Ia36507483e5dc325431b17e9374882ae8102bfb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141263 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-12ScriptForge - (SF_Dialog) new SetPageManager methodJean-Pierre Ledure
The SetPageManager() method Define how the dialog displays pages. The page manager is an alternative to the direct use of the Page property of the dialog and dialogcontrol objects. The arguments define which controls are involved in the orchestration of the displayed pages. Possible options: - select a value in a list- or combobox - select an item in a group of radio buttons - select a button linked to a page placed side-by-side the buttons can simulate a tabbed interface - press a NEXT or BACK button like in many wizards Those options may be combined. The control updates will be synchronized. The method will set the actual page number to 1. Afterwards the Page property may be used to display any other page The SetPageManager() method is to be run only once and before the Execute() statement. If invoked several times, subsequent calls will be ignored. The method will define new listeners on the concerned controls, addressing generic routines. The corresponding events will be fired during the dialog execution. Preset events (in the Basic IDE) will be preserved and executed immediately AFTER the page change. The listeners will be removed at dialog termination. The implementation has next parts: 1. Store the arguments in the Dialog instance 2. Set appropriate listeners on involved controls 3. Page change synchronizes the values in the involved controls (be it by user code or by page manager) 4. Events triggered by listeners change page number The method is available both in Basic and Python contexts. This commit require the Dialog help page to be updated. Change-Id: I00a0212414f283102c73de4ceb488aa1aeddf746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141257 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2022-10-12use WindowTextColor as the fg for high contrastCaolán McNamara
No platform sets TextColor away from its default of black and we're using WindowColor as the bg for high contrast, so we need to use something suitable for use on WindowColor. MSDN docs state COLOR_WINDOWTEXT for HighContrast if using COLOR_WINDOW. Change-Id: Icdd3cf6d76da7eb544f08619717689b44ab1fd38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141247 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-12new uno command uno:Translate with deepl apiMert Tumer
New Uno command added for translation right now it is only using deepl translation api There's a section in the options > language settings for setting up the api url and auth key uno:Translate is a menu button under Format tab which will bring up Language Selection dialog for translation. DeepL can accept html as the input for translation, this new feature leverages that by exporting paragraphs/selections to html and paste them back without losing the formatting (in theory) This works good in general but we may lose formatting in very complex styled sentences. Translation works in two ways; 1) Whole document when there is no selection, it assumes that we want to translate whole document. Each paragraphs is sent one by one so that the output timeout can be minimum for each paragraph. 2) Selection Change-Id: Ia2d3ab2f6757faf565b939e1d670a7dedac33390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140624 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-12Fix apparently-dangling pointerStephan Bergmann
After 001de7e21d29fccff904fe23de05afd68922fe2e, CppunitTest_sw_ww8export CPPUNIT_TEST_NAME=testTdf94386::TestBody started to fail with > svl/source/items/itemset.cxx:176:42: runtime error: member call on address 0x60400083cbd0 which does not point to an object of type 'SfxItemPool' > 0x60400083cbd0: note: object has invalid vptr > 00 00 00 00 b0 6e 02 00 00 00 00 00 00 00 00 00 be be be be 40 44 b1 05 e1 7f 00 00 00 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > invalid vptr > #0 in SfxItemSet::~SfxItemSet() at svl/source/items/itemset.cxx:176:42 > #1 in testTdf94386::TestBody() at sw/qa/extras/ww8export/ww8export.cxx:1555:1 Change-Id: I6dff915866a4e7d1250b253e53061e5646aebf15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141253 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-10-12this adjust not necessaryNoel Grandin
rPaM's nNode and nContent is already kept in sync here Change-Id: Ic79bcf8f950767885e117848475ccbebc4f6537e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141251 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-12tdf#148806 vba: IsCompiled is required for SbxFlagBits::PrivateJustin Luth
Two step approach: -putting this here where I need it - fairly targeted. -put it in FindMethod before returning, so that everything gets it in a valid state. Of course the second will probably cause consternations, but then when it gets reverted at least this will still work. Change-Id: I8772f85c9b9ae6ed9a25ba7966b50519afe0d6ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141243 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-10-12tdf#151190 sw content controls: make them read-write in protected sectionsMiklos Vajna
When the user picked a date in the date picker inside a protected section, then we blocked the deletion of the placeholder, but allowed insertion to the content control, which is inconsistent. The trouble was that SwPaM::HasReadonlySel() detected that the cursor is in a protected section, so deletion failed, leading to an ever growing value of the content control. Fix the problem by handling content controls similar to legacy form fields: if the cursor is inside a content control, then that value is editable, even if we're inside a protected section. This is meant to fix all content control types, not just date pickers. Change-Id: I9eca4c4f71dcfaa61d84414f7727adcd4496735c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141249 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-10-12cid#1515941 Dereference null return valueCaolán McNamara
Change-Id: Id6b191482c70a95d861ba771925570bc5992f534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141250 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-12use unique_ptr for SystemFontList, fix leakNoel Grandin
Using unique_ptr here fixes a leak, which in turn was hiding the fact that we don't manage the lifecycle of CTFontDescriptor in CoreTextFontFace properly Change-Id: I2ade5fae9a40ad0ebb10538488018941f3f285c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140916 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-12tdf#151071 Revise Sifr (Update color to follow symbolic Adwaita)Rizal Muttaqin
Change-Id: I70aa82598f68492ebdfcd26f51858471c0a53f25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141245 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-10-12rearrange node logic hereNoel Grandin
so we don't have to touch SwPosition.nContent. Part of the process of hiding the internals of SwPosition Change-Id: I797eec2b4ccb01360602f2f19ae4a7a51fe712fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141235 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-18 20:25:28 +0000