summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-11-28tdf#120551 DOCX import: fix position of group shape with absolute positionMiklos Vajna
Regression from commit af313fc149f80adb0f1680ca20e19745ccb7fede (tdf#105143 DOCX import: enable DoNotCaptureDrawObjsOnPage layout compat option, 2017-01-06), the group shape which covers most of the single page in the document had a negative left position, while it should have a small positive one (checking the drawingML markup). This was a pre-existing problem, but now it's visible since we no longer force objects to be on the page in Word compat mode. Seeing the ODT import never positions group shapes (it's just a container for child shapes), probably the DOCX import shouldn't do that either. Start moving into this direction, first only for absolute-positioned toplevel group shapes only, which already fixes the bug. (cherry picked from commit d220e476df38e86e094066a690985c624316d37f) Change-Id: I152ba06a81a2bd09195a4c724da4b8878b0457bb Reviewed-on: https://gerrit.libreoffice.org/63710 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Resolves: tdf#121695 call save_valueCaolán McNamara
so get_value_changed_from_saved detects no-op Change-Id: I2b72bc7a6bc4093f9d942aa56f90542521e23cd9 Reviewed-on: https://gerrit.libreoffice.org/64132 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-11-27tdf#120115: Dont crash on Footnote/Table undo/redoBjoern Michaelsen
brown paperbag commit: - for one, we only want to use the anchor format when we dont have another one, not the other way around - also we want to update the anchor format (not the char format) when it tells us so. - finally, keep the selected Char and AnchorFormat in Sync between SwEndnoteInfo and the underlying DocumentStylePoolManager Change-Id: Ic599dc1290c4e30d1746e5eefe6fed27b0ccdfe9 Reviewed-on: https://gerrit.libreoffice.org/63306 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-11-27Put text label outside of the pie if..Tamas Bunth
performLabelBestFitInnerPlacement fails. Change-Id: Ic84e8b42e02da2023b22a9406c44d462170c5305 Reviewed-on: https://gerrit.libreoffice.org/64015 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 3339c730f8c9a6088a2e8b335185f1bf0b232216) Reviewed-on: https://gerrit.libreoffice.org/64033 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-11-27Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-1' - update translations for 6.1.4 rc1 and force-fix errors using pocheck Change-Id: I9c68e9c3bf1907504b52af3e965905f110b56c4c
2018-11-27Resolves: tdf#119790 for gtk3 save and restore typed name on changing filterCaolán McNamara
Change-Id: I17c3d154144b13ce401b0e4afe84c91a2fe98d8e Reviewed-on: https://gerrit.libreoffice.org/63076 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-11-27Resolves: tdf#121238 format welded metricspinbuttons the same as historicallyCaolán McNamara
i.e. not with the UI Language, but with the Locale setting. Change-Id: I5146ece3356fdb67c3c715c6d17e608ec92e739a Reviewed-on: https://gerrit.libreoffice.org/63089 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-11-27Resolves: tdf#121607 set parent for password dialogsCaolán McNamara
Change-Id: I02210a61d103aed4a181b0e907ea2fd141e5f587 Reviewed-on: https://gerrit.libreoffice.org/63792 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-11-27tdf#121607 defer other requests until password dialog is dismissedCaolán McNamara
Change-Id: I82b308f482cc5eb40a00afd01a6848afc3fb8ab1 Reviewed-on: https://gerrit.libreoffice.org/63796 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-11-27tdf#121648 EMF+ Fix displaying DrawDriverString recordBartosz Kosiorek
With introduing String rotation support I made mistake by not removing Maping from DX-Array. With this commit I'm fixing that issue. Now drawing with DrawDriverString record, and rotation is working perfectly. Change-Id: I7ae051b3791d9d2d8e2143ed33d21b7bfbc551c6 Reviewed-on: https://gerrit.libreoffice.org/64080 Tested-by: Jenkins Reviewed-by: Patrick Jaap <patrick.jaap@tu-dresden.de> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-11-27tdf#120879 Remove has_default from helpXisco Fauli
Change-Id: I5b776f89b7a49307e7a3ed4382f28ac58fc738ff Reviewed-on: https://gerrit.libreoffice.org/64054 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2bb070f95a05d52cba6fa36450d6317ab883d881) Reviewed-on: https://gerrit.libreoffice.org/64074 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-27tdf#55058 tdf#106084 EMF+ Add support for Underline and StrikeoutBartosz Kosiorek
Add support of Underline and Strikeout for DrawString and DrawDriverString EMF+ records Change-Id: I24c47e0d7524dabc13edd04c6b68aec69fa35e7b Reviewed-on: https://gerrit.libreoffice.org/62827 Tested-by: Jenkins Reviewed-by: Patrick Jaap <patrick.jaap@tu-dresden.de> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 8d4da5429548ba6ef4d3ee4dd6062c25a77ba78b) Reviewed-on: https://gerrit.libreoffice.org/63576
2018-11-26tdf#121647: fix regression from 85b3c799ede62a3d7ad0493fc80b629214956601Xisco Fauli
the pCP = pCodePairs statement was left behind in - std::vector<sal_UCS4>::const_iterator itInt = aSupportedRanges.begin(); - for( pCP = pCodePairs; itInt != aSupportedRanges.end(); ++itInt ) - *(pCP++) = *itInt; + for (auto const& supportedRange : aSupportedRanges) + *(pCP++) = supportedRange; Change-Id: Icedf7a4dae224f6b328f924691ec4c6767495389 Reviewed-on: https://gerrit.libreoffice.org/64049 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-11-26tdf#120426 save the style names when set or changedCaolán McNamara
instead of waiting until gaining focus of the listbox, because of the differences in what that focus means in the different backends. It was an odd way to do things anyway. Change-Id: I072e3da04db184b49a86a9888080b60223813729 Reviewed-on: https://gerrit.libreoffice.org/63822 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26Resolves: tdf#121644 clear pointer to customlines when customlines clearedCaolán McNamara
Change-Id: I09bf6f3c484a2d90a865f0a5743c4e99d2f77b0a Reviewed-on: https://gerrit.libreoffice.org/63873 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26tdf#108027, add external ref string items to the data arrayMarkus Mohrhard
Change-Id: Iaf607fca6d7e88f2c529ab4a374f34164813331a Reviewed-on: https://gerrit.libreoffice.org/64009 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 72e204da9a062282e52d5060e7f633e3b21414ff) Reviewed-on: https://gerrit.libreoffice.org/64012 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-11-26tdf#116931 Fix scale when calc cells move indirectlyArmin Le Grand
For the anchor mode 'To Cell (resize with cell)' there were errors e.g. when the cell the object is in does not scale but move. If that move went further than the object is, wrong offsets emerged. Also added full linear per-cell scale instead of only scale (no translation through scale). Overhauled to use liner transfomations, too. Change-Id: Icff0fad168476c68ea10fd5830bf53bd7294b89f Reviewed-on: https://gerrit.libreoffice.org/63803 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit 10a58ec15438d34a594437815882862c4576e2c0) Reviewed-on: https://gerrit.libreoffice.org/63852 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23honor getNumDecimalSep for keypad input in native gtk3 dialogsCaolán McNamara
Change-Id: Ibbd37f18ee97eb6ded0ab90cd70b777ffd20f91d Reviewed-on: https://gerrit.libreoffice.org/63292 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-11-23tdf#114836, only set changed SfxItemSet propertiesMarkus Mohrhard
By always setting all existing properties again the calls started to differ between XMultiPropertySet::setPropertyValues and XPropertySet::setPropertyValue. This patch reduces the changes in the called methods. We can not avoid slight differences but at least the risk is minimized that something is unexpectedly changed. Change-Id: I5866db7be2829e6aba930f620f45db655df4e3f7 Reviewed-on: https://gerrit.libreoffice.org/63854 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 80cf278d365a2d357c70b8c28947c91fa97e7a99) Reviewed-on: https://gerrit.libreoffice.org/63857 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22Resolves: tdf#113898 create JumpMatrix for svExternalDoubleRef scalar valuesEike Rathke
Change-Id: I45d2a1e573a7e4923aaaf5b69f3c4b39215aacc2 Reviewed-on: https://gerrit.libreoffice.org/63778 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 266aab73a88ae5b62fcddaf383107d8e7edc51f2) Reviewed-on: https://gerrit.libreoffice.org/63797 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22Fix headless build on LinuxThorsten Behrens
Conditional-compile some OpenGL-ness that crept in Change-Id: I8d12f34db3b4875470a0d81e9ef6a1654153b206 Reviewed-on: https://gerrit.libreoffice.org/63676 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 2bf8469cbca01e53043097708909f6cdf2aae264) Reviewed-on: https://gerrit.libreoffice.org/63689 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-11-22tdf#117108: do not show the master view button after updating the sidebarXisco Fauli
Change-Id: I3e6af9c2a555599e4aa288b8d6e99b43b09d35a6 Reviewed-on: https://gerrit.libreoffice.org/63570 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 60e6593f042e3e2869ece89cc43390b3254b3205) Reviewed-on: https://gerrit.libreoffice.org/63698
2018-11-21Revert "Notebookbar:Disabled appearence of context toolbars"Xisco Faulí
This reverts commit 2c317751c4b7661c10bd9eb11094febeccd1b816. So far, two crashes has been found related to this commit: tdf#121591 and tdf#119945 which can be reproduced with or without the notebook enabled. Besides, the author seems no to be inactive now... Change-Id: Ie1ff88afc59abea176f6ae9d459a835aef39c57a Reviewed-on: https://gerrit.libreoffice.org/63737 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-11-21tdf#121131: Default COMPILER_PLUGINS_CXX to g++ -std=c++11Stephan Bergmann
ab8bf5533f8de9bb1aa9dc83e650e4eccf0fcac3 "Avoid error message from configure about clang's header for compiler plugins" caused problems after cd472d1d8489f30797f47d3f6dafede28c1feb90 "Compile as C++2a, where available", when the compiler used to build LO (CXX) supports -std=gnu++2a but the compiler used to build loplugin (COMPILER_PLUGINS_CXX) does not. So solve that problem instead by just adding -std=c++11 to the default for COMPILER_PLUGINS_CXX. Change-Id: I95e86bc28f2a0dfb2b7bdce6b15955b870428b8c Reviewed-on: https://gerrit.libreoffice.org/62997 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins (cherry picked from commit 4613e105f98af6e3b65ce87432b1a2db45e71ae2) Reviewed-on: https://gerrit.libreoffice.org/63714
2018-11-21Resolves: tdf#121547 do normal dialog layout firstCaolán McNamara
then, if still too small, re-layout with the bigger size Change-Id: I1425e7a55dced4bd93e365a38383eda07fb16d16 Reviewed-on: https://gerrit.libreoffice.org/63708 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-21Always disable loplugin:expressionalwayszero, to avoid false positivesStephan Bergmann
bdade7e3fc33c1832c6f6a472443fca8238738d2 "tdf#105444 DOCX import: don't put extra paragraphs in comments" caused > /home/sbergman/lo2/core/writerfilter/source/dmapper/DomainMapper_Impl.cxx:441:22: error: expression always evaluates to zero, lhs=0 rhs=unknown [loplugin:expressionalwayszero] > (sizeof(SAL_NEWLINE_STRING)-1 == 2 && xCursor->getString() == "\n")) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ now with sufficiently new Clang, and the code looks reasonable, and there's no apparent way to avoid such false positives in the plugin. (It could check for a sub-expression of the problematic expression being an object-like macro, but SAL_NEWLINE_STRING could just as well be a variable instead of a macro. That variable would need to be defined in some #if to have different values on different platforms, so the plugin could theoretically check for such conditional inclusion, but it's not clear whether that's worth it and would even be a useful heuristic to not produce neither too many false positives nor too many false negatives.) So just disable the plugin for good. Change-Id: I85dc8573735ccac4e19be20ab7443cbaa85a3164 Reviewed-on: https://gerrit.libreoffice.org/60907 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 8b1501d80dc9d3f42c351c6e026fa737e116cae5) Reviewed-on: https://gerrit.libreoffice.org/63717 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-21pocheck: don't throw away Plural-Forms headerChristian Lohmaier
also don't change POT creation date when rewriting a po file, update Po-Revision instead. When creating templates, put X-Accelerator before X-Generator (like pootle would order it) Change-Id: I7fec4cb1c50e27b87decd9a892de3f01a02253ed Reviewed-on: https://gerrit.libreoffice.org/63416 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 9ffe350ae344e9863330fbb2405c37df6b9d0984) Reviewed-on: https://gerrit.libreoffice.org/63603 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21localize: sort directories to have predictable sorting in pot filesChristian Lohmaier
also remove pre-onegit special handling Change-Id: Ie60be508a188e00b9eea1b743ea10f1f985c459e Reviewed-on: https://gerrit.libreoffice.org/63288 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 344773c608ea28718b630590ee1023247aa62d63) Reviewed-on: https://gerrit.libreoffice.org/63602 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21pocheck: don't choke on plural formsChristian Lohmaier
Change-Id: I51a82ce5fc09d44ebc6f7c06c67b475ee2adf68b Reviewed-on: https://gerrit.libreoffice.org/62419 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins (cherry picked from commit b44b9c4519794d159b154a9713c10da1155a5198) Reviewed-on: https://gerrit.libreoffice.org/63601 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21fix of extension description l10nAndras Timar
Change-Id: Ica102309627fade2a064ee5516e84801affe4082 Reviewed-on: https://gerrit.libreoffice.org/61184 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 59f4115122f70004d78a85b08607b9678b8fd6ca) Reviewed-on: https://gerrit.libreoffice.org/63600
2018-11-21pocheck: tdf#119080 update po checker tool for post LO 6.0 po filesAndras Timar
Change-Id: I700eaa0d412fb609fdc89ca07003534e6bb13854 (cherry picked from commit 1139c76b60b9a9f6df2bc53deb6c1c1cba42178d) Reviewed-on: https://gerrit.libreoffice.org/63599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21pocheck: we need to access msgctxt of a PO entryAndras Timar
Change-Id: I43978811056692623344239d2c6e4763fa7de16b Reviewed-on: https://gerrit.libreoffice.org/61165 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 2a47dd078bf448f34f05a56a647410a66da00eea) Reviewed-on: https://gerrit.libreoffice.org/63598 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21pocheck: PO entries can have multiple source code reference lines since LO 6.0Andras Timar
Reviewed-on: https://gerrit.libreoffice.org/61164 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 1bf49e98f8019bf62906651804725e4da5b9d514) Change-Id: Icbe0dd5e63eb5b10d162f34347ab86dde547dc62 Reviewed-on: https://gerrit.libreoffice.org/63597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21pocheck: do not change msgctxt when po is regeneratedAndras Timar
Change-Id: I220fce194813f783c807c23eeffd2421cadd7636 Reviewed-on: https://gerrit.libreoffice.org/61163 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 8d4e12a4153868c9d98937d49c4ac6064013a8dd) Reviewed-on: https://gerrit.libreoffice.org/63596 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21pocheck: handle the '#, c-format' flagAndras Timar
Change-Id: I7d1d344e79e0c23886a21032d2ce85e5abb199cb Reviewed-on: https://gerrit.libreoffice.org/61162 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 86919365393a0c3da9c86f63099bc05cb2e39844) Reviewed-on: https://gerrit.libreoffice.org/63595 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21pocheck: stop further processing, if input file cannot be openedAndras Timar
Change-Id: Ida6a13e112871ab6864ae2a32a33a15a591154c2 Reviewed-on: https://gerrit.libreoffice.org/61161 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit baf048cd2ffe1f3afeb204b9dcc11d36999c1725) Reviewed-on: https://gerrit.libreoffice.org/63594 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21Accept also macOS SDK 10.14Tor Lillqvist
Change-Id: I3ff9381e547d40f9155d5324f9178939f9d7dac6 Reviewed-on: https://gerrit.libreoffice.org/63626 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-11-20Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'libreoffice-6-1' - Remove more pointless translatable strings Follow-up for commit 8bece13f73046ebebfb5c18d02d857a961a4cdab. Change-Id: I292553aa666b3c5fccf6a0b239bcfada41899ab6 (cherry picked from commit 68e9ac1e8dacf25cd91068c86d9d353144b43ae1) Reviewed-on: https://gerrit.libreoffice.org/60421 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-20pocheck: fix usage messageAndras Timar
pocheck needs environment variables that bin/run does not provide Change-Id: I0de148363d60c515d4024cd0e97d1025ce50b6a5 Reviewed-on: https://gerrit.libreoffice.org/61160 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit a906b68a9fff30c2af5c03189e59c1952cd3f69f) Reviewed-on: https://gerrit.libreoffice.org/63593 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-19tdf#120677: restore treatment of blanks in SwTextGuess::GuessMike Kaganski
Before commit 0be3db28a4db4d2c81a5cb2edd48711eec55b51b, all non-breakable spaces were converted to plain spaces in SwTextSlot::SwTextSlot (see pInf->SetText call there). The mentioned commit has changed that to allow differentiating non-breakable spaces from other types of spaces (related to the fix of tdf#115067). This broke following processing of the NBSPs when they don't fit to line, causing infinite layout loop leading to OOM. This allows to restore old behavior to not call the break iterator for NBSP by explicitly checking for it. Change-Id: I36ab06abb66bbe65a5fc542c41e816a9f20a2dcf Reviewed-on: https://gerrit.libreoffice.org/63290 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 4bb28ad217ea9d6511b6921dcd3d28328edcb4d6) Reviewed-on: https://gerrit.libreoffice.org/63304 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19tdf#108022, don't overwrite chart export informationMarkus Mohrhard
Change-Id: I47d8a817022829c8cada614469303e440f377299 Reviewed-on: https://gerrit.libreoffice.org/63536 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 9ccdf4d8abf6ec6612c88ab65be25eb6be89b455) Reviewed-on: https://gerrit.libreoffice.org/63540 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19tdf#104579, if no data point shape props are set take the series propsMarkus Mohrhard
Change-Id: Ia2c0d6b05385a0f3900e20ef807b869e4098654c Reviewed-on: https://gerrit.libreoffice.org/63541 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit afe5e1f8de0a25364c8c98b453cfe831330c4eed) Reviewed-on: https://gerrit.libreoffice.org/63544 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19tdf#102186, don't overwrite the deleted flagMarkus Mohrhard
Change-Id: I3cc69a0baebc55ad52b64960657e9daa4be8f39d Reviewed-on: https://gerrit.libreoffice.org/63510 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 4bd2e57653ce22044ab984b06c84f22ef287cecf) Reviewed-on: https://gerrit.libreoffice.org/63513 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19tdf#55058 tdf#106084 tdf#114738 EMF+ Add rotation support for String drawingBartosz Kosiorek
Added rotation support for DrawString and DrawDriverString The EmfPlusDrawString record specifies text output with string formatting. The EmfPlusDrawDriverString record specifies text output with character positions. Now both EMF+ records properly support rotation. Change-Id: I15a7a6dd2b8a209cf2aac2af75d7dd89cedd1aeb Reviewed-on: https://gerrit.libreoffice.org/62805 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-11-19tdf#121267 Handle missing diagonal bordersMaxim Monastirsky
Regression of 9125a4f3f63a7f49fd307908c181e999120063e0 ("Use FeatureStateEvent directly for status updates"). Change-Id: I57856c5707fffcf84f95afa9ef80a394b550c56f Reviewed-on: https://gerrit.libreoffice.org/63497 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit f162066d9df814086c92fa008c563ffc08daaf98) Reviewed-on: https://gerrit.libreoffice.org/63552 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-17thread-safe ScGlobal::GetUnitConverter()Luboš Luňák
Triggered by sc/qa/unit/data/functions/mathematical/fods/convert_ooo.fods with SC_FORCE_CALCULATION=threads. Change-Id: Ibedb32ee03519911650a0deee67011efeda57c93 Reviewed-on: https://gerrit.libreoffice.org/63175 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 9553f2afd0527ba435dae7bf4506c620a943b150) Reviewed-on: https://gerrit.libreoffice.org/63376 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17tdf#121288: ReplaceFile WinAPI doesn't play nicely with WebDAV mapped drivesMike Kaganski
Change-Id: I0d7a64459de283dc10448e0086c66bedbf132553 Reviewed-on: https://gerrit.libreoffice.org/63133 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 603b63b4c154882ecfe95ae3c6960b08eb9fb626) Reviewed-on: https://gerrit.libreoffice.org/63286 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17tdf#121203 DOCX import: fix loss of free-form text in date controlMiklos Vajna
Date SDT from DOCX is imported as date control since commit 3ec2d26dc2017ac4a27483febfc63328632f352d (bnc#779630 initial DOCX import of w:sdt's w:date, 2013-04-30). One detail I missed there is our date control is strict: it doesn't allow free-form text. However, DOCX date SDT has an optional ISO date, but the actual value can be free-form text. This means that importing free-form text without an ISO date is lost on import. Fix the data loss by restricting the creation of the date control: only do this if we recognize the date format or in case we have an ISO date. Otherwise just show the free-form text to avoid data loss. (cherry picked from commit 3583f7a1256c901199574c8373443038e28813f0) Change-Id: I8125bdc749954a6a1c496de74b6682744adb7680 Reviewed-on: https://gerrit.libreoffice.org/63335 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17tdf#121325: Replace all of given length, even if replacement is shorterStephan Bergmann
Both LO and MS Basic restrict the amount of replacement text ("If the Length parameter in the <emph>Mid statement</emph> is less than the length of the text that you want to replace, the text is reduced to the specified length." in helpcontent2/source/text/sbasic/shared/03120306.xhp, resp. "The number of characters replaced is always less than or equal to the number of characters in Target." at <https://docs.microsoft.com/en-us/dotnet/visual-basic/ language-reference/statements/mid-statement>). But cc20344010e94eda22fee662aab966d395a0796a "tdf#111313: Honor bWriteNoLenParam in !bCompatibility, too" had introduced a regression (in the non--compatibility- mode case), restricting the amount of replaced text to be no more than the amount of replacement text, even if the given length argument was larger. (Which had already regressed in the past, see <https://bugs.documentfoundation.org/show_bug.cgi?id=62090> "Mid statement doesn't work as expected".) Added test cases now. Change-Id: I21d4409f49a2437eb0e1a1e200561d803c42a24c Reviewed-on: https://gerrit.libreoffice.org/63328 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit a6a48eeef16e473be14642469cd922f177f54998) Reviewed-on: https://gerrit.libreoffice.org/63332 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17Resolves: tdf#119700 save correct table:last-row-spannedEike Rathke
Regression from commit f6e6a6139e90d6e88fb65308e8592193ac602a8a CommitDate: Mon Nov 21 07:49:06 2016 +0000 tdf#48140 Replace uno CellRangeAddress and CellAddress with direct calls that calculated endrow-startcol instead of endrow-startrow. Change-Id: Ie576f9abdcdc23fc5f0a06735caadc24e975360f Reviewed-on: https://gerrit.libreoffice.org/63374 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 6e566c2b2b23d457a9fd47c16df15ce11e84c8e8) Reviewed-on: https://gerrit.libreoffice.org/63382 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-13 16:54:19 +0000