summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11sw tiled rendering: Ignore window size check.Henry Castro
In the tiled rendering case it does not need to check if the window size is (0,0). But it still has to trigger LOKit LOK_CALLBACK_INVALIDATE_TILES Change-Id: I4c458edfd6e44599b8c8148e0f8543fb0563e627
2015-06-11Cleanup crossplatform cairoMox Soini
Mac / Win cairo is not built / used, this cairo code can be removed to reduce code bloat. 4th Revised version with Android fixes Change-Id: I6e56850f535ca13b77839b7d67e227c5f39d388e Reviewed-on: https://gerrit.libreoffice.org/16218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-11missing includeStephan Bergmann
Change-Id: I7ac5607f911d3ffc469fe01fcf708899f3e23e57
2015-06-11So assume SwUiWriterTest::testEmbeddedDataSource works on MACOSX now tooStephan Bergmann
...similar to 6cca91f7ada91701443225061a5dd0ae81a98b8e "CppunitTest_sw_uiwriter: enable on Windows," whatever the original problem was in 601ba26cb5737970e7e9a173515bb21ebde55db9 "Fix the Windows and OS X build temporarily." Change-Id: Ia1befff90d773637e01e6d88e398ae21a1d47108
2015-06-11SwDBManager: avoid registering two data sources when creating an emebedded oneMiklos Vajna
SwDBManager::LoadAndRegisterDataSource() calls SwXDocumentSettings::setPropertyValue() to set its EmbeddedDatabaseName UNO property, when creating the embedded data source definition. OTOH, during load, SwXDocumentSettings calls SwDBManager::LoadAndRegisterEmbeddedDataSource() to register the data source. The result is that when creating the embedded definition using the MM wizard, we registered two data sources. Fix the problem by first setting the UNO property, and only then storing the data source definition. Change-Id: I3efc141d9ab94828007a48a8bf5949b4f3b6510a
2015-06-11minor clean upStephan Bergmann
Change-Id: Ib4fb12e187eb4bad7da04425328d1f5cdf851654
2015-06-11Typo: vertival -> verticalAndras Timar
Change-Id: I3dce3d131ce78713333d6e4bc2f3e839af5e04ec
2015-06-11convert 'it.begin() == it.end()' to 'it.empty()'Noel Grandin
Change-Id: I244a9eb6bce6b1c649653ec38ebb9a39f8b4c145 Reviewed-on: https://gerrit.libreoffice.org/16212 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11speed up Java unit tests by removing sleepsNoel Grandin
and replacing them with a call to XToolkitExperimental:: processEventsToIdle Change-Id: I9fd6cb8af43d902587186310aebe78b5a5ee6932 Reviewed-on: https://gerrit.libreoffice.org/16201 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11loplugin:staticmethodsStephan Bergmann
Change-Id: If54b3017296f5bcea01b3b0d24d9ac821f6a24e9
2015-06-11tdf#91613 restore functionality of clicking to .uno:Size status bar elementAndras Timar
... in Writer. This (partially) reverts commit ebabf6d1fa648d62dd63529e9fe64dcb631caee8. I did not see the point to open Fields dialog by default, but other uses are fully valid. Change-Id: Ia06803fbb956266fb40c53f51099f9a32ddd6548 Reviewed-on: https://gerrit.libreoffice.org/16221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-11harden build enviroment on mac with LODENorbert Thiebaud
mac build really does not like finding extra stuff in the PATH or in /usr/local/bin as this is prone to happen with macport/fink/etc.. or somethings just due to some other 'ported to mac' pre-canned binaries.. for instance one has found a python3 in /usr/local/bin which confused configure to believe it was ok to use 'system python', which break on mac. This patch sanitize PATH during ./autogen.sh, when running in a LODE environment. it leave only LODE_HOME/opt/bin:/usr/bin:/bin:/usr/sbin:/sbin and optionally the path where git is located if that is not /usr/bin (it is quite common depending on how one installed git, to haev it in /usr/local/git/bin for instance) This is strictly a 'nanny' patch.. but it should not impact anyone that is not ( on Mac and using LODE ). Change-Id: I865047cfeb102ecb22777a1f7fb7cbdd374448aa Reviewed-on: https://gerrit.libreoffice.org/16222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-06-10tdf#91645 don't change selected menu title text color in Aero themeLászló Németh
Change-Id: I99a935ac7c1aee881bca77f95bd5d1a45d8901ea
2015-06-10coverity#1302618 deref of NULLCaolán McNamara
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-10tdf#90640: add a unit test for thisMichael Stahl
Change-Id: I72aecb66d0de4ba2bc3a44f664aab8170ffb3d0f
2015-06-10Remove unnecessary Bool2AnyStephan Bergmann
(It feels better to use explicitly bool-typed css::uno::makeAny<bool>(x) rather than implicitly typed css::uno::makeAny(x) or css::uno::Any(x), in case x is not already of type bool.) Change-Id: I282b3764bb207aeae9f13cc981e68e8ef2b8ab93
2015-06-10tdf#89972: also copy external reference statusMike Kaganski
fixes regression from commit 4467c67dc8bf17c67c70985c0d0ea64636884f9f, where the new optimized code path failed to properly register ScFormulaCell with ScExternalRefManager. Introduces a new public method in ScExternalRefManager: insertRefCellAsTmpl that registers a formula cell to listen to the same external references as template cell Introduces new property to ScFormulaCell: mbIsExtRef that indicates that some external references are referenced by this cell Also introduces new method ScExternalRefManager::hasCellExternalReference (for use in unit test, will be posted immediately) Change-Id: Iee07d7b51949fd31953b5fa662a213052eb85181 Reviewed-on: https://gerrit.libreoffice.org/16066 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-10tdf#89972: unit test: check proper external ref manager registrationMike Kaganski
depends on gerrit#16066 Change-Id: I3dde8acfbf0170d0c2cd3ef0b626f3b286922b65 Reviewed-on: https://gerrit.libreoffice.org/16210 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-10Add very initial support for Visual Studio 2015Jesús Corrius
The new compiler is not detected automatically yet. You have to use --with-visual-studio=2015 to enable it. Change-Id: I0ef8cda7b2d99389b39fd7f8c2e142453ced99ed Reviewed-on: https://gerrit.libreoffice.org/15644 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2015-06-10Revert sw: LOK_CALLBACK_CURSOR_VISIBLE callback.Henry Castro
Already fixed by Miklos Vajna. Change-Id: I848f2296c5f5a4d250308ed3a851c46524181340
2015-06-10Android: improve error handling in ownCloud provider.Jacobo Aragunde Pérez
This provider now throws exceptions with properly internationalized messages to be shown to the user. Change-Id: I0464bffe14cab24d50180cb5e2e62ce746bcba74 Reviewed-on: https://gerrit.libreoffice.org/16197 Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com> Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-10Android: document providers listen to changes in preferences.Jacobo Aragunde Pérez
With this patch, document providers are able to listen to changes in their preferences and update their internal state accordingly. Now ownCloud provider can see its server updated without restarting the application. Change-Id: I833c7ec9fc97be58bdc8ac2cbf4384a33c2b400e Reviewed-on: https://gerrit.libreoffice.org/16196 Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com> Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-10Android: add menu entry for document provider settingsJacobo Aragunde Pérez
Change-Id: Ic48275fe2e7d83fd5e77171f4f5740a527dec7e2 Reviewed-on: https://gerrit.libreoffice.org/16195 Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com> Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-10Android: setup ownCloud provider with user-defined settingsJacobo Aragunde Pérez
Change-Id: I4ad4dd12854ca9f332055a50131959f60f7da504 Reviewed-on: https://gerrit.libreoffice.org/16194 Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com> Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-10Android: settings activity for document providersJacobo Aragunde Pérez
Creates an activity to manage the settings of any document provider that needs them, and populated it with the settings required by the ownCloud implementation. The settings screen is not yet plugged to the document browser UI but can be launched with this command: adb shell am start -a android.intent.action.MAIN \ -n org.libreoffice/.storage.DocumentProviderSettingsActivity Change-Id: I83cff641fa61078f2bddbb98262af989c06985a9 Reviewed-on: https://gerrit.libreoffice.org/16193 Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com> Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-10Android: download documents from ownCloud.Jacobo Aragunde Pérez
Documents are downloaded to the private cache directory of the app, and opened from there. That directory is cleared and created again every time the application starts up. Change-Id: I5c05c8ae750b6ced3b419c67d84063e8ee3d84aa Reviewed-on: https://gerrit.libreoffice.org/16192 Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com> Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-10Android: initial implementation of ownCloud provider.Jacobo Aragunde Pérez
This implementation can connect to a local server and browser its contents, but cannot download and open the documents yet. TODO: * Download and open documents. * UI to configure server, user and password. * Implement filtering to show only the documents of the desired type. * Improve error handling. Change-Id: I54a2e2e1d3e8ec8d824d75639e176ca452551f3e Reviewed-on: https://gerrit.libreoffice.org/16191 Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com> Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-10sw: remove embedded data source on location deregistrationMiklos Vajna
Change-Id: I5b2a24fee50a25a41ba26787f7e30409348d7808
2015-06-10Prop_pSegmentInfo is totally misunderstood apparentlyCaolán McNamara
digging into the crash on export of kde216114-1.odt reveals various horrors Change-Id: I0d24fe303d561a00a08098b306d10fd8273af928
2015-06-10CppunitTest_sw_uiwriter: enable on WindowsMiklos Vajna
I hope that the underlying problem is fixed now by commit 670100fcfbb39d3dbe4afdb27fbced26d7b14283 (Remove FastLoader optimization, 2015-06-10). Change-Id: I1cb577ec1f50a45b40683031e79c0999338a2926
2015-06-10syntax errors, stillStephan Bergmann
(i.e., parentheses do need to be quoted in BERs, but do not forget to escape brakets in configure.ac m4) Change-Id: Ifabb68ede318e5c95a54c420cd06e238fefbd82f
2015-06-10-Werror,-Winconsistent-missing-overrideStephan Bergmann
Change-Id: I2d1aa79a67bf130c3844b3bccb34a1761e8e4dfc
2015-06-10loplugin:salboolStephan Bergmann
Change-Id: I030321e8cb905be78b68f9e404926e22723632ef
2015-06-10tdf#91727 - Unwind non-dispatch of idle handlers.Michael Meeks
This clobbers the functionality from commit: 06d731428ef6cf93c7333e8228bfb6088853b52f make idle timers actually activate only when idle Since now all rendering and re-sizing is done in idle handlers it does effectively the opposite of what was intended. A better solution would allow special-casing the processing of just rendering, re-sizing and window management to spin for eg. progress bar rendering. Also add helpful debugging labels to the idle & timeouts. Also cleanup the Idle vs. Scheduler handling. Also ensure that starting an Idle triggers a mainloop wakeup. Also add a unit test. Change-Id: Ifb0756714378fdb790be599b93c7a3ac1f9209e6
2015-06-10add ./logerrit testfeatureBjoern Michaelsen
- ./logerrit testfeature will trigger a testbuild of the current feature branch as it is on gerrit - ./logerrit testfeature $BRANCH will do the same for $BRANCH - cloning to a tempdir and rm -rf'ing around isnt ideal, so consider this as a template for your own scripting Change-Id: I50a3c80748af82d855522f245ddbff227c8adab2
2015-06-10syntax errors, stillStephan Bergmann
Change-Id: I8ed4b4d221040ddf5f51d7e01134c855fc85a641
2015-06-10sw: fix GCC undefined reference to `typeinfo for sw::LegacyModifyHint'Michael Stahl
Stop pointlessly inlining these virtual functions. Change-Id: I11d123bc704ec6cf54925a13d139fce70cc59566
2015-06-10Revert "There's SAL_DLLPUBLIC_RTTI for that"Stephan Bergmann
This reverts commit 8761ab9b5ec7860eb5bc7d05271da081f66a452b; thinko, as the RTTI needs to be visible with GCC too in the test code.
2015-06-10Bool2Any wants to get bool instead of sal_uInt8Katarina Behrens
which is what GetTransparency() returns. Iow, do what SvxBrushItem does :) Change-Id: Ief65ab75d8c0955c1ec264611a70dcc693412170
2015-06-10tdf#90077 fix freeze when enabling media toolbar in ImpressNoel Grandin
Change-Id: I402bd7319d31859510a06644eb7dc786d56b312e Reviewed-on: https://gerrit.libreoffice.org/16213 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-10Added Test for Export to PictureVarun
Change-Id: I62d44e29cd4376f17270cef548d2cec6f4b621b9 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-10Added Test for tdf#91145 Set Cell Background ColorVarun
Change-Id: I7c41f1d596946706dde4adbeb5434ae0be58b04b Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-10There's SAL_DLLPUBLIC_RTTI for thatStephan Bergmann
Change-Id: I1937374b56b506681876d100112852b68f099038
2015-06-10Android: fix ownCloud lib buildJacobo Aragunde Pérez
The build relied on the presence of ANDROID_HOME envvar, now we pass it explicitly. Change-Id: If33ee2c6a22435151aad244378ee5aaf7b3cc913
2015-06-10tdf#88055: Don't export transparent background colour as whiteKatarina Behrens
The fix is twofold: 1. retrieve transparency from colour in SvxBackgroundColorItem (add QueryValue, PutValue methods, use additional memberID to retrieve alpha channel as a bool property) 2. add CharBackTransparent bool property to Draw [text] shapes, xmloff needs it to be able to output 'transparent' string instead of '#XXYYZZ' colour code in ODF format Change-Id: Id830bd18fd6da5d9a46e2a94aa254d5d2a6b7ebb Reviewed-on: https://gerrit.libreoffice.org/16182 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-10update creditsChristian Lohmaier
Change-Id: Ife3131eac8c653bb851f44f05be618289b5c5116
2015-06-10Fix sd ID conflicts and duplicatesPhilippe Jung
Fix the following cases: - two names for same ID in sd/inc/app.hrc. Two ID defined. - ID defined in include/sfx2/sfxsids.hrc and redefined in sd/inc/app.hrc. Only the sfx2 ID is kept - ID defined in include/svx/svxids.hrc and redefined in sd/inc/app.hrc. Only the svx ID is kept Change-Id: I21c7c25cb6db3c43ea2f9aac5aac75fabe61eaf0 Reviewed-on: https://gerrit.libreoffice.org/16209 Reviewed-by: Philippe Jung <phil.jung@free.fr> Tested-by: Philippe Jung <phil.jung@free.fr>
2015-06-10sc tiled editing: Mapping has to be turned off after drawing the buttons.Jan Holesovsky
Otherwise the redlines are on wrong positions in the tiled rendering case. Also - we are actually never call with something else than MAP_PIXEL, so let's kill the resetting of the mapmode; let's see if some obscure corner case bites us here. Change-Id: I8da07dd5448b8863df3148882ec50e6746760cca