Age | Commit message (Collapse) | Author |
|
Word 2013 refuses to even load a file that has a <v:shapetype
id="shapetype_75"> on some form control shape, reporting a misleading
error in a location far later when the top-level w:tbl that contains
the shape ends.
Using id="_x0000_t75" appears to work, so let's do that then.
Couldn't find any documentation on why this is so.
Change-Id: Ie22bb04244e24b00a1880544872ae8e281422405
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110493
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
- read from sw::DocumentSettingManager::mbGutterAtTop
- improve the preview widget to take gutter position into account
- also change it when the gutter position widget changes
- write it back to sw::DocumentSettingManager::mbGutterAtTop on
modification
- always check if the dialog's input item set has SID_ATTR_CHAR_GRABBAG,
otherwise do nothing to keep Calc/Impress unchanged
Change-Id: I05ef864bf7ac18f4c6829d78312044560e6402d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110488
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Ie9065250341d9ccafc4cae8bc0dbed5cfe911580
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110152
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
to avoid uninteresting timeouts
Change-Id: I20876b10589558a4431433ffd04668b17aea16cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110518
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
... WidowsAndOrphans
See tdf#94879 for motivation.
Change-Id: I1999c83e5afe100b95481ac470f4d854b5f113f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110547
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
...by re-enabling the code temporarily #if'ed-out in
a528392e71bc70136021be4e3d83732fccbb885e "Fixed/improved
loplugin:cppunitassertequals" (and which then triggers lots of other
lopglugin:cppunitassertequal CPPUNIT_ASSERT -> CPPUNIT_ASSERT_EQUAL warnings).
For two css::uno::Reference equality comparisons in cppu/qa/test_any.cxx, it
was more straightforward to rewrite them with an explicit call to operator ==
(which silences loplugin:cppunitassertequal) than to adapt them to
CPPUNIT_ASSERT_EQUAL's requirement for arguments of identical types.
In sc/qa/unit/ucalc_pivottable.cxx, ScDPItemData needs toString, which has been
implemented trivially for now, but might want to combine that with the
DEBUG_PIVOT_TABLE-only ScDPItemData::Dump.
Change-Id: Iae6d09cf69bd4e52fe4411bba9e50c48e696291c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110546
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I3887273aa0b4e88dd454099052db8ce3811b5d66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110524
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
including ODF/OOXML import/export (and test)
Change-Id: Id5a5194630a67476f7c5390294400a00ea3ad42d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110338
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
When development tools window was closed, the selection listener
was still listening and tried to change the selection because it
was never unregistered from the selection supplier. This caused
a crash as it tried to change the object on an non existing
tree view.
This change modifies the selection change listener so that is adds
itself to the selection supplier when constructed and removes
itself from the selection supplier, when the development tools
window is disposed.
Change-Id: Ifcb56aaee8f3c5c71ec609e68ffc78573f1b4179
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110121
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I0493c505be1eb06b121535128ae819b294c643a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110554
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
* Update helpcontent2 from branch 'master'
to cb6c6cf9d15fe60a235b5fe25cf7bb7013c98207
- Fix localization in sf_dialogcontrol and manage_templates
Change-Id: I865da2b0960ad00866a0f242e9f8ef27ba30a7ea
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110446
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
* Update helpcontent2 from branch 'master'
to c3fe3dbb29852fced390431da173a66a82e0c9c6
- Remove excessive <emph>
Change-Id: I861022023d0b526382406f4194c70d30c4df10c9
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110556
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 6abb464fb6017594f62b9a240a886012ee25dce2
- Recreates SF_String Help page (ScriptForge)
SF_Array:
- Adds a <variable> tag
SF_Document:
- Fixes localization issues pointed out by translators on WebLate
00000003.xhp:
- Fixes the message explaining how to load libraries
Change-Id: I9361f86e7907b95e0546197203e2d23c6211fd4d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110366
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
At least with current Qt Creator 4.14, no proper
names were shown for the build configurations in
the project's "Build" settings, but just integers.
Using the config key 'ProjectExplorer.ProjectConfiguration.DisplayName'
instead of 'ProjectExplorer.ProjectConfiguration.DefaultDisplayName'
in the *.user.pro file makes this work as intended, and "01-Global Build"
(and others) shows up as the name for the top-level 'lo.pro' project
and "1-Build vcl" for 'vcl.pro', etc.
Along with the two previous qtcreator-related commits,
this should generally (re)implement an easy way to
run unit tests etc. directly from the Qt Creator IDE
without having to set that up manually, which cloph
mentioned as missing in his FOSDEM talk today
("Using IDEs for LibreOffice development", [1]).
To use this, select the corresponding build configuration
by clicking on the "screen" icon on the bottom left,
then build the project (Ctrl+B or left-click on the
"hammer" icon on the bottom left).
I didn't check whether the single targets are still up
to date.
[1] https://fosdem.org/2021/schedule/event/lo_ideforlodevelopment/
Change-Id: I9965829db319a8b26f5ad82d3ffa723a28da7910
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110536
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Regression from commit b4dfba947768834ffecc09056992019878711c8b
("python3: update to 3.8.4"). Previous Python versions included
the source for libffi on all platforms, but now just for MacOS.
So now LO must build that DLL on Windows, which was done in
commit 883068462fe5bcbb01a8e14736fc06d0c3695c62 ("libffi: build
DLL on Windows").
Since OpenSSL is installed in the program directory and the LO
Python directory, this currently works "accidentially". Not sure
the Python OpenSSL DLLs should be handled via some extra gbuild
package to separate both, but that can be done in an additional
change.
Change-Id: I4a42e39cc2f4434a9944aad32836f66ec2819931
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110537
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: I104fe6b7d82f224c340fcd95e3ffe52d7397919f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110540
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The 'Idle' timers are misnamed. They are zero-timeout times, i.e.
they are invoked immediately after returning to the main loop.
But that does not necessarily mean they are invoked when idle,
there may be e.g. user input pending in the system event queue.
In fact, LO events are processed before system events, which means
that 'Idle' timers are normally processed before user input.
Besides being confused, this also leads to poor performance in some
cases, such as when using mouse wheel to zoom in a large document.
This results in several mouse wheel events, each of which will
result in adjusting the zoom and that causing a repaint. Repaints
are internally handled using a TaskPriority::REPAINT 'Idle',
and so what happens is zoom->repaint->zoom->repaint->zoom->repaint
instead of the more efficient zoom->zoom->zoom->repaint.
This change (besides trying to clarify the confusion in the docs)
delays invoking tasks with priorities TaskPriority::HIGH_IDLE
and lower if there is user input or repaint events in the OS queue.
That means that tasks using idle priorities actually will be invoked
only when idle (barring background threads etc.).
I'm reasonably certain this is a safe change, there's no guarantee
when exactly tasks will be invoked (e.g. other tasks with a higher
priority go first) and explicitly specifying such a priority means
asking for it.
I already implemented this once in 06d731428ef6cf93c7333e8228b,
and it was also again done in 87199d3829257420429057336283, but
apparently these have been removed. There was d348035a60361a1b9ba9e
'Drop special idle handling' with the reasoning that 'Idles are just
instant timers'. Which strictly technically speaking is true due to
'Idle' being a misnomer, but the point is that some idles should be
actual idles and that's why they need to be handled specially.
Change-Id: I36c2b02a80ae7e1476b731f878d9b28aa87975f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110538
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Added a unittest to ensure that a hyperlink Url is
exported correctly in doc files.
Change-Id: I883abe7edcc669213452f4b92cd1530526a9403d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110510
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Fix indentation and drop some extra empty lines that are
automatically removed once the project is loaded in
Qt Creator and then closed anyway.
This will make it a little easier to compare what the initially
generated file looks like compared to the one as it is written
after (implicitly or explicitly) carrying out the configuration
in Qt Creator after loading the project.
Change-Id: I52173162efe635e6fb3e7f889c42ed67271c05b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110535
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Use the 'lib' instead of the 'app' template for the
qmake files in the subdirectories, which avoids
automatically creating a useless run configuration
for each subdirectory pointing to a non-existent
execuatable, like '<BUILDDIR>/accessibility/accessibility'
etc.
With this in place, I just get a single "Custom Executable"
run configuration running 'instdir/program/soffice.bin'
when opening the newly generated 'lo.pro' in Qt Creator 4.14.
Change-Id: I69a7f1b56b02849b217bf66f110d9ee1f61125ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110534
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I2fe98b4bfb221c838a8810f2c08b3e7723e40e8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109428
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: Ic6cabe1d4e5a1e7c4d42294550d654e38e27db22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110458
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
|
|
Change-Id: I0a7b3a5fc89bcbced4acee18415308ed8aa57ba2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109035
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 408e59359b5b67af119059a5d3f47bc807f81300)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110434
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
|
|
Change-Id: I0224b161cb419ac731b962232f77c8911400a7a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110515
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Extending this:
https://gerrit.libreoffice.org/c/core/+/110512
Change-Id: I9e7cf757a346d603d0acb818be0c9bc488c8d5c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110516
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
* Update helpcontent2 from branch 'master'
to 1a00a0acf7ded93fbe1c684f3a4a3b8821ef81ff
- tdf#132643 Translate German section IDs
Change-Id: If7cbdf219ff475bca82b192001bf26d116fb7b7b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110529
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to acf0b947624c801d8d5a367cd3e053a893e8eb42
- tdf#132643 Translate German section IDs
Change-Id: Iabde3845a10b5d62d0d97f582d18baec38cdeea7
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110528
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to eb9ea4ae07baa8fb50cc53506cff5f41a6245f8e
- tdf#132643 Translate German section IDs
Change-Id: Ia647a7b289a42d2e9e556f6a2943de8a0468d07c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110527
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 4803fd8060756e247bed6aeffe8c69b69c6877cf
- tdf#132643 Translate German section IDs
Change-Id: I44600da4388360e4b31a098b100071e62f3d4b7b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110526
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 7ecb8df9bffc2b3c0c9ca4386d16121c57b77c39
- tdf#132643 Translate German section IDs
Change-Id: Ib3b19c482c4a4a1c6e76dd1d0c90bf89e7b8a9b8
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110525
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: Idf57df70ac895915959e8d35e493c0e8b8db137f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109080
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
Extending this:
https://gerrit.libreoffice.org/c/core/+/110512
I add a simple check about the subject.
Change-Id: Iec63299f5c0a03f2ddd0e06549ddc9dba0fb28fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110514
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I30743ea4caf9702f26005567d293f076ff7f78fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110517
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
|
|
Commit 4dc823990ab217cb9d07a0555d3015d43380fdf5 ("tdf#107852
Support DisplayName property for table styles") only handled
the getPropertyValue method, which isn't enough to make it
work with introspection, as used from Basic or the new dev
docking panel.
Change-Id: Ia4d90ab6030585dc469c0b274bef4b988ce647c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110468
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Change-Id: I9bc31ac6a3990418c11a2f40ec0cc84f79f93d53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110495
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
There are no functional changes, only type change.
This patch unlocks other possibilities like:
- Syntax highlight for errors
- Visual editor for structure nodes
- Implement some mathml features
Change-Id: I76a1b62126ae5fcb6a7285b07b24e9defa63fd44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110481
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I3cd72110ae2601b1b11539702c5fb91086d779eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110486
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iaa428f28ba36b21766d9cf2f7c622a179daf0002
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110492
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6baf00837de37604a872bb1a125010a7a6f06e89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110511
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Made modifications for:
- Being able to highlight syntax errors
- Displaying error description in visual editor
- Easier constructor
- Rely on starmathdatabase instead of long switch in code.
Change-Id: Ic6c7f920463090176d80668f9b660ccf3e9b5708
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110497
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This unifies conversion functions to provide both floating-point
and integral overloads, with correct rounding for the latter.
Also sanitizing code it templatized to allow reuse if needed.
Change-Id: Ibe1c9fe4d5baa226c600445779dbaf7dc41a02cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110487
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
* Update helpcontent2 from branch 'master'
to e11819032b6926d774bcb529d629a6c6770fb60d
- Dialog/DialogControl layout updates
+ a few text precisions
Change-Id: I700f78045843a9a8a6a47c6eb002fea8ff213c6e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110443
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I235462f3ce81816f3ce36c7423dd3e50fc03778a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109320
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
The SetFocus() method simply applies the setFocus() UNO method
for usual controls.
However controls belonging to a table control require,
to receive the focus, the columns to be scanned from left to right
up to the targeted column.
Change-Id: Idbb1ca4b4b29bff889daa83cfa895501c466bb26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110485
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
|
|
The documentation for \gutterprl is "Parallel gutter.", but it seems
that's what Word use to convert between RTF and DOCX's <w:gutterAtTop/>.
Change-Id: I06d80f234c6f52950db8a047bfc88910b808977d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110484
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
But leave the fRTLGutter case alone for now, I can't find the Word UI
for that.
Change-Id: I1d97e85308aa13892f50c0fcd3680cec514ef566
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110471
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
* Update helpcontent2 from branch 'master'
to 4d729a974b430318ea296148805a3bb02dfb95e5
- tdf#132643 Translate German section IDs
Change-Id: I1619486a82b8e7739de40f4910bf2d0e179fc308
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110500
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 6f5ef67bda3b22ba2f2fd31ab32c2e2cc88f5c6b
- tdf#132643 Translate German section IDs
Change-Id: I076c6306f60ecb08821cc54c9d8b699b97276b49
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110509
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to ae7a7dd416051bfa975278654a53f4a457f81d6e
- tdf#132643 Translate German section IDs
Change-Id: I98d3445b37b7b744df7363f1f0098aec27c5203e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110508
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to ba779828d2ccc65973ab8d3a14f63c014fdff38a
- tdf#132643 Translate German section IDs
Change-Id: I7ebf4ef926a45aa02dd6ed601c5fe26944ff1232
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110507
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|