summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-07-04Set error on more than max params (255) per functionEike Rathke
Parameter count is size byte, so.. SUM(1,1,1,...) with 256 arguments resulted in 0 (uint8 wrapping around). Change-Id: Ib9997ad0d0d13d4c5171f276148b6c5cad570d5b
2017-07-04reportdesign: -Werror,-Wc++1z-extensionsMichael Stahl
static_assert with no message is a C++1z extension Change-Id: I90750252a5c0b856d74ca0ef3f999d457a9bb8be
2017-07-04loplugin:unusedfields in cui..idlNoel Grandin
Change-Id: Icb393cc0b2f79ded154e186ab6975b95e5126903 Reviewed-on: https://gerrit.libreoffice.org/39496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04Prepare for change of VAR_ARGS valueEike Rathke
Change-Id: I0b1955bb660b5e19587799de657c63634705b99c
2017-07-04xmloff: prefix members of XMLTextStyleContextMichael Stahl
Change-Id: I9db514a20aad0e82a99a02334dfd5910b66e3a01
2017-07-04Move definition of VAR_ARGS and PAIRED_VAR_ARGS to formula/funcvarargs.hEike Rathke
... to have it at one central place instead of two. And add comments why changing the value is not just easily done. Change-Id: I266ea55c79c02a653a0704c33f9fa712bbcd104e
2017-07-04loplugin:unusedfields in sc part3Noel Grandin
Change-Id: I7323e8644e5d336d52fa21b063264b0847b5e780 Reviewed-on: https://gerrit.libreoffice.org/39064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04tdf#96505 Get rid of cargo cult "long" integer literalsJens Carl
Remove "long" integer literals in extensions/ Change-Id: I2eb5daa178ec9adcaddb999bad410aff0e94220c Reviewed-on: https://gerrit.libreoffice.org/39149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-04typo in commentStephan Bergmann
Change-Id: I816f2dad87d798296e60a5eb8842a147f504b90b
2017-07-04loplugin:unusedfields in editengNoel Grandin
Change-Id: I9806d87028a11a8103c35004c87b5098ca591409 Reviewed-on: https://gerrit.libreoffice.org/39495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04Fix tdf#106029 - Add setting XML_doNotExpandShiftReturn when exporting to docxnikki
Change-Id: Ie8ffb0f2d5444c6ead13bdc894715c5a2e6d0baa Reviewed-on: https://gerrit.libreoffice.org/36485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-04loplugin:unusedfields l10ntools..rscNoel Grandin
Change-Id: I78785eeab436910c9e8733924a7c43fa998ba36f Reviewed-on: https://gerrit.libreoffice.org/39491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:unusedfields in formulaNoel Grandin
Change-Id: I5d8fe8869087efda68d040448b2d9e0e7e5611f6 Reviewed-on: https://gerrit.libreoffice.org/39493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:unusedfields in frameworkNoel Grandin
Change-Id: Ibb602e037bcee518c31dfe9734a5c5773cff23ab Reviewed-on: https://gerrit.libreoffice.org/39492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04support for saving a modified image instead of original versionMarco Cecchetti
Normally when you save an image through the "Save..." entry in the context menu for an image, the saved image is the original one more eventually applied filters (which are not removeable). Further applied transformations like rotations, cropping, color effects are not included in the saved image. This patch offers the user to choose if saving the original image (with filters) or the modified version through a pop-up dialog. The new feature is available in Writer, Draw and Calc. Change-Id: I4f983e3a5e8a6839fa5789a96c4d8c44477c1fd7 Reviewed-on: https://gerrit.libreoffice.org/39480 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-07-04tdf#105095 DOCX import: conditionally ignore leading tab in footnotesMiklos Vajna
Commit b38629ae210b204a6d24d6e9c5c62eaaf563d494 (cp#1000017 DOCX/RTF import: avoid fake tab char in footnotes, 2013-12-05) added code to strip leading tabs from footnote text to improve odt->docx->odt rountrip experience. Turns out that this is correct only in case the gap between the footnote number and the content is provided by a paragraph margin. In case there is no such margin, then the tab is wanted; so only conditionally ignore such leading tab characters. Change-Id: I9d419bf2fd3b4899208489210cbe9809a2ab0736 Reviewed-on: https://gerrit.libreoffice.org/39490 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-04Any mentioning of "1 to 30" arguments is nonsenseEike Rathke
Except for CHOOSE that is limited to 30 jumps. Change-Id: I91c139ec574595eea00fb282887476e790bc95b2
2017-07-04Remove artificial parameter count limit from NPV()Eike Rathke
Change-Id: I09b1afa89d57a41a3c58cd7cc27ea62dcd508550
2017-07-04Use ReverseStack() in NPV()Eike Rathke
Change-Id: Iff84889c4ff5f7a2c5916e18911cbf624937a8f4
2017-07-04Remove artificial parameter count limit from SUMPRODUCT()Eike Rathke
Change-Id: I49956ebad76628588743e2af4eee9bfde4775198
2017-07-04Remove artificial parameter count limit from GRETPIVOTDATA()Eike Rathke
Change-Id: I28fd0398fa7c8a45e8b372c79955f20eb3ff8c99
2017-07-04loplugin:unusedfields in sdNoel Grandin
Change-Id: I42def3dc21ae1a18e1c98d1aeeff4ed4425e941a Reviewed-on: https://gerrit.libreoffice.org/39479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:unusedfields in sfx2Noel Grandin
Change-Id: I9f57545ca4ee5159a095f9b35267d298ccc7fb4e Reviewed-on: https://gerrit.libreoffice.org/39476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:unusedfieldsNoel Grandin
Change-Id: I6bf3de7ba6e6bff2fd607156a0dcdd554887e491 Reviewed-on: https://gerrit.libreoffice.org/39475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04extract common code in TokenPool into templateNoel Grandin
Change-Id: I773ade4f8c4f1a2a99f80482b7dd86212137b2c4 Reviewed-on: https://gerrit.libreoffice.org/39305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:casttovoid: fix containsPreprocessingConditionalInclusion()Stephan Bergmann
...and re-enable plugin Change-Id: I0b42cfc0f0b45711e714e6661ae9dd39f05f8960
2017-07-04loplugin:casttovoidStephan Bergmann
...cases that were initially missed due to the broken containsProcessingConditionalInclusion() Change-Id: Ib7d801ab5173ee590ef35a9e075d3ce4d4aa06da
2017-07-04loplugin:casttovoid in VCL_BUILDER_DECL_FACTORYStephan Bergmann
Change-Id: I4b0dd08963cf50daa41901975c6f92fe21db2048
2017-07-04loplugin:casttovoid in RTLFUNCStephan Bergmann
Change-Id: I810278640936e9b3c73f56a37e8c4786fd2790e3
2017-07-03EditEngine: Added test to check multi para start copy/pasteVarun Dhall
Change-Id: Ic253af5ab75783280926f2ed8387f69015014227 Reviewed-on: https://gerrit.libreoffice.org/39488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-03No need anymore to duplicate DBFType enumJulien Nabet
Change-Id: I4108cc3ec98796f6d5e2e5ba139f20f00a692d30 Reviewed-on: https://gerrit.libreoffice.org/39486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-07-03tdf#108609 rtl mode set on ruler when it should be ltrNoel Grandin
regression from commit 8ccbc16b5e3f94b8db105232d7085a8553e6bc03 "convert SvxFrameDirection to scoped enum" Change-Id: I2063ddf4344fb41b54f2ad96a471df4d3205406d Reviewed-on: https://gerrit.libreoffice.org/39478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03Revert "Workaround to call /app/bin/xdg-open when run under flatpak"Stephan Bergmann
This reverts commit 28a03248b1d1649e157b788e43dfe8326f165379 (and removes a stry empty line). There is no more need for our own /app/bin/xdg-open, as xdg-open in the freedesktop.org (and thus also GNOME) runtime (see <https://github.com/flatpak/flatpak-xdg-utils/blob/master/src/xdg-open.c>) by now knows to ask the Desktop portal, too. Change-Id: Ie4141d02ba5f43c0264afcfae9edfc2d3a8cdb16
2017-07-03Access2Base - RecordSource property of Form classJean-Pierre Ledure
Use Command instead of ActiveCommand which delivers only SQL statements while expected command type should be table, query or sql Change-Id: I824a02cf5dab7b59f70b3a0ae9ba9f874e86733b
2017-07-03Restore copyright headerSamuel Mehrbrodt
Change-Id: I390ba8851bb16ca37c2af97d2fa0ab6bdf4a9a14 Reviewed-on: https://gerrit.libreoffice.org/39481 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-03tdf#108524 sw: attempt to split section frames inside table cells, take twoMiklos Vajna
Tables-in-sections were already split across multiple pages, but not secions-in-tables. To be safe still don't allow sections-in-tables-in-sections, so you can combine these in both orders now, but not recursively. To achieve this, relax two "not in table" conditions to just require "not in a table that is already in a section", and define that in case a section-in-table is to be split, the follow section frame should be inserted under the follow of its cell. With this, finally the section frame in the bugdoc is split into two, and the second section frame is moved to the second page as expected. This restores commit f991b842addddeada6dc45c4054deeca5aa7f17b, but this second take makes sure that we do not crash while laying out ooo61225-1.sxw. GetNextSctLeaf() used to assume that SwTableFrame::Split() created the follow cell frames; and when that wasn't the case, it crashed. Still don't attempt to create the cell frame in GetNextSctLeaf(), but handle when the cell follow frame is missing, and return early, as it used to be the case before this commit. Change-Id: I9dcc76b4c61b39b9d23b140b84420e89cf274cf3 Reviewed-on: https://gerrit.libreoffice.org/39471 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-03loplugin:unusedfields in slideshow..svtoolsNoel Grandin
Change-Id: I74d5a4b8cfc4b18267f99648a3112b163c91fd8c Reviewed-on: https://gerrit.libreoffice.org/39474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03loplugin:unusedfields bIsMarked in SvTreeListEntryNoel Grandin
write-only since GetIsMarked was removed in commit 06ea347b939895d3091ce747c26de58f4d4a766a "loplugin:unusedmethods svtools" which in was unused since introduced by commit b755fb8c0f6b1282f62c12f378c0a5ecac64d490 Author: Steve Yin <steve_y@apache.org> Date: Mon Nov 25 16:15:58 2013 +0000 Integrate branch of IAccessible2 Change-Id: I1342d4c020e53380f4c52fadcbf36ff520efaad4 Reviewed-on: https://gerrit.libreoffice.org/39470 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03use begin()/end() when working with SequenceNoel Grandin
Change-Id: Icf9da6a24d72c073338f6fbb513d7250b3898015 Reviewed-on: https://gerrit.libreoffice.org/39469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03loplugin:oncevar (clang-cl): xmlsecurityStephan Bergmann
Change-Id: Ic5e4dac2626474dd3d44ef5097522bc7e2207cd1
2017-07-03loplugin:oncevar (clang-cl): winaccessibilityStephan Bergmann
Change-Id: I26dca32ba03c7fe163886ebcd4a6a8bc4871b065
2017-07-03loplugin:oncevar (clang-cl): vclStephan Bergmann
Change-Id: I0459978c2cfb61cd7251f0e8d9a30f1f19c02c11
2017-07-03loplugin:oncevar (clang-cl): toolsStephan Bergmann
Change-Id: I6670c2fd0c5897939b16874ed2106475fa948d2d
2017-07-03loplugin:oncevar (clang-cl): shellStephan Bergmann
Change-Id: I594596f27aa6f223d2294586357b11595377e1fe
2017-07-03loplugin:oncevar (clang-cl): salStephan Bergmann
Change-Id: Ib43dd6f8c96274d251bbf5935888789964ba3f9b
2017-07-03loplugin:oncevar (clang-cl): fpickerStephan Bergmann
Change-Id: I13e11f07a8022b315ffa80282575472bcb0c3acc
2017-07-03loplugin:oncevar (clang-cl): extensionsStephan Bergmann
Change-Id: I70cac146d09f015db3f7889f3cdd46c00c45c41a
2017-07-03loplugin:oncevar (clang-cl): embedservStephan Bergmann
Change-Id: Icc9d01b46975505c54a6395edfbeb15cf25c8700
2017-07-03loplugin:oncevar (clang-cl): dtransStephan Bergmann
Change-Id: I2ec41f641f3784ef86322c25481e6794e29eb889
2017-07-03loplugin:oncevar (clang-cl): connectivityStephan Bergmann
Change-Id: I76dcc99c29302b49a1d66fa22db8b28714421a98