summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-05-17Correct common misspellings, and remove some ASCII art along the way.Chris Laplante
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c Reviewed-on: https://gerrit.libreoffice.org/9356 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17Comment why it's not a copy paste errorJulien Nabet
See http://nabble.documentfoundation.org/Question-unoType-for-getXmlToken-dbaccess-reportdesign-module-td4109071.html Thank you Lionel! Change-Id: I999bad0d6de0327bea7ba04a6c61a497d45f53a0
2014-05-17add missing OpenGL type error stringMarkus Mohrhard
Change-Id: I53a7eba4a4f8b1bd61381283b20190cfc05a138a
2014-05-17prevent access to uninitialized variablesMarkus Mohrhard
Change-Id: I1a12e2453ec935dc642135c30a36e1a97fc3d0f9
2014-05-17vcl: fixup svdemoChris Sherlock
Change-Id: Ifb7cc12da349fcbcd1d3dc25b64cd2bf3fd7e819 Reviewed-on: https://gerrit.libreoffice.org/9378 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-05-16fdo#77735: Don't proceed when all cells in the range are empty.Kohei Yoshida
That means there is nothing to delete, and proceeding would cause Calc to freeze. Change-Id: I2a8fb5736870ba459082873c8f864283d8b9c664
2014-05-16fdo#77735: Write test for this. This test will freeze with the bug present.Kohei Yoshida
Change-Id: I7b7e67fe2ee59b57ce74f8303d30bebc84f6b0d0
2014-05-17Back out change for fdo#78119 now that we have StringContainsWord()Eike Rathke
This reverts commit 3b3b690c1f0479cfbebcfa68595f75a4994e7a5f. With the use of StringContainsWord() it is unnecessary to loop all available names.
2014-05-17resolved fdo#41166 match month and day name word instead of substringEike Rathke
Follow-up, check for ASCII first to avoid calls to i18n, and check the type flags instead of calls to CharClass methods that give unexpected results with their masks. Change-Id: I10e685998299dceb2dbcf1d87ae1de09680b8a99
2014-05-17resolved fdo#41166 match month and day name word instead of substringEike Rathke
Change-Id: I897dbcee47de574d91ba3e3b40a39a35b779fef8
2014-05-16I should check for NULL here.Kohei Yoshida
Change-Id: I245f4a26c8fdee8230bb0af2963cae2739413253
2014-05-17fdo#78149: set the ViewPort even when painting to a MetaFileMichael Stahl
ObjectContactOfPageView::DoProcessDisplay() has a special case for painting to MetaFiles, and does not set the ViewPort from the passed-in RedrawArea unless it's a printing or PDF export, with the result that for a plain MetaFile all fly-frames in a Writer document are painted, whether visible or not. Since e2eda70f2746f08376d8cdf5e5360df217335aef now calls GetPreviewMetaFile() after every document load, this issue is more visible. Since there is no obvious reason to ever ignore a passed RedrawArea, simply always use it for the ViewPort, not just when printing. Change-Id: I256710f1476181f567069b45a2a494b0d2064d6b
2014-05-17sw: try to fix a valgrind warningMichael Stahl
Invalid read of size 1 at SwParaPortion::SetPrep(bool) (porlay.hxx:299) by SwTxtFrm::Prepare(PrepareHint, void const*, bool) (txtfrm.cxx:1756) by SwTxtFrm::Prepare(PrepareHint, void const*, bool) (txtfrm.cxx:1663) by SwCntntFrm::MakeAll() (calcmove.cxx:1310) by SwFrm::OptPrepareMake() (calcmove.cxx:356) by SwFrm::OptCalc() const (frame.hxx:1037) by SwLayAction::_FormatCntnt(SwCntntFrm const*, SwPageFrm const*) (layact.cxx:1829) by SwLayAction::FormatCntnt(SwPageFrm const*) (layact.cxx:1660) by SwLayAction::InternalAction() (layact.cxx:597) by SwLayAction::Action() (layact.cxx:376) by SwLayIdle::SwLayIdle(SwRootFrm*, SwViewImp*) (layact.cxx:2179) Address 0x1f9507e0 is 832 bytes inside a block of size 840 free'd by FixedMemPool::Free(void*) (mempool.cxx:48) by SwParaPortion::operator delete(void*, unsigned long) (in /work/lo/master/instdir/program/libswlo.so) by SwParaPortion::~SwParaPortion() (porlay.cxx:1972) by SwTxtFrm::ClearPara() (txtcache.cxx:102) by SwTxtFrm::Init() (txtfrm.cxx:329) by SwTxtFrm::CalcLineSpace() (txtfrm.cxx:746) by SwTxtFrm::Prepare(PrepareHint, void const*, bool) (txtfrm.cxx:1680) by SwTxtFrm::Prepare(PrepareHint, void const*, bool) (txtfrm.cxx:1663) by SwCntntFrm::MakeAll() (calcmove.cxx:1310) by SwFrm::OptPrepareMake() (calcmove.cxx:356) by SwFrm::OptCalc() const (frame.hxx:1037) by SwLayAction::_FormatCntnt(SwCntntFrm const*, SwPageFrm const*) (layact.cxx:1829) by SwLayAction::FormatCntnt(SwPageFrm const*) (layact.cxx:1660) by SwLayAction::InternalAction() (layact.cxx:597) by SwLayAction::Action() (layact.cxx:376) by SwLayIdle::SwLayIdle(SwRootFrm*, SwViewImp*) (layact.cxx:2179) Change-Id: I64a1cc6ea301b653af951ba0e00e28d4655d2d97
2014-05-17FixesJulien Nabet
Change-Id: I5e2c57f4c53147ab4ae58f48059c8020de144f3c
2014-05-17FixesJulien Nabet
Change-Id: Iaecba29cb5958787ec2581198943d373e37a3934
2014-05-17More fixJulien Nabet
Change-Id: Iadb275a3799195a8c2eb57a975315f21d8215b31
2014-05-17Fix previous commitJulien Nabet
Change-Id: I22ded05f328aeb4479c90e79b12729eb3835b3ec
2014-05-17Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part14Julien Nabet
Change-Id: Ibccaa2138426c22cd63d273a1b6cdc927ebe80dc
2014-05-16coverity#704866 Unchecked dynamic_castMiklos Vajna
Change-Id: Ib1108a6641635bbbb0d88968754d7bb19a8c9e73
2014-05-16unused XGradient::VclGradientMiklos Vajna
Change-Id: Ia0c416ce7c1323f9c0c20b969bd57e9a2174a3dc
2014-05-16sw: fix indentation in rtf{export,import} testMiklos Vajna
Change-Id: Ie777de47dc70da136b145028a08ea17a0de7a87d
2014-05-16OGLPlayer: comment out gltf_animation_get_timeZolnai Tamás
It leads confusing behavior. Time is not set by now because set method does not work. Change-Id: I447d07d4193e25e6916ee05ee335d4cf150380a2
2014-05-16fdo#78799 - ignore overlayed monitors with co-incident origin.Michael Meeks
This happens with certain fglrx drivers etc. where 'cloned' is not set but instead both monitors are placed over the top of each other (by XFCE) -> work around that. Change-Id: I9d1846bfae2692681606717f7f5e8408df532d95
2014-05-16WaE: unused parameter 'fTime'Tor Lillqvist
Change-Id: I1f44de228fe09584699a1e158c32882cd9e7eac7
2014-05-16Fix typo: this is a static libraryZolnai Tamás
Change-Id: I663e8da9ee3f4b860d727abb3783e322eedd7d9f
2014-05-16fdo#77315: When in cell edit mode, use the EditView instance already there.Kohei Yoshida
This prevents creation of a temporary EditView instance which would mess up the cursor state while the mouse pointer is hovering. Change-Id: I7759667b105b4389dd4de2673cd2fbe32082c95d
2014-05-16use SvxLanguageBoxBase* in the general routinesEike Rathke
... so we can switch later to an SvxLanguageComboBox for some. Change-Id: I1a48ee7207a14b2666be09f091c47f09fcbce192
2014-05-16OGLPlayer: fix playing of animation in edit modeZolnai Tamás
gltf_animation_set_time doesn't work but stops the animation. Change-Id: Ia17724c36e2007451e24f97e04a09240359ad969
2014-05-16Collada2gltf: add -lrt to fix compilation problemsZolnai Tamás
Change-Id: I1c0c9459cb716512dc726ee96fb811d03084aa62
2014-05-16OGLPlayer: set a timer which call redrawing to show animationZolnai Tamás
Change-Id: I7c98ba61be0510e9f86cb80fda73d18f7f7957cf
2014-05-16more SvxLanguageBoxBase interfacingEike Rathke
Change-Id: Ife9317d40756099ae4d8ecb84cccea91bd75a14c
2014-05-16strangely obvious leaky codeCaolán McNamara
Change-Id: I968cbb784d53e0cff0649061c58f752939226a09
2014-05-16valgrind: SfxBaseModel's pImpl of fallback TargetDocument for paste leaksCaolán McNamara
e.g. repeatedly pasting a metafile into writer and deleting it. ==13369== 342 (232 direct, 110 indirect) bytes in 1 blocks are definitely lost in loss record 19,396 of 22,170 ==13369== at 0x4A06965: operator new(unsigned long) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==13369== by 0x686D72E: SfxBaseModel::SfxBaseModel(SfxObjectShell*) (sfxbasemodel.cxx:518) ==13369== by 0x288CA9C1: SvxUnoDrawingModel::SvxUnoDrawingModel(SdrModel*) (unomod.cxx:255) ==13369== by 0x28961055: SvxDrawingLayerImport(SdrModel*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, char const*) (xmlexport.cxx:164) ==13369== by 0x28960FA2: SvxDrawingLayerImport(SdrModel*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&) (xmlexport.cxx:148) ==13369== by 0x2896175E: SvxDrawingLayerImport(SdrModel*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&) (xmlexport.cxx:254) ==13369== by 0x240B1002: SwFEShell::Paste(SvStream&, unsigned short, Point const*) (fecopy.cxx:1333) ==13369== by 0x247B981A: SwTransferable::_PasteSdrFormat(TransferableDataHelper&, SwWrtShell&, unsigned short, Point const*, unsigned char, bool) (swdtflvr.cxx:2207) ==13369== by 0x247B678E: SwTransferable::PasteData(TransferableDataHelper&, SwWrtShell&, unsigned short, unsigned long, unsigned short, bool, bool, Point const*, signed char, bool) (swdtflvr.cxx:1481) ==13369== by 0x247B5AE4: SwTransferable::Paste(SwWrtShell&, TransferableDataHelper&) (swdtflvr.cxx:1150) ==13369== by 0x2488FCCE: SwBaseShell::ExecClpbrd(SfxRequest&) (basesh.cxx:277) Reference< lang::XComponent > xTargetDocument( xComponent ); if( !xTargetDocument.is() ) { > xTargetDocument = new SvxUnoDrawingModel( pModel ); pModel->setUnoModel( Reference< XInterface >::query( xTargetDocument ) ); } Change-Id: I3bd0fc983d9b6bdcdc91071a4ec3d2c584397ebf
2014-05-16fix memory leak on pasting metafiles into writerCaolán McNamara
copying from mspaint to writer and then deleting the image in a loop will eventually exhaust all memory. regression since 004a29b9ac66f68af5ea12a2303a4b2be77d8145 Change-Id: I381285cda3823de7df0c1725a339943caf9536fe
2014-05-16OGLWindow: fix key capturing issueZolnai Tamás
Sometimes the event handler parent captures the mouse moce which should grab the focus for key event handling. Change-Id: Ida1022968543059154de824fc3d026c5cecba7b3
2014-05-16slideshow/glTF: make sure parent window does not cover the OpenGL windowZolnai Tamás
Change-Id: I0da3978cefeb3d145f7411cc1c83a87d981cac62
2014-05-16Use SQL_DEFAULT_TXN_ISOLATION to get getDefaultTransactionIsolationJulien Nabet
Change-Id: I7f4785088151490ae1d55d2bb78bce28357d5c45 Reviewed-on: https://gerrit.libreoffice.org/8863 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-16Access2Base - Correct error message for some actionsJean-Pierre Ledure
Change-Id: I8b49886c3b9a884ffc8e68c7483be8f940c3449e Reviewed-on: https://gerrit.libreoffice.org/9376 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-16Access2Base typoJean-Pierre Ledure
Change-Id: Id5161f2b8e8132c2a8b68073b233137db3fe74b1 Reviewed-on: https://gerrit.libreoffice.org/9373 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-16Access2Base - solve compatibility issuesJean-Pierre Ledure
1) AOO <> LO "Append" is a reserved word in AOO Basic, not in LO => Append method replaced with Add 2) Windows <> Linux ActiveConnection not ready under Windows for standalone forms when database is (user/password) protected => Connection may be postponed to first use of form Change-Id: I8ba409191ba2a2a4c057480ec3287d7d48262073 Reviewed-on: https://gerrit.libreoffice.org/9372 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-16coverity#708868 Unused pointer valueCaolán McNamara
Change-Id: I5d25f7de37df6fe79bb195e1cb68876fb3b4fcca
2014-05-16coverity#708847 Unused pointer valueCaolán McNamara
Change-Id: Id16ebc576834e418a3bf2d3d6eb3e2545e0aac2b
2014-05-16coverity#708815 Unused pointer valueCaolán McNamara
Change-Id: Ie58034f0475dc9a876eeb54f3bc6a3c415c3e0a1
2014-05-16coverity#708811 Unused pointer valueCaolán McNamara
Change-Id: I18ed52cc6c00c5c462629c4fff7804ea22035e3a
2014-05-16coverity#984442 Use after freeCaolán McNamara
Change-Id: I28822f6b74cbf8ace8f7a194248840cb401679be
2014-05-16coverity#705542 Unintentional integer overflowCaolán McNamara
Change-Id: I87712c71689d45259bc9e4e2f71c92375bc887ea
2014-05-16trivial cleanupsCaolán McNamara
Change-Id: I50bc7ab36690e572825109de9f0b1bb11d26867f
2014-05-16coverity#1202771 Operands don't affect resultCaolán McNamara
Change-Id: I6a0228594d31cda252f299cad55469ad02c6b353
2014-05-16Use SVM (metafile) instead of PNG for diagrams (SmartArt)Tor Lillqvist
It seemed a bit pointless to waste CPU cycles on PNG-compressing a bitmap image only to later then uncompress it anyway. vcl's PNG writing code showed up as 13% on the time profile of TiledLibreOffice when displaying a document full of SmartArts. Miklos suggested I try using SVM (which I guess means "StarView Metafile") instead. When using SVM, no rendering of diagrams to bitmaps during loading is done, but the diagram stays stored in a resolution-independent (vector-ish) form. Which means it will be rendered nicely and crisply regardless of the zoom level. At least, that is my understanding, and experimentation (on OS X and Linux) seems to confirm. ce8c0ff07559ddcc729bffd7a68f4c6f281882e3 Change-Id: Ice8c0ff07559ddcc729bffd7a68f4c6f281882e3
2014-05-16git pre-commit hook: block large filesMiklos Vajna
Change-Id: Id27cfa805fc7cd0f4f6cc3d8bb770aa7abd536e1