summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11python3: upgrade to release 3.5.4David Ostrovsky
Change-Id: I9300b2ec1e1dcedbcbfe793e1450166af1bf1944 Reviewed-on: https://gerrit.libreoffice.org/40944 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-11Fix typosAndrea Gelmini
Change-Id: Ia36c8abe91e8c2ac46498e88def59a9887711ba1 Reviewed-on: https://gerrit.libreoffice.org/41014 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-11Removing unused SfxItemPool serialisation from svxVarun Dhall
Change-Id: Id479c77335c7c4d8dd959a70ebc382a8448077e1 Reviewed-on: https://gerrit.libreoffice.org/41000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-11tdf#105705 sw: fix another case of bookmarks becoming un-sortedMichael Stahl
The loop in SwTextNode::Update() that reassigns bookmark end positions away from the node to a temporary SwIndexReg can stop prematurely in a particular situation where there is a bookmark that is expanded and with both mark positions at the critical "rPos" insertion position, and also both their SwIndexes consecutive in the SwIndexReg::m_pFirst linked-list. What happens then is that the iteration gets to the first of the 2 consecutive positions of the bookmark, then calls GetMarkEnd() on the mark, which happens to return the other position, which is already stored in the "next" local variable. That other position is then moved to aTmpIdxReg, and in the next loop iteration GetNext() is null as it is the last one in aTmpIdxReg and the loop terminates. Thus various bookmark end positions don't get preserved, or the bAtLeastOneExpandedBookmarkAtInsertionPosition doesn't get set, either of which can cause the bookmark array to lose its sort order. This was found playing around with Zotero 4.0.29.10, while switching between different citation styles. (regression from 6a5dbe73537642b06bcde782118a34b4593d17eb) Change-Id: Ia35ce0656bcb2d6af7ea189458af3942ff83e4da
2017-08-11tdf#109216 - Alignment/spacing at the new controls in the special charactersAkshay Deep
Change-Id: I7c07750e131060fb8ba796e7dcdc5f5bafcb1d74 Reviewed-on: https://gerrit.libreoffice.org/40916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-11tdf#108494 fix regressionSzymon Kłos
* correct watermark position * insert also on left and right pages if headers are different Change-Id: Ibacfa6ea14bd8e9c1fd0d0b15de020b30d0a109f Reviewed-on: https://gerrit.libreoffice.org/40891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-11EPUB export: rework to use context classesMiklos Vajna
Before writerperfect::exp::XMLImport grows into a God object. Also, if I'm at it, recurse into text:h to include heading text. Change-Id: Iede56d00dbede40186b6484d0be92a2ac2e4768e Reviewed-on: https://gerrit.libreoffice.org/41005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-11sw: fix inconsistent param naming in interface/implementationMiklos Vajna
SvxPostureItem& rWeight is confusing at best. Change-Id: I70a7e94151f49bf3539af77160cd4a68b8753464 Reviewed-on: https://gerrit.libreoffice.org/41006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-11ofz#2906: direct-leakCaolán McNamara
Change-Id: I61323f36922842ddc45b2a63a9ba7334c847a8fd
2017-08-11sax parser: remove long-disabled codeThorsten Behrens
Entity ref and decl was disabled since 2014, let's remove it now. Change-Id: I35dac78b8530bab99e955bf68dfe3f8951a63f99 Reviewed-on: https://gerrit.libreoffice.org/40998 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-08-11Correct icon size assignmentYousuf Philips
Change-Id: I9cefadba78688aebbf93e63f0bf29dbe96839fea Reviewed-on: https://gerrit.libreoffice.org/38408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-08-11tweak string convert table dialog to load the same with native gtk builderCaolán McNamara
Change-Id: I5f6753645452b578d30909614cb3cc36ae3d7e64 Reviewed-on: https://gerrit.libreoffice.org/40983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-11Typos about "translate"Julien Nabet
Change-Id: I6047920ef5860f0f3535467d6af1d1bf0aa250af Reviewed-on: https://gerrit.libreoffice.org/40988 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-11editviewoverlay: corrected AttributeChangeArmin Le Grand
EditView on Overlay visualization needs to handle selection change when e.g. FontSize attribute of a selected text portion changes. Changed handling so that selection overlay is an integral part of text visualization overlay and refreshing text visualization always refreshes selection visuals, but not the other way around. Both anyways check for real change, so just extra testing is avoided which is still the better solution Change-Id: I3ce6570fd9a18a7c1d7ced4bc4ca9aeda57538e0 Reviewed-on: https://gerrit.libreoffice.org/40993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-08-11tdf#111492 Honor ODF 1.2 style tab indentation in XHTML exportSamuel Mehrbrodt
Change-Id: I9db61ed54b59b142d5198ec977044f7f52ba6b4d Reviewed-on: https://gerrit.libreoffice.org/40981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-08-11Add xsl files to .editorconfigSamuel Mehrbrodt
Change-Id: Ic5e44527eb821b42b607cc805d6f2e6883a74755 Reviewed-on: https://gerrit.libreoffice.org/40982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-08-11Revert fallout from 772686adb99137733db79b7d1ab6ebb21bf93b4aSamuel Mehrbrodt
Change-Id: I0f05373d76435341ab2fbbf93840686a3f702308 Reviewed-on: https://gerrit.libreoffice.org/41004 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-08-11tdf#111567: fix memleak in TemplateLocalView::insertItemsJulien Nabet
Clearing mItemList at the begin of insertItems is a bad idea because it prevents ImplDeleteItems (called by updateItems, itself called at the end of insertItems) from clearing correctly mItemList See comments from bugtracker for more info (Thank you Alex for the precious info attached with memleak reports! :-)) Change-Id: I04976dbb065d1369562649fc97c33f7fd599b107 Reviewed-on: https://gerrit.libreoffice.org/40995 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-10tdf#111318: Improve msg about pivot table/chart when removing a cell (take 2)Julien Nabet
Change-Id: I56e0fb1716d38471682084569d48907520922b26 Reviewed-on: https://gerrit.libreoffice.org/40991 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-10tdf#107797 UpdateAutoFilter handle more entriesTamas Bunth
Prepare UpdateAutoFilterFromMenu to handle more entries. Filter items can be hold by more than one entries. In that case we have to remove all the old entries before updating. E.g. setting AutoFilter from vba script results in more than one entries. Change-Id: I4f18f26281d0b8e689cd331f9a66f4c344fb6c6b Reviewed-on: https://gerrit.libreoffice.org/40967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-08-10tdf#107858 oovbaapi: Autofilter always has headerTamas Bunth
If AutoFilter created with vba macro, it should always use a header (because Excel does the same), regardless of the type of cells in the first row. Change-Id: I586e092ac62c893b9873cc4b988566d8f00636cc Reviewed-on: https://gerrit.libreoffice.org/40969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-08-10WIP: Removing unused SfxItemPool serialisation from svxVarun Dhall
Change-Id: I3222033fadd688959fd55e3f335540054fc418f4 Reviewed-on: https://gerrit.libreoffice.org/40612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-10tdf#39468: Translate some german commentsChristian Barth
Change-Id: Ie9062738de26b44394d4c91b31fab99a7777813f Signed-off-by: Christian Barth <Christian.Barth@zoho.com> Reviewed-on: https://gerrit.libreoffice.org/40994 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-10Fix typosAndrea Gelmini
Change-Id: Ia138abbdb81f0c324721118d487392757f779a96 Reviewed-on: https://gerrit.libreoffice.org/40971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-10external data: add a method to list all data providersMarkus Mohrhard
Change-Id: I4bb29288dc16aa8c076a0957ea777e8e7451acf0 Reviewed-on: https://gerrit.libreoffice.org/40966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-10external data: fix a few issues with the dialogMarkus Mohrhard
Change-Id: I16358e785d4ebd6375c98b84f4a31d3fa604d734 Reviewed-on: https://gerrit.libreoffice.org/40965 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-10external data: use the DB name instead of a DB pointerMarkus Mohrhard
When we modify the DB range we create a copy and replace the original DB range with the modified one. Therefore, we would store a pointer to a deleted object. We can always get the range through the name. Change-Id: Ifce28efb7263c300c2c8722ac969807de1ab8b2a Reviewed-on: https://gerrit.libreoffice.org/40964 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-10external data: import all the csv dataMarkus Mohrhard
Change-Id: Ifcb2c42594713ed263ef38c1ef0e8bc0efbce01e Reviewed-on: https://gerrit.libreoffice.org/40963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-10Revert "tdf#111318: Improve message about pivot table/chart when removing a ↵Julien Nabet
cell" This reverts commit fac539889e32e5e47ca6b6da0a588abbe4cbe066. Change-Id: I1496f13119936e7be24345bc6f56469ce40b6080 Reviewed-on: https://gerrit.libreoffice.org/40990 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-10external data: some work on the dialogMarkus Mohrhard
Change-Id: I4962688db1ccd766a7ff0e379033b5dc19a7462b Reviewed-on: https://gerrit.libreoffice.org/40962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-10external data: make sure we don't use wrapping during copyingMarkus Mohrhard
Change-Id: Id369ea3be5c318704fa6907df30d11ef0764f65b Reviewed-on: https://gerrit.libreoffice.org/40961 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-10external data: use the existing copy data functionalityMarkus Mohrhard
Change-Id: Id9eb9bcfaf67a17a945b69d8bc65c7180051f90d Reviewed-on: https://gerrit.libreoffice.org/40960 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-10external data: remove some unnecessary concepts from the csv threadMarkus Mohrhard
Change-Id: Ie0299307b32808f91f1043794a149eb8f8d4f948 Reviewed-on: https://gerrit.libreoffice.org/40959 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-10external data: move the copying to the document to ScDBDataManagerMarkus Mohrhard
Change-Id: Ic97dcc6418176630ceb50c0c6010c848f2302b59 Reviewed-on: https://gerrit.libreoffice.org/40958 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-10Add UI for the sc::dataproviderJaskaran Singh
Change-Id: I29acc8903d5694e46e7575133ee852bbaae6eeee Reviewed-on: https://gerrit.libreoffice.org/40851 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-10tdf#88742 Renaming of Styles deckheiko tietze
Styles and Formatting renamed to just Styles Change-Id: I058d41589cf94de556ed4b4e0e0fb7048be1eff2 Reviewed-on: https://gerrit.libreoffice.org/40487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-08-10EPUB export: write EPUB3 outputMiklos Vajna
EPUB3 was released in 2011, it makes little sense to target the older EPUB2 in new code. Change-Id: Ifdd547bfc7e8f097124ed3effe9053ee2e5f2163 Reviewed-on: https://gerrit.libreoffice.org/40975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-10tdf#109187 Fix OOXML import of flipped shapes with gradientsPaul Trojahn
The rotation of the gradient instead of the shape needs to be flipped because OOXML flips shapes before rotating them. Change-Id: I332412078ae0f8d555bd462964c7b20037147e02 Reviewed-on: https://gerrit.libreoffice.org/40136 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-10xmlsecurity: Log unknown xml elements for ooxmlSamuel Mehrbrodt
Change-Id: I0daf81ac91da1d6206282e486298d059b937bb21 Reviewed-on: https://gerrit.libreoffice.org/40819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-08-10tdf#109317 Fix incorrect rotation of flipped custom OOXML shapesPaul Trojahn
The shape wasn't imported correctly because IsPostRotateAngle wasn't set. As a result the shape was flipped after it was rotated instead of before. This commit removes 1c44b263 and converts the rotation to the internal format instead. This also fixes that ooxml preset shapes can't be exported to odf correctly and that ooxml preset shapes rotate in the wrong direction when rotated in LO. Change-Id: I9691902fdfb2cfecc8fe50d6eb66ac3880ddd4e8 Reviewed-on: https://gerrit.libreoffice.org/40789 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-10SmartArt: add nested shapes only if they are node's childrenGrzegorz Araminowicz
Change-Id: I6527fc4166001ffc1e1e170b179cd4eadf55305c Reviewed-on: https://gerrit.libreoffice.org/40870 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-10editviewoverlay: Adapted URL in edit modeArmin Le Grand
For histotrical reasons a URL in edit mode is visualized in a single line. To keep compatible, also do this when EditView is on Overlay Change-Id: Ib11b1716aa558c13295a8a02e2845a88fa98ed11
2017-08-10editviewoverlay: correct reaction on property changeArmin Le Grand
Do not hand over LogicalSelectionRanges directly on selection change, better let the visulizer do what he needs. On AttributeChange, tge resulting repaint needs to refresh all OverlayObjects, not only text, but also the selection to make look okay e.g. at font size change Change-Id: Ibb9737c33d6f85a9f68df3edbb989c0443cd4a5c
2017-08-10editviewoverlay: more cases securedArmin Le Grand
Added support for vertical text, checked all combinations for text positioning, secured cursor stuff, ensured collaboration with LibreOfficeKit Change-Id: I98d1187700907c0c72abdccb9c9979496f6c20cf
2017-08-10editviewoverlay: EditViewSelection reorganizedArmin Le Grand
The Selection visualization in EditVierw is organized to use XOR for visualization, thus DrawSelection is used e.g. before and after changes to the Selection. Ensured athat all changers of selection have to use SetEditSelection by making return of GetEditSelection const. This allows to use a central and safe SelectionChanged which is needed for alternatives of Selection visualization. Change-Id: I994553f3be6b58fd595aa500922d8d1d8ddd36d4
2017-08-10editviewoverlay: Allow EditView to run in OverlayArmin Le Grand
This is the first basic functionality to get the active EditView with EditEngine work in the Overlay which all Apps support. Reason is that the current EditEngine 'plugs' into the Window and uses Invalidate() calls to repaint deeply everything under a text change. While this is acceptable for simple cases it can get very slow when there are excessive, expensive to paint objects in the background, e.g. MasterPages in Draw/Impress with gradients and other stuff. This was avoided in older versions (LO51) by 'guessing' a good BackgrundColor by the EditEngine, not invalidating but painting actively using that guess (with better or worse results) which someone removed. For the future it is anyways the better way to get the EditEngine functionality to Overlay and using Primitives, this will be a first step. This may enable Text Editing without repainting the Background (fast), using a non-XOR selection paint and more. It will need thorough testing and further experimenting due to EditEngine being used in many places (DrawObjects, Calc Cells, Formular Fields, Controls, ...) Change-Id: Ib9eb0f3999fd61a82ddf7a60ab1ea6ccda3a60da
2017-08-10related tdf#111518 pptx: These attributes are not supposed to be here.Jan Holesovsky
Change-Id: Ibd61bd32ce23f5966ec69d16540d6e4a70b4ad59
2017-08-10tdf#62303: Drop version in installdir name for releases on WindowsMike Kaganski
Change-Id: Iad07c19a6f87ea697a499b6075752d9f24ba1cb4 Reviewed-on: https://gerrit.libreoffice.org/40957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-08-10loplugin:unusedenumconstantsNoel Grandin
Change-Id: I54c0c1fca8ea5c89e71c6cd1110fad081ed3d334 Reviewed-on: https://gerrit.libreoffice.org/40953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>