Age | Commit message (Collapse) | Author |
|
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend
loplugin:external to warn about enums".
Cases where free functions were moved into an unnamed namespace along with a
class, to not break ADL, are in:
filter/source/svg/svgexport.cxx
sc/source/filter/excel/xelink.cxx
sc/source/filter/excel/xilink.cxx
svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx
All other free functions mentioning moved classes appear to be harmless and not
give rise to (silent, even) ADL breakage. (One remaining TODO in
compilerplugins/clang/external.cxx is that derived classes are not covered by
computeAffectedTypes, even though they could also be affected by ADL-breakage---
but don't seem to be in any acutal case across the code base.)
For friend declarations using elaborate type specifiers, like
class C1 {};
class C2 { friend class C1; };
* If C2 (but not C1) is moved into an unnamed namespace, the friend declaration
must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see
C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither
qualified nor a template-id and the declaration is a function or an
elaborated-type-specifier, the lookup to determine whether the entity has been
previously declared shall not consider any scopes outside the innermost
enclosing namespace.")
* If C1 (but not C2) is moved into an unnamed namespace, the friend declaration
must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882>
"elaborated-type-specifier friend not looked up in unnamed namespace".
Apart from that, to keep changes simple and mostly mechanical (which should help
avoid regressions), out-of-line definitions of class members have been left in
the enclosing (named) namespace. But explicit specializations of class
templates had to be moved into the unnamed namespace to appease
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of
template from unnamed namespace using unqualified-id in enclosing namespace".
Also, accompanying declarations (of e.g. typedefs or static variables) that
could arguably be moved into the unnamed namespace too have been left alone.
And in some cases, mention of affected types in blacklists in other loplugins
needed to be adapted.
And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which
is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is
not moved into an unnamed namespace (because it is declared in
sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about
such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler
doesn’t give this warning for types defined in the main .C file, as those are
unlikely to have multiple definitions."
(<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The
warned-about classes also don't have multiple definitions in the given test, so
disable the warning when including the .cxx.
Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4
Reviewed-on: https://gerrit.libreoffice.org/83239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
where it was showing before tabbing away
Change-Id: Ia87aeb9789ae034611431983c6489569a59d47d3
Reviewed-on: https://gerrit.libreoffice.org/83434
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
This replaces LO 4.3 commit 8766011bccfd0f12f8dd77d2f94eb16e2e8c3471
DOCX import: set document-level font size default based on default para style
...and is needed for tdf#118947, since bogus DEFAULT_VALUEs
really hinder determining what a table style should override.
Shape text should inherit the font size from the style that is specified.
In many cases, it will not be specified, and therefore the default style
was appropriate, but in cases where a style IS specified, then of course
use that fontsize ... and every other character and paragraph property.
HOWEVER, I only added the properties used in vml import for now,
and I skipped asian/complex fontnames since VML only handles CharHeight,
and not CharHeightAsian/Complex.
-note: this does not affect direct formatting - it just sets
default value at the shape level, not at the paragraph level.
So far I have only looked at DOCX:VML - which satisfies the
unit tests. There are other codepaths that lead to PushShapeContext
though, and this should be easy to expand to other import
situations. I've tried lots of asserts to find unit tests
that should be modified, and so far they all seemed to point
to VML - although round-tripping doesn't use VML and still
requires at minimum the CharHeight property to be overridden,
so limiting non-VML to that to maintain backward compatibility,
and reduce regression footprint.
Since we have to emulate here (since paragraph styles are not
supported on Draw text), a perfect solution cannot possibly be
found - specifically in cases where multiple paragraphs exist
in one shape with different styles applied, or where some
pararaphs apply a paragraph property and others do not.
Compromise 1: For ambiguous paragraph styles, fallback to the
default paragraph style. Rationale: Normally, most styles
inherit from default and only change a couple of properties.
So MOST of the properties will match the normal style.
The chances that the default style will be correct are
more likely than that some other random default would be.
-note: no existing unit tests were ambiguous
Compromise 2: Ideally, each paragraph could report whether
it had DIRECT formatting, and the paragraphs could be
walked through instead of the shapes. But I don't think
that is reasonably possible in this SyncProperties situation.
At first I had a grabbag framework setup that monitored
when a paragraph property was set, and then skipped applying
that property. But I later noticed that the PropertyState
for paragraph properties actually did seem to reflect
that - which is a better solution if it works properly.
Regression potential:
-for VML: should be limited to non-charheight properties
where the default style sets some weird default, and
an ambiguous style sets it back to the program default.
Prior to this patch, the default style value wouldn't apply.
On the flip side (and more likely scenario), non-ambiguous
cases will use the correct value and look more like MSWord,
as seen in many existing unit tests that now use corrected fonts.
-for non-VML: should be none since I limit it to only
CharHeight which was previously emulated by changing the
program default.
Change-Id: I8f1fb7ed01f990dbf998ebe04064c2645a68e1aa
Reviewed-on: https://gerrit.libreoffice.org/81365
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I0968cfd6a94c20e6b0d324f068ca658d7d5c0296
Reviewed-on: https://gerrit.libreoffice.org/83294
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
See tdf#74608 for motivation.
Change-Id: I68db3d4969e4bd40d1029ca3302bbda0dfe6e718
Reviewed-on: https://gerrit.libreoffice.org/83432
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
to make debugging easier
Change-Id: Ia19384a925a2bb437fa5d961e6c3d44eebe0c6b6
Reviewed-on: https://gerrit.libreoffice.org/83345
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This attempt tries to avoid affecting other .wk1 files as well.
The old fix was even applied to the wrong patch section, not done for
MacOSX or Windows. Geez..
Change-Id: Ia79383f33ff760cba9bfb44f166e27f3ef212c57
Reviewed-on: https://gerrit.libreoffice.org/83431
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I7c602068e34b904559c0cbe3f869618c9149705a
Reviewed-on: https://gerrit.libreoffice.org/83352
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
see bt:
0 0x00007ffff209866a in std::type_info::name() const (this=0x0) at /usr/include/c++/9/typeinfo:100
1 0x00007ffff20966e1 in exceptionToStringImpl(rtl::OStringBuffer&, com::sun::star::uno::Any const&)
(sMessage="DBG_UNHANDLED_EXCEPTION in bool connectivity::hsqldb::OHsqlConnection::impl_isTextTable_nothrow(const rtl::OUString&) exception: com.sun.star.sdbc.SQLException message: Unexpected token: S in statemen"..., caught=
uno::Any("com.sun.star.sdbc.SQLException": {<com::sun::star::uno::Exception> = {Message = "Unexpected token: S in statement [s]", Context = uno::Reference to (com::sun::star::uno::XInterface *) 0x555559269238}, SQLState = "37000", ErrorCode = -11, NextException = uno::Any(void)})) at /home/julien/lo/libreoffice/tools/source/debug/debug.cxx:113
2 0x00007ffff209855d in DbgUnhandledException(com::sun::star::uno::Any const&, char const*, char const*, char const*, char const*) (caught=
uno::Any("com.sun.star.sdbc.SQLException": {<com::sun::star::uno::Exception> = {Message = "Unexpected token: S in statement [s]", Context = uno::Reference to (com::sun::star::uno::XInterface *) 0x555559269238}, SQLState = "37000", ErrorCode = -11, NextException = uno::Any(void)}), currentFunction=0x7fffdb5ca340 "bool connectivity::hsqldb::OHsqlConnection::impl_isTextTable_nothrow(const rtl::OUString&)", fileAndLineNo=0x7fffdb5ca2e8 "/home/julien/lo/libreoffice/connectivity/source/drivers/hsqldb/HConnection.cxx:301: ", area=0x7fffdb5c9f49 "connectivity.hsqldb", explanatory=0x0)
at /home/julien/lo/libreoffice/tools/source/debug/debug.cxx:418
3 0x00007fffdb58a16a in connectivity::hsqldb::OHsqlConnection::impl_isTextTable_nothrow(rtl::OUString const&) (this=0x555558a43de0, _rTableName="William Kidwell's Address Book")
at /home/julien/lo/libreoffice/connectivity/source/drivers/hsqldb/HConnection.cxx:301
https://bugs.documentfoundation.org/attachment.cgi?id=155952
Change-Id: I2bc744164b1470d8f09bcb126b02e48af180e886
Reviewed-on: https://gerrit.libreoffice.org/83245
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
And start a drawingml test suite in oox, so the test and the tested code
is close to each other (just like how it's done in chart2/ already).
Change-Id: I9a2810691f12604d240e4394e6a5ff4e7f52f1c1
Reviewed-on: https://gerrit.libreoffice.org/83412
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
cause ~200 asserts of https://dev-builds.libreoffice.org/crashtest/299a13e8f7307b38ac10ad351273e2559e21ab16/backtraces
This reverts commit 1d81d52b5da45f26e9d3adeb3b279eb9a488b94f.
Change-Id: I8d00443f2fc8c71d6ef7baed5db0072847867ce1
Reviewed-on: https://gerrit.libreoffice.org/83406
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
- tdf#128893 corrections in Navigator for Document Overview
Change-Id: I9bb76d79540ee93ab05c227ccade494605ba54a0
Reviewed-on: https://gerrit.libreoffice.org/83413
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I9debf80755a3950cc34be280af8006e52006b14a
Reviewed-on: https://gerrit.libreoffice.org/83313
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Now default compatibility mode AddParaSpacingToTableCells uses
not only paragraph bottom margin, but also proportional line
spacing before bottom cell border, as in MSO.
Note: disable testForcepoint76, because it fails again with
its fixed layout.
Change-Id: I52f6204a5efc63aac4aa332a1563ada0cbeb9618
Reviewed-on: https://gerrit.libreoffice.org/83236
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Take over the current document-specific print settings for
a newly created printer in 'sw::DocumentDeviceManager::Create_Printer_'.
This makes sure that the options of an 'SfxPrinter*' retrieved
by calling 'DocumentDeviceManager::getPrinter(true)' are in line
with the 'SwPrintData' currently set.
This among other fixes the issue described in tdf#118263,
comment 7, i.e. the options shown in "File" -> "Printer Settings"
-> "Options" were not properly initialized when the config option
for loading user-specific settings with the document was disabled.
(All checkboxes were unchecked in the UI in this case instead of
showing the default values.)
What happens is that when importing the document,
'bPrinterIndependentLayout' in 'SwXMLImport::SetConfigurationSettings'
is 'false', so that this block is entered there:
if( ! bPrinterIndependentLayout )
{
xProps->setPropertyValue( "PrinterIndependentLayout", Any(sal_Int16(document::PrinterIndependentLayout::DISABLED)) );
}
resulting in the following call stack where the printer is created and
set:
#0 sw::DocumentDeviceManager::setPrinter(SfxPrinter*, bool, bool)
#1 sw::DocumentDeviceManager::CreatePrinter_() const
#2 sw::DocumentDeviceManager::getPrinter(bool) const
#3 sw::DocumentDeviceManager::setReferenceDeviceType(bool, bool)
#4 SwXDocumentSettings::_setSingleValue(comphelper::PropertyInfo const&, com::sun::star::uno::Any const&)
#5 comphelper::MasterPropertySet::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&)
#6 SwXMLImport::SetConfigurationSettings(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
[...]
Writer's default settings were not applied in this case.
For the case where loading user-specific settings is enabled,
no printer is set at this stage, but it's later set in the call to
'SwView::GetPrinter', in which case there is already an explicit
call to 'SetAppPrintOptions' after the printer is created via
'DocumentDeviceManager::getPrinter(true)', so all was fine there
earlier as well.
(Apparently, the same issue could be reproduced with the config
option for loading user-specific options enabled, but an ODT
document that has "PrinterIndependentLayout" set to "disabled"
in it's settings.xml.)
Change-Id: I39fd300fb56b767e7103b65537b0eac1365e5fd7
Reviewed-on: https://gerrit.libreoffice.org/83394
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Base class's SwPrintData::GetFaxName does exactly
the same thing, namely returning its 'm_sFaxName'
member, so just use this one directly.
Change-Id: Idd50eeeba94a1b1a25c5475511a60730368884c7
Reviewed-on: https://gerrit.libreoffice.org/83393
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
SwAddPrinterTabPage doesn't access any private members,
so doesn't have to be a friend.
Change-Id: I82918af61e7b1568127002e70da8c767aec7f03f
Reviewed-on: https://gerrit.libreoffice.org/83392
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
This is a follow-up to bd2ada701aad2c4e85d03cd8db68eaeae081d91c,
which added the check for nesting hints in MarkManager::makeMark().
Change-Id: Ife847a677514fb1aeb28dc8d6254caea365b754d
Reviewed-on: https://gerrit.libreoffice.org/83388
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
In Calc when a cell is copied and its value is filled/pasted to different
cell(s) by using the "Enter" key when focus is on selected cells --
replace warning is not shown even if the selected cells have values of
their own inside it. The old data is simply lost. Provide a replace
warning dialog box whenever such a case is encountered.
Change-Id: I13acb424bc449e096512b5a0864ebc47a407f234
Reviewed-on: https://gerrit.libreoffice.org/83333
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ic4cb8444123864fdaee64960f00a05b3066ae5fc
Reviewed-on: https://gerrit.libreoffice.org/83387
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
text, also its preview in the dialog window, when the URL contains
anchor at the end.
Change-Id: Ibedb86238f660177b3dd476cd6a13f1ca5f05e12
Reviewed-on: https://gerrit.libreoffice.org/82654
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I55972388b1f15dc86d309c5ffe998b44596b1cf2
Reviewed-on: https://gerrit.libreoffice.org/83351
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
|
|
by exporting PercentageNumberFormat, checking the "Label" format
directly and taking the respective number format based on that.
Note: also fix the "LinkNumberFormatToSource" property. If we create a
pie chart with data labels and set the "Show value as number" or
"Show value as percentage" and check on/off "Source format", this move
is not set the property in the XPropertySet.
Because of this, it fixes also the export of correct value of
"link-data-style-to-source" property into ODS files.
But this patch doesn't fix the export of old ODS files to OOXML,
because they contain wrong (always true) "link-data-style-to-source"
value.
Change-Id: I4098a245dec5bf35cde20c9ccb79aca726230118
Reviewed-on: https://gerrit.libreoffice.org/82703
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
|
|
As discussed in the commit message of 46c645bf4e9909f5296e75028f1f5434e83942d2
"Move dubious file: -> smb: conversion from INetURLObject to file UCP", it is
unclear why exactly file://<host>/ URLs should be retried as smb URLs on Linux.
That commit had tried to keep that dubious feature alive with a different hack,
but tdf#128598 "FILEOPEN: Certain syntax of opening file from samba share
results in Document in Use dialog" demonstrates that that hack doesn't work well
either (see libreoffice-6-4 <https://gerrit.libreoffice.org/#/c/83396/>
"tdf#128598: Revert 'Move dubious file: -> smb: conversion from..." for further
details).
So just drop the dubious (mis-)feature entirely from LO 6.5. On Linux, use
GIO's smb URLs to access Windows SMB shares, just like you would use e.g. GIO's
afp URLs to access AppleTalk resources.
Change-Id: I2ad53f508919a5f581e3afc4c4a5d26461b8ed2b
Reviewed-on: https://gerrit.libreoffice.org/83402
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I8451e88f8e1ea9b58e18015159d2acc65d818bf7
Reviewed-on: https://gerrit.libreoffice.org/83379
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
making this similar to existing cases like the writer word count
and other toggleable utility windows
Change-Id: I0239114596a01d8c341e2ed2fd92bf1bd323938b
Reviewed-on: https://gerrit.libreoffice.org/83380
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
They were exported with 86ea64f216819696cd86d1926aff0a138ace2baf "Support for
native 32bit Bitmap in VCL and SVP (cairo) backend" but appear to only be used
within Library_vcl.
Change-Id: I03595c8345b289676e6260e7bd88b6b146ac002d
Reviewed-on: https://gerrit.libreoffice.org/83385
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I041dfdaac4903d1bb0bb9ee70a2e5e705af3aafb
Reviewed-on: https://gerrit.libreoffice.org/83398
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I8a7efffb2866e46e978d09ca9fb5c9dec231e132
Reviewed-on: https://gerrit.libreoffice.org/83384
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: Ibc90b3b68a55f8396fbe623eb0db6c289fe978a1
Reviewed-on: https://gerrit.libreoffice.org/83383
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
- TDF#128911 typo in formula SUMIF.
Change-Id: I30241cc84bc715ac9ae0a6af39db3a9e95476860
Reviewed-on: https://gerrit.libreoffice.org/83389
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
so the TreeList does not get the mouse release it expects stolen
from it by the dialog, leaving it stuck in "selecting" limbo
Change-Id: If83dcdd8697b2a67e67fb062ae65ad947f49e8cd
Reviewed-on: https://gerrit.libreoffice.org/83372
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Test this from sd, so that SdModelTestBase::saveAndReload() calls
BootstrapFixture::validate() for us.
Change-Id: I6c90a3a71a5603604e69f9b45137bc8e4388dc0f
Reviewed-on: https://gerrit.libreoffice.org/83371
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Fixes CVE-2019-18197.
Remove obsolete e03553605b45c88f0b4b2980adfbbb8f6fca2fd6.patch.1.
Change-Id: I95cf498e245083528f98bfef8cdd240bbe2211b9
Reviewed-on: https://gerrit.libreoffice.org/83312
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Scenario: a new document where the first thing the user wants
to do is create a footer. Scroll down to the bottom of the page
(this does mean that you can't see the top of the page, right?
None of my screens show an entire page by default anyway...)
and click in the footer area. The screen jumps back to the top
of the page and the user needs to scroll to the bottom again
in order to enable the footer.
So, in the very specific case of the control being turned on
(because I don't care about a jump if the control is being
turned off) don't process a return to the cursor position.
Regression potential:
The only use case I can think of is someone trying to
drag a section by starting too low on the page. The early return
will quickly cancel any kind of drag attempt. Basically if the user
clicks in the footer area without intending to get the
separator bar, it might act differently than what previously
happened. I don't really see this scenario as a problem.
One additional limitation could be added to only apply this
if it is dealing with the footer, since in the case of a
header there would be no screen-jump.
Change-Id: I11cd3089b85d8eb49063b902e6bf8bf2e1412aa7
Reviewed-on: https://gerrit.libreoffice.org/82701
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
if the object isn't valid, e.g. link to something that doesn't exist, set the fallback
graphic as mxGraphic so SdrOle2Obj::GetGraphic will show the fallback, otherwise
the failing mxObjRef.is test in SdrOle2Obj::GetGraphic means it doesn't get used
Change-Id: I8f1aea6b25dc216e01a0f888a44d10876bb1bebd
Reviewed-on: https://gerrit.libreoffice.org/83322
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Recheck after recent refactorings and improvements in f-u-i
* Drop now unused TabPageIds.h
* The problem noticed in bug #119699 now seems to be gone too
so drop those lines from the blacklist.
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I44f26c7370f5328c8f67ac61cd8f0cdb29077f15
Reviewed-on: https://gerrit.libreoffice.org/83182
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I82fe7ae4e9a564af27d1f080c0bf27e5aab17bfd
Reviewed-on: https://gerrit.libreoffice.org/83188
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I21eadcd210aef38e7690da2492bf1dfe030427e4
Reviewed-on: https://gerrit.libreoffice.org/83356
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I390ac076136140f6aaa391212afeca49ebbd1dc3
Reviewed-on: https://gerrit.libreoffice.org/83355
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
|
|
or it has a parent style so when a custom paragraph style is in use it
can be deleted and the style will revert to the parent
Change-Id: I0e4ff953835c105241d3bb027d24841afdccc7ba
Reviewed-on: https://gerrit.libreoffice.org/83008
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: Iafa89df6f724fa6b64712d970502091e38300dad
Reviewed-on: https://gerrit.libreoffice.org/83341
Tested-by: Jenkins
Reviewed-by: Aron Budea <aron.budea@collabora.com>
|
|
This patch provides intended highlight behavior to my understanding of
comments found in the toolbox source code.
*only highlight when the focus is not inside a child window of a
toolbox eg, in an edit control
*do not highlight when focus is in a different toolbox
*only clear highlight when focus is not in toolbar
Change-Id: Ia18d35c4255ed0940bce5f0c6d9448ed2c85c6fe
Reviewed-on: https://gerrit.libreoffice.org/81356
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: Ia8f00cd882c1c8c239b95de8e917ff317a6485e8
Reviewed-on: https://gerrit.libreoffice.org/83152
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
At present this doesn't work with gtk3 backend. Works with X11, tested
by using SAL_USE_VCLPLUGIN=gen. I suspect it also works with kf5.
Change-Id: I14b82bc7a6f25a4c88d547290d847217aa1b0de2
Reviewed-on: https://gerrit.libreoffice.org/83252
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
...that had been introduced with 51eb969cb77f8b54681033f4959b15ce32116b56
"Replace comphelper::ServiceInfoHelper::addToSequence" and obsoleted by
<https://gerrit.libreoffice.org/#/c/83291/> "loplugin:redundantfcast: Don't warn
about cast from braced-init-list"
Change-Id: Ic5bb63cf4f528285587f46437a27bafbb05a07ac
Reviewed-on: https://gerrit.libreoffice.org/83315
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...in non-deduced context. That means that the necessary cast in
84322944980f6e2f9d4a531de7a6803797156968 "Simplify sequence initialization"
(cf. <https://gerrit.libreoffice.org/#/c/82974/4/>) no longer causes a false
positive, and doesn't need to use comphelper::OUStringLiteralList.
Change-Id: I788da61cc0be82d2166653760e527bb18e366c99
Reviewed-on: https://gerrit.libreoffice.org/83291
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Id5f7a9c34d1d159dd0f930a4ce66871bdd3796c1
Reviewed-on: https://gerrit.libreoffice.org/83305
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This gets rid of the last 72 lost bytes I could identify in the
huge valgrind logs to look like its PDF generation related.
Change-Id: Idda3c2c5b7f5ce0211199b86503037b74438ccf2
Reviewed-on: https://gerrit.libreoffice.org/83302
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
fixup from 93ee955c5359e283e2fe88e45b4c02a60525ed11
Change-Id: I94fa357e982bdf6a74bc182a51fb562ac39c0090
|