summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-04-09use more subView when converting to Int32Noel Grandin
Change-Id: Ia1be48050cca386a6e765aa2229de1bc9e64ffff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132749 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-09Introduce `unoidl-read --summary` modeStephan Bergmann
...as needed by odk/docs/idl/wikilinks.py Change-Id: I6dd096338e9f200679810d33e89c8b9ce18f69f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132752 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-09add a more complete o3tl::getTokenNoel Grandin
so we avoid OUString copying (mostly when doing stuff like parsing numbers of out of strings) Change-Id: I4ef6ac23671c0b40807a22158e655e92dfad4af6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-09Resolves: tdf#148052 accept a ". Month " name for matching DMY formatEike Rathke
... even if the locale doesn't define such DM order or LongDateDaySeparator. Change-Id: I4bef720dff3582de9b60313824a84b570c153e98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132741 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-04-09SwNavigator: set entry focus and update toolbox items sensitivityJim Raykowski
when content tree entry selection is made by the SelectContentType function The SelectContentType function is used when the Navigate By control combo box selection is changed by direct selection. This patch makes the tree entry cursor position be set to the selected content type entry so keyboard tab navigation will land on it. It also makes the move chapter up/down and promote/demote outline level toolbox items sensitivity update when the selection is made. Change-Id: I56675592678accc6db3eacb25bf9bccae8eb1cef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132689 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-04-09Use DateTime(css::util::DateTime&) ctorEike Rathke
Individual fragments set in the given order even raised SAL_WARN about non-existing year 0 ... Change-Id: Iadfc648423b9fc7ec1a9ebfbc05a1ea814078ac2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132742 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-04-09use helper GetTextArray() in all placesLuboš Luňák
Change-Id: Icec4326cf614574d7dabe6752f985b3ac4462fb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132744 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-09cache failures in SalLayoutGlyphsCache tooLuboš Luňák
Change-Id: I0ddbb8ac94705d7a1a843fe39d0821644dfb5084 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132743 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-08add SalLayoutGlyphs* parameter to OutputDevice::GetTextBreak()Luboš Luňák
Change-Id: I278e485e03cf27bc57724233453a672569dfd53f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132682 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-08use just one shared global SalLayoutGlyphsCacheLuboš Luňák
Now the cache should be capable of detecting what needs to stay the same for having the same result, so it should be enough to have just one cache that can reuse results even between callers from different places. Change-Id: Ibdc0303f5b727d1a1d7be91d61db9465ed95e1c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132673 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-08ignore Point logicalPos argument in SalLayoutGlyphsCacheLuboš Luňák
It's only used for the DXArray argument in ImplLayout(), so if we ignore that one when caching, the position can be ignored too. Change-Id: Id2a7b452e2b75139177c1e73c48eaa466742a59c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132672 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-08check better for unchanged OutputDevice in SalLayoutGlyphsCacheLuboš Luňák
Some things like font could change, so it needs to be saved and compared. If would be even better to avoid comparing OutputDevice pointers and instead compare only what actually matters, in order to reuse the same glyphs used for different output devices, but I can't find all the relevant data in OutputDevice. Change-Id: Ib8634165b5b312d1db2c9fc28f8d7fdf7b552d25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132671 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-08use SalLayoutGlyphsCache in PDFWriterImplLuboš Luňák
It's unlikely to repeatedly lay out the same strings often, so it probably won't gain much, but still. If SalLayoutGlyphsCache would work even on different OutputDevice pointers (that would provide the same glyphs) then presumably this would be able to reuse caching even from e.g. Writer. Change-Id: Ib52d9ee92e950e69229497122df1789f5fc6b07e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132670 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-08faster hashing of very long strings in SalLayoutGlyphsCacheLuboš Luňák
tdf#147284 being a (pathological) testcase. Change-Id: I08d8dffb40193b461555bed818c040761e8d575b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132669 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-08use vcl::text::TextLayoutCache in SalLayoutGlyphsCacheLuboš Luňák
Change-Id: I0ec22fe53e05319dec15456a916b10e97ea91a75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132668 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-08tdf#83037: sw_uiwriter6: Add unittestXisco Fauli
Change-Id: I42a2b697e1b3efd719c0f45474420c9367300776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132680 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-08sw_uiwriter: put autocorrect tests togetherXisco Fauli
Change-Id: I06e720b6fccab298a866eb05403ca98152ab4c8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132679 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-08move comphelper::string::toInt32 to o3tlNoel Grandin
so we can use it in places where we cannot include comphelper Change-Id: Iba0ba3e4c0dcf0f9d1f09092a77c3b2010ec4f6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132732 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-08Fix typoAndrea Gelmini
Change-Id: I0e365196f90e0f117e80df2c194d8137252b959d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132735 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-04-08allow to override the generator/producer string in output documentsLuboš Luňák
Add a (non-gui) setting GeneratorOverride that, if set, is used for odt/docx/pdf generator string identifying the application that has written it instead of the normal productname etc. string. Change-Id: Ibe12a063e7e6b5a09c69cdf66cba073793650d62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132495 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-08tdf#141578 Qt handle QtFrame screen changesJan-Marek Glogowski
LO doesn't provide any way to notify screen changes / scaling factors of a window and in fact doesn't really handle scaling factors in VCL. The QWidget doesn't receive a resize event, because it's size doesn't change, just the scaling factor. So we trigger a faked resize on QWindow::screenChanged signal. Change-Id: I6928c4c62d1c0995c70fea0088cff17849bcd1d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132650 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2022-04-08tdf#148423: Half a hackStephan Bergmann
"Regression" introduced with de4d296619b978ec303f1d7b1e2c78e13fa7a512 "Avoid overflow in ScColumn::GetOptimalColWidth", which, for this bug document's nWidth/nPPTX = 6004/0.0647708 = 92696.1, changed the calculation of nTwips from the undefined-behavior 92696 % 65536 = 27161 to the clamped 65535, but which is apparently a value large enough to cause "silent" issues (i.e., not causing further undefined behavior) down the road, leading to a super-narrow column. That commit already wondered whether sal_uInt16 is a useful choice here, but lets keep that question unanswered and just clamp at half the previous value, which happens to cause presumably more pleasing results. Change-Id: I1df642b2b9d6818c8be0f8d8f4567a00c399c154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132734 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-08Fix buildMike Kaganski
... after commit 36e0e88b28e818faf25b8e32cc8c4dc444b8a0be Change-Id: I540d19f7146651035cd5fafe077c0ccdfcee11ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132733 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-04-08ofz#46162 and ofz#46287 Integer overflowCaolán McNamara
Change-Id: I58bc9aadab1765e8ce4bc8e6e631cd72b853f9b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132731 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-08tdf#148330 fix vertical offset for DFKai-SB (ukai.ttf).Mark Hung
DFKai-SB (ukai.ttf) is a built-in font under tradtional Chinese Windows. The font is very common, especially for official documents. It is one of the so-called tricky fonts in FreeType[1]. DFKai-SB has incorrect extent in the glyf table[2]. It results in incorrect glyph positions in vertical writing. FreeType recalculates the extents based on the glyph outline, but LibreOffice uses Harfbuzz with built-in ot font functions instead of ft (FreeType). This patch decides if the fix is necessary by checking the family name of the font and the y-offset value, and recaculates the glyph offset based on glyph height and top bearing obtained from the glyph bound rect. [1]https://freetype.org/freetype2/docs/reference/ft2-base_interface.html#ft_face_flag_tricky [2]https://github.com/harfbuzz/harfbuzz/issues/3521 Change-Id: If632dd38c462c229837e1efb5446e2142f8f0639 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132511 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2022-04-08tdf#143447 ignore IME candidate window state.Mark Hung
Some traditional Chinese IMEs ( Input Method Editors ) under Windows10 send WM_IME_NOTIFY with IMN_OPENCANDIDATE but not IMN_CLOSECANDIDATE. The behavior is different if users configure the IME and enable "legacy" option. That caused the cursor been hidden, misled by mbCandidateMode. The patch ignores the candidate window mode in case the length of the composition string is 0, assume in that case candidate window is useless, and resets the candidate window mode when composition ended to maintain the state as much as we can. Change-Id: I91a1c23ee1a031313243e032653f50f39b0f2a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132512 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2022-04-08sw_uiwriter6: use keyevents to simulate the autocorrectXisco Fauli
This way, the tests mimic what users do while typing Change-Id: I04ade61ce5026f2d5de58c1d0e87c1dee1e5053b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132674 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-08use more subView when converting to Int32Noel Grandin
Change-Id: I54e3ddf79ba793fd4328bf8bda7f949b65349651 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-08sw content controls: add ODT exportMiklos Vajna
Wrap the text portions inside the content control in a <loext:content-control> XML element. Also map the (so far) single UNO property of it to <loext:content-control loext:showing-place-holder="...">. This is just initial export for inline text content controls, more properties are to be added in follow-up commits. Change-Id: I5d928255b925ed7e08fb635ba39f546e9a4879de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132717 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-04-08configure: require GNU make 3.82Michael Stahl
Reportedly make 3.81 already fails since commit: b04be559ddf4a7f0a5cdc0b9abc2bcfc4aae25cc "gbuild: implement static partial build" <sberg> mst___, the `/usr/bin/make --version` "GNU Make 3.81" I have on macOS does not work to build LO (Some LinkTarget.mk:913 erroneous endef error is the first I encounter) There was an ESC decision years ago to drop support for make 3.81. Change-Id: I2e0ebec9eeb326df8c5a4d89ce1d53da6ed332ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132716 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-08Adapt to latest VS 2022 MSM versionsStephan Bergmann
...as present at least with VS 2022 17.1.3 Change-Id: I6d1cf247c8507ebab56c106aff6933ff739a4314 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132714 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-08Removed duplicated includeAndrea Gelmini
Change-Id: I898c24abd5366a85705b5f54258b16b22e044355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132715 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2022-04-08sc: add an overlay to show sparklines in a sparkline groupTomaž Vajngerl
This adds an overlay that shows/selects all sparklines in a sparkline group for the cursor cell sparkline, if the cursor cell has an associated sparkline. Change-Id: I60a5873ebdf8606f262d217caf6011c4a003801a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132692 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-08tdf#147179 sw: select tracked row change in Manage ChangesLászló Németh
In Manage Changes dialog window, selecting items of list of changes results selection of the associated text changes in the main text, as a visual feedback. From commit eebe4747d2d13545004937bb0267ccfc8ab9d63f, text changes of deleted/inserted rows or tables are listed under a single "tracked row" list item, as its children. Selecting a "tracked row" list item in Manage Changes resulted incomplete text selection in the main text: only the first text change in the first cell was selected instead of all associated text changes of tracked row(s) or table. Note: Manage Changes supports multiple selections, i.e. it's possible to select multiple list items by Ctrl + click, and select ranges by Shift + click. This commit does the same with redlines of tracked row changes. Follow-up to commit eebe4747d2d13545004937bb0267ccfc8ab9d63f "tdf#144270 sw: manage tracked table (row) deletion/insertion". Change-Id: If7b12e8d3c0e437495e1fcae0e8f04e34301c516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132685 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-04-08tdf#95706: RTF import: tolerant font table parsingVasily Melenchuk
While font name in font table should end with semicolon ({\fonttbl{\f42 Arial;}}) it is not always true and MS Word is tolerant to it: it still able to parse this correctly. Seems LO also should not require strict spec conformance. So idea of font parsing is changed: instead of inserting font on semicolon, it is done on next \fN or destination end. All collected text to this moment is a font name. Change-Id: I6b41951217442a71fd2ebbfc58a3fc79f6f913db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132686 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-08loplugin:stringviewparam convert methods using trimNoel Grandin
for which we add a new o3tl::trim method Change-Id: I9d37b6264eea106aa2f3502bd24b8cccf7850938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-08lok: unit test for invalid entry saveDennis Francis
Unit test related to the fix lok: avoid validation-dialog yield when saving e0175ee821eaff56c4b8e0a1b7afa1cabe0ab593 The test ensures that the document is marked unmodified after save has been executed in the middle of entering partial data to a validation cell. Change-Id: Idffd6d647034e128d0d800fe8e29efc333c03db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132655 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-04-08lok: avoid validation-dialog yield when savingDennis Francis
Disable error dialog box when about to save in lok mode as this ultimately invokes SvpSalInstance::DoYield() when we want to save immediately without committing any erroneous input in possibly a cell with validation rules. After save is complete the user can continue editing. Conflicts: sc/source/ui/app/inputhdl.cxx Change-Id: Iffa0766ad594db75f57158986c4e1d2646f71da4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132410 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit e0175ee821eaff56c4b8e0a1b7afa1cabe0ab593) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132654 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-04-08prevent using O[U]String::subView on temporatiesNoel Grandin
by making the method "const &" Change-Id: I8b369ca1dd1f8d10832c85ccf3d890edb14e2c54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132688 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-08tdf#147861 sw ms export: DI_SUB_MASK must exclude FIXED nowJustin Luth
This is a follow-up to 7.4 commit daef39352b008fc1f903fd8c09288ff5e772fa42 There is only one place in which DI_SUB_MASK is used, so I'm just changing it to what it could have always been, since it never was actually used to mask out DI_SUB_FIXED. Otherwise, I might have made this a MASK2 or whatever. The issue here is that AUTHOR was not being recognized when it was paired with FIXED, so every FIXEDFLD was ended up being considered as a date/time. In practice, this didn't really change anything because bWriteExpand already ignored any of these areas of the code. It is only when I turn off bWriteExpand as I implement fixes that I am seeing the wrong field type being created. And regardless, since the field is FIXED, the visible content remains the same anyway (until someone in MS Word refreshes the field with F9). Both Author and date have the same field name ":Created" so I couldn't super easily test this. Change-Id: Icd2d0be2d3fbe24dc4763e0e25801569bcca471b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132660 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-08CppunitTest_sw_layoutwriter: avoid some a11y-based layout testingMiklos Vajna
The contents of SwTextFrames are currently dumped two times in the sw xml layout dump: the first is misusing a11y's SwPortionHandler interface for testing purposes (older approach), the second is visiting the portions inside the text frame directly (newer approach). The advantage of the second is that it can show information inside multi-portions, and also extending it won't affect a11y. This commit updates some asserts to use the second -- the first can be removed once no asserts depend on it. Change-Id: I5112946a964f338fc873ba13300023de9418e837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132687 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-08Resolves tdf#142071 - Align Tip of The Day with real menu/optionsRizal Muttaqin
Change-Id: I2050d0335d2d25e42b9c0164e56b0c981deee1bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132555 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-04-08tdf#148357 SwNavigator: recover scroll positon after content deleteJim Raykowski
Change-Id: I6c376e5190575232d2867843c1b2b0e57e620aaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132691 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-04-07Related: tdf#148448 add a separate WarningColor settingsCaolán McNamara
instead of a hard-coded yellow. For gtk we can use the named color "warning_color" to populate it: https://docs.gtk.org/gtk4/css-properties.html Change-Id: I538bffdc0f6286c78a08cef649fa8a074a6510ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132684 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-07ofz#46467 TimeoutCaolán McNamara
Change-Id: Ib2a248a6f912a340d2f0b79a068b68036fa357c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-07work around ICU performance problem in text breaking (tdf#116400)Luboš Luňák
Reported upstream at https://unicode-org.atlassian.net/browse/ICU-21946 , they've confirmed the problem, but so far no actual code change. So let's push my patch for now. Change-Id: Idd92ca66eea9b28103ad890aec66c40029ec7ebd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132676 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-07Red used instead of GreenCaolán McNamara
Change-Id: I1261154fcff6f4904b4360099cbf26e33b9e7463 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132683 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-07tdf#148445 sw: Make "Exchange Databases" dialog modalMichael Weghorn
This among others prevents opening the "Exchange Database" dialog from the mail merge wizard, then closing the mail merge wizard while the "Exchange Dialog" is still open, resulting in a crash. Change-Id: I86bd80d0bfa6084bf0f772bb430b2a871e9b5ef0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132678 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-07tdf#148445 sw: Resave exchangedatabases.ui with glade 3.38.2Michael Weghorn
... in preparation of fixing the actual issue. Change-Id: Ia3e60984b06e4fda856889f5116b49aecbbfb960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132677 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-07sw: keep URL when applying frame style on imagesMiklos Vajna
It seems that the intention is to reset properties which are possible to set in a style when applying a style. For example the paragraph alignment can be defined in a paragraph style, so reset that on style apply. URLs on frames can't be defined for frame styles, so it looks incorrect to reset the URL of a frame/image on style apply, fix this. Change-Id: Ie3a57b654cf06b9512b25d2dc103d15cd83727b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132675 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-30 08:31:18 +0000