summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-10-23uitest: move navigator tests to their own folderXisco Fauli
Change-Id: Iacc2e21fde8fc126752d0b1fa14cd1f962930d4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104723 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-23uitest: remove duplicated testsXisco Fauli
already covered in sc/qa/uitest/autofilter/autofilter.py Change-Id: I55259bdf741bcf3d51f7970b070bb15aaf144f22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104722 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-23call gtk_im_context_focus_in only if its widget has focusCaolán McNamara
Change-Id: Ib69b43b5247f34ccf36591b49a35d701a3715f82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104721 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-23PyLong_AsLongAndOverflow returns long, and that's fine to use hereStephan Bergmann
...where the goal is to check for a value in the range [SAL_MIN_INT32 .. SAL_MAX_INT32], i.e., [-2^31 .. 2^31 - 1]: While C++17 (via C LONG_MIN, LONG_MAX) only guarantees a range of [-(2^31 - 1) .. 2^31 - 1] for long, C++20 now requires two's complement and a fitting range of at least [-2^31 .. 2^31 - 1]. No need for 0d79d216886a71436e705c93829ed66a33270a9c "long->tools::Long in pyuno..sd" here. Change-Id: I6be60b50acfe5ed798cc8e9e1183c336c8d72059 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104712 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-23Resolves: tdf#137615 fix EffectPropertyPanelandreas kainz
Change-Id: I451850524948a623d496920ef832af0fef5b5a52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104700 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-23Missing call to curl_easy_cleanup (--enable-online-update=mar)Stephan Bergmann
<https://curl.haxx.se/libcurl/c/curl_easy_init.html> states that each call to curl_easy_init "MUST have a corresponding call to curl_easy_cleanup". (And <https://curl.haxx.se/libcurl/c/curl_easy_cleanup.html> states: "Passing in a NULL pointer in handle will make this function return immediately with no action.") The call to curl_easy_cleanup appears to be missing ever since the code calling curl_easy_init was introduced with 9c3b05f2d571b58ee2322a942162ecec654544dc "improve update checker and update downloader code". Change-Id: I5757efe131f73783c6f66a77d07676b8ce440f9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104711 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-23tdf#131679 sw: fix crash when copying fly via context menuMichael Stahl
sw::DocumentContentOperationsManager::CopyImplImpl() is called with a rPam that's on an SwOLENode. The problem (which i can't reproduce in --enable-dbgutil build, presumably for timing reasons) is that after the context menu pops up, some idle layout runs and reformats the document and deletes a SwFlyFrame and that calls SdrMarkView::UnmarkAllObj(). Then when SwFEShell::Copy() is called, it finds IsFrameSelected() returns false, and it tries to copy normal text when the cursor is on an SwOLENode. Fix this in SwFlyFrame::FinitDrawObj() by first moving the cursor out of any selected flys. (regression from 81ec0039b2085faab49380c7a56af0c562d4c9e4 - previously CopyImplImpl() would return early) Change-Id: Id135fcc002c03c07c34fbdc0355f2895d8b6565b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104697 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-23-Werror,-Wunused-private-fieldStephan Bergmann
...since 5a342bde16fb46c895eec302af73d7836226eccf "weld backing window" Change-Id: I1a34c70fa0357a05c8e864106261868e04171a87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104713 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-23Prevent crash with invalid lang tag.Gülşah Köse
Change-Id: I778b5b007d4edce946e8b4c26e5a07f12103a968 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104707 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-10-23CreateTextFromNode is goneIlmari Lauhakangas
Change-Id: Ia5786a642a4eea57eef224ace384cb3f9da9fe75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104728 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-10-23tdf#104378: don't reset para attributes whileMark Hung
converting Chinese characters. In TextConvWrapper::ChangeText_impl, calls to EditView::RemoveAttribs() reset the paragraph attributes. That makes SvxLanguageItem of EE_CHAR_LANGUAGE_CJK become LANGUAGE_DONTKNOW. Hence it always stops converting after the first success. This patch overload EditView::RemoveAttribs() so that it is possible to clear all character attributes of the selction without touching paragraph attributes. Before, bRemoveParaAttribs either removes items between EE_ITEMS_START and EE_CHAR_END, or removes items between EE_CHAR_START and EE_CHAR_END. The patch add a new enum class EERemoveParaAttribsMode, with the following values: 1. RemoveAll : correspond to the old bRemoveParaAttribs = true 2. RemoveCharItems: correspond to the old bRemoveParaAttribs = false 3. RemoveNone: new thing for "don't touch para attributes." Change-Id: I5132e708dea9e2066f13f1b001bd954d7b477f56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104484 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2020-10-23Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 236b483252c94f7b38ca7fecfa16cabab498a1ac - update translations for master/7.1.0 alpha1 and force-fix errors using pocheck Change-Id: If200fbab2e1c793a45c3f361275028afdced7b91 - update translations for master and force-fix errors using pocheck Change-Id: Ia30711726a4e2c71ba0d1c4fb24c370deefc0f98
2020-10-23Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 4e397eae35d108b7167cbafd9ad8da371c21dbad - Fix menuitem issue A menuitem element should only contain text nodes Change-Id: Ic0853849d2a055e7bde968173e7211f69a755ed0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104717 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-10-23list-uitest.py: use regex to find the bug idXisco Fauli
Change-Id: Ieef4cf5594ec0b417617391dd0534f36844853e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104698 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-23Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 03901b1b4451bbc3fca8038fed83d4533f40ee07 - fix typo in Select ID Change-Id: I511c665f62be338df5957a61b7b3d92972f70899 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104675 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-10-23Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to e35d17ff60061a6c88f86cbcb4bdd25649dd19ca - update Format menu - tried to make all <menuitem> - added <keycodes> - added sys-switches for F11/Command+T Change-Id: Ib360147bf6e1c3d6a22e0f96bc073150b8aff67b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104674 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-10-23remove debug code from SvXMLImportNoel Grandin
accidentally committed in commit fe2b4e7dc6533535736a8f08496f316427386179 Date: Tue Oct 6 18:27:27 2020 +0200 make SvXMLImport fast-parser only Change-Id: I5fb46399f6e562cc289859ef13998dfafaae6a7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-23long->tools::Long in pyuno..sdNoel
Change-Id: I67c1218d225f49ea9ce789433283ab85275e39a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104627 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-23Change SystemParentData::aWindow to sal_uIntPtrStephan Bergmann
...with similar reasoning as in 5d422c0348efd1df6b3d44dd6efcf5c5490fc321 "Revert 'sal_uIntPtr->unsigned long in SystemEnvData'": Prior to 3aef606f2758172a27718a06fea0ff9080e4d80f "use tools::Long in vcl" this was long, but besides X11 window resource IDs (for whose appropriate type see the commit message of 5d422c0348efd1df6b3d44dd6efcf5c5490fc321), at least vcl/unx/gtk3/gtk3gtkframe.cxx uses it in combination with GdkNativeWindow (e.g., GtkSalFrame::m_aForeignParentWindow and GtkSalFrame::findTopLevelSystemWindow), which itself is a typedef for sal_uIntPtr (vcl/inc/unx/gtk/gtkframe.hxx). Change-Id: I6d26ca7056da413d948215682425ee1ddb622326 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104695 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-10-23Implement SalGenericInstance::getOSVersion() for FreeBSD.Gleb Popov
Change-Id: I01f565bdfc3c46a94485a62cd0f249ce2002fe21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104689 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-10-23Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 1e2a67f38e12e25fdc9ea26b13680ee2c8c84e5c - tdf#128837 add "note" about outline levels and export to PDF bookmarks Change-Id: I1edf868ef12f759395feb17aa1ad96f3a8bad103 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104595 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2020-10-23Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to c80b3a21ba69edf4410e3adfdfaadc95b488ad5f - Fix typo Change-Id: I2b8e5a1a763acacb9bd6063a54ca97df86322517 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/101471 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 6e737196f2d0da47ca52365dc8fa70f788f5930e - tdf#132643 Translate German section IDs Change-Id: I1b514854f5cdd984840b6fdeb906581d615d8009 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104187 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to e621af93b2dfcf9fb2dc7c2cf27fe313fa47e01a - tdf#132643 Translate German section IDs Change-Id: I97116efd8c5cf5b88b0b811407cf0bc8683e4450 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104188 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to dcc69650998f393a6f1ba528f93a1ffd715c8044 - tdf#132643 Translate German section IDs Change-Id: Ibf291ac4c2283dab137867ec2d971b396371d7eb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104186 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 66c66c7a43f6c360fcd3a9ff65b095b7313fd399 - tdf#132643 Translate German section IDs Change-Id: I2b0b64ec22dc60d0c077ed8d7e241f077fe8ba84 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104185 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 77ded5d5318d76e8d6925a533c8f1c2bdde993f4 - tdf#132643 Translate German section IDs Change-Id: I07a69d6ec36457d1c998f600c6624ea24afdbb5e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104183 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 08ce4a8f703b22b787e39c9753e6eb493d4b2a9d - tdf#132643 Translate German section IDs Change-Id: Iece9a1f5185c88dd22fbaf53517bf96b7a1d83fa Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104146 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 87bdf7e4fd92098c751287b1601ef10d55ea22a5 - tdf#132643 Translate German section IDs Change-Id: I557b7dd603763e91dcc35c755b3617b3180f4a68 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104168 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-22Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 76cb6b253f073b7d1cea5f5c73dc4e65be14045e - tdf#132643 Translate German section IDs Change-Id: I9fbac3e0261bbda0ac59fd344b6c07986c2a366a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104147 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-22Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 0035c596bce9cacdb97c2fa7bd4f4afe60994aad - tdf#132643 Translate German section IDs Change-Id: Ic1fd222c1616de378a5ee55b550a19fde26922af Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104144 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-22Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 1f40f43834ba6ea222ad56fd8b5a76f1fd5e7fd1 - tdf#132643 Translate German section IDs Change-Id: I6bfcbc80cdf5f49d08571a2c572a19587de3bac9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104145 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-22Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 6f23f560ea55871c9d436ecb0aeba528ddd13185 - tdf#132643 Translate German section IDs Change-Id: I1f7872c513d4156454f3aa9f1d2d8c016e510791 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104143 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-22Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 39957e3094713752e54c651293b1d6d116479bb3 - tdf#132643 Translate German section IDs Change-Id: Ic56961dc348ebe035ca12e58fb71a9aa767ec491 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104142 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-10-22set all .ui min require version of gtk to 3.20Caolán McNamara
and update the version mentioned in our min req in the readme.xrm follow up to commit 0c9ccc7dbf6deb4d012e0d1e6eb934e54e0f19bc Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Oct 2 21:21:45 2020 +0100 raise min version of gtk to 3.20.0 Change-Id: Ibae55c97e1ee577f4b7435d124cda6a21005ad0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22always call GetFocus if GrabFocus succeededCaolán McNamara
so the CustomWidgetController can replace vcl::Control more seamlessly Change-Id: I3c2ff9c45ff0dc55b09863611df2a7d941d1c534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104574 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22if nothing selected, don't select something on gaining focusCaolán McNamara
which is how this traditionally worked before commit fd2ea8e03510c6a99ec8be6228b7422f6c5b182b Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Aug 19 14:59:33 2020 +0100 weld OApplicationSwapWindow Change-Id: Ib844f903bf160eb7a58c2860e41b0b7acf4aa783 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104688 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22rename SfxTemplateLocalView back to TemplateLocalViewCaolán McNamara
Change-Id: Ib5221799604886120f498313ffd37c0a80987bc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22rename SfxThumbnailView back to ThumbnailViewCaolán McNamara
Change-Id: I07251905c3bf5bccb23c684d47ed34e79dde55fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104645 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22MenuToggleButton no longer needs to be in public headersCaolán McNamara
Change-Id: Ifc190ddc0c9b5eb33555dcec5ed14fd9b36134e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22drop newly unused ThumbnailViewCaolán McNamara
Change-Id: I6c025120abf7f7dfbc1c06ad47e80e1d23ba731d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22drop newly unused TemplateLocalViewCaolán McNamara
Change-Id: I8c7fb0fe21df55056eba4a0672cff1689f0f4aea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104535 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22DOCX import: handle <w:altChunk r:id="..."/>Miklos Vajna
This refers to a self-contained full DOCX file inside a DOCX file. Change-Id: Ic9451833db30231f08ff2e2493da678edbc9a4c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104654 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-22Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 05f4f62675bd837aaa230d4f3b637b7152b8de7c - tdf#102265 - more work on Format menu for Impress - embed Align and Lists from Writer - both Align and Lists still need submenus (also in Writer) - when those are made, then the embeds can change. - change label from "Position and Size" to "Object and Shape" - embed Name and Description controls from Writer - move "Interaction" in relation to Name and Description Change-Id: Ied907bc152cf41027b65a52cb47e0191564b6b85 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104670 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2020-10-22only need to check the version onceNoel
Change-Id: Ie02ce5e7823a7564da919525f9cbdf4fc92072dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-22fix welded editengine delete-surroundingCaolán McNamara
Change-Id: I71c2f8e2483c2ef8d7f5cfcfcd7849f64792022f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104659 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22tdf#137520 shrink some text glyphs in iconsRizal Muttaqin
Change-Id: I1e85f69acd5d8ea0341a27671fab0eba001dd9dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104408 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-10-22weld backing windowCaolán McNamara
Change-Id: I250e46d3f1d558567bddbd4f0330470222e8fd4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22tdf#137652 fix XDL import: no more missing empty items for comboboxSerge Krot
Change-Id: I6837968ee7cc5e4b3bc9abd7e320f562c6ff0833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104619 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-10-22Don't make list of JREs active when parent frame is inactiveMichael Weghorn
When the Java framework's direct mode is used, there is no use in allowing the user to change the Java options in the "Advanced" options page, so the corresponding frame is grayed out, s. commit 2976590ed9f727c24064c97d80a51e9891253119 ("Gray out Java options when framework's direct mode is used", 2020-10-21). For the native gtk3 implementation, this also means that the child widget holding the list of JREs ('m_xJavaList') automatically remains grayed out as long as the parent widget ('m_xJavaFrame') is. However, it turns out that this is not true for the plain VCL implementation (used e.g. by the gen or kf5 VCL plugins) where the child widget can be made sensitive while the parent widget is insensitive. Therefore, commit 3935a0bd3bcf747aa9bede59b045d23ab598f2d4 ("Properly (un)tick Java checkbox in Java options in direct mode", 2020-10-21) resulted in the widget holding the list of JREs becoming active again when the 'EnableHdl_Impl' handler was called in the non-gtk3 case (while the parent widget and the buttons to add JREs, edit Java parameters and classpath would remained grayed out). Make sure the widget holding the list of JREs remains grayed out along with the whole frame holding the Java options. Change-Id: Ic46bf317afec9bc566493ec56ab5319a78050da0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104657 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
generated by cgit (git 2.34.1) at 2025-02-23 11:25:31 +0000