summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-08-09Simplify GetObjectRectangles function with JSonWriter.Gökay Şatır
This is a follow up for: * https://gerrit.libreoffice.org/c/core/+/171374 Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: I66bf8c100053907a0e2999730a6ef19e1144ae58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171598 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-08-09tdf#162398: InsertItem_ may modify itemsMike Kaganski
... which would invalidate the iterators of the for loop. Change-Id: I4962441e75a304a46d6f8ef5bc44fae1f4e03cc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171642 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171653 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-08Add SdrModel "IsImpress" function.Gökay Şatır
Functionalities like "SetMarkHandlesForLOKit" can now use this to send data selectively. Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: I8d300d1d6fe0d953f4798ec3ee0c48e258054335 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171597 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-08slideshow: change transition drawing view to icon viewJaviya Vivekkumar Dineshbhai
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com> Change-Id: I109d2268824d3be233c5c7b560c1777b95aa4276 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171180 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-08-08jsdialog: support textWithIconEnabled into Dump icon viewJaviya Vivekkumar Dineshbhai
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com> Change-Id: Ib005da05fe500aae5729095533aab05578e567d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171491 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-08-07Related: tdf#162295 DOCX import: optimize copying headers/footersMiklos Vajna
The original DOCX bugdoc has 150 sections on 88 pages, which means that copyHeaderFooter() in the domain mapper is a significant cost. Setting a property on a page style involves making a copy of the SwPageDesc, working on that copy and then copying it back. Which means that setting UNO properties one by one vs working via setPropertyValues() is a big difference. - old cost: 11984 ms - new cost: 7764 ms (65% of baseline) (cherry picked from commit cf22d66c5837f108296b37bc98f17ee96869a7ef) Change-Id: Iea99fb3ad9d3e61494c9f012c4c7fa10cc7ab09d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171579 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-06We need --with-buildconfig-recorded to display build config in admin consoleAndras Timar
Change-Id: I2269a753f73adbf180f3af26726edad397bb5273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171545 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-08-06cool#9704 calc jsdialog autofilter send disabled entry informationJaume Pujantell
Added the code necessary to disable already filtered entries on jsdialog autofilter, like it is done on desktop UI. Change-Id: I095b7fe0054efcaff2717d05a2ab7bd1d8248b29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171246 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-08-05use the new linker on macOS (introduced in XCode 15)Christian Lohmaier
the classic linker will be removed in upcoming versions of XCode and is deprecated XCode 15.0 has a bug that would cause runtime crashes on macOS 11, but that bug has been fixed with XCode 15.1 and all users of XCode 15.0 could update to 15.1 or 15.2 (15.3 or later requires newer version of macOS) - so remove the workaround of using the old linker and instead require a fixed version of Xcode (or a different minimum deployment target) Change-Id: If516ac85539da83f54b1792450cf43ea55d0d808 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170652 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-08-05cool#7710: Make Slide Properties Dialog in Impress AsyncSven Göthel
How to reproduce the synchronous dialog: - Build in debug mode - Click on 'Format' menu, then sub-menu 'Slide Properties' - The sync-dialog warning shows up This commit updates the dialog from synchronous to asynchronous processing. How to manually test the asynchronous dialog: - Apply patch - Build in debug mode - Click on 'Format' menu, then sub-menu 'Slide Properties' - The 'Slide Properties' modal dialog box opens and is functional. Tested manually within COOL 24.04 (online) with - Changing aspect-ratio and background color FuPage's lifecycle is extended by wrapping itself into rtl::Reference<FuPage> and passing a copy to the async-action lambda-capture, as it is being called from FuTemporary and managed as rtl::Reference<FuPoor>. Otherwised resources are passed to the async-action simply using std::shared_ptr<>. Signed-off-by: Sven Göthel <sven.gothel@collabora.com> Change-Id: I692204403e8a6ee526e7b463c8bf8a41c1416489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171393 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-05lok: avoid excessive progress updates.Michael Meeks
Perhaps for desktop 40 updates per second can provide a nice smooth status experience for a full screen-width progress bar in some cases; but it seems likely that five per second over a remote protocol might be better. Change-Id: Ic77b3b76d680771cb766984bdbcd9c8af4af303d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171431 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2024-08-05tdf#162295 DOCX import: optimize the check if the header/footer is emptyMiklos Vajna
The original DOCX bugdoc has some 813 shapes and 150 sections, which means that isContentEmpty() in the domain mapper is a significant cost. We don't have layout at import time, so checking if a shape has its anchor in this header/footer is still expensive, but using internal sw API makes the 2 other checks constant and the shape check is faster this way. - old cost: 16638 ms - new cost: 11910 ms (72% of baseline) (cherry picked from commit cfd3b14fd4e1ee889dd356523e5cdaa639786d37) Change-Id: I22f75ef82b0e2f618e425e076377eea3640b83cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171476 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-08-02reduce cost of dynamic casting in SdrMarkView::CheckSingleSdrObjectHitNoel Grandin
which shows up when navigating large complex documents with lots of shapes Change-Id: I0631daf1365387f1192815402921ada191ab6046 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170760 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins (cherry picked from commit 0ee4b0339c3f3fd2f39f7193e2cf54df63a071b6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170730 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-02When a shape is selected, send other shapes' rectangles.Gökay Şatır
GitHub issue link: * https://github.com/CollaboraOnline/online/issues/9689 Also add OrdNum property to ExtraInfo in order to exclude the selected shape from the list. Check new properties in tiledrendering test. Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: I544e2c8089510f47b0cc0f25e368cad6d459cb2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171374 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-08-02Fix potentially uninitialized pointer variablePranam Lashkari
Change-Id: I296b6d27dab327b49884369461abc25ece62d308 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171387 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-08-01slideshow: add flag to skip animation renderingTomaž Vajngerl
Animations currently don't work yet, so skip rendering them by default, or they cause infinite rendering loop in some cases. Change-Id: Iaf6e7d67197e86c21af65ecd3bba656c23fd74eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171383 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-08-01optimise ScTable::dumpColumnRowSizes a littleNoel Grandin
use an OStringBuffer to accumulate the result Change-Id: I7d585b48183208200c62fe4f1d9e639cc3b1d466 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 4726058aa522bf72df4938bf76075ff68f8bacc3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171356 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2024-08-01tdf#162280 vcl: consider font family type for glyph cachingMiklos Vajna
Open tdf105820-1.doc from crashtesting in a dbgutil build, save as PDF, we assert in checkGlyphsEqual(). This is a problem since commit 6dfac38bacd449c64a13363797b56aff49cf8f52 (tdf#162072 vcl, fontconfig: consider font-family-generic for substitute, 2024-07-18), because now the font name no longer determines the fallback name alone, so 2 paragraphs may share the cached vcl-level text layout, even if the underlying fallback font is different. One would naively expect that in the SalLayoutGlyphsCache::CachedGlyphsKey ctor, the fontMetric.GetFamilyType() already has the correct family type, but it turns out that is always the default, and only outputDevice->GetFont().GetFamilyType() has the up to date setting: debug:12372:12372: SalLayoutGlyphsCache ctor: output device font family name is 'Verdana', output device font family type is roman, font metric family name is 'Verdana', font metric family type is 'swiss' debug:12372:12372: SalLayoutGlyphsCache ctor: output device font family name is 'Verdana', output device font family type is swiss, font metric family name is 'Verdana', font metric family type is 'swiss' Fix the problem by explicitly including the output device font family type in the cache key. Note that this only happens in practice if the same font is used in the document with different family types, which is probably never the intention of the user. E.g. Verdana is meant to be sans, a serif Verdana is some weird corner-case. (cherry picked from commit ef1870810ec8c069e26538fd7626ad0656bed276) Conflicts: include/vcl/glyphitemcache.hxx Change-Id: Id6cc60809a35a3dcdc6e83122a559ddfbe5d5d0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171375 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-01m_aPixelSize should be in pixels, but GetPrefSize depends on GetPrefMapModeCaolán McNamara
i.e later we do: Size aSize = PixelToLogic(rEmit.m_aPixelSize, MapMode(m_aMapMode.GetMapUnit())); and PrefSize is in PrefMapMode units. Change-Id: I387316804496fc0a05c3370f370f5f562c288d77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171251 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-01fix(invert): Avoid spurious LOK invalidationsSkyler Grey
Using the same mechanism as with theme changes, we can avoid LOK getting invalidations if we have an invert-background change that doesn't apply. The trouble is that this method of inverting the background causes *lots of* properties to change, so there's no single "If we inverted the background" to check... To get there, I've checked if all of the following are true - We didn't change the color scheme - We didn't have any new colors after this change - All of the properties we were changing should have been within this color scheme While they don't necessarily mean "there was a background inversion", they do mean "something changed in your theme but no action is needed from you" - which should only be a background inversion - and if we added anything else that could fit in that category, it should also avoid LOK invalidations Change-Id: Idb680d5241db7879d9be834268ab616848c1f165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171283 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-08-01feat(invert): Allow inverted background on initSkyler Grey
Previously for Online there was no way to save the background invert state and reload it. Worse, when someone changed the state it would become the default for new document loads. This patch allows Online to specify whether it wants the background to be inverted, which should allow smooth tab refreshes while also avoiding mingling state from different people. There is a change to online to support this here: https://github.com/CollaboraOnline/online/pull/9652 Change-Id: I8c22c03d3b4589736d48509004f7789dd5166389 Refs: https://github.com/CollaboraOnline/online/pull/9652 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171208 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-01test(invert): ensure background-invert separationSkyler Grey
I0aed702185e642f631854b1f8234355c9e69ff6e made inverted backgrounds separated by view. This change adds a test to make sure that it really works, based on the work in I05486860c5f562c3cfa59b4a7fc492d48913a181 to allow a specific theme to be stated on a per-view basis Change-Id: I3d0c4814cde5cafe069f984fe7904080660f10d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171207 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-01feat(invert): Allow specifying a themeSkyler Grey
In Online, we previously weren't able to specify what we wanted the theme to be after an invert. This led to the theme being "whatever the *last* person toggled it to" rather than "whatever isn't our current theme" This commit also lays the groundwork for loading the same invert theme after a reload/rejoin/new doc in Online There is a change to online to support this here: https://github.com/CollaboraOnline/online/pull/9652 Change-Id: I05486860c5f562c3cfa59b4a7fc492d48913a181 Refs: https://github.com/CollaboraOnline/online/pull/9652 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171206 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-01fix(invert): Use separate view IDs when invertedSkyler Grey
Previously in Online the document background inversion was tied together such that if someone inverted the background, everyone in dark theme would end up with an inverted background. By adding whether the document background is dark to the view render state, we can create a new view when the background is inverted, and avoid everyone getting an inverted view. Change-Id: I0aed702185e642f631854b1f8234355c9e69ff6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171045 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-31Bump version to 24.04.6.1cp-24.04.6-1Aron Budea
Change-Id: Ia649da7a8ce3a047413d14c1ae542f6c55c310b6
2024-07-31tdf#153040 PDF export: disable export of form fields as PDF forms by defaultMiklos Vajna
Open <https://bugs.documentfoundation.org/attachment.cgi?id=195586>, notice that from "bbb", the middle "b" is bold, export to PDF, none of the "b"s are bold. The reason for this is that by default we map form controls and content controls to fillable PDF forms, which can only contain plain text. Fix the problem by defaulting to not exporting form controls / content controls to PDF forms: most users just want a PDF that is close to what they saw in the edit window -- and the ones who want a fillable PDF form can still opt in. Once the UI checkbox is enabled, we even remember that. Based on <https://gerrit.libreoffice.org/c/core/+/152622>, thanks Justin! (cherry picked from commit 159d823c7b7502ee07d897d74c4e74c6e1873596) Conflicts: filter/source/pdf/impdialog.cxx filter/source/pdf/pdffilter.cxx vcl/qa/cppunit/pdfexport/pdfexport.cxx vcl/qa/cppunit/pdfexport/pdfexport2.cxx Change-Id: Iddb75d1dbd969045321e139154f254c059eebf16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171305 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-31test: Refactor pixel assertionSkyler Grey
When a test fails, the line the assertion failed on is printed. Unfortunately, in the case of this assertion, it was always inside the same function. If we instead change the function to only return the pixel color, and perform the assertion inside the test, assertion failure error messages are more helpful Change-Id: Ia56da1b245882c8ddbf21ad98f69facc36d3ec3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171205 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-31cool#9352 unassign cursor on SdrObjEditView to avoid crashJaume Pujantell
On stress test with shapes and typing a segfault ocurred due to using a freed vcl::Cursor. On SdrObjEditView::SdrEndTextEdit, delete pOLV can delete the cursor remembered in pTECursorBuffer. But if it is set to the window before the deletion, it will be safely removed from the window. And on SdrObjEditView::ModelHasChanged a re-anchoring sets a cursor on the window that sholdn't be there and other SdrObjEditView can see, remeber, and use it even after this one died and freed the cursor. Change-Id: I3cfef3b68b77e6e6b49c3b68297a6a20e1f9394a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171184 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-31MSVC 2022 Preview: One HAVE_CPP_CONSTEVAL blocker down, one upStephan Bergmann
While the previously known issue appears to be fixed in VS 2022 Preview 17.9.0 Preview 5.0, a new one showed up that now caused > sal/qa/rtl/oustringbuffer/test_oustringbuffer_assign.cxx(63): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'rtl::OUStringLiteral<2>' > sal/qa/rtl/oustringbuffer/test_oustringbuffer_assign.cxx(63): note: Invalid aggregate initialization > sal/qa/rtl/oustringbuffer/test_oustringbuffer_assign.cxx(63): note: too many initializers etc. Change-Id: Ia74a8d6454bb5f15c0af4d3cf29989342f2eef7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163072 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170423 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-07-30Bump version to 24.04.5.3Aron Budea
Change-Id: I9b02b3a8d7cb2f2c6f3f45a8413847223cdf7026
2024-07-30fix: Skip invalidation if it won't go throughSkyler Grey
On Android, we often hit this condition where we should get an invalidation. Unfortunately, the invalidation is skipped due to being in LOK Tiled Painting, leaving us to deal with whatever tile was rendered on this go-around... ...Also because of this condition, the tile rendered here is broken. pFrame->PaintSwFrame is never called, leading to a tile which renders without things like its text. Normally, this wouldn't be a problem as it's about to get invalidated, and is more of a nice performance optimization... ...However given we don't invalidate it, we really see that tile without any text. Similar workarounds were considered (such as skipping the condition in another case that appears to be true on Android or rendering the tile anyway, even if we're about to invalidate it) but this seems to be the safest bet to avoid something like this happening on other platforms... ...The true solution is still elusive. It probably includes figuring out why this happens on Android without happening on other platforms, and fixing that, as well as perhaps figuring out what to do about this condition if we *do* genuinely trigger it on Android - as the previous solution of invalidating everything nearby won't work Change-Id: Id58f5bae8ae357d116c5f2345e88ec3364cb2172 Fixes: https://github.com/CollaboraOnline/online/issues/9654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170853 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-30Related: tdf#162072 DOCX import: handle font family for charactersMiklos Vajna
Open the bugdoc, the first paragraph is meant to be sans and the second paragraph is meant to be serif, but both of them are serif. The bugdoc uses the fonts 'IBM Plex Sans' and 'IBM Plex Serif', which is not something we bundle, so the font fallback is expected, but the fallback should have a matching font family (roman vs swiss). Fix the problem by implementing support for <w:family w:val="..."> in the DOCX import, which was just ignored previously. Now the DOCX import result in on par with the ODT import result. (cherry picked from commit d06de2e049761b7b9e8a95f17557d309812f7acc) Conflicts: writerfilter/qa/cppunittests/dmapper/data/font-family.docx Change-Id: I321b9fc6f63126ca5ad61af57af8a5bc7456d5b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171227 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-29LOK: Mention name of unknown command in exceptionAron Budea
Change-Id: I665c9aebaa4e215b8bc4622f3e245e5f2c47deab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171133 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-29lok: remove code that renders other slide layers to increase speedTomaž Vajngerl
This (temporary) removes rendering the other layers so we speed up fetching and rendering of the slides as we will only render and send the main slide layer to the online. Change-Id: I40a809499ae87850922b48785842ae6eead3a001 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171087 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-29CppunitTest_sd_annotation_tests: fix gcc buildMiklos Vajna
sd/qa/unit/AnnotationTest.cxx:256: error: undefined reference to 'typeinfo for sd::DrawViewShell' sd/qa/unit/AnnotationTest.cxx:256: error: undefined reference to 'typeinfo for sd::ViewShell' Seems SAL_DLLPUBLIC_RTTI expands to __attribute__ ((type_visibility("default"))) with clang, but not with gcc. Change-Id: Ib110ad76069c4e0ed781b7aa14d3e69bd6bfaedf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171175 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-29drawpage::getCount is expensiveNoel Grandin
so only call it once at the start of the loop. Shaves 1% off the cost of loading complex documents with lots of shapes. Change-Id: Ieb985b2523f6b4db3313eb000cf64e9c689e65c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170820 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 041b3d8166fcfe38aa04c39f94c2ada140eaf991) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170741 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-26Revert "lok: Sidebar: Fix Shadowed btn not fitting properly in the grid"Pedro Silva
This reverts commit a26c07e37ed2e5996a5f1e07a23fa4f7ddb96534. Reason for revert: it breaks mobilewizard, since it expect it to be under `fonteffects` node Change-Id: I9a4f0e4cfb5eb84557bb9e55b83ca96eb1349ae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171037 Reviewed-by: Pedro Silva <pedro.silva@collabora.com> Tested-by: Pedro Silva <pedro.silva@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-26lok: Sidebar: Fix Shadowed btn not fitting properly in the gridPedro Pinto Silva
Better to move it down where we have more space. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: If5d898f1491ed933dad00a5635036d2ceaf7fa73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170931 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-24fix-up 2 slideshow: provide animations infoMarco Cecchetti
wrong node name Change-Id: I57e91e708e0ec585aee2dd4873b60ab54e6aa8d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170978 Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-24slideshow: enable comb transitionJaviya Vivekkumar Dineshbhai
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com> Change-Id: Iac0c07f83904055a30c65e4133443772246d9502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170936 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-07-23fix-up slideshow: provide animations infoMarco Cecchetti
Avoid to export json node with the same name node name moved to nodeName property Change-Id: Ibefc6689e6af22e9d2a27b39fd1e08ced6756051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170917 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-23Resolves: tdf#162161 reexport of specific pdf appears blankCaolán McNamara
the contents of the referenced colorspace obj disappears so it gets rendered blank Change-Id: Iaa76d355b5903c695e74edadc329043156bad3b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170906 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-07-23slideshow: enable mics shape transitionJaviya Vivekkumar Dineshbhai
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com> Change-Id: I88ac6dbba007f67b2d3648f7303869825f86b377 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170541 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-23lok: render the whole slide temporary (with bg and master content)Tomaž Vajngerl
This changes the rendering of the main slide layer content to also render the master page and the background. This is needed because of the issue with the white background (instead of transaprent). Change-Id: I88b6f0287482ad1ee498b0bbda8e19d015649879 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170897 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: vivek javiya <vivek.javiya@collabora.com>
2024-07-23annot: make all keys work when writing in annotation windowTomaž Vajngerl
We did not call the method on the superclass when we don't handle the key ourselves, but we should. Change-Id: I67d55773b7e86297c00727b4791c16a1adcc37f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170430 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 3f7d0f79f1c43222bd160cffd9e443bb5fc91c99) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170832 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-23tdf#161994 annot: trigger selection of the current annotationTomaž Vajngerl
Delete annotation isn't active if no annotation is selected, but we do not report a new selection anymore, so fix this. Change-Id: Idb455d0c0d42412c55de4a7ca037342b58da548b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170429 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit aff09d7cb464af3223ee43cac0483ae3bf22fddd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170831 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-23annot: simplify getting the proper window for popupTomaž Vajngerl
Change-Id: Ic9e01d57137ddfbb6f4ec741a275b579741675a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170428 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 45d8c51610ce8e8989961135249af0b89544c094) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170830 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-23tdf#161911 annot: fix for annotation with 0 sizeTomaž Vajngerl
We need to set the size to something non-zero or it will stay zero even if we try to adapt the frame to the text content. Additionally when we adapt the frame to text, we need to update the annotation with the new size. Change-Id: I4125f95fe6d0e55ab3b00a6a457cd2c9e04ec7c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170260 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins (cherry picked from commit b547e9f19de339531709c14931998125b9a41649) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170334 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-22crashtesting tdf135164-3.docxNoel Grandin
./instdir/program/soffice --headless --convert-to odt ~/Downloads/tdf135164-3.docx fails after commit f98f684d22e6323185104ca9c082241c53dfc2b3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sat Jul 13 18:50:34 2024 +0200 remove RecalcObjOrdNums in DoTextBoxZOrderCorrection add a check to catch this case and flatten the method to make it more readable Change-Id: I7827807c77f51b28f16b1042b77b8211ab5416ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170839 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit f08fdf3e81e63469609eaafaf790cb3fea6b27c4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170866 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-07-22lok: sd: slideshow: provide animations infoMarco Cecchetti
This patch is an initial effort for collecting animations information and make them available in json format. Change-Id: I00470ea3b56c215c591f7e1e56227b63cf3be014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170785 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-08 11:14:06 +0000