summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-12-08Branch libreoffice-24-2Christian Lohmaier
This is 'libreoffice-24-2' - the stable branch for the 24.2.x releases. The commit rules are different according to the development phase: A. 24.2.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 24.2.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master.
2023-12-08Revert "Related: tdf#155266 force flush after drawing native scrollbars"libreoffice-24-2-branch-pointPatrick Luby
This reverts commit 5ff701226b00963312cb2a78e77966d012b79c82. Reason for revert: Tester reports no change in behavior after the commit. Change-Id: Ic6d9f4834c7c6e3fae34d132298b335f433df280 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160470 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-08tdf#129357 editeng: show soft hyphen in text boxes and shapesLászló Németh
Shapes and text boxes didn't show the optional hyphen at line break. Change-Id: I5cc842964fc91571e5c55995981de697da966b14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160453 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-12-08Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to a0c2cb43becec95fddd09ed6300525a735b4ba95 - update translations for master/24.2.0 Beta1 and force-fix errors using pocheck Change-Id: Ib7130fc4085faf604d249a62ae42e92019f69cf0
2023-12-08Related: tdf#156379 better align the doc statistics selectable labelsCaolán McNamara
Change-Id: I4b8270ac38ad4a4a4919be48bed717d68101466d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160457 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-08resave with latest gladeCaolán McNamara
Change-Id: Ieec096149d581e523cbd54e1ec9e97b8eab92785 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-08use same formatting for "Lines" as the other numbers in doc statisticsCaolán McNamara
Change-Id: I16991ceab68a33f154975e47145f50795ddfbcc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160455 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-08tdf#43157 vcl: remove DBG_ASSERT() from DrawDeviceAlphaBitmapSlowPath()Chris Sherlock
Change-Id: I6c120eb2bb8999276103f50bf3679366b6ee86ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157189 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-08fontconfig android: Drop obsolete patch for API level < 21Michael Weghorn
Now that the minimum SDK version/API level has been bumped to 21 in Change-Id: I875e784dd4e62993f51059ae6a280d425cb49c0a Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Dec 5 09:57:22 2023 +0100 android: Bump minSdkVersion to 21 (Android 5.0) , this patch is no longer needed. Change-Id: I391657caac76ed5b66f564a5888a35b5afb16ed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160335 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-08android: Bump minSdkVersion to 21 (Android 5.0)Michael Weghorn
NDK 26 dropped support for API levels < 21 [1] [2]. Do the same for our Android build, to ease the maintenance. Adapt configure.ac accordingly and drop the now obsolete code paths in Android Viewer Java code. This in also means that the same minSdkVersion will be used for all architectures now, while API level 21 was already used for the 64-bit variants (for which the minimum supported version was 21 anyway) and API level 19 was used for x86 and 32-bit ARM when building with NDK 24/25, API level 16 when building with NDK 23. According to [1] and [3], more than 99% of Android devices have at least Android version 5, i.e. support API level 21. [1] https://github.com/android/ndk/issues/1751 [2] https://developer.android.com/ndk/downloads/revision_history [3] https://apilevels.com/ Change-Id: I875e784dd4e62993f51059ae6a280d425cb49c0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160334 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-08tdf#156379 Fix Line count width in the Properties dialogRafael Lima
In Writer, the "Lines" property in File - Properties - Statistics does not have enough width to handle numbers with 4 digits or more. This patch fixes the issue by adjusting the label width when it is updated. Change-Id: I1a56da106f7c80ffbbaa8bdfb93932a3974b1ee0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160367 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-08Fix --enable-online-update-mar on WindowsStephan Bergmann
The code had apparently rotten a bit, * a wchar_t vs. char16_t confusion in desktop/source/app/updater.cxx * code broken by 926e4e469d0285ee72f8da80f00370b4b3120417 "Rename online updater functions and strcmp relpath" in onlineupdate/source/update/updater/updater.cxx * -DUNICODE missing in some places (so that plain Windows functions resolve to the ...W variant), which had been set centrally in the past IIRC * silencing some warnings like "C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data" (where silencing is the right thing to do for effectively extern code); no sure why those apparently didn't hit in the past, maybe it is all warnings that compilers only started to emit in recent years, or only for recent -std:c++... modes * silencing some "Conversion from string literal loses const qualifier" errors with -Zc:strictStrings-; these hit at least with recent VS 2022 Preview and --with-latest-c++, where -Zc:strictStrings is apparently now on by default Change-Id: I7fe46f5aa2b42fc9c03f24f7f0236512b4d3b936 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-08tdf#158577 Allow locking down adding new trusted authorsNoel Grandin
regression from commit 6ed8c5a0f19901ab413c6610649326b2475c3a8c Author: Noel Grandin <noelgrandin@gmail.com> Date: Sun Jul 25 21:35:05 2021 +0200 use officecfg for security options where I forgot to go back and complete a piece that was initially a little tricky. Change-Id: I2df8529ec7047bdcd9d7f655303fd72eeaa50cc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160429 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-08cid#1545617 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545748 COPY_INSTEAD_OF_MOVE cid#1545741 COPY_INSTEAD_OF_MOVE cid#1545698 COPY_INSTEAD_OF_MOVE cid#1545594 COPY_INSTEAD_OF_MOVE cid#1545588 COPY_INSTEAD_OF_MOVE cid#1545558 COPY_INSTEAD_OF_MOVE cid#1545545 COPY_INSTEAD_OF_MOVE Change-Id: I5dfec77a68959b9384fc71a2fc0908c5d1b42869 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-08cid#1545692 std::swap COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Ic0679eccd7cc781fb799b15fbb2660fcbd1445f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160447 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-08cid#1545764 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I5636f571b6c157b5b23d453d39f2c43eedc2e2a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-08cid#1546472 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1546459 COPY_INSTEAD_OF_MOVE cid#1546452 COPY_INSTEAD_OF_MOVE cid#1546403 COPY_INSTEAD_OF_MOVE cid#1546396 COPY_INSTEAD_OF_MOVE cid#1546394 COPY_INSTEAD_OF_MOVE cid#1546338 COPY_INSTEAD_OF_MOVE cid#1546324 COPY_INSTEAD_OF_MOVE Change-Id: If61457cfaf1d7ce4a069bcecdc0cc657aeb43c68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-08cid#1546475 std::swap COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Ic5325a85deb370db2091e5ce5209b6408a8652bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-08cid#1546501 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1546486 COPY_INSTEAD_OF_MOVE cid#1546485 COPY_INSTEAD_OF_MOVE cid#1546484 COPY_INSTEAD_OF_MOVE cid#1546482 COPY_INSTEAD_OF_MOVE Change-Id: I53cc622f16afc0f57ffd72e3e0a6f18e390fbb83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160443 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-08xmlsecurity: deploy asserts in OCipherContextMichael Stahl
Missed a special case in previous commit, in case the input is completely empty and PK11_DigestFinal() doesn't see a problem with it, aResult could be empty too. Change-Id: I8ea900774ae390857307ec5bab38876bead6bc86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160441 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-08tdf#158466 - UI: Part 49 - Unify lockdown behavior of Options dialogBalazs Varga
for Calc - View Page. Change-Id: I75fcb41b82c4946812d27dd364ffef8eb3086c0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160439 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-08external/libnumbertext: Silence -Werror,-Wdeprecated-declarationsStephan Bergmann
...when building against LLVM 18 trunk libc++, > In file included from Numbertext.cxx:6: > ~/llvm/inst/bin/../include/c++/v1/locale:3772:1: error: 'wstring_convert<std::codecvt_utf8<wchar_t>>' is deprecated [-Werror,-Wdeprecated-declarations] > 3772 | wstring_convert<_Codecvt, _Elem, _WideAlloc, _ByteAlloc>:: > | ^ > ~/llvm/inst/bin/../include/c++/v1/locale:3649:17: note: in instantiation of member function 'std::wstring_convert<std::codecvt_utf8<wchar_t>>::to_bytes' requested here > 3649 | {return to_bytes(__wstr.data(), __wstr.data() + __wstr.size());} > | ^ > Numbertext.cxx:164:22: note: in instantiation of member function 'std::wstring_convert<std::codecvt_utf8<wchar_t>>::to_bytes' requested here > 164 | return converter.to_bytes( s ); > | ^ > ~/llvm/inst/bin/../include/c++/v1/locale:3591:28: note: 'wstring_convert<std::codecvt_utf8<wchar_t>>' has been explicitly marked deprecated here > 3591 | class _LIBCPP_TEMPLATE_VIS _LIBCPP_DEPRECATED_IN_CXX17 wstring_convert > | ^ > ~/llvm/inst/bin/../include/c++/v1/__config:942:41: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX17' > 942 | # define _LIBCPP_DEPRECATED_IN_CXX17 _LIBCPP_DEPRECATED > | ^ > ~/llvm/inst/bin/../include/c++/v1/__config:915:49: note: expanded from macro '_LIBCPP_DEPRECATED' > 915 | # define _LIBCPP_DEPRECATED __attribute__((__deprecated__)) > | ^ (The warning is apparently only emitted late during compilation when instantiating template code, so extending the existing `#pragma GCC diagnostic push/pop` area did not work, and the `#pragma GCC diagnostic ignored` rather had to be enabled all through to the end of the TU.) Change-Id: Iffc1c468426407e3252724d18f358b9923f7f733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160437 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-08tdf#126084 document OOXML SVG tests and importTomaž Vajngerl
Change-Id: Ief29d04f2f0693a4cdfa44c7c100ac6164da38f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160378 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-08tdf#143148 Use pragma once instead of include guardsKira Tubo
Replace include guards with #pragma once Change-Id: Id7378d6cf43817a8501a314dd8614467fb10e33a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160417 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-12-08Remove duplicated includeAndrea Gelmini
Change-Id: I9c0f1e9188c731077f57b6adaf8208bc8c84d829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160438 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-12-07Related: tdf#155266 force flush after drawing native scrollbarsPatrick Luby
When scrolling on some Intel Macs either via dragging the scrollbar thumb or via swiping the trackpad with two fingers, final repaint of scrollbars doesn't appear to get flushed to the screen. It appears that scrollbars aren't updated and repainted until after a batch of native scroll events have been dispatched. On slower machines, this lag is long enough that any pending forced flushes have already been done so when the timer that repaints scrollbars finally fires, the repainted scrollbars won't get flushed to the native window until the next normal flush which may not occur until seconds later. Change-Id: Iadef6812cd2495a28347560caae81f604c908b51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160440 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-07update creditsChristian Lohmaier
Change-Id: I6bb7de64be70c68362169ae459cffa37478395b1
2023-12-07xmlsecurity: check for errors in OCipherContext::Create()Michael Stahl
If this function returns null, storing a document will proceed without reporting an error to the user, and lose all the data. Change-Id: I0f9fd53702321e7997b28e12eb5bed3349bbcc13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160435 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-07Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 193b35fe99d7112b6a2b9c8077bbca6471326db3 - update translations for master/24.2.0 beta1 and force-fix errors using pocheck Change-Id: Ie89030ffdc21fe71f753b07ea11bbf838e91417c
2023-12-07tdf#158576 Require viewing the certificateSamuel Mehrbrodt
before adding it to the list of trusted certificates. This prevents certificates from being thoughtlessly added to the list of trusted certificates. Change-Id: Ifd0273df39f13432ebad72f1289ede0e6e7a8d5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160427 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-07tdf#158223: chart2_uichart: Add unittestXisco Fauli
Change-Id: I11e20682155c524fcc119701111f5bc91f6beed8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160404 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-07cid#1546503 Using invalid iteratorCaolán McNamara
and cid#1546284 Using invalid iterator cid#1546275 Using invalid iterator cid#1546049 Using invalid iterator cid#1545929 Using invalid iterator cid#1545870 Using invalid iterator cid#1545668 Using invalid iterator cid#1545420 Using invalid iterator Change-Id: I3ad3000631b4be5917b9c5f49f21b8cc003a309c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159056 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-07Turn on MAR-based updater for Win64Thorsten Behrens
But make it default-off for the while. Change-Id: I54e2fb8544ceb5ffe88053504294e2f3d5df50d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160436 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-07xmlsecurity: W3C padding max size is the block sizeMichael Stahl
Change-Id: I90c48aafd11deb2895d01c90764fc433a9161e07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160434 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-07Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to 95ebe8994002023b90215765f0d0cbd946a25f89 - rows are shown by clicking on rows headers Change-Id: I34ac6fd200964eac8bd83d4b49694a45480095de Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160403 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-07busy loop seen on ods export attemptCaolán McNamara
ScXMLExport::ExportFormatRanges cannot advance because nMaxCols is 0 so busy loop and no progression In ScRowFormatRanges::GetMaxRows, aRowFormatRanges is empty which is why nMaxCols is 0 In ScFormatRangeStyles::GetFormatRanges aTables appears to be 30 empty items. But why it is empty can't be seen from the bt. Force this to be an assert to ensure crashtesting can flush out this case, rather than letting it get killed off as a timeout. Set this case as an error and break so failure results in an error message of failure to save instead of a hang. Change-Id: I827e1e638cddd976a48340f86741c21075afe856 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-07tdf#158500 missing style Object with no fill no lineLaurent Balland
Style "Object with no fill no line" was not correctly treated during automatic translation to UI language Change-Id: I9364b25e326387110af81494d7fa5e4c05b5f972 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160262 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-07[API CHANGE] Drop unused SnapGrid/[X,Y]Axis config groupsGabor Kelemen
from Impress/Draw last mention of them was removed in 2006 by: commit deef3fdfd9148ce1987b35a224998d63bb6b9d56 removing a commented out caller that was already commented out by "initial import" time Change-Id: I50fefe42a92c752727dfbf3b9d7c645492d034da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160190 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-07tdf#158250 Candy Impress template: replace pictureLaurent Balland
Contribution from Jérôme Bouat Replace 24 bits color picture by 8 bits color picture Change-Id: If4f2f3a75f475a9dc0b43be4e0e8afdb98a0eaa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160256 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-07GUI to en-/disable the --enable-online-update-mar feature at runtimeStephan Bergmann
...sharing the existing option tab page for the traditional --enable-online-update feature Change-Id: Ic7b04bf15bf841a46a96d62cf5a857deaa399428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160430 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-07Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to e14d56e82ecb749cbb965dfaca447c72d9a3ca04 - sf_toc updates - Old missing properties - New properties Change-Id: I7e95dcf99917bfddc7c478e7ff068f3adad190d3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160364 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2023-12-07Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 77f51afc9223e752950b42306385cbbcbdf24473 - ScriptForge (SF_Document) new XDocumentSettings property + Styles management + Toolbars Change-Id: I3c9b979a26a44aadb8dff0ab18122e1fb32ccb2a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158903 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2023-12-07tdf#158465 - UI: Part 48 - Unify lockdown behavior of Options dialogBalazs Varga
for Calc - Defaults Page. Change-Id: I813469c6e56f0bd148afb17644853116e4ae0398 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160419 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-07use std::erase_if instead of std::remove_if + std::eraseJim Raykowski
Change-Id: Ib505c89d224c9d8418ff3b1138f26d3d6e576120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160406 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-12-07Make --enable-online-update and --enable-online-update=mar orthogonalStephan Bergmann
...by turning the latter into its own option --enable-online-update-mar. (The intention is to potentially have the experimental --enable-online-update-mar configured in alongside any traditional --enable-online-update, and have it disabled by default at runtime---for which some configuration is needed and which is forthcoming.) Change-Id: Id53b4f52b310da472b305c8b23c1e2ba1931296d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-07Resave with newer Glade versionBalazs Varga
Change-Id: I252b2a2a51a12463fb2ffc764c2531ac8d5f723c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160418 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-07tdf#158375: add expert option to disable active contentSarper Akdemir
adds new expert option DisableActiveContent Right now only disables active embedded content / OLE. If OLE content is being imported via UNOEmbeddedObjectCreator::createInstanceInitFromEntry with the expert option DisableActiveContent set, the imported OLE object is now forced to be ODummyEmbeddedObject. ODummyEmbeddedObject doesn't implement any other state then embed::EmbedStates::LOADED (i.e. doesn't implement RUNNING, ACTIVE etc.) which makes it possible to prevent the imported OLE object becoming active. The functions that now throw lang::NoSuchElementException are usually called on new creation of embedded content via UI. But since the call sites expect the possibility of embedded content failing to initialize, that is handled by showing a popup stating some form of `unable to insert`. A follow-up improvement of disabling insertion of OLE content via dialogs could be implemented. Change-Id: Ib558a2a129b491798f5036a7bb269116545be75d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160402 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2023-12-07cid#1558798 Unchecked return valueCaolán McNamara
Change-Id: Iddb702f40ced018c104a8a42847bc396ba258ff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-07cid#1545320 Unused valueCaolán McNamara
Change-Id: I772a5d7608b92634b7cfed1c1e1730eab34bee89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160421 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-07tdf#33201 Move Cell position logic inside the functionSahil
Previously to Highlight some cell's row/column, one had to get the current cell cursor position, and pass it to HighlightOverlay(), but now that is not required. Change-Id: I4d08bf1fa84fcbd4820fd166c1d137bd3d950413 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160151 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-17 22:45:44 +0000