summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-06-13coverity#1362679 try and tell coverty these are non-null by restoring...Caolán McNamara
to the pre vectorization code layout before... commit e5d378b1ba04c470e0c6c16b48af97ab5818e2bb Author: Kohei Yoshida <kohei.yoshida@gmail.com> Date: Tue Apr 3 18:26:29 2012 -0400 Check for empty-ness of vector before accessing the first element. I hope this will keep Stephan's tinderbox happy. If not... changed it, now that c++11 data is available to us Change-Id: Ie5e584c02f51d9cc8dc3b3f65f7cfc90822f65c2
2016-06-13Related: tdf#100337 revert x-crossplatform ToTop...Caolán McNamara
which was added in... commit 82abd23f3ee1900b7579e5a0afa23581d5836f01 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Nov 12 16:05:44 2015 +0000 Resolves: tdf#93317 Modified Document Dialog misses focus on Gtk3 because it reportedly causes a windows-only regression and instead fix tdf#93317 by presenting windows and taking focus using the last received user input time to ensure that the ToTop on the main window doesn't take precedence over the following gtk_widget_show of the quit dialog Change-Id: I08d1889232af75ca214ccafe9e4e9364df74fbe2
2016-06-13sd: implement per-view LOK_CALLBACK_DOCUMENT_SIZE_CHANGEDMiklos Vajna
These callbacks were invoked from the model, so need to iterate over the view shells and invoke them on all the views. Change-Id: Ie8107f4782b513b874d0b94464ea372994dabbe9 Reviewed-on: https://gerrit.libreoffice.org/26221 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13notebookbar: reduced paddingSzymon Kłos
Change-Id: I43df4ba611d7b377829ac3b5f17ff26077e9f13d
2016-06-13sw comments: implement per-view LOK_CALLBACK_INVALIDATE_TILESMiklos Vajna
After registration and invalidation is handled per-view, the scrollbar and the text control of the comments is rendered correctly. Change-Id: I5cfa8b43fdc3a2ce7a008269b0283ee25d141440 Reviewed-on: https://gerrit.libreoffice.org/26218 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13gtk3: m_bSetFocusOnMap is only used on gtk3Caolán McNamara
Change-Id: I3cf9e13dafb59031ab8dc4e678de9d502a376d52
2016-06-13tdf#43157 Clean up DBG_ASSERTkrishna keshav
Change-Id: I2a7d5d507a875e555441a9d30d54e638e5dea026 Reviewed-on: https://gerrit.libreoffice.org/26099 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-13Resolves: tdf#90419 diminish precision error in Series FillEike Rathke
There may be more elegant ways to accomplish this, go and find one.. Change-Id: Iceaa0783db9cf3d3e1aa20f075fe7e0618a1feb6
2016-06-13Remove unused member varStephan Bergmann
Change-Id: I0f4143cb2a34cf18e6c926432d707d84ef0ea579
2016-06-13tdf#42949: clean up includes in include/vbahelper with iwyuJorenz Paragas
Change-Id: Iaf93ff58229e9362b03b3e810611e969ef8baf38 Reviewed-on: https://gerrit.libreoffice.org/26206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-13editeng: implement per-view LOK_CALLBACK_TEXT_SELECTIONMiklos Vajna
These were the last callback invocations in editeng that did not support the per-view callback. Change-Id: Ic703f6708a37f059dcdbbc321d6b18a7fd04edae Reviewed-on: https://gerrit.libreoffice.org/26216 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13Added Test for tdf#73162 TOC/IndexVarun
Change-Id: I1bd6dc18277aa009c23c75b85932d1c93fc13b5e Reviewed-on: https://gerrit.libreoffice.org/26190 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-06-13GSoC Table Styles, CellStyleJakub Trzebiatowski
- insertByName - replaceByName - removeByName Change-Id: I964aa0dc2e7f5a5be9eaec719b8944e847eb9d6a Reviewed-on: https://gerrit.libreoffice.org/26037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-13Related: tdf#93135 adjust the ui to reflect the text fit options entanglementCaolán McNamara
We have two major groups of text fitting options in draw/impress ones that apply only to custom shapes * Word wrap text in shape * Resize shape to fit text those that apply to other elements, e.g. text boxes, legacy rectangles and lines * Fit width to text * Fit height to text * Fit to frame * Adjust to contour Of the second group, only "fit to frame" is always available. Text boxes have "Fit width to text" and "Fit height to text", while stuff like legacy rectangles and lines etc have "Adjust to contour" instead. A fun issue is that (currently anyway) the bit for "resize shape to fit text" in custom shapes and the bit for "fit height to text" in text boxes is the same bit, SDRATTR_TEXT_AUTOGROWHEIGHT. So before this change in all circumstances the same collection of checkboxes for all settings was visible. With context used to enable or disable which ones could be set according to the type of shape it was. Simultaneously there is logic to enable/disable checkboxes depending on if other checkboxes that control contradictionary options were checked/unchecked. e.g. "Fit to frame" disabled if "fit height to text" is enabled. So its not apparently why some can be enabled and some disabled by clicking about the place in the shared collection. In this commit we split the sizing options into their two families, one frame and column for each of "custom shapes" and "everything else". When adjusting a single selected object we use context to determine which column to show or hide. When editing multiple objects or the underlying graphic styles we show both columns. When editing a presentation style we show just the text box column. (The use of HasText in the original code is a concern, cause it doesn't make sense to me, using it like that means that in the original dialog format->text on an empty text box from F2 shows the contour option, but after entering text and then format->text it shows a set of different text box sizing options, so that's dropped here) Because (currently) the same SDRATTR_TEXT_AUTOGROWHEIGHT bit it used for two apparently different things then we visually toggle on all things that use that bit in multi-column mode when its togged on, i.e. on editing a style visually both "fit height to text" and "resize shape to fix text" are kept in sync when you toggle one or the other. We don't disable the "resize shape to fit text" checkbox (unlike the fit height to text checkbox which controls the same bit) if "fit to frame" and "adjust to contour" are set, and give it additional powers to unset those if clicked. This hopefully makes the ui describe the way things actually are. Because this SDRATTR_TEXT_AUTOGROWHEIGHT is currently sort of doing two purposes selecting a freshly drawn custom rectangle and using format->default formatting will cause it to change properties because the underlying SDRATTR_TEXT_AUTOGROWHEIGHT bit is cleared. The way things should probably be I guess is that there should be a SDRATTR_TEXT_AUTOGROWSIZE property (which used to exist but wasn't hooked up to anything) just for custom shapes which overrides the old family of options if set. Change-Id: I49241c90d919eeb5caa8775beab57746d5c6df04
2016-06-13looks to me we can merge these ctorsCaolán McNamara
Change-Id: Iab1e9888d35ecad7b1ca9713a571f32d59389cd1
2016-06-13Clean up uses of Any::getValue() in editengStephan Bergmann
Change-Id: I2bce1aba3e01e5c8d67d47b88cddca1f7ad37a93
2016-06-13editeng: imlement per-view LOK_CALLBACK_CURSOR_VISIBLEMiklos Vajna
Also assert that we don't try to invoke the model callback in editeng in the the view-callback case. Change-Id: I9f7b7d74da154ac8d0fe3404b7d8114008f74773 Reviewed-on: https://gerrit.libreoffice.org/26211 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13remove the correct but unwanted no-break space in percentage, tdf#63272Eike Rathke
As per l10n request https://listarchives.libreoffice.org/global/l10n/msg09997.html Change-Id: I4f83c85abc15c12f77ac478589736cd799760832
2016-06-13sw: prefix members of SwCacheAccessMiklos Vajna
Change-Id: Ia18ad7e283898418118237c1997a6ee72c468341 Reviewed-on: https://gerrit.libreoffice.org/26209 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13improve formatting of DBG_UNHANDLED_EXCEPTION messageNoel Grandin
put more useful info on the same line, and indent following lines, to visually separate them from new log messages. Change-Id: Ieda71aebf68420a0521ce98c621b0236d533bc53
2016-06-13loplugin:sallogareasNoel Grandin
Change-Id: I6ce045db236b81aa8bc7bce2a0e20c4132c5931f
2016-06-13coverity#1362685 Uninitialized scalar variable (UNINIT)Eike Rathke
Change-Id: I5da1a04d2fce6583fad0934d06dcba452181f256
2016-06-13coverity#1362684 Uninitialized scalar variable (UNINIT)Eike Rathke
Change-Id: I19ba749ae4cca43602330834f155eca89638c711
2016-06-13VCL: Simplify Splitter initialisationArnaud Versini
Change-Id: I95e42012d8503493a89aee94fd05b2a878535f06 Reviewed-on: https://gerrit.libreoffice.org/26198 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-13tdf#98602 Duplicate code in onlineupdate/Ras-al-Ghul
Converted libmar into static library and removed duplicate code. Change-Id: I51c58ae9a6a1f1128422b4a79491d0cd62e6ced6 Reviewed-on: https://gerrit.libreoffice.org/23312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-06-13coverity#1362680 Pointer to local outside scopeCaolán McNamara
this doesn't seem to make sense anymore since... commit 4d49c9601c9b3e26a336e08e057d299895683480 Author: Stephan Bergmann <sbergman@redhat.com> Date: Wed Jun 8 17:14:34 2016 +0200 Let loplugin:passstuffbyref also look at fn defn not preceded by any decl so lets revert that to be safe Change-Id: I78fe8ae48dc4c4f3d5786c7232d7e791ff50d9b4 Reviewed-on: https://gerrit.libreoffice.org/26189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-13loplugin:passstuffbyref: For now disable "pass parm by value" warningsStephan Bergmann
That needs fixing, to check that the parm is not bound to a reference, cf. <https://gerrit.libreoffice.org/#/c/26189/> "coverity#1362680 Pointer to local outside scope". Change-Id: I3656354ccd10affafa006c9e46cf1db608b5b2a7
2016-06-13loplugin:sallogareasStephan Bergmann
Change-Id: If054c98f887b62adaf6c73ee35e664507a69b6df
2016-06-13loplugin:vclwidgetsNoel Grandin
Change-Id: I3567c3f9c5fe8374abd81d3f6e9a4a41e6a4c23d
2016-06-13Convert DBG_ASSERT in xmlsecurityNoel Grandin
Change-Id: Ideec43617ff214b7e0dcbb0a1969955b34ee19e4 Reviewed-on: https://gerrit.libreoffice.org/26196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-13loplugin:sallogareasStephan Bergmann
Change-Id: Ib28e76ed6947431c6466d11aaadca8d95abfc275
2016-06-13loplugin:sallogareasStephan Bergmann
Change-Id: I97fe4a566531015fe6c9fd275aaa46723aee9513
2016-06-13fix buildDavid Tardon
Change-Id: I01a111160d43e2f398ff4c560810b737b62b6ba3
2016-06-13Remove redundant redeclarationStephan Bergmann
Change-Id: I61f811ddfff624f76eb75695cb12576b8aeca47a
2016-06-13Fix typosAndrea Gelmini
Change-Id: Ic3efae53430fbb2c1eb7962c3cf69bf99315e55b Reviewed-on: https://gerrit.libreoffice.org/26202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-13opengl: vertex colors are defined in range 0-255 (GLubyte)Tomaž Vajngerl
Change-Id: I27962119ade7bcbc20b94eb548bd2c9dfb386404 Reviewed-on: https://gerrit.libreoffice.org/26207 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-06-13starmath: SmElement owns SmNodeTakeshi Abe
SmNodePointer is no longer used, so drop it. Change-Id: I5194cc7e1d9e551f4131cbcac0d84351bb2f2eab Reviewed-on: https://gerrit.libreoffice.org/26146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-12tdf#100333 Ctrl + G for Save in SpanishYousuf Philips
Change-Id: Iec5c18e32c35d10c4992490d2b039d5106d3f1c6 Reviewed-on: https://gerrit.libreoffice.org/26194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-12VCL: Simplify MessBox and its children initialisation.Arnaud Versini
Change-Id: Icf24af615e6020b40f92f565194b2328e99f47ad Reviewed-on: https://gerrit.libreoffice.org/26199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12convert more DBG_ASSERT(false to SAL_WARNNoel Grandin
Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55 Reviewed-on: https://gerrit.libreoffice.org/26195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12Resolves: tdf#100313 OutputDevice::isDisposed doesn't work anymoreCaolán McNamara
since commit 51fe4d63dfdf0ea24d2fecf75d25cbe607ed1c09 Author: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Date: Tue May 3 00:34:05 2016 +0300 tdf#97527 vcl: reference-count Menu Change-Id: Ia12434fede69ad247ed67691517437a9ada31acd Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/24596 which created a base-class VclReferenceBase for OutputDevice and Menu and so moved isDisposed from OutputDevice to VclReferenceBase, but *duplicated* the mbDisposed in VclReferenceBase so the bit set by disposeOnce in OutputDevice was a different bit to the bit returned by isDisposed from VclReferenceBase. Which meant that the fix of... commit 26c32cfee9fc9a769adba19f455e4d6c13b6d89d Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Nov 27 16:10:10 2015 +0000 Resolves: rhbz#1283426 using vdevs based on now dead physical devs is unsafe no longer worked. Finish moving the mbDisposed to VclReferenceBase to fix this Change-Id: I9bc1ba3d03f3aae7c3f58eb277176d9521bdb05d
2016-06-12Resolves: tdf#92478 avoid crash on using scanner on windows x64Caolán McNamara
which appears to correspond to backtrace http://crashreport.libreoffice.org/stats/crash_details/ad46ef89-6b98-44f9-b060-ccb25015269d Change-Id: Ic5a4b66028db6ba4aea08baf5bf4a672f71745a0 Reviewed-on: https://gerrit.libreoffice.org/26197 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-06-12VCL: Move local methods to anonymous namespaceArnaud Versini
Change-Id: Iac31e2653c40ff118e319ecf3ee14da91152f65e Reviewed-on: https://gerrit.libreoffice.org/26193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2016-06-12tdf#92218 tweaks to single toolbar mode toolbarsYousuf Philips
Change-Id: Ia8311c48dfa116b4557880a48a7299659a10cb0e Reviewed-on: https://gerrit.libreoffice.org/26131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-06-12convert DBG_ASSERT(false, to SAL_WARN(Noel Grandin
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c Reviewed-on: https://gerrit.libreoffice.org/26187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12BASIC : Add SbModule::FindMethodArnaud Versini
Change-Id: I3418c4a3d24b3b6630d6c80a6c8aa9d4ffb7e73a Reviewed-on: https://gerrit.libreoffice.org/24346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12remove some unnecessary castingNoel Grandin
Change-Id: I451df09db58256fed68ce8537b2d8eb4b6ab6942 Reviewed-on: https://gerrit.libreoffice.org/26184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-11coverity#1362678 Dereference after null checkCaolán McNamara
RelocateToWindow is only called by RelocateToParentWindow RelocateToParentWindow is only called by RelocateToWindow and ViewShellWrapper::relocateToAnchor ViewShellWrapper::relocateToAnchor never passes nullptr as its argument to RelocateToParentWindow so presumably this can never be null WriteFrameViewData was never called by that logic and ReadFrameViewData was always called Change-Id: Ida584b330d7c7539515a5e7287206f6469699b98
2016-06-11coverity#1362676 Dereference after null checkCaolán McNamara
ImplGetDefaultWindow has to exist, its created if its not Change-Id: I51364ef1a525856424c0b7afcd8c906d3eb73fb9
2016-06-11coverity#1362681 Untrusted loop boundCaolán McNamara
and coverity#1362682 Untrusted loop bound Change-Id: I97eacad09abed4f91744b36f572761e43a3477fb
generated by cgit (git 2.34.1) at 2025-02-11 04:44:04 +0000