Age | Commit message (Collapse) | Author |
|
When lokit is destroyed, the Desktop service
is still alive. So in order to avoid debug
assertion "Desktop disposed before terminating it",
terminate to quit application.
Change-Id: Id1391cde516915d915e5321799436e92b444e935
Reviewed-on: https://gerrit.libreoffice.org/22359
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Project: help 9f126548f1640b34521037502dc7a1bc0d0d3094
tdf#86866 describe AutoCorrect Options dialog btns
In Help, describe AutoCorrect Options "Ok, Cancel, Reset"
buttons (all tabs of dialog)
Added an embed tag with definition of OK, Cancel and reset buttons
Change-Id: Ie0d55a06ebe0a94c965b25d048567b164f1697cc
Reviewed-on: https://gerrit.libreoffice.org/22361
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I21faf2034c6253226637bfb65deb869d0c4eda07
|
|
Project: help 8259390d2d978d37dc73e8e2cb0f1fcd0299afdf
tdf#95281 Help page for the SKEWP function
Write help page for SKEWP spreadsheet function
Change-Id: Ib7fc372bc2be4c55663a6ab58f488aa204631d20
Reviewed-on: https://gerrit.libreoffice.org/22322
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Project: help e53a0d788c6a34d9375e33adc2e9946e2348ad23
tdf#95282 Help page for the COLOR function
Write help page for COLOR spreadsheet functions
Change-Id: I2a34cb2b1f25f3d0013a93dff320b70d76a1f4d6
Reviewed-on: https://gerrit.libreoffice.org/22300
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Because the writerfilter::ooxml::OOXMLFastContextHandlerShape
constructor only sent the input stream (and not the full media
descriptor) to oox::shape::ShapeContextHandler, it's startFastElement()
tried to reconstruct a media descriptor from just the input stream. As a
result, the base URL of the document got lost at the time the
oox::drawingml::BlipContext constructor tried to call getAbsoluteUrl(),
to convert the relative URL to an absolute one.
Fix the problem by sending not only the input stream, but the full media
descriptor to the shape importer. As a bonus that makes code simpler,
too.
Change-Id: I1f06c04d0745aa7e2e06d4848cf454790d5073ca
|
|
Change-Id: I45865bdce1957bb4f970e069241e1bb7714b4f4c
|
|
Change-Id: I112dec3253c6eb41dd18bd5cdbcc5a488e4d268c
|
|
Change-Id: I370973066604fc04201431a67d3752cc63a60e6d
|
|
Change-Id: I7df457dfa3f1d36641c577f353a50e03c37cb09b
Reviewed-on: https://gerrit.libreoffice.org/22382
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I654151d662d579533f89cbc13af1e10cb8944edf
Reviewed-on: https://gerrit.libreoffice.org/22383
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
In the preinit stage, the VCL initialization is done by the parent process
and when the lo_startmain thread de-initialize the VCL, some services are
disposed early, and it causes segmentation violation.
So it is ensured that pointers to service objetcs is set nullptr after
deleting.
Change-Id: I65ecfc2d2694a981ec2986988efabdfd28d0cce4
|
|
Change-Id: I8dafbf99638fd24828327ce4493bfbbf1b9d2c6d
|
|
conditional expression of the form '!A ? B : true' (with A of type
'bool' and B of type 'bool') can literally be simplified as 'A || B'.
Change-Id: I46bee836425bf1c76def23e30dca9ddd9e791b42
|
|
In the preinit stage, the VCL is initialized in the parent process
and when the lo_startmain thread is started, the thread initialize
VCL again.
It is not necessary to initialize twice.
Change-Id: I819cf0125afe7760c3f4d91c420d36a3a383902c
|
|
Change-Id: I768b45818eaa0138d033bfcf6fd6e94459e44c0b
|
|
In the preinit stage, the preInitBootstrap is called to load
implementations for each service registered by the service manager.
All service requests are: initial Component Context and the process
service factory is set.
However, some services require that VCL is properly initialized.
Change-Id: Ib116e3da172b860f2df4d672f6181b5de0b7e6b2
|
|
Change-Id: Ie6f6d769b611c8440ddab802545e6bdc482d1476
|
|
Should fix the build for Android.
Change-Id: Iabba9da8755805ad4d9d21d7a6b4b22e3fa6418f
|
|
Change-Id: I96bda48eb553f467fcf5d7120561d2160647e3bb
|
|
Change-Id: I849e2e945a31ab37c9a24969d6e1decd69170380
|
|
Fails when the relevant part of XSecController::exportOOXMLSignature()
is commented out, i.e. the member function just writes a <Signature> XML
element, no child elements.
Change-Id: I526c1170c8ada71f111a1ad56d74af1a4102dbce
Reviewed-on: https://gerrit.libreoffice.org/22375
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I9cc99c3108bae582d0da9645ba75947cced904fc
|
|
Change-Id: I933266695bfa88eb6665c7d2968176d74b640172
|
|
Change-Id: I3a4097abe5887f0859ea11ac2025cf52689dc4e4
|
|
Parsing unit test checks that the xml values are parsed correctly
and that the DriverInfo structure is populated with the expected
values.
Evaluate unit test checks that blacklisting / whitelisting
logic blocks OS/vendor/driver/device as expected.
Change-Id: Ib1b0926606f0835207c324193bbe19ba83f86bdc
Reviewed-on: https://gerrit.libreoffice.org/22371
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: I3b0effe35ad7b37ff7ab3de2a3b78b6312779139
|
|
sort of thing and genericize it
Change-Id: I27e1e47f2b371e5269db079cfc1262d056105f80
|
|
Change-Id: I97acb4a2e9aedb15671d65f6995faeab4ff5716f
|
|
It's hard to unit test signing when the logic is implemented in the Add
and OK button handlers.
Change-Id: I5e07df69cd808cf170e21dfd55f2f44bc79c58a8
|
|
Otherwise OpenGL can't render, cache and diff these; so we loose them.
Change-Id: Iac4f3ee0fc68154f708a881d5e0255fc9f8df62d
|
|
Change-Id: Ifc3501e5f4c1f2b20e32ff41759ff836c3236b86
|
|
Change-Id: I8d44b302bc78d9c89717f7169a04e9c736047b94
|
|
Intended to be used from an application like the LibreOffice On-Line
server so that it can be called in a process that then will call
fork() several times, and much space consuming data will end up being
shared.
Change-Id: I65341c57d00308d246ec90deab8050b2c4bb3e61
|
|
...and SolarMutex, when e.g. during JunitTest_framework_complex the main thread
has the SolarMutex locked and tries to lock
> osl_acquireMutex(oslMutexImpl*)
> osl::Mutex::acquire()
> osl::Guard<osl::Mutex>::Guard(osl::Mutex&)
> sd::ToolBarManager::Implementation::LockUpdate()
> sd::ToolBarManager::LockUpdate()
> sd::ToolBarManager::UpdateLock::UpdateLock(std::shared_ptr<sd::ToolBarManager> const&)
> sd::framework::ToolBarModule::HandleUpdateStart()
> sd::framework::ToolBarModule::notifyConfigurationChange(com::sun::star::drawing::framework::ConfigurationChangeEvent const&)
> sd::framework::ConfigurationControllerBroadcaster::NotifyListeners(std::__debug::vector<sd::framework::ConfigurationControllerBroadcaster::ListenerDescriptor, std::allocator<sd::framework::ConfigurationControllerBroadcaster::ListenerDescriptor> > const&, com::sun::star::drawing::framework::ConfigurationChangeEvent const&)
> sd::framework::ConfigurationControllerBroadcaster::NotifyListeners(com::sun::star::drawing::framework::ConfigurationChangeEvent const&)
> sd::framework::ConfigurationUpdater::UpdateConfiguration()
> sd::framework::ConfigurationUpdater::RequestUpdate(com::sun::star::uno::Reference<com::sun::star::drawing::framework::XConfiguration> const&)
> sd::framework::ChangeRequestQueueProcessor::ProcessOneEvent()
> sd::framework::ChangeRequestQueueProcessor::ProcessEvent(void*)
> sd::framework::ChangeRequestQueueProcessor::LinkStubProcessEvent(void*, void*)
> Link<void*, void>::Call(void*)
> ImplHandleUserEvent(ImplSVEvent*)
> ImplWindowFrameProc(vcl::Window*, unsigned short, void const*)
> SalFrame::CallCallback(unsigned short, void const*)
> SvpSalInstance::DoYield(bool, bool, unsigned long)
> ImplYield(bool, bool, unsigned long)
> Application::Yield()
> Application::Execute()
> desktop::Desktop::DoExecute()
> desktop::Desktop::Main()
> ImplSVMain()
> SVMain()
> soffice_main()
> main()
while some URP worker thread has sd::ToolBarManager::Implementation::maMutex
locked and tries to lock
> osl_acquireMutex(oslMutexImpl*)
> osl::Mutex::acquire()
> SalYieldMutex::acquire()
> SolarMutexGuard::SolarMutexGuard()
> framework::ToolbarLayoutManager::implts_calcWindowPosSizeOnSingleRowColumn(int, int, framework::ToolbarLayoutManager::SingleRowColumnWindowData&, Size const&)
> framework::ToolbarLayoutManager::doLayout(Size const&)
> framework::LayoutManager::implts_doLayout(bool, bool)
> framework::LayoutManager::implts_doLayout_notify(bool)
> framework::LayoutManager::unlock() (this=0x2b0d9ff633e8)
> (anonymous namespace)::LayouterLock::~LayouterLock()
> std::default_delete<(anonymous namespace)::LayouterLock>::operator()((anonymous namespace)::LayouterLock*) const
> std::unique_ptr<(anonymous namespace)::LayouterLock, std::default_delete<(anonymous namespace)::LayouterLock> >::reset((anonymous namespace)::LayouterLock*)
> sd::ToolBarManager::Implementation::Update(std::unique_ptr<(anonymous namespace)::LayouterLock, std::default_delete<(anonymous namespace)::LayouterLock> >)
> sd::ToolBarManager::Implementation::UnlockUpdate()
> sd::ToolBarManager::Implementation::UpdateLockImplementation::~UpdateLockImplementation()
> sd::ToolBarManager::Implementation::SetValid(bool)
> sd::ToolBarManager::Implementation::EventMultiplexerCallback(sd::tools::EventMultiplexerEvent&)
> sd::ToolBarManager::Implementation::LinkStubEventMultiplexerCallback(void*, sd::tools::EventMultiplexerEvent&)
> Link<sd::tools::EventMultiplexerEvent&, void>::Call(sd::tools::EventMultiplexerEvent&) const
> sd::tools::EventMultiplexer::Implementation::CallListeners(sd::tools::EventMultiplexerEvent&)
> sd::tools::EventMultiplexer::Implementation::CallListeners(unsigned int, void*)
> sd::tools::EventMultiplexer::Implementation::frameAction(com::sun::star::frame::FrameActionEvent const&)
> (anonymous namespace)::Frame::implts_sendFrameActionEvent(com::sun::star::frame::FrameAction const&)
> (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&)
> (anonymous namespace)::Frame::close(unsigned char)
> gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*)
> cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**)
> bridges::cpp_uno::shared::unoInterfaceProxyDispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**)
> binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const
> binaryurp::IncomingRequest::execute() const
> request(void*)
> cppu_threadpool::JobQueue::enter(long, bool)
> cppu_threadpool::ORequestThread::run()
> threadFunc(void*) (param=0x2b0db00019e0)
> osl_thread_start_Impl(void*)
> start_thread
Change-Id: Ie846bd95944680160eebc93b904875142723ac70
|
|
...after 8c125eca7f8a0dd2d59678cff2574bbccc70e536 "tdf#45904 move java based api
tests to c++"
Change-Id: Ia8469a6bcbb27658f4f26d41ff83389e37888bde
|
|
Change-Id: I273d80b4e9fb45955c5496cf5559df5dd4b057b0
|
|
Change-Id: I95cce21c6c9beb5637dd4f4a769f455eaacbec2b
|
|
Change-Id: I1ba88bca82b5b251ed34330ab5e0cb8bd88a5815
|
|
Change-Id: Id3ce7ce651f541106cf60116f717e6ffd805db24
|
|
Although LO was exporting whether an image was flipped
horizontally or vertically, it wasn't reading it in during
an import.
Change-Id: Ia85e3459d00f40d852bbcd3fcfe15e7b53d518ba
Reviewed-on: https://gerrit.libreoffice.org/22344
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
These pointers must be non-null, or deferencing null can happen.
Change-Id: I3ced1204abb70cf7c525ea9d50c6a3a295728ab5
Reviewed-on: https://gerrit.libreoffice.org/22365
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Given that all DOCX signing code is in xmlsecurity and it wasn't
DOCX-specific, this works out of the box.
Change-Id: I18429f63c125a43346e9e52021e1b7e33b300af4
|
|
Change-Id: I9e20a35dd8e18ba1a9251f4dc3ce903183c250cf
Reviewed-on: https://gerrit.libreoffice.org/22368
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
|
|
- MenuBarManager::Activate has a check for duplicate activation,
which makes the second activation attempt fail. Removing this
check or deactivating after each activation will likely affect
performance even more, but on the other hand should solve
lp#1296715, which was the main reason of the over activation
in the first place. So let's activate only one menu at a time,
and do full activation only on the initial update.
- Unfortunately the HUD activation callback doesn't work, so
we still have to keep active status listener for all menu
items. (Which is BTW against the recommendation in
XPopupMenuController::updatePopupMenu IDL doc. Fortunately
the performance problem hardly noticeable on modern hw.)
Change-Id: I96affa72412f3f38160fdca4b6efd20ca68d059f
Reviewed-on: https://gerrit.libreoffice.org/22369
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Change-Id: I15f0320b646d20f0093c77286c1ff2715aacb8ce
|
|
Change-Id: I48552afc35c1f7cfff3562c36eca3f1cf6174077
|
|
...and fix its documentation, and use it throughout the code base.
Change-Id: I349bc2009b1b0aa7115ea90bc6ecd0a812f63698
|
|
Change-Id: I268f0de42e0567d74dd9b9b84b19d6afbf4d44df
|
|
Change-Id: I4f147c3d55de86eb4bd56bb4c728df19c925b376
Reviewed-on: https://gerrit.libreoffice.org/22366
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
|