summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-04-14loplugin:passstuffbyref in toolkitNoel Grandin
Change-Id: I0f44beaec29a24e81e3c3ccace00013091eeae92
2016-04-14loplugin:passstuffbyref in svxNoel Grandin
Change-Id: I7d405830785cb12aaceb65d6ed03dda04aa90fd8
2016-04-14use atan2 from std instead of glmTomaž Vajngerl
Some system glm libs don't (yet) have atan2 available and it is not really needed in this case anyway (as we don't use it for glm::vec2 for example) so just replace it with std::atan2. Change-Id: I5d417338ec167489f0252821650c64be454cca8a
2016-04-14Use const_iterator when possible (svx/dialog,engine3d,fmcomp,form)Julien Nabet
Change-Id: Ie08593a3b5b3043a1f212d51d77ced467c309749 Reviewed-on: https://gerrit.libreoffice.org/24064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-14149Tor Lillqvist
Change-Id: I63f055756ff5f571d5ebe89aa4aee52d8ae2c510
2016-04-14no need to call rowHidden and rowFiltered repeatedly, tdf#90659Markus Mohrhard
Change-Id: Ie104a0d6c2ee0a88363fb461762e2bcca00976dd Reviewed-on: https://gerrit.libreoffice.org/24052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-14tdf#99244 opengl: miter limit for poly linesTomaž Vajngerl
Change-Id: I1c363a8f1d21bbacab0c5785544aa8becfe39363
2016-04-13Missing spacing in Show Detail dialogAdolfo Jayme Barrientos
Change-Id: I70ba6ec821d0d82b8c73810d7d3cf3acd0bad0f7
2016-04-13upgrade to ICU 57Eike Rathke
This does not apply patches external/icu/khmerbreakengine.patch external/icu/khmerdict.dict anymore, as the khmerbreakengine.patch failed to apply with several hunks of which one was 16k. Asking the patch contributor to follow-up on this. Change-Id: I78d4371d04a7b03417d402a222bcd384f02a619e Reviewed-on: https://gerrit.libreoffice.org/24067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13lok context menu: Add module specific unit testsPranav Kant
For calc, now click on the image to have more diverse context menu with checkbuttons etc. Change-Id: Ibe2471348b2572523f2684144bd18664ab48a2bb Reviewed-on: https://gerrit.libreoffice.org/24006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.com>
2016-04-13vcl: fix valgrind warning in g_lo_action_group_query_actionMichael Stahl
Change-Id: I0755254d4d6d24689d4f5b39c3a6c9a29ae53b99
2016-04-13tdf#97853 connectivity: fix inverted conditionMichael Stahl
Also in 2 places IS_TYPE was converted to dynamic_cast instead of a typeid check; use typeid there too, just for consistency. (regression from ac9671f94800b647f82b12e718968311a025e87e) Change-Id: I0df47a845eff660c791304c22c97704589ab999f
2016-04-13Avoid null ToolBox::mpData deref during Frame::closeStephan Bergmann
Oh my, whatever the true cause for this SEGV in JunitTest_framework_complex, <http://ci.libreoffice.org/job/lo_tb_master_linux_dbg/6628/console>, processing an incoming URP request > ToolBox::GetMenu() const at vcl/source/window/toolbox2.cxx:1775 > framework::ToolBarManager::ImplClearPopupMenu(ToolBox*) at framework/source/uielement/toolbarmanager.cxx:1309 > framework::ToolBarManager::dispose() at framework/source/uielement/toolbarmanager.cxx:470 > framework::ToolBarWrapper::dispose() at framework/source/uielement/toolbarwrapper.cxx:106 > framework::ToolbarLayoutManager::destroyToolbars() at framework/source/layoutmanager/toolbarlayoutmanager.cxx:654 > framework::ToolbarLayoutManager::reset() at framework/source/layoutmanager/toolbarlayoutmanager.cxx:363 > framework::LayoutManager::implts_reset(bool) at framework/source/layoutmanager/layoutmanager.cxx:413 > framework::LayoutManager::frameAction(com::sun::star::frame::FrameActionEvent const&) at framework/source/layoutmanager/layoutmanager.cxx:2804 > (anonymous namespace)::Frame::implts_sendFrameActionEvent(com::sun::star::frame::FrameAction const&) at framework/source/services/frame.cxx:2953 > (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) at framework/source/services/frame.cxx:1449 > (anonymous namespace)::Frame::close(sal_Bool) at framework/source/services/frame.cxx:1689 > framework::Desktop::impl_closeFrames(bool) at framework/source/services/desktop.cxx:1674 > framework::Desktop::terminate() at framework/source/services/desktop.cxx:238 and the main thread idling in Application::Yield. Change-Id: I41ff8007ee4bbc37473aa5f077ff706b51d31c64
2016-04-13tdf#96996 sc: fix the data pilotMichael Stahl
ScDPSaveData::GetInnermostDimension() should iterate in reverse (that fixes the reported bug), and ScDataPilotFieldObj::setOrientation() loop needs an early exit. (regression from 37856f59d2351951b95cf5eb3a5e4f0c011a8762) Change-Id: I7e0309385f3444bfd3ad21268cce4d25e60d7b05
2016-04-13Also dump registersStephan Bergmann
Change-Id: Ibff54fcbcf1bbd96a32ec48923b57eaa71a3ca1a
2016-04-13switch off 'warning treated as error' in external/nss in Win32Oliver Specht
This prevents errors from ms sdk sal_supp.h: warning '__useHeader': macro redefinition Change-Id: I122bbf6171c73d77970a549353dca67dd26d0300 Reviewed-on: https://gerrit.libreoffice.org/24055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-04-13Fix showing tooltips in RTL UI with GTK 3Khaled Hosny
Change-Id: I29c2c7988fb97e2472188a600a483e5f6ed12d80
2016-04-13tdf#99264 svx: don't pass null pointers to SfxDispatcherMichael Stahl
(regression from 51d7f466df85f679f54e4e690f8b5e602192eb7b) Change-Id: I79863f8e5767acc90dc3c6ef5e94d2d90a03dd0e
2016-04-13tdf#99165 initialize nLastX, nLastYArmin Le Grand
... even when inited in 1st loop run to avoid warning 'maybe-uninitialized' Change-Id: I67607767b8091d220efcf4c4ca70f570f955e297
2016-04-13tdf#94306 replace boost::noncopyable in sfx2 to sotJochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. Make some overloaded ctors explicit, seems cppcheck doesn't flag: T(const template<X>& rx). Change-Id: I63c5a3ac84a33ea6d49868e2d9aa281ada79958e Reviewed-on: https://gerrit.libreoffice.org/24050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13loplugin:passstuffbyref in svtoolsNoel Grandin
Change-Id: Ie166eaef65e56fafe4e57a5559b587d7558d7aa4
2016-04-13loplugin:passstuffbyref in svlNoel Grandin
Change-Id: I1434d96ae800d8e155262831472cf632d640b4c5
2016-04-13loplugin:passstuffbyref in sfx2Noel Grandin
Change-Id: I8c9d6e972f74ee04c8befda3b4cabb6e9b6b2054
2016-04-13loplugin:passstuffbyref in saxNoel Grandin
Change-Id: I95f0a17b9b8bab592a60f6b5223b4668c5355275
2016-04-13loplugin:passstuffbyref in ooxNoel Grandin
Change-Id: Iec989e9060c77dd5b010224b37633179cee4f7e9
2016-04-13loplugin:passstuffbyref in jvmaccessNoel Grandin
Change-Id: I0c5daabe31393db08654dd9f22abc757f6c67d4c
2016-04-13loplugin:passstuffbyref in formulaNoel Grandin
Change-Id: I6a46110c6d0092b21e7b3a0245ccf11ca7ccac85
2016-04-13loplugin:passstuffbyref in filterNoel Grandin
Change-Id: I68e69620d4725aac66ded11e7d316caf03098249
2016-04-13loplugin:passstuffbyref in editengNoel Grandin
Change-Id: I11deb7c73a1c160d587d74c9851ff10c875c972b
2016-04-13loplugin:passstuffbyref in drawinglayerNoel Grandin
Change-Id: I563c18c35291ced91bc29ab9162c5363ee8b19f9
2016-04-13loplugin:passstuffbyref in dbaccessNoel Grandin
Change-Id: Ice52ebbfeca45c8587fdcd0d3dea5c02c7de27e3
2016-04-13loplugin:passstuffbyref in connectivityNoel Grandin
Change-Id: I751977ecc1b532f72dd5673767471cb0a2cdbd06
2016-04-13loplugin:passstuffbyref in comphelperNoel Grandin
Change-Id: I502a0ec6627f37e17c4a9adebda58299167a8126
2016-04-13loplugin:passstuffbyref in codemakerNoel Grandin
Change-Id: Ib6a3342fdeeb7eb566e12eb599022b99c5f54b7e
2016-04-13loplugin:passstuffbyref in canvasNoel Grandin
Change-Id: Idde288ab4bb7935e5da2a84190fd4b398961d358
2016-04-13loplugin:passstuffbyref in basicNoel Grandin
Change-Id: Ie93b33502325f00ba95ab168a445a347148f9edd
2016-04-13loplugin:passstuffbyref in basegfxNoel Grandin
Change-Id: Ia7fc22152af2facf3134d9e0975cfb9608b2e931
2016-04-13update loplugin passstuffbyref to check return typesNoel Grandin
of methods like Foo getFoo() const { return m_foo; } where we can rather do const Foo& getFoo() const { return m_foo; } and let the client code decide if it wants copy Foo. Inspired by a performance problem where we were unwittingly copy constructing a large struct repeatedly just so client code could interrogate the members of the struct. When all of the changes this plugin finds are applied, I find that 'perf stat make check' shows on average a 1.7% reduction in CPU cycles. Change-Id: Ic27b4f817aa98f2a2a009f2d4e4a962cbe9c613e
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13remove dead stuff from Windows SalDataNoel Grandin
- drop mbInTimerProc field - drop mnSageStatus,mpSageEnableProc fields i.e. SAGE.DLL (System Agent) workaround, which died out with Win95/98 - convert some TRUE/FALSE constants to true/false where the field is a bool - drop maDwmLib, mpDwmIsCompositionEnabled fields Change-Id: I7b773f915dbc329eb0262bc8fee2ea7c72d25c66 Reviewed-on: https://gerrit.libreoffice.org/24047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13remove Windows95 MouseWheel supportNoel Grandin
since we no longer support Windows95 Change-Id: I6b2fe5fdb2cde3c69fc0d18bcaac25afccbffc16 Reviewed-on: https://gerrit.libreoffice.org/24049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13tdf#99165 always provide control points for beziersArmin Le Grand
Some graphic sub systems cannot handle cases where control points of bezier curves are not set and produce wrong geometry for fat line drawing when MITER or similar LineCap and/or LineJoin is used. To avoid that, provide the mathematically correct fallback control points instead. Change-Id: Iabc724e51fb89e702f858db820c920f7b5b7d302 Reviewed-on: https://gerrit.libreoffice.org/24031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-04-13Use UNO service constructorsStephan Bergmann
Change-Id: I8ac2621a4594b2d8a7cf8fdafd2191f3bf52579b
2016-04-13tdf#97087 Give comprehensible names to timersMuhammet Kara
Timers and idles should have programmer comprehensible, unique names Change-Id: I837d1890c687936f8a31278c0102391e6f87212d Reviewed-on: https://gerrit.libreoffice.org/23917 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-13Upgrade libxmlsec to 1.2.20Miklos Vajna
Obsoletes xmlsec1-update-config.guess.patch.1. Also update xmlsec1-ooxml.patch.1 as it was upstreamed at the end (with improved error checks, etc), which wasn't possible before without loads of conflicts. Change-Id: I6fee428f73f8908289d87cc262ad323ec62e65cf Reviewed-on: https://gerrit.libreoffice.org/24032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-13Related tdf#99089: avoid second crashJulien Nabet
Second bt quoted in https://cgit.freedesktop.org/libreoffice/core/commit/?id=43109b751bf5fd36318de56b2fb686acc724673f wasn't solved, try to fix it now. Change-Id: I68484f9417ff0bf747306ac8774cad5fdf84b924 Reviewed-on: https://gerrit.libreoffice.org/24042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-13Fix non-OpenCL buildsStephan Bergmann
...after ec53ac63e342d9d00e1aed4372a903630b6a191b "Move clew/clew.h into external, too" Change-Id: I33e9f839f9bcc86f009b90ed9579e61197657e1b
2016-04-13Stop assigning null to intrusive_ptrTakeshi Abe
which added at f6d61562d41b8a49449d881da66a3d8fa519487f. But they seems unnecessay because, even without them, soon the intrusive_ptr goes out of scope then its dtor decrements refcount. Change-Id: I6e35ecb7d5a0b5ccaef6ea9b7507300dcb589801 Reviewed-on: https://gerrit.libreoffice.org/24013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-04-13tdf#98395 : Remote File dialog showing wrong details in columnsSzymon Kłos
Before patch: - File type in the Size column (only first launch) After patch: - File type is not visible Change-Id: Ia2e3775f49dd9bfcc77a985812e040f70201f45c Reviewed-on: https://gerrit.libreoffice.org/22921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-28 22:40:13 +0000