summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-08-23Version 7.6.1.1, tag libreoffice-7.6.1.1libreoffice-7.6.1.1Xisco Fauli
2023-08-23bump product version to 7.6.1.1Xisco Fauli
Change-Id: I95adec4cc901a4f0b1e38c6b95885c4abfeff247
2023-08-23Branch libreoffice-7-6-1Xisco Fauli
This is 'libreoffice-7-6-1' - the stable branch for the 7.6.1 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.6.x release, please use the 'libreoffice-7-6' branch. If you want to build something cool, unstable, and risky, use master.
2023-08-23spellchecking wave doesn't extend to the full width of superscript textCaolán McNamara
or subscript, e.g. enter tmalltmalltmalltmalltmalltmalltmall in impress, format character, position, superscript, ok and without this change the wave extends only 80% of the width of the misspelt text Change-Id: I5d3ad61541152199809c950349533ca3fa7ed1c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 8ec43f37a7a5babe9227a5ca1ea84720fc2e15e5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155923 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-23tdf#155510 ODT import: ignore props of covered table cells, unless in comp modeMiklos Vajna
The problem was that the A5 cell on page 2 used to have a solid background, but this was lost after commit 1001dbaef4dec2b51c25ed8343bab6910f1219e1 (ODT import: handle style name of covered cells, 2021-03-19). Covered cell formatting was interesting for cell borders, in Word compat mode the covered cell can have its own border style, so e.g. there is left border on a vertically merged cell till its center, but not after its center. Fix the problem by limiting the import of covered cell formatting to the case when the TABLE_ROW_KEEP compat flag is on, to keep both native ODT and ODT-from-Word documents happy. If there is a need, some smarter way of merging properties could be implemented in the future. Change-Id: Icc1e6f48d9f5a0379d9a9052a1f5b9ae3f294477 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155957 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 7c15750cecea2aeb05653c0ee67b933d969b1f0b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155922 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-23tdf#156681: Revert "tdf#152048: Fix underline width for Kashida-justified text"Xisco Fauli
This reverts commit 43a5400063b17ed4ba4cbb38bdf5da4a991f60e2. The idea is to revert it in libreoffice-7-6 and libreoffice-7-5 branches only since tdf#156681 is fixed in master by 507a8745870e9a755be3a72f59c6e9a9d811fdcf "vcl: Use doubles for glyph item coordinates" This commit also reverts 34df6c92e513c5f428eff7c9cb1d6b9831eeb323 "tdf#152048: Add test" Change-Id: Id246c388df45d16b9bce86d1827949c644fc8517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155969 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-23update creditsXisco Fauli
Change-Id: I9747388a7b1514a165b2e6aad3e211139a0e4633 (cherry picked from commit 3a3060f6eb1f6d66fe230f919e560c28987135be)
2023-08-23Update git submodulesXisco Fauli
* Update translations from branch 'libreoffice-7-6' to 1fe6272f670d5fd5d7e85be25da1f77918c7bce0 - update translations for master/7.6.1 rc1 and force-fix errors using pocheck Change-Id: Ibf94fb3aaa4d0146d310c54bb99238dd767e31ad
2023-08-23tdf#156721 Crash if cursor in Basic IDE is in a macro from a document..Noel Grandin
.. and that document is closed regression from commit f3e127217d8daa443b8eda52ac4810e375cc7d63 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue May 9 15:21:20 2023 +0200 use comphelper::WeakComponentImplHelper in DocumentEventNotifier::Impl Change-Id: I5c8e68cd222ee1d66dc832700c4a39fd74223643 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155889 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit ab38a8d13de0b14b3c389ef27152aac958033401) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155921 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-23sfx2: fix crash in SfxLokHelper::notifyOtherView()Miklos Vajna
Crashreport signature: Fatal signal received: SIGSEGV code: 1 for address: 0x0 program/libmergedlo.so SfxLokHelper::notifyOtherView(SfxViewShell const*, SfxViewShell const*, int, boost::property_tree::basic_ptree<std::string, std::string, std::less<std::string> > const&) sfx2/source/view/lokhelper.cxx:473 program/libmergedlo.so ImpEditView::ShowCursor(bool, bool) editeng/source/editeng/impedit.cxx:1423 program/../program/libsclo.so ScViewData::SetEditEngine(ScSplitPos, ScEditEngineDefaulter*, vcl::Window*, short, int) sc/source/ui/view/viewdata.cxx:1635 program/libsclo.so ScTabView::UpdateEditView() sc/source/ui/view/tabview3.cxx:2190 Change-Id: I219a1e9685db9bc3ea03d6ab67ff5db74aac9343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155823 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 20f6e960cda073012a56597bf6544524240ce246) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155920 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-22tdf#137523 sw: layout: fix text below tables in footerMichael Stahl
In the footer, the text frames below a table have a very small height and are effectively invisible. This is because the JoinLock in SwLayAction::FormatLayoutTab() causes SwTabFrame::MakeAll() to return early, which is called for every cell frame in the table, and which would move the table up the page in MakePos(), by calling SwHeadFootFrame::Format(). (regression from commit cc5916cd314a27b0cc99560ab887480026630a95) Change-Id: I4add9fdd73ad3756000969af20ebf758025a0ada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155902 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 027f8328eef1e149b6c99b478ed5df870291dc2d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155915 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-22tdf#156351 sw floattable: fix missing bottom border in master tableMiklos Vajna
The problem was that the bugdoc has a split floating table, and the bottom of the table on the first page was missing its border. The borders on the second page were correct. This happens because the cell itself has no bottom border and the layout did not extra effort to mirror the top table margin at the buttom, like Word does. Fix the problem similar to commit 53798fef2cc0b5b0b9706081a4af5ceca964a41b (Related: tdf#156351 sw floattable: fix missing top border in follow table, 2023-08-18), so we add a bottom border for master tables at a layout level, similar how a top border was already added for follow tables. Given that this kind of worked already in the past (just top borders, just the 1 row case), do this unconditionally; but if needed this could be limited to the "Word table cell" case. Change-Id: Iafdcd90226fdc425be597d36ad97fb69dca5a89a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155884 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 08aea5526c75ff4c5385e960bd940f10ffa19cd5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155914 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-22tdf#129356: handle css combinator when the element name is combined...Xisco Fauli
... with the ID or the class While at it, simplify the code a bit Change-Id: I9e36f334b884d31229568835a346d4427a47c760 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155945 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 0bf0871f2dabb6c11f4976a40dcc12f6f5cb90c8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155919
2023-08-22tdf#156834: Add basic support for dominant-baseline attributeXisco Fauli
Change-Id: I005d6ca6bc340d73cae639ccd09321a0a00bc4b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155892 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 3b357ecb7bca4ab3844d1900eced55f46e6f8e1c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155913
2023-08-22tdf#156682 sw floattable: fix missing del of master anchor para por on splitMiklos Vajna
Pressing "enter" at the end of B1 in the bugdoc resulted in a split floating table, which had the anchor text duplicated (both on page 1 and page2). What happened is that the master anchor frame didn't have its paragraph portion cleared, the follow anchor frame had a correct frame offset (of 0). Fix the problem in SwTextFrame::FormatEmpty(), similar to what commit 00b9b33334791079c2dc26b1ed4c123450cabf7d (sw: call FormatEmpty() in SwTextFrame::Format() for split fly masters, 2023-02-09), did; here what we want to avoid is setting some properties on the paragraph preventing the deletion of non-last anchor paragraph portions. As a side effect, this also fixes the hang from the bugreport, after pressing "enter" 5 times at the end of B1. Change-Id: I16e6d786f02ad503a0fdff465ecf7716c1c5f8b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155732 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 1cf29168840f84c2e946e2678b99988e83503c96) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155787 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-22tdf#156728 sw: layout: invalidate fly on header/footer sizeMichael Stahl
On page 30 there are at-page anchored shapes Shape22, Shape23 and Shape25. Shape22 and Shape23 are positioned relative to the bottom of the page text area, and that is working; Shape25 is positioned with an offset to the top of the page text area, and that doesn't work. The problem is that the shapes are positioned when the header on the page hasn't been formatted yet, and once the header is formatted, the position of the Shape25 is not invalidated, so it's a header-height too far up. (regression from commit 425a252c3cc5e5a79a533965026dd4af6b8df739) Change-Id: Ic907d98b1bcd4bb544fd1af9bf93ebc7b75bf362 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155762 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit ee82accbd0d67eaf0f5a164a82b86abd00c3b0c9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155774 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-22tdf#156727 sw: layout: allow MoveBwd if previous has keep-with-nextMichael Stahl
In the pathological fdo56431-6.odt there are 16 pages of 1-line paragraphs that all have keep-with-next set, and only the first of them has a page break before. The layout temporarily uses 5 pages for the table of content at the start but then everything fits on 4 pages, so page 5 is empty. Now the first text frame on page 6 moves backward despite its keep-with-next, because it hits SwFlowFrame::SetMoveBwdJump(true) in SwFrame::GetPrevLeaf(). The next one however nopes out in SwContentFrame::WouldFit_(). This is because it continues along the sequence of keep-with-next frames until it runs out of space in the new upper; this happens with a frame that's actually on page 7. Ignore keep-with-next in case the previous frame in the new upper also has it set, because it really doesn't mean anything then. (somehow regression from commit 25a252c3cc5e5a79a533965026dd4af6b8df739) Change-Id: I0cfbc8b67bd0b95dfe08054660a2935de923a661 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155741 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 169b4d72b28b05e1a14d9b00571f7488200e39c2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155709 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-22sw: PDF/UA export: add /Placement/Block to NoteMichael Stahl
PDF 1.7 defines Note as an ILSE (inline), but that is rather odd and definitely not how footnotes work in Writer. PAC 3 complains about "Possibly inappropriate use of a "Note" structure element" and "Possibly inappropriate use of a "P" structure element" which is rather opaque but experimenting shows the warnings disappear when the Note has a /Placement/Block attribute. PDF 2.0 (ISO-32000-2:2020 Annex M) even removes the Note ILSE and introduces FENote as a BLSE to replace it. Change-Id: I46ee32c88d4be495bf79549280e2fa68d7da091c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155722 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 7712221f5340b8eb875d391967b2726e93285ab4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155701 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-22tdf#142694 sw: layout: fix infinite loop in SwFrame::PrepareMake()Michael Stahl
The problem is that SwFrame::FindNext_() returns itself, because it's a table frame 401 and its last cell is empty. There was a nested table in the cell, but during an attempt to split the outer table 401, the inner table moved backwards. This is due to code that was added in commit c9c956f2716c58e2573a9ac07073f712d736ed02, which only checks that the height of the table frame is 0, but in this case the inner table does contain a text frame which has never been formatted yet, but still the table frame's size and print area was set to valid. Unfortunately adding an obvious !ContainsContent() check to the condition breaks uiwriter4 testTdf114306_2, the last table is not on page 4 but on page 5, for no good reason. So just fix SwFrame::FindNext_(), it should never return "this" anyway. (somehow regression from commit 53a0a86df6eb5fc64a85ecd03f2e354fd4d8e213) Change-Id: If043a53c32f175fc560d422c4a4e16d8e8c6ef49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155563 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit fcf6f5550cc7949e94dc74cbcd10a700a225e574) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155608 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-22Fix heap-use-after-freeTibor Nagy
The issue is caused by commit Ic87983fa6e3279a64841babc565fbe97710ff730 (tdf#99808 sc: fix background of conditional formatting in merged cell) Change-Id: Ic72ba16c2649537dc3b486e07c12e2486cdf1957 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155328 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 694bacca057c9f1d93ab27d61199aec9d060b868) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155299 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-22ScriptForge - fix tdf#156836 Abort on MoveFirst()Jean-Pierre Ledure
The incident occurs when a move (last(), first(), next()) within the form's resultset is done from a Basic script immediately after the opening of the document containing the form. The insertion of a Wait 1 statement prevents the occurrence of the incident by interrupting very shortly the Basic process. Change-Id: I5e798db6e3f9ffaeeef38fb9badd008cbb190d1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155897 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins (cherry picked from commit f1412705bed9faad3d9a4e36e7dcea9eb3cb98d0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155912
2023-08-22tdf#156534 Add Firebird's DATEADD function to SQL parserjucasaca
Add DATEADD function to SQL parser, so the function can be used in Query's Design and can produce editable queries Change-Id: I14f9d88f6a96021b0f9199fd79df18c8f4bb5ea3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155071 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit ccf30787a701860d19941a1d36ad3d1db2fb2e06) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155786 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-22related tdf#156683 a11y: Dispose FrameSelectorImpl a11y childrenMichael Weghorn
Don't just invalidate, but also dispose the a11y children in `FrameSelectorImpl::~FrameSelectorImpl`. This fixes a crash on exit that's reproducible with the gtk3 VCL plugin e.g. like this (maybe some steps aren't even needed): 1) start LO Writer with the gtk3 VCL plugin 2) right-click, select "Character" > "Character" in context menu 3) switch to "Font Effects" tab 4) press space key with focus in the font color combobox to open the popup 5) use Tab key to get to the view of colors 6) move around with arrow keys a bit 7) close the dialog and Writer Reverse-continuing to `atk_object_wrapper_dispose` (frame #10 in the below backtrace) in rr showed the involved a11y object: uno::Reference to (svx::a11y::AccFrameSelectorChild *) 0x5557832b9150 Backtrace (somewhat similar to the one in tdf#156683): #0 0x00007ffff6b15cd6 in comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::disposeAndClear(std::unique_lock<std::mutex>&, com::sun::star::lang::EventObject const&) (this=0x7fffffffca88, rGuard=..., rEvt=...) at .../include/comphelper/interfacecontainer4.hxx:397 #1 0x00007ffff6b13c6f in comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing(unsigned int, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) (_nClient=1058, _rxEventSource=uno::Reference to (svx::a11y::AccFrameSelectorChild *) 0x55555cecfdf0) at .../comphelper/source/misc/accessibleeventnotifier.cxx:204 #2 0x00007ffff6b1028a in comphelper::OCommonAccessibleComponent::disposing() (this=0x55555cecfdf0) at .../comphelper/source/misc/accessiblecomponenthelper.cxx:61 #3 0x00007ffff6674aeb in cppu::WeakComponentImplHelperBase::dispose() (this=0x55555cecfdf0) at .../cppuhelper/source/implbase.cxx:104 #4 0x00007ffff2ddf0e0 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext2, com::sun::star::accessibility::XAccessibleEventBroadcaster>::dispose() (this=0x55555cecfdf0) at .../include/cppuhelper/compbase.hxx:90 #5 0x00007ffff6674834 in cppu::WeakComponentImplHelperBase::release() (this=0x55555cecfdf0) at .../cppuhelper/source/implbase.cxx:79 #6 0x00007ffff2ddf642 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext2, com::sun::star::accessibility::XAccessibleEventBroadcaster>::release() (this=0x55555cecfdf0) at .../include/cppuhelper/compbase.hxx:86 #7 0x00007ffff2ddf378 in cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent, com::sun::star::accessibility::XAccessibleComponent>::release() (this=0x55555cecfdf0) at .../include/cppuhelper/implbase.hxx:171 #8 0x00007ffff2ddf0a0 in cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper, com::sun::star::accessibility::XAccessible>::release() (this=0x55555cecfdf0) at .../include/cppuhelper/implbase.hxx:171 #9 0x00007fffe3f29535 in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>::clear() (this=0x55555d40a010) at .../include/com/sun/star/uno/Reference.hxx:231 #10 0x00007fffe3f288de in atk_object_wrapper_dispose(AtkObjectWrapper*) (wrapper=0x55555d409fa0) at .../vcl/unx/gtk3/a11y/atkwrapper.cxx:1078 #11 0x00007fffe3f27527 in atk_object_wrapper_finalize(GObject*) (obj=0x55555d409fa0) at .../vcl/unx/gtk3/a11y/atkwrapper.cxx:674 #12 0x00007ffff138c48c in g_object_unref () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0 #13 0x00007fffe3f003f7 in AtkListener::~AtkListener() (this=0x55555ce6ecb0, __in_chrg=<optimized out>) at .../vcl/unx/gtk3/a11y/atklistener.cxx:57 #14 0x00007fffe3f0042e in AtkListener::~AtkListener() (this=0x55555ce6ecb0, __in_chrg=<optimized out>) at .../vcl/unx/gtk3/a11y/atklistener.cxx:58 #15 0x00007ffff6756838 in cppu::OWeakObject::release() (this=0x55555ce6ecb0) at .../cppuhelper/source/weak.cxx:230 #16 0x00007fffe3f0a7de in cppu::WeakImplHelper<com::sun::star::accessibility::XAccessibleEventListener>::release() (this=0x55555ce6ecb0) at .../include/cppuhelper/implbase.hxx:115 #17 0x00007ffff6b21b99 in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>::~Reference() (this=0x55555d40a0c0, __in_chrg=<optimized out>) at .../include/com/sun/star/uno/Reference.hxx:114 #18 0x00007ffff6b217a9 in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*) (__pointer=0x55555d40a0c0) at /usr/include/c++/13/bits/stl_construct.h:151 #19 0x00007ffff6b20bcf in std::_Destroy_aux<false>::__destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*>(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*) (__first=0x55555d40a0c0, __last=0x55555d40a0c8) at /usr/include/c++/13/bits/stl_construct.h:163 #20 0x00007ffff6b1f105 in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*>(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*) (__first=0x55555d40a0c0, __last=0x55555d40a0c8) at /usr/include/c++/13/bits/stl_construct.h:196 #21 0x00007ffff6b197aa in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >&) (__last=0x55555d40a0c8, __first=0x55555d40a0c0) at /usr/include/c++/13/bits/alloc_traits.h:947 #22 std::__cxx1998::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >::~vector() (this=0x55555cf22af8, __in_chrg=<optimized out>) at /usr/include/c++/13/bits/stl_vector.h:732 #23 0x00007ffff6b17402 in std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >::~vector() (this=0x55555cf22ae0, __in_chrg=<optimized out>) at /usr/include/c++/13/debug/vector:230 #24 0x00007ffff6b1742a in o3tl::cow_wrapper<std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >, o3tl::ThreadSafeRefCountingPolicy>::impl_t::~impl_t() (this=0x55555cf22ae0, __in_chrg=<optimized out>) at .../include/o3tl/cow_wrapper.hxx:176 #25 0x00007ffff6b17485 in o3tl::cow_wrapper<std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >, o3tl::ThreadSafeRefCountingPolicy>::release() (this=0x55555d40a0b0) at .../include/o3tl/cow_wrapper.hxx:207 #26 0x00007ffff6b15700 in o3tl::cow_wrapper<std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >, o3tl::ThreadSafeRefCountingPolicy>::~cow_wrapper() (this=0x55555d40a0b0, __in_chrg=<optimized out>) at .../include/o3tl/cow_wrapper.hxx:271 #27 0x00007ffff6b145b4 in comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::~OInterfaceContainerHelper4() (this=0x55555d40a0b0, __in_chrg=<optimized out>) at .../include/comphelper/interfacecontainer4.hxx:126 #28 0x00007ffff6b206c6 in std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >::~pair() (this=0x55555d40a0a8, __in_chrg=<optimized out>) at /usr/include/c++/13/bits/stl_pair.h:187 #29 0x00007ffff6b1aac4 in std::__new_allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> >::destroy<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > >(std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >*) (__p=0x55555d40a0a8, this=0x7ffff6f64988 <(anonymous namespace)::gaClients+40>) at /usr/include/c++/13/bits/new_allocator.h:194 #30 std::allocator_traits<std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> > >::destroy<std::pair<unsigned i--Type <RET> for more, q to quit, c to continue without paging-- nt const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > >(std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> >&, std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >*) (__p=0x55555d40a0a8, __a=...) at /usr/include/c++/13/bits/alloc_traits.h:557 #31 std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> > >::_M_deallocate_node(std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false>*) (this=0x7ffff6f64988 <(anonymous namespace)::gaClients+40>, __n=0x55555d40a0a0) at /usr/include/c++/13/bits/hashtable_policy.h:2020 #32 0x00007ffff6b188b7 in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> > >::_M_deallocate_nodes(std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false>*) (this=0x7ffff6f64988 <(anonymous namespace)::gaClients+40>, __n=0x55555d409ef0) at /usr/include/c++/13/bits/hashtable_policy.h:2042 #33 0x00007ffff6b164e6 in std::_Hashtable<unsigned int, std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > >, std::__detail::_Select1st, std::equal_to<unsigned int>, std::hash<unsigned int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::clear() (this=0x7ffff6f64988 <(anonymous namespace)::gaClients+40>) at /usr/include/c++/13/bits/hashtable.h:2509 #34 0x00007ffff6b187cc in std::__cxx1998::unordered_map<unsigned int, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > > >::clear() (this=0x7ffff6f64988 <(anonymous namespace)::gaClients+40>) at /usr/include/c++/13/bits/unordered_map.h:798 #35 0x00007ffff6b164a0 in std::__debug::unordered_map<unsigned int, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > > >::clear() (this=0x7ffff6f64960 <(anonymous namespace)::gaClients>) at /usr/include/c++/13/debug/unordered_map:234 #36 0x00007ffff6b14151 in comphelper::AccessibleEventNotifier::shutdown() () at .../comphelper/source/misc/accessibleeventnotifier.cxx:268 #37 0x00007fffee53fa20 in DeInitVCL() () at .../vcl/source/app/svmain.cxx:594 #38 0x00007fffee53e227 in ImplSVMain() () at .../vcl/source/app/svmain.cxx:229 #39 0x00007fffee53e283 in SVMain() () at .../vcl/source/app/svmain.cxx:236 #40 0x00007ffff7a9f51d in soffice_main() () at .../desktop/source/app/sofficemain.cxx:94 #41 0x00005555555549d4 in sal_main () at .../desktop/source/app/main.c:51 #42 0x00005555555549ba in main (argc=2, argv=0x7fffffffd8e8) at .../desktop/source/app/main.c:49 Change-Id: I22c665f3c41624f4916b956ea266ff1d39fbe507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155848 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 79cc574270582d03408286544d99227881f13bb8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155781 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-22Related: tdf#156351 sw floattable: fix missing top border in follow tableMiklos Vajna
The problem was that in case a table has a table border but no cell border, then the follow table was missing a top border in case the follow table had multiple rows. This was already working for single-row follow tables since commit a4da71fb824f2d4ecc7c01f4deb2865ba52f5f4c (INTEGRATION: CWS fmebugs04 (1.115.46); FILE MERGED 2008/05/13 13:56:19 fme 1.115.46.2: #i9860# Top border for tables - correction 2008/05/13 13:49:23 fme 1.115.46.1: i#9860 Top border for tables, 2008-06-06). Fix the problem by checking for the case when the first row in a follow table has no own bottom border and then take that bottom border from the last row instead, if that has a bottom border. The reported case around the missing bottom border in the master table still needs work. Change-Id: Ib418da99067a42efcf3bd0e2d6a9467797de619a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155824 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 53798fef2cc0b5b0b9706081a4af5ceca964a41b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155788 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-21tdf#156837: check baseline-shift from parent tooXisco Fauli
Change-Id: I6e62d794dd4410447db3bee26c1e18fe9dad6a9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155895 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 56a360328790eb009efed6fce94a795f6fe0a7d2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155911
2023-08-21tdf#144073 and tdf#147645: use bounds and angle for gradientPatrick Luby
Passing an expanded, rotated polygon noticeably modifies the drawing of the gradient in a slideshow due to moving of the starting and ending colors far off the edges of the drawing surface. So try another way and set the angle of the gradient and draw only the unadjusted bounds. Change-Id: I95441dfa3215396d5bc7edfa9f985335480b37de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155729 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit 9e0249b62afeca701dec27a4371f20829775422a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155705 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-08-21tdf#156419 sw: layout: don't prevent moving between linked flysMichael Stahl
... when there is a page break on the next page. Of course you can put a section into a fly, and then link multiple flys. (regression from commit 325fe7ab507fd8f2ca17a3db32181edf30169525) Change-Id: I5cb854fc7ee5caa2af4e04f4da2d8a8083c0d007 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155842 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 987fe1175de2db53235cc6f2441335fcc3548d64) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155779 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-21tdf#156725 sw: layout: don't prevent moving between columns ...Michael Stahl
... on the same page when there is a page break on the next page. The existing, presumably pointless/always-false in case of same page, check of WrongPageDesc() let me assume that this would only be reached if the current page and the target page are different, but that was a mistake. (regression from commit 325fe7ab507fd8f2ca17a3db32181edf30169525) Change-Id: I4df53b77bed006095c34976011aa0cd5e12879e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155809 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit db83c41d460103df5d80f5bd99816575c4ead5cd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155775 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-21ofz: Use-of-uninitialized-valueCaolán McNamara
same as seen at: https://gitlab.com/libtiff/libtiff/-/issues/582 Change-Id: Ifc4eaaa47ad392968db814783281f1db76564d9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155784 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-21tdf#156724 tdf#156722 sw: layout: remove IsPaintLocked() checkMichael Stahl
Get rid of the problematic IsPaintLocked() and only check for a column parent; effectively this prevents formatting frames in columns even when loaded from the UI, so the layout will hopefully be the same regardless of how it is invoked. Change-Id: Ib4cc2efdb68ef4db73dcad01c7e1bd4be35de071 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155673 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 61a78a523a6131ff98b5d846368e5626fe58d99c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155694 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-21tdf#156724 tdf#156722 tdf#156745 sw: layout: partially remove IsPaintLocked()Michael Stahl
Having the layout algorithm dependend on IsPaintLocked() is very problematic; it is typically set when the layout is invoked from SwViewShell code, as happens several times when loading a document in response to window resize events etc., but not for idle formatting or from SwXTextDocument::getRendererCount(), hence these bugs only reproduce with soffice --convert-to pdf, not via UI. For tdf#156724 the problem is that the table is split, during formatting of the split row a new footnote is created on page 1, and this reduces the space, so splitting fails and is never attempted again. When the document is loaded from UI, when the table is split the footnote already exists and so splitting succeeds; it was created by a call from SwLayAction::FormatLayout() of the cell frame. It turns out that when the condition is removed completely, testUXTSOREL will take 5 minutes instead of 5 seconds, which seems excessive; the problem there appears to be that a text frame in a columned section moves forward and backward; plausibly columned section content should be formatted by ::CalcContent() only. (reportedly regression from commit c605283ad6785dea762feab5fdffd9d27e75c292 and commit 7e8b4756d95057f069467b34e7849f9354856578) Change-Id: I9ed73588efeec654a769eee8aa825186bd51e059 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155672 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit dc5991ccc8f7d8e86c1e04be9095dda5c08b4763) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155691 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-21sw floattable: handle AllowOverlap==false in the DOC filterMiklos Vajna
Map sprmTFNoAllowOverlap to SwFormatWrapInfluenceOnObjPos::mbAllowOverlap on import, and do the opposite on export. Change-Id: Id61be49adb39862e30ffb2da9ff9aabae11f7d83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155650 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155714
2023-08-21sw floattable: handle AllowOverlap==false in the RTF filterMiklos Vajna
Map \tabsnoovrlp to SwFormatWrapInfluenceOnObjPos::mbAllowOverlap on import and do the opposite on export. Change-Id: I3d786041648d62e80f2ea9e3d726426e01a8d192 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155687 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 68c8466dd80e7a964e1377ee3e0308dc449fbf2d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155698 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-21tdf#151134 Always write inset properties when exporting placeholder shapesSamuel Mehrbrodt
The default value works for text boxes, but not for these special presentation placeholder objects - here the values need to be written explicitly. Change-Id: Id606bd5e6b63dee2fd3b385435ce13ecec63b5f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155838 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 1524a1915d79c4fc598311114eaea87cde9be9aa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155780 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-19tdf#86938: fix calculation of baseline-shiftXisco Fauli
Change-Id: I8c30c29052f2ea1fe6e49360b972af868851131b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155671 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155725
2023-08-18tdf#117920: Revert "related tdf#156579: just break for switch element"Xisco Fauli
This reverts commit e222f60ac2a71032dbdf62d7c7e28978b5a0b19c. To make the switch element behave like a group as least, so the transform attribute is parsed Change-Id: Id8c21ac6da217d8f7bc350ff41022335bf1e0f1f Change-Id: If1e53f9baad8995f26f9b885cfef6265040736bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155770 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-18tdf#156783 sw tracked table column: fix crash setting borderLászló Németh
or border padding without correct table cursor. Table formatting is allowed on text selections starting with tables, but adding border or border padding resulted crashing. This regression became more visible with hidden deleted table columns, where SelectTable (e.g. Ctrl-A) doesn't select the whole table, but only the text content of the visible cells, and in the case of hidden right table columns, without table cursor. Manual test: insert two tables in the document, and in the first cell of the first table, select the whole document by pressing Ctrl-A 2 times or more. In table settings, enable table border or modify padding to crash LibreOffice. Regression since version 7.5. Change-Id: If8ebb52c7662ff37ac42348c8f412549b793b6d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155749 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 3a2d3926bbaf6907a50b595d867d7e36cc4ffeaa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155773
2023-08-17tdf#156594 - A11Y - add fix button for "Avoid background images."Balazs Varga
- add fix button for "Avoid background images." - add .uno:PageAreaDialog command to navigate page style-->Area tab Change-Id: Ibad4e8896d05e72713189a0042c3f156a0733171 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155464 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins (cherry picked from commit 0ec629fe50220cb216c26c5ab93c194b9d987058) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155484 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-08-17tdf#156741 - A11Y - fix drawing shape is not highlighted by clickingBalazs Varga
"Avoid floating text" warning. If GotoFly not select the textframe object try GotoDrawingObject. Change-Id: Ica7829dd0cc21f3f1fb344dfb21afdfb43783cef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155676 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> (cherry picked from commit 54c158ff35ab5a0b5fa538562755638e052d51f2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155699 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-08-17tdf#153012: import chart's c:clrMapOvr elementMike Kaganski
Otherwise, a wrong mapping could be used, e.g. from slide. Change-Id: I8b0fcebcd21ac2bab8b7f58d0c24753d2eca02c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155748 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 953e586dbce1c3195ecb07b2491b6e1a20a2cd7f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155708 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-17tdf#156777: check for css style in textpathXisco Fauli
Change-Id: I63a274dd9fba37852412a194a490cb2b7634f1cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155726 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 20f57e14362674d321ef184e1987f41a6418adc2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155702 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-16tdf#156782 sw tracked table column: fix missing right table borderLászló Németh
Last visible column of a table followed with hidden deleted columns hid also the right border of the table, if the inner vertical column borders drawn only by left-only borders (like in the default table style). See also commit f9898fa64bd2a575be94c309b43373de53c5331b "tdf#150308 sw: fix missing top table border after hidden table rows" Note: layout testing doesn't work, because of the missing calculation with the width of the enabled border of the row frame. Also there is a problem with metafile testing (empty meta file?). Change-Id: I5e98c6751d889f8d5a3f7f2b0b31e44149742e25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155669 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit f7189c63b297b8756f02be65a7050609599651af) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155704 Tested-by: Jenkins
2023-08-16Resolves: tdf#127334 Backport tools::Duration ScInterpreter::CalculateAddSub()Eike Rathke
All tools::Duration implementation for completeness. This is a combination of 5 (+2 typo) commits. Introduce tools::Duration(sal_Int32 nDays, const Time& rTime) ctor xChange-Id: If002e04536149b49b2249103ac914d17dec3fae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153409 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 986c2d86a7b53a6599d014db7327f47cb33d4fea) Introduce tools::Duration individual time values ctor xChange-Id: I516d3727cbcf6667b32dc963febbf4b753ef6a91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153497 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit c968d8989004301b49d67a093a6eb8a629533837) Clamp and assert maximum hours value in Time::init() xChange-Id: Ia777222f3c797b90663b55499a57025e410b1d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153407 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit b07d72c6c1075efa6b64c67758566426c22c5225) Use tools::Duration in ScInterpreter::CalculateAddSub() ... for all (date+)time inflicted operands. xChange-Id: I93043d912867e2ef7d4af271b5c4566a3ffb4ef9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153291 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 174a72f3fd50d1146d6bedd4cc2a1971aa33be67) Resolves: tdf#127334 Increase tools::Duration accuracy epsilon unsharpness ... when converting from double, i.e. to 300 nanoseconds. Empirically determined.. xChange-Id: I92c43b5f244923363af5d44bece9c155126ca343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155324 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 46e672db8002e7aaac881bee65b5c50c4e14c666) Change-Id: I92c43b5f244923363af5d44bece9c155126ca343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155427 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-08-16tdf#156557 Sidebar: Make Shift+Tab kb navigation behave as expectedJim Raykowski
This patch makes Shift+Tab change keyboard focus to the last panel control of the previous panel when focus is currently on a panel title. It also makes Shift+Tab change keyboard focus to the Tabbar hamburger menu when focus is currently on the "Close Sidebar Deck" button. Change-Id: I3ff849655afc4f01dba2268055292eee573adf43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155333 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit e2db54b9bf48b79802154d5fc9460fc432ea69a0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155396 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-08-16update creditsXisco Fauli
Change-Id: Ife0d509b91f17510e6a32494e6456fe7043781ec
2023-08-16tdf#156670 - A11Y - Open the Format->Description dialog with the fix buttonBalazs Varga
The Fix button will open the Format->Description dialog in case of shapes, textBox, graphic, OLE objects. (Remove Description text from (AccessibilityTests1.odt) the shape for proper testing of no_alt_text.) Change-Id: I6678fa44a0a47bab60558f770cc709012f02d83b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155653 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit e027ef6c0534b7ce50dc5f8b74e27ce85b9eb97b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155696 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-16Simplify and improve conversionMike Kaganski
Using o3tl::convert makes sure that rounding is correct, which shows in the improved unit test, that now doesn't need different values before and after roundtrip. Change-Id: If46e27300bc199e89c0abf0ea4d0cd825024aeb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155728 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit d2c7cbc7d724d608f6d37bbb0233ad2b39eb938e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155703 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-16tdf#153008: srcRect may have some members negativeMike Kaganski
The overly strict check (implying that all members must be non-negative, to perform the crop) excluded valid cases where some of the members were negative, and some positive. Change-Id: I629689bdccedf9e37632a9fe14654778c0f14a6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155717 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 6c06c8a2be3d8cbbcb8ab1aaaeb04db95114dfcb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155700 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-16tdf#93583: use getTextWidth to calculate line's widthXisco Fauli
Since every character in the line might use different styles Change-Id: I2ce079d4308f4acde42a8366838749a7c20331b4 Change-Id: I01f51f157caa667cebc8860ae37d4458fac2d511 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155666 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155724 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-16Update git submodulesXisco Fauli
* Update translations from branch 'libreoffice-7-6' to 7ed7b5db0b4937a15cf07967fe59e6aeef5ab3e5 - update translations for master/7.6.1 rc1 and force-fix errors using pocheck Change-Id: Ie4e0754d95811399ba74227f3387d7930a640cb1