summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-26crashtesting: infinite recurse with moz609361-1.svgCaolán McNamara
Change-Id: I18c2dd159dd7a64c3627abdb472d65013453b1b9 Reviewed-on: https://gerrit.libreoffice.org/57892 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-26tdf#118816 recover initial intent of enabled possibility of tristate as a flagCaolán McNamara
Change-Id: I0150b96e063818cc20e2404081b906ccc5ff0be6 Reviewed-on: https://gerrit.libreoffice.org/57712 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9f01dca60e6539f48cd529180f0d64c2131e0ea1) Reviewed-on: https://gerrit.libreoffice.org/57713 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-26Allow the comphelper threadpool to be reset after construction.Michael Meeks
Otherwise some pre-init components can start it, and threads get stranded in the forkit process causing grief. Change-Id: Ib1846f8b329b4c6b84645999dafba1252c5129c7 Reviewed-on: https://gerrit.libreoffice.org/57635 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-26tdf#98074, using the same builtinId maps the styles to the same oneMarkus Mohrhard
Additionally, using customBuiltin for all styles is a bad idea as well. Change-Id: I788a3c5b9164f79aa65ded2fc3e6a556e44ee0a8 Reviewed-on: https://gerrit.libreoffice.org/57807 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit fa881095bc62c3646406c82a98d8503377288a54) Reviewed-on: https://gerrit.libreoffice.org/57813 Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-26valgrind: use of unit value exporting tdf107162-1.ots to xlsCaolán McNamara
Conditional jump or move depends on uninitialised value(s) at 0x4554B657: SetApiUnderline (xlstyle.cxx:487) by 0x4554B657: (anonymous namespace)::lclSetApiFontSettings(XclFontData&, rtl::OUString const&, float, float, com::sun::star::awt::FontSlant, short, short) (xlstyle.cxx:583) by 0x4554C096: XclFontPropSetHelper::ReadFontProperties(XclFontData&, ScfPropertySet const&, XclFontPropSetType, short) (xlstyle.cxx:679) by 0x4546D8BE: XclExpTbxControlObj::XclExpTbxControlObj(XclExpObjectManager&, com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, tools::Rectangle const*) (xeescher.cxx:753) by 0x45593D99: XclEscherEx::CreateTBXCtrlObj(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, tools::Rectangle const*) (xcl97esc.cxx:441) by 0x45594E85: XclEscherEx::StartShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, tools::Rectangle const*) (xcl97esc.cxx:254) by 0x44E4FFBC: ImplEESdrWriter::ImplWriteShape(ImplEESdrObject&, EscherSolverContainer&, bool) (eschesdo.cxx:164) by 0x44E510C3: ImplEESdrWriter::ImplWriteShape(ImplEESdrObject&, EscherSolverContainer&, bool) (eschesdo.cxx:215) by 0x44E5452B: ImplEESdrWriter::ImplWritePage(EscherSolverContainer&) (eschesdo.cxx:848) by 0x44E54D27: ImplWriteCurrentPage (eschesdo.cxx:932) by 0x44E54D27: EscherEx::AddSdrPage(SdrPage const&) (eschesdo.cxx:945) by 0x454696BC: XclExpObjectManager::ProcessDrawing(SdrPage const*) (xeescher.cxx:1523) by 0x45407A35: ExcTable::FillAsTableBinary(short) (excdoc.cxx:518) by 0x454088B8: ExcDocument::ReadDoc() (excdoc.cxx:767) Change-Id: Ibefe8ea808bfbd9dfc8e773b4c13936387633507 Reviewed-on: https://gerrit.libreoffice.org/57905 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-26Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann
(cherry picked from commit 5c016d6ae4e59629cfd0b80c631f67cf46e42d3e) Conflicts: solenv/flatpak-manifest.in Change-Id: I7799abe1a6fc9cf79a751d76360ea7ad2face133 Reviewed-on: https://gerrit.libreoffice.org/57982 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-26crashtesting: infinite recurse with moz384637-1.svgCaolán McNamara
Change-Id: Ia4bbc9d471c63812dc3ef490f32e8490bda72bfe Reviewed-on: https://gerrit.libreoffice.org/57889 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-26Resolves: tdf#118862 new instances cannot be editedCaolán McNamara
Change-Id: I9b10ff4f043949c7140852ac9ad9106ca611c98c Reviewed-on: https://gerrit.libreoffice.org/57961 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-26ofz#9431 don't check attribs of Invalid columnCaolán McNamara
Change-Id: I9c5adcadfa2a8593ff90622449d6bdfa4810f2c0 Reviewed-on: https://gerrit.libreoffice.org/57916 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-26Resolves: tdf#118919 crash on double click ole objectCaolán McNamara
Change-Id: Id7b3df447db56f6f80d6255dabdcc7f6ab149e95 Reviewed-on: https://gerrit.libreoffice.org/57954 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-26forcepoint#53 restrict to expected index rangeCaolán McNamara
Change-Id: I22f01e5a3e3cf51b014ac841cd14071dce5baf0f Reviewed-on: https://gerrit.libreoffice.org/57921 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-25tdf#118777 cui: use right XText in SignatureLineDialogMichael Stahl
Writer has multiple nested XText and we have to call insertTextContent on the one that corresponds to the xCursor, so use the convenient getText() instead of hard-coding the body text. Change-Id: I86bce48e97730917aa8c4b093bb74c03e3f0dd36 Reviewed-on: https://gerrit.libreoffice.org/57969 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 7213a583f5c1d42c05dc4f19b4d4d2f9dded7733) Reviewed-on: https://gerrit.libreoffice.org/57978 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-25tdf#118777: Disable signature line slot if non-text objectKatarina Behrens
in 6.1 only in sw, the functionality ain't there yet in sc Change-Id: I54f7ec336026013d09ac6262779e7fcbd17c2084 Reviewed-on: https://gerrit.libreoffice.org/57949 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-on: https://gerrit.libreoffice.org/57990 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-25tdf#118528 sw layout: only direct formatting for EmulateTableKeepJustin Luth
Emulating MSWord's way of keeping a table with the next paragraph has caused a few complaints, but never anything that seemed to clearly indicate a real problem - usually just badly designed documents. But a common theme has been the keep attribute coming through styles. Since our export-emulation writes directly to the paragraph properties, lets make the emulation dependent on direct formatting to avoid some of these complaints. Change-Id: I008fc7b6a7083292463c20972ad209761ec97601 Reviewed-on: https://gerrit.libreoffice.org/57613 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit ef86b2e7a08ea25c434db85087d094f030f762cc) Reviewed-on: https://gerrit.libreoffice.org/57697 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-25tdf#63561 docx export: "clear" unused inherited tabsJustin Luth
If a style contains tab definitions, then the paragraph inherits these. They are added to any tabs defined at the paragraph level. Unwanted inherited tabs must be explicitly removed. (TODO: LO ought to be inheriting from ALL parents, so the same logic ought to apply to a style's parent tabs, but currently LO does not import that way. So the proof unit test looks different in MSO compared to LO.) Change-Id: Ida8ed2792482655d512c753fdff8d02062d895a8 Reviewed-on: https://gerrit.libreoffice.org/57255 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 859a0389b5639397e9c46cd4828a35793bd194f8) Reviewed-on: https://gerrit.libreoffice.org/57267 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-24sw,sc: Signature Line: fix VclPtr assertionMichael Stahl
Insert a Signature Line, right click, Sign..., Cancel include/vcl/vclptr.hxx:116: VclPtr<T>::~VclPtr() [with reference_type = AbstractSignSignatureLineDialog]: Assertion `(!m_rInnerRef.get() || m_rInnerRef->isDisposed() || m_rInnerRef->getRefCount() > 1) && "someone forgot to call dispose()"' failed. Reviewed-on: https://gerrit.libreoffice.org/57913 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 6de194cb685dbe105a73812afa73070d04341bfb) (The sc part is missing in libreoffice-6-1 so only fix sw) Change-Id: I09a1b37b917b267a84ee95fb375658974ee1b320 Reviewed-on: https://gerrit.libreoffice.org/57924 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24tdf#81943 sw RTF import: fix missing wrap in background for in-table shapeMiklos Vajna
Regression from commit 015fd55c94b7b650ed8e572cafaf3b0f903b01b9 (tdf#96275 RTF import: fix anchor of shapes inside tables, 2016-05-10), remember more context when delaying the import of a shape. (cherry picked from commit 0c91f8f839d36c8b5af272b1d3c835d2f4af6b65) Conflicts: writerfilter/source/rtftok/rtfdocumentimpl.cxx Change-Id: Idc02868eb3fe5b7637c9fd00c841bf71423adf2b Reviewed-on: https://gerrit.libreoffice.org/57555 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24tdf#118517: Use xStg before resetting itXisco Fauli
Regression from 0f166ef5240ee155bf2544e6bc3c985b1e3bf646 Change-Id: I083951700895a00be8d4407871c27804ca3e5f30 Reviewed-on: https://gerrit.libreoffice.org/57881 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a61d61f66f80c91c14825f8fe8fb9bd3f295591b) Reviewed-on: https://gerrit.libreoffice.org/57906 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-07-24tdf#118716 Inner border of an embedded table can't be dragged aroundNoel Grandin
regression from commit f14b9d30293f180500fc56d81e5390021758e7c1 convert (a>b?a:b) to std::max(a,b) In this code int a; std::max<sal_uInt16>(a,0) std::max will first convert a and b to sal_uInt16, therefore potentially converting a negative number to a positive number due to the conversion rules. Then it will take the larger number. While this code int a; static_cast<sal_uInt16>(a > 0 ? a : 0) will compare first, and then convert the larger number to sal_uInt16, which might result in making a "a" that is larger than 2^16 into a smaller value, but which will never convert a negative "a" value into a positive value. Change-Id: Id4f6df0089b1a74ea4ac1c5d05655e7c1d8f0c7f Reviewed-on: https://gerrit.libreoffice.org/57846 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit c13865a4caf7898c4e59a5b22bbd493d6dad9661) Reviewed-on: https://gerrit.libreoffice.org/57908 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-07-24forcepoint#51 anchor location deleted before graphic anchor processedCaolán McNamara
try deferring to after anchor stack is cleared Change-Id: Iaa42d19635968d1656e171a7e0c5e473879cd8f3 Reviewed-on: https://gerrit.libreoffice.org/57776 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-23ofz#9507 wrong start point for Johab block 59Caolán McNamara
Change-Id: I011f4cbb10324c4a7d4e1be3ab1355291f79730b Reviewed-on: https://gerrit.libreoffice.org/57840 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-23fix shutdown crash when SfxApplication has already been destroyedMarkus Mohrhard
See e.g. http://crashreport.libreoffice.org/stats/crash_details/dc1ae6ff-923e-44f6-99a9-84893039efd7 Change-Id: I3b5a24bfb62977ca922bf3bececb6676691bf6ea Reviewed-on: https://gerrit.libreoffice.org/57789 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 715fcaff01ed048c52c69264a7a0fb773dd57b32) Reviewed-on: https://gerrit.libreoffice.org/57808 Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-21tdf#118150 Fix displaying of chart where Legend is set manuallyBartosz Kosiorek
By default Legend's position is automatic and it is located at the right side of the chart. Unfortunately even if layout with manualLayout is set: http://www.datypic.com/sc/ooxml/e-draw-chart_manualLayout-1.html the empty space for the automatic legend on the right side of the chart, was left. This is issue with opening of the OOXML charts by LibreOffice, as MS Word is opening the same document properly. This patch fixes issue with wrong chart displaying, when manual position of the legend is set. Change-Id: Id5363d48b049c469b6761b43cecfbb56514bf7d8 Reviewed-on: https://gerrit.libreoffice.org/57787 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins
2018-07-20tdf#104797 DOCX change tracking: handle moveFrom and moveToLászló Németh
data as deletion and insertion instead of importing them as normal (unmodified) texts (messing up document content and losing change tracking information). Change-Id: I9c0a7da83f3e8235d65d47afdb99ffe188f52704 Reviewed-on: https://gerrit.libreoffice.org/57723 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> Reviewed-on: https://gerrit.libreoffice.org/57729 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-20tdf#118304 reselect current glyph on changing fontCaolán McNamara
preview glyph will rerender the glyph if its there, or the glyph description changes to "missing glyph" if its not there anymore. Don't auto select first entry of the subset when font changes, leave it as unselected and let the glyph determine what's ends up there Change-Id: I33d7dd3a071100175ac9bc7c7e9d44684a1aff28 Reviewed-on: https://gerrit.libreoffice.org/57724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e8bf2cb72dbe55f4e9ac7ace48e644a934cfc503) Reviewed-on: https://gerrit.libreoffice.org/57764 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-07-19Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-1' - newlines at end of string must match what is in msgid Change-Id: I1e3ab006b238e11412f3d281fc1e9ac63169801b
2018-07-19bump product version to 6.1.1.0.0+Christian Lohmaier
Change-Id: I7c8f85f0321741da21e01e1f02911c95ccf8559d
2018-07-19Resolves: tdf#118827 SetCareWin should be SetCareDialogCaolán McNamara
Change-Id: I84c00a193e65a18b3ba82351c07be0b63e0cd5d4 Reviewed-on: https://gerrit.libreoffice.org/57720 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19tdf#118800 fix rounding error in Calc function HOUR, MINUTE, SECOND.Winfried Donkers
Change-Id: I7a875b172493112b66fca8f70d2061371a05486c Reviewed-on: https://gerrit.libreoffice.org/57721 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit c69e7266916ac1b8917477fb4eccdb9098da5792) Reviewed-on: https://gerrit.libreoffice.org/57728
2018-07-19Resolves: tdf#118302 drag n drop to same tab should cancel dndCaolán McNamara
dropComplete is used to do this, follow the mac pattern here to propogate this in the drag and drop from self to self case. Maybe this also affects tdf#105320 ? Change-Id: I2b8f8b0e0486f6ee45a65918fae2537750a75f2d Reviewed-on: https://gerrit.libreoffice.org/57590 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-07-19tdf#118651 OOXML ActiveX textbox: fix multiline supportBalazs Varga
of textfield component in DOCX/PPTX by handling properties AX_FLAGS_MULTILINE and AX_FLAGS_WORDWRAP during the import and export. Both of them need to be enabled to get multiline textfield in MSO, but LibreOffice has got only one multiline property. With this fix, LibreOffice imports only really multiline textfields as multiline, and it doesn't export multiline textfields as single line anymore. Change-Id: I9b567c3fcdc5d01a5838a3ec2517579f8d788954 Reviewed-on: https://gerrit.libreoffice.org/57552 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> Reviewed-on: https://gerrit.libreoffice.org/57619 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-07-19related tdf#106174 writerfilter: replace broken FindParentStyleSheetJustin Luth
FindParentStyleSheet didn't do anything right. An empty stylename was supposed to check currentEntry, but instead it just returned null. The passed stylename was completely ignored if there was a currentEntry. And on top of that, the stylename itself was returned, not its parent. Even worse, the currentEntry properties were ignored because in that case it DID return the parent. Even the comments were totally bogus. Amazing... GetPropertyFromStyleSheet() has the potential for LOTS of use in writerfilter. I'm surprised it has hardly been used. Perhaps the completely wrong results led people to ignore it rather than investigate why it didn't give the expected results. Change-Id: I89a6b02877ab7990aa4eb58e5e0b6a572f3d10e3 Reviewed-on: https://gerrit.libreoffice.org/57195 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit bc67bda7363df48f1983513a8e969b61738139f5) Reviewed-on: https://gerrit.libreoffice.org/57483
2018-07-19tdf#117038 set button width to max possible content widthCaolán McNamara
Change-Id: I97e7c27523d213cb06cdf87a8ed0124d1ea8d5ba Reviewed-on: https://gerrit.libreoffice.org/57718 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19Resolves: tdf#118115 add missing help response idCaolán McNamara
Change-Id: Ie050285cc10d82cf80e560be3f1766c50dd1527c Reviewed-on: https://gerrit.libreoffice.org/57716 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-1' - update translations for 6.1.0 rc2 Change-Id: Ic312751e80079dee34a798631ac3bc7e4920d113
2018-07-19Resolves: tdf#118802 map GTK_RESPONSE_DELETE_EVENT to RET_CANCELCaolán McNamara
Change-Id: I8285f329e4672c90f47d96ccffe60c21c565dde7 Reviewed-on: https://gerrit.libreoffice.org/57656 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19tdf#118579 ignore body in body instead of flagging as an errorCaolán McNamara
Change-Id: Ie6626a320a5264aea004f7c57244643798703de8 Reviewed-on: https://gerrit.libreoffice.org/57653 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19Colibre icons: fix links.txt link and update addwatch iconandreas kainz
Change-Id: Iddb48d2cde206824f7721c5f4374166cc4979ad9 Reviewed-on: https://gerrit.libreoffice.org/57272 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 85f4ec6e0ebf4f97c1253c723d3c9c9b823ae372) Reviewed-on: https://gerrit.libreoffice.org/57465 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19move freeze/thaw to WidgetCaolán McNamara
Change-Id: I3944092c26ca81028912f6fb206b148b49e4f172 Reviewed-on: https://gerrit.libreoffice.org/57495 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19tdf#118635 relative checkbox disabled on reopenCaolán McNamara
Change-Id: Ic52737e5122b1ae37390061a5f7cf17b69e7e665 Reviewed-on: https://gerrit.libreoffice.org/57499 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'libreoffice-6-1' - Helponline: Fix alignment of TOC in sidebar It was too close to the window border in Edge, Chrome and Firefox Nightly. (cherry picked from commits 01319d64fae5989f35d10038d19d3371efb69d73 and 1ee609da2c58c8628535602348d2a51dd7ac9f14) Change-Id: Ic65fd8bcddf9836cfa4c6529fe286885983c78d1 Reviewed-on: https://gerrit.libreoffice.org/57341 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19xmlsecurity UI: restore lost AdES default for PDF signingMiklos Vajna
Regression from 13596e704e4b48e8b0892867b3f3fc351a2729f9 (Don't pass ODF version, just retrieve it directly, 2018-05-17). Change-Id: Ia031e597c610000db2820920c3dc1b58430dcc12 Reviewed-on: https://gerrit.libreoffice.org/57246 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit a9c0289886ee5519d4a718d8e3145d66b187faac) Reviewed-on: https://gerrit.libreoffice.org/57259 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19tdf#118354 Do not dereference non-exsisting ObjectArmin Le Grand
Change-Id: Ie7323302f3b29dfc19b26e2185321c2e609cab2b Reviewed-on: https://gerrit.libreoffice.org/57629 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-on: https://gerrit.libreoffice.org/57711
2018-07-19Resolves: tdf#94925 proper recalc mode and dirty broadcast for OOXML importEike Rathke
This is a combination of 4 commits. Rework FormulaTokenArray ScRecalcMode in preparation for tdf#94925 Strictly order the exclusive bits by priority, let AddRecalcMode() handle all sets except forced ALWAYS or NORMAL. Introduce ONLOAD_LENIENT and ONLOAD_MUST splitting ONLOAD to be able to distinguish later during OOXML import. Reviewed-on: https://gerrit.libreoffice.org/57402 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Resolves: tdf#94925 do not unset dirty if formula cell must be recalculated Reviewed-on: https://gerrit.libreoffice.org/57404 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Broadcast formula cells marked for recalc, tdf#94925 related In fact the ScDocument::CalcFormulaTree() call in WorkbookFragment::recalcFormulaCells() never did anything because no formula cell was added to the tree. Only visible dirty cells were recalculated, but not their dependents. Reviewed-on: https://gerrit.libreoffice.org/57431 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Remove the check for IsRecalcModeMustAfterImport(), tdf#94925 follow-up It's now superfluous as we set those cells dirty and broadcast in ScDocumentImport::broadcastRecalcAfterImport() Reviewed-on: https://gerrit.libreoffice.org/57439 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> f70860b8babf1cce7fda2ae63412659e72dbb4c3 a9dd4ad16c20b23ee8a1d46b69a4702b1ad4c81f 188de2d53a2d54df32d24eeeb148c4f9e87e7cfc Change-Id: I11217fa19adb766f509d0d6854502112de547c59 Reviewed-on: https://gerrit.libreoffice.org/57438 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-19Related: tdf#117016 DoubleRefToVars: always put in orderEike Rathke
... as all callers expect, whatever dynamic range creating process may have created it. Change-Id: I47b2e174d5bf4d5c23f10685526b48eee07dd6a4 Reviewed-on: https://gerrit.libreoffice.org/57567 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 6db5e1bdd67531fab14b375d6c624237d38de297) Reviewed-on: https://gerrit.libreoffice.org/57621 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-18tdf#118738: use SwDepend instead of WriterMultiListener in SwContentNodeXisco Fauli
This reverts commit 83243003b46dfb258c2b41049b0e1cb82a2d7ddb use WriterMultiListener instead of SwDepend in SwContentNode - also move SwContentNode and SwTextNode from Modify to SwClientNotify - this removes the last public use of SwDepend, which should now become an implementation detail of WriterMultiListener and commit ecf50fe71596c3edba8ce437481ab80ae1cd8935 remove now obsolete SwDepend Revert them for now ( specially before the relese of LibreOffice 6.1 ) until a fix for the bugs listed in tdf#118738 is provided Change-Id: I174feb3b092ff31b4c4837011c31343296c0c693 Reviewed-on: https://gerrit.libreoffice.org/57698 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-18crashtesting: infinite recurse on moz330387-6.svgCaolán McNamara
Change-Id: I3c39d49504a4651b92f41c07e4cef8887366dc2b Reviewed-on: https://gerrit.libreoffice.org/57627 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-18bubble referer to LinkManager::GetGraphicFromAnyCaolán McNamara
Change-Id: Id2c6d629692a365f96f3f81c5686930668389a6a Reviewed-on: https://gerrit.libreoffice.org/57549 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-18put load of html images (to measure dimensions) under referer controlCaolán McNamara
Change-Id: I1de4a5214ef48394dcafa97e4ea12bb460f2fba2 Reviewed-on: https://gerrit.libreoffice.org/57566 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-18only ellipize menubutton label when requesting narrower sizeCaolán McNamara
Change-Id: I32f4856756910ec1db8d37854b6e57dbec5aae76 Reviewed-on: https://gerrit.libreoffice.org/57618 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-12 08:55:56 +0000