summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-02-11devtools: use xInvocation to get values of all property typesTomaž Vajngerl
Without XInvocation we could only get the values of XPropertySet type of properties. XInvocation however supports getting values of all types of properties as it can invoke any kind of methods. Change-Id: I1f6c7b932b8bc554bcf6600a8c9eef81b7b2cfa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110464 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-11tdf#117899: sc: Add UItestXisco Fauli
Change-Id: Iddb34ccd3455efc9ea37a7b8c12bc374a0a488d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110730 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-10uitest: sc: remove duplicated testXisco Fauli
Change-Id: Ib24bfb42cd178c51256c01965e395242323d3daa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110724 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-10Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to dc49a6fffb002ab158b7052ab40048f0ddf7f54a - tdf#137084 update help for Tools menu ( swriter/main0106.xhp ) "Tools" menu + add "Automatic Spell Checking" heading and embed explanation + embed Thesaurus heading and explanation + add "Address Book Source" heading and embed explanation + embed AutoCorrect heading and explanation - remove "AutoCorrect Options" and its embed - remove "MediaPlayer" embed - remove "XML Filter Settings" heading and embed explanation + add "Endnotes" to label * move position of "Update" * update to <h1>,<h2> ( shared/01/06020000.xhp ) "Thesaurus" + add <relatedtopics> * move link to relatedtopics * update to <h1>,<h2>,<h3>,<warning> ( shared/00/00000406.xhp ) * update command sequence to Thesaurus command * update to <menuitem> ( shared/01/01110101.xhp ) * update "Configure" command to "Assign" * update to <h1>,<h2>,<h3>,<menuitem> ( shared/02/18030000.xhp ) * update to <h1> ( shared/autopi/01170000.xhp ) * update to <h1>,some <h2> ( swriter/01/02120000.xhp ) * update to <h1>,<tip> ( swriter/01/05150000.xhp ) "AutoCorrect" * update to <h1>,<h2> ( swriter/01/06990000.xhp ) "Update" * update to <h1> Change-Id: Idd28b5b6da0abbed349499581f9c85470928bfe5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110566 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-02-10tdf#140006 don't limit dropdown width to 300pixelsCaolán McNamara
let it use the full width of the cell. Keep that 300 pixel limit if we are expanding the widget width beyond its size request. Change-Id: Ifeaa9ee60e0d5649de71c960ae83270fb1afb2e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-10tdf#139667 modify tooltips that include "numbering style"Seth Chaiklin
This patch is part of a general effort to eliminate the use of the phrase "numbering style" in the UI. Most of the changes here are to use "numbering scheme" instead of "numbering style" And explicit mention of "character style" instead of "formatting" Change-Id: Ie3ca434133a1d04f074b68d16bd9394c1e05516a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110149 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-10tdf#128469 Tooltips for Reset in Character and CS + Standard (renamed)Seth Chaiklin
tooltip and extended tooltip added to "Reset" button for Character dialog and Character Style dialog. Rename "Standard" button to "Set to Parent" add tooltip for "Set to Parent in Character Style dialog Change-Id: I932be4f906393c0a40e45c9094f708b142f30b9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110151 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-02-10Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 0ba09fdc2fa1ecc55790e6b094bf883bdea719fa - typos Change-Id: I5d454f184d5787eccdff2f732a43eac056c9ad49 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110679 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-02-10Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to dd6644f72864fec9043739e9939df284e8505853 - Fix Examples section in Help description of Calc's HLOOKUP function. In the table of sample data, we have omitted the first column of row headings (as described in the text above the table). Also the heading of the last column should be "DO" rather than "DO4". File 04060109.xhp. Change-Id: Ib90f11f4937ba2f3283dfb96119ad5106a9e2274 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110680 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-02-10uitest: sd: check embedded document is open in a new dialogXisco Fauli
Change-Id: Ie2e9e7c9f97fba5f4bb8915098e61f86947197fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110702 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-10Fix creation of some OUString from non-ASCII ordinary string literalsStephan Bergmann
On platforms where char is signed, > OUString aTmpName10(aTempDirectoryURL + "/\xE6\x9C\xAA\xE5\x91\xBD\xE5\x90\x8Dzhgb18030"); would have created, via addDataLiteral (include/rtl/stringconcat.hxx), an OUString containing sign-extended char16_t counterparts of the \x char values (\xE6 -> \uFFE6, etc.). That caused CppunitTest_sal_osl CPPUNIT_TEST_NAME=osl_FileBase::SystemPath_FileURL::getSystemPathFromFileURL_005 under an RTL_TEXTENCODING_ISO_8859_1 locale (e.g., LANG=C, as used by Fedora when executing the %check part of libreoffice.spec) to fail on such signed-char platforms (e.g., Linux x86_64) with > [_RUN_____] osl_FileBase::SystemPath_FileURL::getSystemPathFromFileURL_005 > createTestDirectory failed: 21! > sal/qa/osl/file/osl_File.cxx:267:osl_FileBase::SystemPath_FileURL::getSystemPathFromFileURL_005 > assertion failed > - Expression: (osl::FileBase::E_None == nError) || (nError == osl::FileBase::E_NOENT) > - In deleteTestDirectory function: remove Directory file:///tmp/?????????zhgb18030 -> result: 21 because FileURLToPath -> osl::detail::convertUrlToPathname -> getSystemPathFromFileUrl<rtl::OString> -> decodeFromUtf8 -> convert (all sal/osl/unx/file_url.cxx) would fail to convert those values beyond \u00FF to RTL_TEXTENCODING_ISO_8859_1, ultimately returning osl_File_E_INVAL (i.e., 21). (We could "fix" addDataLiteral in include/rtl/stringconcat.hxx, explicitly converting from char to char16_t via unsigned char, but arguably that concatenation construct should only be used with ASCII-only ordinary string literals, similar to the restrictions for OUString construction from such string literals.) (Before 5a77636c9a638c86fd3de3afb6e88cf48f987b6a "WIN enable osl_File.cxx part of CppUnitTest_sal_osl", that aTmpName10 was constructed as > OUString aTmpName10(RTL_CONSTASCII_USTRINGPARAM( FILE_PREFIX TEST_PLATFORM TEST_PLATFORM_TEMP "/\xE6\x9C\xAA\xE5\x91\xBD\xE5\x90\x8Dzhgb18030" )); but that would have caused similar issues, as RTL_CONSTASCII_USTRINGPARAM uses RTL_TEXTENCODING_ASCII_US which converts non-ASCII chars to RTL_TEXTENCODING_MS_1252 (see comment at aImplUSASCIIByteCvtData, sal/textenc/textenc.cxx), which would have converted e.g. \x9C to \u2018, which then would have failed to be converted to RTL_TEXTENCODING_ISO_8859_1. And that use of RTL_CONSTASCII_USTRINGPARAM had violated the requirements as stated in include/rtl/ustring.h anyway: "Each element of the referenced array must represent an ASCII value in the range 0x00--0x7F.") Whatever this crappy getSystemPathFromFileURL_005 actually wants to prove, it happens to work now also for RTL_TEXTENCODING_ISO_8859_1 locales. Change-Id: I044c4bd3aee4f7ea4f29737b6876cc55e4e6e436 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110714 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-10lok: remove annotation viewshell notifierHenry Castro
Unfortunately the Annotation window sends cursor position to client side and it causes horrible effects like scrolling document due to different coordinates with the document. This patch will disable any notification to client side, also it removes a unit test related to check annotation cursor position. Change-Id: Ib432ef020c48bb1a9c82acc43ffccdb4230589c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110328 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 7a9b6456227c2a54b0b23cfc18679883b638e969) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110352 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-02-10tdf#140257 duplicate entire PaM ring when making copyCaolán McNamara
tdf#134439, tdf#135636 are the motivation behind copying the PaM, but multiselections require multiple PaMs Change-Id: I9f95eb6c62ac0e61053298d4e4dbe386f5686275 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110717 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-10Resolves: tdf#140225 remove action when item is removed from GtkSalMenuCaolán McNamara
and we have previously ensured that all items are removed by Menu::dispose before GtkSalMenu dtor is called Change-Id: Id91cfb96a16dfa7c55bb8bc6676cb7921ec8dd37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110704 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-10use zlib crc32() rather our own implementationLuboš Luňák
They compute the same thing, only zlib can do it four bytes at once. Since crc32() is used when loading documents, with larger documents this is a difference than can be measured (not much, but a couple percent of loading time). And we already depend on zlib anyway. Change-Id: I65c5a1f050af717a5a2d6e334e216d42c4e4dbbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110651 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-02-10sw tooltip on bibliography fields: add a text factory that gives us a stringMiklos Vajna
Normally an SwTextNode is created, then we insert the result directly to that at a specified position. This way the text for a ToxAuthorityField can be created without a temporary SwTextNode. Towards providing a tooltip on mouseover for bibliography reference fields. Change-Id: I66e9ca12129b988b7301c33fb80c133d4f7fadfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110712 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-10Be a bit more verbose in that crappy test codeStephan Bergmann
Change-Id: Ic0500db292d52a827f2139cd2cbbc0e8e4274dac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110701 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-10Related: tdf#140225 when clearing pItemList, keep SalMenu in syncCaolán McNamara
with their removal during menu teardown Change-Id: Ic5555372112c5717cbc39c38c6172344e807deb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-10Related: tdf#140225 ignore activate/deactivate of a disposed VclMenuCaolán McNamara
prep work for improved solution for tdf#140225 Change-Id: I381d018725c8981ea09ca5d30ec6d669fba15226 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110699 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-10cid#1472858 Unchecked dynamic_castCaolán McNamara
Change-Id: I3103719f6184efb7b9ecfb6d589d6757449814cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110693 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-10sw tooltip on bibliography fields: add an SwTOXInternational factoryMiklos Vajna
This is normally created in SwAuthorityFieldType::GetSequencePos(), but this way the logic can be reused when creating an SwTOXAuthority outside SwTOXBaseSection::Update(). Towards providing a tooltip on mouseover for bibliography reference fields. Change-Id: Ide15d0e30223ca40514439c3f3c506651228c69b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110705 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-10Fix dependency of CppunitTest_sal_osl on CppunitTest_Module_DLL libraryStephan Bergmann
The former only depends on the latter's library, not on actually running the latter test. (Something like > $ make CppunitTest_sal_osl CPPUNIT_TEST_NAME=osl_FileBase::SystemPath_FileURL::getSystemPathFromFileURL_005 > make -j 12 -rs -f Makefile.gbuild CppunitTest_sal_osl > [CUT] Module_DLL > > Fatal error: CPPUNIT_TEST_NAME contains no valid tests > > Error: a unit test failed, please do one of: > > make CppunitTest_Module_DLL CPPUNITTRACE="gdb --args" > # for interactive debugging on Linux > make CppunitTest_Module_DLL VALGRIND=memcheck > # for memory checking > make CppunitTest_Module_DLL DEBUGCPPUNIT=TRUE > # for exception catching > > You can limit the execution to just one particular test by: > > make CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params... > > make[1]: *** [solenv/gbuild/CppunitTest.mk:125: workdir/CppunitTest/Module_DLL.test] Error 1 > make: *** [Makefile:166: CppunitTest_sal_osl] Error 2 thus used to fail rather unexpectedly.) Change-Id: Id6051b192679d598100bbb5eae854bef59af9f44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110698 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-10Don't shrink row height when deleting cell contents interactively eitherTor Lillqvist
Follow-up to e763e13873adfe3c6abfa4c2dfd3ac3847e2d494. Such shrinking of row height, typically by a few silly pixels, just causes unnecessary invalidation thrash in a collaborative editing context. Change-Id: I5651ce994ba4bf82c83d7d4ef1bb8ed5bab0a66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110696 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-02-10devtools: show properties nested if the the property is an objectTomaž Vajngerl
If the property value is an object, show the expander and allow to show properties of that object nested. Change-Id: I93edf1a47738b9d6f15949dd4116b92ee54c8f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110463 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-10devtools: handle object inspector with attached objectsTomaž Vajngerl
This changes the object inspector tree view to create child nodes on demand (when expanded) and attach specialized node objects to the node, which are responsible to get the specific introspection information for the current inspected UNO object. Change-Id: Ib8431cc2a2c6d6d3ac7fd9db5bc61c9071d5e8f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110462 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-10devtools: add values for properties in object inspector tree viewTomaž Vajngerl
Change-Id: Ia53ea2cbc9797cd787d1ea3d841f947a515055e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110251 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-10Revert "tdf#138512 sw: fix crash on textbox alignment"Xisco Fauli
This reverts commit 54302a574a98d6fc071472f1fa64adaf70864a26. Reason for revert: This reintroduces tdf#137546. Besides, the UItest doesn't make much sense, it tries to test a GTK3 only issue, when the UItest runs with GEN Change-Id: I8694edd700484fcd3cf232057ecb4f67c186ff11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110676 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-10tdf#140252 Controls in Calc are always on layer 'controls'Regina Henschel
The ctor of SdDrawLayer had set the name of the control layer to 'Controls' (uppercase), whereas the ctor of SdrLayerAdmin sets it to 'controls' (lowercase). In result, for a control object in Calc the layer was not found and therefore set to default layer ID 0. I have not investigated in detail why it was not found, but simple change the name in Calc to use 'controls' too. Second error was, that a control, which was inserted as default object via ctrl+click, had not get 'controls' als layer. Change-Id: Iaac349cda0b0dcf3f098ca3484308ac52a83aa38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110636 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-02-10cid#1472857 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ib2901a8751f45a33bc125ac3f9a5fdeee94b7448 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110694 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-10cid#1401334 silence Uncaught exceptionCaolán McNamara
Change-Id: Ie8425ea3d528811fbb27d0e793c6ebed5a65ac68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-10Fix loplugin:stringliteralvarStephan Bergmann
...detection of OUString( const sal_Unicode * value, sal_Int32 length ) ctor. (On platforms where sal_Int32 is a typedef for int, an argument that already is of type int will not be wrapped in an ImplicitCastExpr to the sal_Int32 typedef.) Change-Id: Ifc5456a62d42c1acad76ea949549dc24bd67201a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110654 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-10Fix chart label import, use the locale as MS Office doesAndras Timar
Change-Id: Ic2b9198d37c102721c3043825113567d703d72b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110674 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-02-10loplugin:refcounting also check OWeakObject subclassesNoel
Change-Id: I2d89085a22d7424c6f8f7662307433ce50fc61d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110666 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-10pdfium: eliminate FPDF_SCHHANDLE from the public headerMiklos Vajna
Change-Id: I3b4fe169304c34d78019c4cc84b786ca84221d89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110659 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-10Remove unneeded breaksAndrea Gelmini
Extending this: https://gerrit.libreoffice.org/c/core/+/110512 Change-Id: If7e6f9c4079c2e0b48e642aa0b140fb4e03996bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110520 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-10tdf#134210 Handle greyscale effect on bitmap filled custom shapes.Gülşah Köse
Change-Id: Ia4a0828dad80e32cc0c7fe12227ffca717d62e03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110572 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-10tdf#139511 Correct calculation of minimum row height during resize.Gülşah Köse
Change-Id: Id47b5877d56850c80395897a83daae8e24f5c099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110662 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-10pass FastAttributeList around by rtl::ReferenceNoel
Change-Id: I958a22f60975c74dfaeb8469b4c0cd3759d40130 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-10clean up SdrObject cloningNoel
using operator= implies that overwriting an SdrObject is a useful operation, but that is not at all true - they are typically linked into and referred to by many other things. So rather use a copy-constructor. Also clean up a couple of weird "do some stuff after the clone" code into the main copy constructor. Change-Id: Iefc1481b527602748b5f3abed06e7cca66c0581c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110633 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-10tdf#134210 Import crop position of bitmap filled shape.Gülşah Köse
Change-Id: I6a62d68cd0f57e53934851a2f53dae05bf7d3730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110262 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-10Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to c36ab9284db666581cb814ce6f2265107439c4ee - Fix typos Change-Id: Ic59e55a6b3b31211dedca20572f53914eb9a47ef Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110660 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-02-10Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 8364e1a17ab04680905248d96be010af0d8c7ede - "Formula" -> "Text Formula" in Table menu help Change-Id: I5415717ed44c57ef76a259fc349cdd6e007e54fb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110571 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-02-10Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to b8df7b86811aa6433f2df6e8fbcbcf635020f894 - tdf#137084 add relatedtopics section to Styles menu help + add links to guide pages for "Update Selected Style" and "New Style from Selction" commands Change-Id: I6c5e9bfe7a9129ed4202af82ed1e45a1d49d3fbd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110565 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-02-09tdf#123052: sc: Move UItest to CppUnitTestXisco Fauli
Change-Id: If7a30aef44a722b4c0d91ecd7626a2a39fe1290a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110652 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-09tdf#139301 line dash interoperability: fix asynchron UI testLászló Németh
to avoid false alarms during slow testing. Also the test doesn't open the same file n times for testing the n line dash styles now. The problem reported by Stephan Bergmann. See also commit 8cc78b527bf2b7dcaaff73d8f0770f3d324ac839 ("Avoid test_tdf139301 hanging upon failure") and commit commit 183c06fc02a50fb117bb6162e4d6e56cdd34fad1 ("tdf#139301 fix OOXML-compatible preset dash styles"). Change-Id: I4b072f334a59abda373ab3a92f27afafda981145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110574 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-09no need to use unique_ptr for a simple value classNoel
Change-Id: Id83cd16fe3eb815ad419cc331e65fb731161bd30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110635 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-09loplugin:stringview (clang-cl)Stephan Bergmann
Change-Id: I5c2420d5fb886926540bb3502c130404786f1698 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110641 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-09loplugin:fakebool (clang-cl)Stephan Bergmann
But GetMessageW encodes more than true vs. false in its BOOL return value, so silence the unhelpful loplugin with auto. Change-Id: I77d053b760e93f918367532c63a6dfe963faa12d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110645 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-09Revert "on SelMouseButtonDown check if window pointer is not null"Caolán McNamara
because there is no pWin for the cases where an EditEngine is hosted in a native widget, e.g. comment in a sidebar in writer or format header/footer in calc's format page, header/footer, edit... and with change applied clicking doesn't move the cursor This reverts commit 0a2fa32f8756b3c99975df6d98736a8e9abb625a. Change-Id: Ie1da24d22b6d298f0c074f7bf187c5d891b78368 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110648 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Tested-by: Jenkins
2021-02-09configure.ac: allow --enable-python=system on macOS if PYTHON is non-emptyAndrew Udvare
This will work as long as a valid Python is in PATH, such as /usr/bin/python3 from Xcode or another version in some prefix like /opt/local. Change-Id: Ic967c3ce2f9949d94c11c3449363841a1565cfa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108486 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2025-02-26 13:07:31 +0000