summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-03Fix typoAndrea Gelmini
Change-Id: I54ab0fd193e0a133a49462f456fb2fe120494bee Reviewed-on: https://gerrit.libreoffice.org/70170 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03Fix typoAndrea Gelmini
Change-Id: Id1a9ca4952e52df2ca48b81d80c24f62d451a811 Reviewed-on: https://gerrit.libreoffice.org/70169 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03Remove now obsolete _TableRow interface testsJens Carl
Remove obsolete _TableRow.java file, missed it with commit cc9a8c13dad6f3d82a2386554bd6113b486a1752. Change-Id: I900ae9368d145dbe95b144323459ba05e38f6766 Reviewed-on: https://gerrit.libreoffice.org/70165 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03Add XServiceInfo tests to ScTableRowObjJens Carl
Change-Id: Ia3ad25e5e401abd3b27687a951a8c00fe710e57f Reviewed-on: https://gerrit.libreoffice.org/70164 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03tdf#45904 Move XCellRange Java tests to C++Jens Carl
Move XCellRange Java tests to C++ for ScTableRowObj. Change-Id: I2735779cae777c5af4e622bc1b538df2d8bf70df Reviewed-on: https://gerrit.libreoffice.org/70163 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03tdf#45904 Move TableRow Java tests to C++Jens Carl
Move TableRow Java tests to C++ for ScTableRowObj. Change-Id: I72cd8006b8ad932bab56681de9aac66fb40542fe Reviewed-on: https://gerrit.libreoffice.org/70159 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-02tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScTableRowObj. Change-Id: Ib448d6440cd6a285cd55297669bb19bd8aec6b07 Reviewed-on: https://gerrit.libreoffice.org/70156 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-02Introduce next Japanese gengou era 'Reiwa'Takeshi Abe
starting from 2019-05-01, which has been announced officially. This fills the provisional slot acknowledged at cacbb0faef77ae8462de9ff5c7307a6a2e28b2bb. Change-Id: Ifb12e6afaad4c66d455f664b46ec946e80324e87 Reviewed-on: https://gerrit.libreoffice.org/70028 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-04-02tdf#121103 ANOVA sum of squares formula correctionJaromir Wysoglad
The ANOVA sum of squares is now hardcoded to use '$Sheet?' in the source cell addless every time. Change-Id: I215b719be11ecfc2ae20c5df8e86876bc22d50f0 Reviewed-on: https://gerrit.libreoffice.org/69899 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-04-02obsolete .ui suppressionsCaolán McNamara
Change-Id: Icb873895cadb7cfd039e6cf0f9b23f52555c7941 Reviewed-on: https://gerrit.libreoffice.org/70147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02tdf#124272 use ClipRegion's geometry if not a rectangleArmin Le Grand
By error the ClipRegion's geometry was replaced by it's BoundRect expanded to PixelBounds. If the ClipRegion is not a rectangle, this will create wrong results. To do both - extend to PixelBounds and have the original geometry included - use the PolyPolygon topology as needed (see comment in code for details) Change-Id: If3f75223144eba8eb23909a7c701ad544346099b Reviewed-on: https://gerrit.libreoffice.org/70146 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-04-02Add a few SAL_INFOsTor Lillqvist
Change-Id: Ibdb013f4eeee8a2b2e29e3adb56943b5fccf9772
2019-04-02Implement the FullName property correctly in the Automation caseTor Lillqvist
Return a complete pathname. For or internal Basic, keep the existing semantics, that for some reason returns just the filename. Change-Id: I897cc797ca2158ca7c798f3e8adcdfa57a41ee3b
2019-04-02Sifr icon theme update last missing lc_ iconsandreas kainz
Change-Id: I004883067cc8ac747db2263654203dd777bcab7d Reviewed-on: https://gerrit.libreoffice.org/70148 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-02Warn when getFileURLFromSystemPath() fails, not when it succeedsTor Lillqvist
Also, display the name that the call failed for in the warning message. Change-Id: I0b6b7baca1d534b5bada5286b2b0e5b8e94f1832
2019-04-02Resolves: tdf#124485 [none] is at index 0Caolán McNamara
rather than the meaning of nothing-selected which is -1 Change-Id: I3be01fa8d6b57f61aa660be5912f479e79cff2b2 Reviewed-on: https://gerrit.libreoffice.org/70142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02limit URLBox growthCaolán McNamara
Change-Id: Icea856be18aeaf07379be25eaeab240fe263bb52 Reviewed-on: https://gerrit.libreoffice.org/70140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02find-unneeded-includes: use a better data structureGabor Kelemen
Turns out plain dictionary requires keys to be unique. So we need to store values as lists. This way there are no more false positives for <set> as in include/sfx2/linkmgr.hxx and include/sfx2/objsh.hxx Thanks Miklos for the advice! Change-Id: Ie2cfb63644d6cbd51171eb95e3bcdd9246343efa Reviewed-on: https://gerrit.libreoffice.org/69953 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-02State the name of the log file that contains an errorStephan Bergmann
...to make it easier to debug a failing build Change-Id: Ic936a6e6026db4208f58e19fb27e2c2d6e4adfec Reviewed-on: https://gerrit.libreoffice.org/70138 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-02weld XMLFilterSettingsDialogCaolán McNamara
Change-Id: Ia027fa0b5e99651988f2447bf29f6f5653dd0c48 Reviewed-on: https://gerrit.libreoffice.org/70139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02tdf#124266 : Paint cell if formula-cell has changed even if...Dennis Francis
not dirty. Change-Id: Id54811009079438945bb162dd3eb8705ce174781 Reviewed-on: https://gerrit.libreoffice.org/70043 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-04-02tdf#124329 Keep ResizeWithCell value when anchoring to a different cellSamuel Mehrbrodt
Change-Id: I62010b4882268aae135a406eb27634c3335d72cf Reviewed-on: https://gerrit.libreoffice.org/70118 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-02Split large test method in twoSamuel Mehrbrodt
Change-Id: If1b915f721a5768b682c63dc9c08b708ba37a705 Reviewed-on: https://gerrit.libreoffice.org/70116 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-02tdf#124329 Test setting ResizeWithCell via UNO APISamuel Mehrbrodt
Change-Id: Iab8733e5a5df2b189197df89c3e08cd3463f2ec7 Reviewed-on: https://gerrit.libreoffice.org/70111 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-02Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Current help page does not provide focus on UNO ...introspection that Python console is offering. Change-Id: Ic35833d7658d3ae9d465c1f3f7cc7a2ea1ecfa1a Reviewed-on: https://gerrit.libreoffice.org/69831 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-02Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Housekeeping on Help pages for Basic Change-Id: I2562226411498712dfad91bcd3e4690442d9c1d1 Reviewed-on: https://gerrit.libreoffice.org/70132 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-02tdf#124329 Add API to make cell anchored graphic resize with cellSamuel Mehrbrodt
Change-Id: Ib2335b1eb26e55fcfcfb964d0f3fe3dd267bdd0d Reviewed-on: https://gerrit.libreoffice.org/70067 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-04-02Force UITests locale en_USMike Kaganski
... otherwise they fail e.g. on Russian locale like this: $ /opt/lo/bin/make UITest_calc_tests7 UITEST_TEST_NAME="tdf123479.tdf123479.test_tdf123479_Crash_ScFormulaResult_GetMatrixFormulaCellToken" C:/cygwin64/opt/lo/bin/make -j 12 -rs -f C:/lo/src/core2/Makefile.gbuild UITest_calc_tests7 ... [UIT] calc_tests7 ... Execution time for tdf123479.tdf123479.test_tdf123479_Crash_ScFormulaResult_GetMatrixFormulaCellToken: 3.847 tearDown: calling terminate()... ...done FAIL ====================================================================== FAIL: test_tdf123479_Crash_ScFormulaResult_GetMatrixFormulaCellToken (tdf123479.tdf123479) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:/lo/src/core2/sc/qa/uitest/calc_tests7/tdf123479.py", line 42, in test_tdf123479_Crash_ScFormulaResult_GetMatrixFormulaCellToken self.assertEqual(get_state_as_dict(edArg2)["Text"], "OFFSET($Data.$A$2:$Data.$A$4,0,COLUMN()-3)") AssertionError: 'OFFSET($Data.$A$2:$Data.$A$4;0;COLUMN()-3)' != 'OFFSET($Data.$A$2:$Data.$A$4,0,COLUMN()-3)' - OFFSET($Data.$A$2:$Data.$A$4;0;COLUMN()-3) ? ^ ^ + OFFSET($Data.$A$2:$Data.$A$4,0,COLUMN()-3) ? ^ ^ ---------------------------------------------------------------------- Ran 1 test in 77.822s FAILED (failures=1) Tests run: 1 Tests failed: 1 Tests errors: 0 Tests skipped: 0 Change-Id: I65a199cc3f9667b8a2d72ba09ceb68732da3ec88 Reviewed-on: https://gerrit.libreoffice.org/70127 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-02drop some unneeded includesCaolán McNamara
Change-Id: I78b9682968acea7564554fb589d2759b6c8e67d0 Reviewed-on: https://gerrit.libreoffice.org/70126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02sw_redlinehide: remove WrongListIterator::MergedOrSame assertsMichael Stahl
There is a surprising recursion with 2 SwTextSlot on the stack, with 2 consecutive fields, and then the m_pOldGrammarCheckList is not the SwTextNode's but a SubList of that, so the assert triggers spuriously. SwExpandPortion::Paint(SwTextPaintInfo const&) const (this=0x7d61cc0, rInf=...) at sw/source/core/text/porexp.cxx:66 SwFieldPortion::Paint(SwTextPaintInfo const&) const (this=0x7d61cc0, rInf=...) at sw/source/core/text/porfld.cxx:437 SwLinePortion::PrePaint(SwTextPaintInfo const&, SwLinePortion const*) const (this=0x7d61cc0, rInf=..., pLast=0x6fa49d0) at sw/source/core/text/porlin.cxx:138 SwExpandPortion::Paint(SwTextPaintInfo const&) const (this=0x6fa49d0, rInf=...) at sw/source/core/text/porexp.cxx:78 Change-Id: I915f31ce6de57b6a4a051598428441ae6c86d264 Reviewed-on: https://gerrit.libreoffice.org/70131 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-02tdf#122926: Use o3tl::sorted_vector in other similar placesXisco Fauli
it doesn't give any win to the attached document, but seeing we get a 2 secs win with 9634f5ee73e57e8cef75461316d5d45b06ee104f, we can use the same logic in two similar places hoping other documents will get benefited Change-Id: Ie1e76a4317d5b2274335479037b248fe7b1e2a61 Reviewed-on: https://gerrit.libreoffice.org/70092 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-04-02tdf#124261 sw btlr writing mode render: fix invalidation rectangleMiklos Vajna
SwTextFrame::SwitchHorizontalToVertical(SwRect) did not handle the non-swapped case, also the text frame took the tblr codepath when determining the invalidation rectangle of the layout frame, but that special-case is not needed for the btlr direction. Typing into the cell of the bugdoc now determines the paint rectangle correctly, so the typed letters show up right after typing. Change-Id: I48c75603963868591d72bf4d0e8dbba679f3b5e9 Reviewed-on: https://gerrit.libreoffice.org/70087 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-02weld CrashReportDialogCaolán McNamara
Change-Id: Ifc4b606596db1469af03748da2d04659b8fa443a Reviewed-on: https://gerrit.libreoffice.org/70124 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02more standard way to populate textview contentsCaolán McNamara
Change-Id: I2d628ae62cef76be6ab05bd8710eed5cece75ffe Reviewed-on: https://gerrit.libreoffice.org/70123 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02tdf#100007: slider and time field update during video playbackKatarina Behrens
To make this happen, restart idle in timeout handler (also start it when user bonks Play button and stop it when they bonk Pause or Stop button). The idle also needs a lower prio than TaskPriority::Repaint, otherwise the higher-prio events from our idle are going to starve UI repaints in the scheduler queue Change-Id: I4c767c3533e0e2ee9015c48b17075db5e0dc7ade Reviewed-on: https://gerrit.libreoffice.org/70068 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-02tdf#124361 hide Add / Import button in OnlineAndras Timar
Change-Id: I6c8fb30fc1b8e0e6467a428f65838084fc08ca1e Reviewed-on: https://gerrit.libreoffice.org/69967 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-04-02tdf#122926 FILEOPEN ODT Slower compared to the past (part2)Noel Grandin
Further improvement: on my machine, this takes the time from 8.9s to 5.7s Change-Id: Ic7f7c46b10fbb671ff5bbf9d0a6a0195696741bc Reviewed-on: https://gerrit.libreoffice.org/70112 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-02sw menubar: rearrange subgroup items to have > items last sortedandreas kainz
Change-Id: Id208d22190485ed9c3e1042b8e862ef40345672b Reviewed-on: https://gerrit.libreoffice.org/69898 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-02Sifr icon theme update lc_andreas kainz
Change-Id: Ib521754b2a00a18cf184071c6248f47e483f18f6 Reviewed-on: https://gerrit.libreoffice.org/70114 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2019-04-02only use GdkSeat where availableCaolán McNamara
Change-Id: I346ab7a7c88350eef289c58b8bce299bdd891fbb Reviewed-on: https://gerrit.libreoffice.org/70085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02Improve sc shape testSamuel Mehrbrodt
Actually test anchoring the shape to a cell and to a page again Change-Id: I2d625b9a4f04aaf61dd8c1e8d10c639cbb4f0da5 Reviewed-on: https://gerrit.libreoffice.org/70110 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-02Related tdf#124329 Handle shapes resizing with the cellSamuel Mehrbrodt
The same as shapes just anchored to the cell. Change-Id: I0ce03e4c650dd10bd89cee87aa26775c32703d06 Reviewed-on: https://gerrit.libreoffice.org/70065 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-02tdf#108423 autocorrect English word i' -> I’László Németh
Now correction of the ASCII quotation mark to the typographical one (’) capitalizes the preceding single lowercase i, too, as in MSO, if the language of the text is English. Change-Id: Ic7586f07aa13f441e25494ff4cc11c672ac4a67a Reviewed-on: https://gerrit.libreoffice.org/70088 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-04-02Remove unnecessary commentsSamuel Mehrbrodt
Change-Id: Ie6dfdc87d209686955ae4b758cd020f2587e7dac Reviewed-on: https://gerrit.libreoffice.org/70117 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-02For Python extensions, set __file__ before executing the moduleThomas Viehmann
Previously __file__ was set after executing the module. This meant, however that it was not available during execution. This patch moves setting __file__ before the execution. As __file__ is a string (and not bytes), we remove the encoding. Change-Id: I63fe34b6f5d30f53aab16627d413c87b9de81992 Reviewed-on: https://gerrit.libreoffice.org/70048 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-02Fix typoAndrea Gelmini
Change-Id: I253b4582f2d22d2fa39ff469810c54c75a079e38 Reviewed-on: https://gerrit.libreoffice.org/70100 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-02Removed executable permission on data fileAndrea Gelmini
Change-Id: Ia0de0ebd0c8fb19ade2db76a6b402a6d97a75e57 Reviewed-on: https://gerrit.libreoffice.org/70099 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-02tdf#124463 XLSX export: fix splitDataSeriesByAxisBalazs Varga
splitDataSeriesByAxis couldn't split series correctly into two sequences, because it put all series into the first created sequence, except the first series of the newer sequence. Other improvement: first sequence of the return vector always contains the series attached to the primary axis. Change-Id: I6e107aa990f9a1a1db49cae2a4f3c9d8a35fb54c Reviewed-on: https://gerrit.libreoffice.org/70059 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-04-02tdf#120445 File-open ODS: Slower as compared to LibO 4.4.7.2Noel Grandin
This takes opening the file from 21s to 9.4s on my machine Change-Id: I38248f3c9acfa413fc105fcbe9ece06192389d46 Reviewed-on: https://gerrit.libreoffice.org/70073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-02renamed ssl test to testsslShubham Goyal
Renaming used as it was confusing to assume the .mk file based on the python test case, which was testssl.py. Change-Id: I903b59aecf3b167f75494aefcfcde916febee69e Reviewed-on: https://gerrit.libreoffice.org/69217 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>