summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-01-03WB_PINABLE isn't set anywhereCaolán McNamara
Change-Id: I6acc4b9dc87dd6023b5ad7013bc27180d6e0db6c
2017-01-03TyposJulien Nabet
Change-Id: I487db955caff589b9f62c50b83067628bb768d50 Reviewed-on: https://gerrit.libreoffice.org/32460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-01-03Mark [Scoped]VclPtrInstance as SAL_WARN_UNUSEDStephan Bergmann
Stack-allocated instances of the non-Instance [Scoped]VclPtr variants are occasionally used merely for the side-effect of holding objects alive (like css::uno::Reference and rtl::Reference, which are also not SAL_WARN_UNUSED for that reason). Change-Id: I37ebfaf028a646cb2777c0baf0d99992057a22bd
2017-01-03Hold SfxInfoBarWindow by VclPtrStephan Bergmann
In SfxInfoBarContainerWindow::removeInfoBar, disposeAndClear is already called on the removed member (once found), so the ScopedVclPtr (also calling disposeAndClear when going out of scope) should not be necessary. Change-Id: Ibf4d19ebd5f1a6217e1d18ef0458c9b865667898
2017-01-03tdf#104729 FILESAVE Save author name in comment during export to .xlsxBartosz Kosiorek
Change-Id: I59d46f6a713e4f252844cda0f631ace239d73cdb Reviewed-on: https://gerrit.libreoffice.org/32115 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-01-03tdf#87111 Warn about data loss when deleting source data of pivot tableAbhilash Singh
Change-Id: I59ab7551494622b8f1e68bfd9ef5e7ae19e65aee Reviewed-on: https://gerrit.libreoffice.org/31852 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-01-03Related: tdf#104841 sw PDF export: handle linked videosMiklos Vajna
This is the sw-specific part only, the real work is done by the common CreateScreen() / SetScreenURL() API added for sd earlier. Change-Id: Ief9fd80082960ddd1f92f413eac79577621551ce Reviewed-on: https://gerrit.libreoffice.org/32687 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-03tdf#104492: Fix bad docx opening and bad layoutDimitri Bouron
The problem seems to be the table's repeated rows value which is setted to max table rows in some docx file. Decreasing repeated rows value by one avoids loops but renders a bad layout. Table continuity is lost and lots of rows are hidden. So I set repeated rows value directly to one in order to avoid bad layout. Change-Id: If4adc33febe088a866b704e87e49339710e5aaf5 Reviewed-on: https://gerrit.libreoffice.org/32349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-01-03rename members and use range based loopsJochen Nitschke
rename members to reflect their type css::table::CellAddress maCellAddress -> ScAddress maAddress Change-Id: Id95461512600023dbfd3209a5b0fdcf3d3e53b1e Reviewed-on: https://gerrit.libreoffice.org/32661 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-03tdf#104744 RTF import: fix unexpected zero para left margin wrt style dedupMiklos Vajna
See commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF import: override style properties like Word, 2014-06-17) for the details on style override in RTF. Here the problem was that we added an unneeded "reset to 0" property, the opposite situation that commit 657c6cc3acec0528209a8584b838cd6de581c437 (tdf#104228 RTF import: fix override of style left/right para margin, 2016-12-13) was fixing (there a "reset to 0" was missing). Change-Id: I37f079b9cb4773214d2531c2e34920b3b8927211
2017-01-03avoid some numeric type conversionsJochen Nitschke
Change-Id: I89329ae1dc2c46b6412fcefd31cdb3dcd907354d Reviewed-on: https://gerrit.libreoffice.org/32658 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-03use proper message passingBjoern Michaelsen
Change-Id: Id0ac2e87344fdab4db97357158c5cc60eed70898 Reviewed-on: https://gerrit.libreoffice.org/32663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-01-03default copy ctor and assignment operator are good enoughCaolán McNamara
and block default move equivalents Change-Id: I360860512d2c88f8688685f4e751ded6335549da Reviewed-on: https://gerrit.libreoffice.org/32656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-03Move documentation for parameter of SfxObjectShell::GetTitle() to include fileTor Lillqvist
A re-design of this API would be a good idea. Is this function ever called with some specific max length that would not be one of the magic values? Probably the sanest would be to turn the magic value constants into a normal (scoped) enum, and have two separate functions: One that takes no parameter and returns the whole title (and then let the caller take care of truncating as necessary), and one that takes such an enum and returns a correspondingly mangled title. The less magic and defaulted parameters the better. Change-Id: I9e3aa95fae981c5ed48300b753556fa9074c1166
2017-01-03tdf#49102 - UI: remove list numbering from merged cellsJustin Luth
The hidden cells in a vertical merge retained their numbered list properties while the document was loaded (bad). However, on closing and reopening, the hidden cells no longer had any numbering (good). This patch immediately removes the numbering, so that the working copy matches the saved copy. Now vertical merging works the same way as horizontal merging already worked. Change-Id: Ia37151031eab4fd57bf958e9cddf6dce06dafc3c Reviewed-on: https://gerrit.libreoffice.org/32518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-03tdf#43157 Cleanup OSL_ASSERT in scenwnd.cxxMuhammet Kara
Change-Id: If2bd3c96c6d6344d70ceb4d9c3d23d91c116893a Reviewed-on: https://gerrit.libreoffice.org/32447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-03add PERMUT test caseZdeněk Crhonek
Change-Id: Iae53698eeb2fbe58671dc51b3364b0611ebbce49 Reviewed-on: https://gerrit.libreoffice.org/32542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-03tdf#48140 replace CellRangeAddress in xlsx import (11)Jochen Nitschke
Change-Id: I033b2ddb720942882aad5ceaa8b140546f32356d Reviewed-on: https://gerrit.libreoffice.org/32580 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-03tdf#48140 replace CellRangeAddress in xlsx import (10)Jochen Nitschke
Change-Id: I8a2d7edb33b093a7069d1289d3b66e3e0bb27548 Reviewed-on: https://gerrit.libreoffice.org/32579 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-03tdf#48140 replace CellRangeAddress in xlsx import (9)Jochen Nitschke
Change-Id: If0b9d35305c4e109cb3edf8c5041d95854cd6c28 Reviewed-on: https://gerrit.libreoffice.org/32578 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-03tdf#48140 replace CellRangeAddress in xlsx import (8)Jochen Nitschke
Change-Id: I45856e73dc189e00898f9ce8fa2281a0fbb99718 Reviewed-on: https://gerrit.libreoffice.org/32577 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-03tdf#48140 replace CellRangeAddress in xlsx import (6)&(7)Jochen Nitschke
Change-Id: Idc44249b96009633f63b72dd51a74e51bef41284 Reviewed-on: https://gerrit.libreoffice.org/32576 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-03tdf#48140 replace CellRangeAddress in xlsx import (5)Jochen Nitschke
Change-Id: Ib0ebc3e92e595cdc2ed1241efdb1131fb79452cd Reviewed-on: https://gerrit.libreoffice.org/32574 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-03tdf#48140 replace CellRangeAddress in xlsx import (4)Jochen Nitschke
Change-Id: I4576c8553205c075ae932567242d98aae3c20b1a Reviewed-on: https://gerrit.libreoffice.org/32573 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-03tdf#48140 replace CellRangeAddress in xlsx import (3)Jochen Nitschke
Change-Id: I75392908ee90ae96c79d0e44a33920e1441b2129 Reviewed-on: https://gerrit.libreoffice.org/32572 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-03tdf#48140 replace CellRangeAddress in xlsx import (2)Jochen Nitschke
Change-Id: I91115c65671910e4208cb14ae3837ff2129af472 Reviewed-on: https://gerrit.libreoffice.org/32571 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-03tdf#48140 replace CellRangeAddress in xlsx import (1)Jochen Nitschke
Change-Id: I0ce4101c4f9f5554e505f170e95119431a8963f8 Reviewed-on: https://gerrit.libreoffice.org/32570 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-03tdf#97361 Use join() for string concatenationJustn Lavoie
The PEP8 suggest to use join() instead of + operator for string concatenation. Change-Id: I35325cc73845a450f5c8ce40b7594e6d57ad6f45 Reviewed-on: https://gerrit.libreoffice.org/32504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02add RANK and RANK.AVG test caseZdeněk Crhonek
Change-Id: Ia695c8fe92b1034fa1ad9e645e8459d23dac5cf9 Reviewed-on: https://gerrit.libreoffice.org/32653 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02add QUARTILE test caseZdeněk Crhonek
Change-Id: I4cb90025f8459b756f484497abb0c70bbd61fa87 Reviewed-on: https://gerrit.libreoffice.org/32540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02add PHI test caseZdeněk Crhonek
Change-Id: I23afaf7381a8619c4224a55e368ede1973ba457a Reviewed-on: https://gerrit.libreoffice.org/32541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02add PROB test caseZdeněk Crhonek
Change-Id: I7d03035c330bc0711264e8fe84aefa99d386acdb Reviewed-on: https://gerrit.libreoffice.org/32535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02add QUARTILE.EXC and QUARTILE.inc test caseZdeněk Crhonek
Change-Id: I52eaea05dd1430da04ab44bd07416da477f735af Reviewed-on: https://gerrit.libreoffice.org/32652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02micro optCaolán McNamara
Change-Id: I2d713783f1ad533c23a3fe319e7c37b7fd0e0e0d
2017-01-02coverity#708661 Uninitialized scalar fieldCaolán McNamara
Change-Id: I1e87e7f6d135f9e4a0b4efbb4ce7e6e08663f675
2017-01-02Remove package with dbghelp.dllMatúš Kukan
ENABLE_CRASHDUMP is always empty. dbghelp.dll was removed from scp2 in 8ab4d2f29fdd2c058db23f6ee7b2200655d4c6f6 Change-Id: I5c47ce4b4cafb2f24185ddd9a31eb1a3176fa176 Reviewed-on: https://gerrit.libreoffice.org/32395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2017-01-02fix indentCaolán McNamara
Change-Id: I39e79bc56c437323d4d860174242905ee5261cf6
2017-01-02coverity#1103741 Uninitialized scalar fieldCaolán McNamara
Change-Id: I22a960e1170339aaf7939c0c5823dd1a53ae040f
2017-01-02coverity#1397202 Unchecked return valueCaolán McNamara
Change-Id: Iba346a5379f89b1a726f57b2d2a48cc827ec4a1f
2017-01-02add a jpg fuzzerCaolán McNamara
reshuffle things to share common core Change-Id: I50aa0e2ddeefaa4b2d0592b1118defd28b7347db
2017-01-02tdf#95416 Get rid of #include ../foo/bar.hxx style includesGaurav Dhingra
Change-Id: I9b05c261faebd3e0e5d65ca524a4379c1d5918f1 Reviewed-on: https://gerrit.libreoffice.org/32419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-02gbuild-to-ide xcode generator moved proj filesjan Iversen
All .xcodeproj files are now located in <core>/osx to prepare for combining into 1 .xcodeproj for all of LO Change-Id: I649389ba2b94355ebaf6b5413bdb5dfae8c04764
2017-01-02coverity#1371220 Missing move assignment operatorCaolán McNamara
Change-Id: Ie2947ea621da7ffc6c9530f007e1acdd4efb50cb Reviewed-on: https://gerrit.libreoffice.org/32650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-02tdf#104841 sd PDF export: handle linked videosMiklos Vajna
Use the screen annotation markup for this purpose. Change-Id: I129111cbe08c19c2f3b3ae046408ff9b2a28520c Reviewed-on: https://gerrit.libreoffice.org/32654 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-02use std::unique_ptrCaolán McNamara
Change-Id: I1c4f81e0ba0529b9e365c6ddb3d77a8a6a6d5741 Reviewed-on: https://gerrit.libreoffice.org/32649 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-02gbuild-to-ide update to xcode generatorjan Iversen
The generator now generates the same groups as xcode, with relative paths. This patch has been tested with l10ntools/pocheck. Next step is "sal" and actually compile Change-Id: I02c202434a346918e9ec725bd20e4713fc6fa73e
2017-01-02Remove newly added SAL_WARN_IFJulien Nabet
Following Stephan's comment from https://gerrit.libreoffice.org/#/c/32643/ Change-Id: I6bb5c243313c3f0793286c6bae2967a6208dc854 Reviewed-on: https://gerrit.libreoffice.org/32651 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-02Typo: m_nColumnPostion->m_nColumnPositionJulien Nabet
Change-Id: Iab83a89b5cfa1ca379cb59366682d5d2adeb0e31 Reviewed-on: https://gerrit.libreoffice.org/32645 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-02Remove some OSL legacies in dbaccessJulien Nabet
Change-Id: Id809265c1df7df48e77ac2d8fbff685c599f8432 Reviewed-on: https://gerrit.libreoffice.org/32643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-02tdf#105005 Breakpoint has wrong image in BASIC IDERegina Henschel
Breakpoint, inactive breakpoint, step marker and error marker have got wrong images in 96d0506fceb8064c5ae156dfaf12d5b45623c557 Change-Id: I7c03595dfa41e03b5b4a23d36c514a6c782281a3 Reviewed-on: https://gerrit.libreoffice.org/32590 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>