summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-10-13oox: refactor embedded media importMichael Stahl
Currently the oox import creates a temp file and leaks it, and there is no way to clean it up afterwards. Unfortunately it turns out that SdrModel has no way to access the imported OOXML storage, so add a really ugly hack to get the embedded media into the SdrMediaObj by setting both MediaURL and PrivateStream properties (currently oox really wants to set the properties in alphabetical order too...) Change-Id: I5a235fbeb08e7bc17faf066de52b94867e9a79a2
2014-10-13coverity#707458 Uncaught exception (better fix)Michael Stahl
getStatementsGraph_NoLock() cannot throw the exception because of the i_Internal=true parameter, which may confuse Converity; but possibly xIter->nextElement() could throw this in a multi-threaded scenario... Change-Id: I204c0e5b38fee919d6cfe9247bde76b6ea78ed0f
2014-10-13scripting: Null pointer dereferenceRobert Antoni Buj i Gelonch
Change-Id: I0d72ef34945065f68e9af8b0957dc440a74c14ce Reviewed-on: https://gerrit.libreoffice.org/11923 Reviewed-by: Matthew Francis <mjay.francis@gmail.com> Tested-by: Matthew Francis <mjay.francis@gmail.com>
2014-10-13Resolves: #i125325# added code to handle block comments...Armin Le Grand
in Css style definitions (cherry picked from commit 7b071b828a5f602cc30c17ddd871a75426a53faf) Conflicts: svgio/source/svgreader/svgtools.cxx Change-Id: I094228ea398686c5b39f5f279a964a2df7b00368
2014-10-13Resolves: #i125326# accept CssStyles with missing type attributeArmin Le Grand
(cherry picked from commit bb72d5b3ecbe6a03d3d3dfe101ad67ff4650a9f9) Conflicts: svgio/source/svgreader/svgdocumenthandler.cxx Change-Id: I5395c2cada92d5abcde9f6cc18bc237a58e77992
2014-10-13build error: specialization in different namespaceCaolán McNamara
Change-Id: Ic1730a49576a663a2e04a2386bd3962a21b6fc48
2014-10-13Resolves: fdo#84930 format page background in report-builder crashCaolán McNamara
another regression from one of... commit 7d9bb549d498d6beed2c4050c402d09643febdfa Author: Armin Le Grand <alg@apache.org> Date: Mon Jun 2 15:00:50 2014 +0000 Related: #i124638# Second step of DrawingLayer FillAttributes... for Writer objects, now added support for Paragraph and PageStyle (including Header and Footer) for direct attributes and style attributes commit 4a0b5e569d070c286daefb0fdfe45c0dd15d241c Author: Armin Le Grand <alg@apache.org> Date: Thu Apr 17 16:44:58 2014 +0000 i#124638 support for DrawingLayre FillStyle for GraphicFrames and ... ... EmbeddedObjectFrames in Writer commit 6e61ecd09679a66060f932835622821d39e92f01 Author: Armin Le Grand <alg@apache.org> Date: Wed Mar 19 16:17:02 2014 +0000 This is something of a horror, and this is a suboptimal fix, but it appears to work. Change-Id: Iee7e6fdb40ca2e32beaa8e4bfea31872b8e0642e
2014-10-13coverity#704061 Unchecked return valueCaolán McNamara
Change-Id: I460f258cb3b44949176561d397837184cd08bfbd
2014-10-13coverity#982170 Unchecked return value from libraryCaolán McNamara
hopefully rsc is on the way out Change-Id: I270de6c4433560dbed0185e462237c3aa95a98a3
2014-10-13coverity#1078470 Unchecked return valueCaolán McNamara
Change-Id: I2dab114efc8c98a17561f1694acf63918e68620d
2014-10-13coverity#1078466 Unchecked return valueCaolán McNamara
Change-Id: Ia78578303cadda713b3c015cd0e30446cd6f8f25
2014-10-13coverity#1078451 Unchecked return valueCaolán McNamara
Change-Id: I7652c609228e90fa0c71a6d20852da111be77d3d
2014-10-13coverity#1078450 Unchecked return valueCaolán McNamara
Change-Id: I1dce4448ccc1a3af143dc4435a00aa434b4114ae
2014-10-13coverity#1027273 Unchecked return valueCaolán McNamara
Change-Id: I25c6b11fee909559a5f3bac7566fd161851ae14d
2014-10-13coverity#982191 Unchecked return valueCaolán McNamara
Change-Id: Ieb5607513b61b2a5436332bdd8a572fb6a739be7
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13coverity#1066164 Resource leakCaolán McNamara
Change-Id: I152f22728a8eeea65114fe102511940bccf40478 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-10-13Register flat file mime types on OS XMatthew J. Francis
Change-Id: I505703b2f6890586e05e6c2146d9b37774f101d0 Reviewed-on: https://gerrit.libreoffice.org/11957 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2014-10-13java: Collections.addAll for adding an array of elements to a CollectionRobert Antoni Buj i Gelonch
Change-Id: I4689aa73e1e261c6461e04b9e814ffefa5817c09 Reviewed-on: https://gerrit.libreoffice.org/11953 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13java: import from the same packageRobert Antoni Buj i Gelonch
Change-Id: I1bb0999783f365e20b682c3707e73c65724265c9 Reviewed-on: https://gerrit.libreoffice.org/11955 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13reportbuilder: import from java.lang packageRobert Antoni Buj i Gelonch
Change-Id: I039f7cf28dddede48627c3c624c87741ee9de0ed Reviewed-on: https://gerrit.libreoffice.org/11956 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13android: Dump my debugging notes to the readme's.Jan Holesovsky
Change-Id: I8f91e73fe5df5dfef054df80d43be3c74d01388b
2014-10-13fdo#84872 give each SheetDataContext a new FormulaParserCaolán McNamara
Change-Id: I120a9d0943db38571892defe1b5d3169158e3e42
2014-10-13enhance perfcheck failing messageLaurent Godard
add the expected number Change-Id: Ib068288f7efbfebc2705c6084dc34a651def1986 Reviewed-on: https://gerrit.libreoffice.org/11948 Reviewed-by: Matúš Kukan <matus.kukan@collabora.com> Tested-by: Matúš Kukan <matus.kukan@collabora.com>
2014-10-13fdo#82980: Cancel FmXFormView::OnStartControlWizard when breaking creationStephan Bergmann
The problem is that SdrCreateView::EndCreateObj (svx/source/svdraw/svdcrtv.cxx) first calls FmFormObj::EndCreate (svx/source/form/fmobj.cxx) -> FmXFormView::onCreatedFormObject (svx/source/form/fmvwimp.cxx) -> Application::PostUserEvent( LINK( this, FmXFormView, OnStartControlWizard ) ), and only then, upon bPntsEq, calls FmFormObj::BrkCreate (svx/source/form/fmobj.cxx), which does not cancel the posted OnStartControlWizard link. The fix is apparently not perfect, though, as afterwards the text document goes back to text input mode (cursor blinking, mouse pointer has I-beam shape) even though the "List Box" icon is still selected. Change-Id: I3137110a88885b04c8dde5377265b1dee91ed6ac
2014-10-13Quit after 100 roundsTor Lillqvist
Also, print the timing output to stdout, so that one can run the time command on this, redirecting the program output to /dev/null, and just see the 'time' output. Change-Id: I4b2bfe7f0d37746fe0a015b961512850a880560c
2014-10-13runner: Object comparisonRobert Antoni Buj i Gelonch
Change-Id: I41b245f20652187dc36b4639272d0ddbc602afda Reviewed-on: https://gerrit.libreoffice.org/11921 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMapChris Sherlock
To do this, I've made FontCharMap a friend class for ImplFontCharMap, and have moved the functions directly into FontCharMap. In this patch, I am attempting to stop the direct use of ImplFontCharMap by anything other than FontCharMap. However, FontCharMap itself requires a refcounter, so we will use FontCharMapPtr to access the font character map. Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9 Reviewed-on: https://gerrit.libreoffice.org/11823 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-10-13Make the image continuously resize back and forth in both casesTor Lillqvist
Change-Id: Ia543e5355c8d6a7712bf6f10c989945ff830627d
2014-10-13android: When debugging, the installLocation must be "internalOnly".Jan Holesovsky
Otherwise the gdbserver ends up with run-as: exec failed for /data/data/org.libreoffice/lib/gdbserver Error:Permission denied (you need to run ndk-gdb with --verbose to see that). Change-Id: Iccdf0ff268c20d2fb5abc1e93404375fa51c1cf1
2014-10-13boost::rational throws if 0 is passed as denominatorDavid Tardon
Change-Id: I312fd6b964555b3b4aa4e22cec6054c9a83b2c52
2014-10-13Avoid manual realloc, use comphelper::SequenceAsVector insteadMiklos Vajna
Change-Id: I26c6bcf7361bbb787fcb4133d05b0a668fd72d01
2014-10-13nlpsolver: ensure that the stream is cleaned up before the method returnsRobert Antoni Buj i Gelonch
Change-Id: I081194d802bd835285bdc37fbef55f229f1185dc Reviewed-on: https://gerrit.libreoffice.org/11940 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13xmerge: ensure that the stream is cleaned up before the method returnsRobert Antoni Buj i Gelonch
Change-Id: I377ae1a7b71c207313ad3468a51b1ab06b9fffd5 Reviewed-on: https://gerrit.libreoffice.org/11939 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13accessibility: ensure that the stream is cleaned up before the method returnsRobert Antoni Buj i Gelonch
Change-Id: Ib46d24be831b5c9bda0582bd7064f34528e1d609 Reviewed-on: https://gerrit.libreoffice.org/11938 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13convert SW_TAB #defines to enumNoel Grandin
Change-Id: I8f2c63dc381416af1eb74794a1bbc3417eb272d6 Reviewed-on: https://gerrit.libreoffice.org/11936 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13android: When rotating, we also need to update the viewport geometry.Jan Holesovsky
Change-Id: I04502c56b1e1d16cf65cbeb47632c508ef9889d0
2014-10-12convert SW_MOVE constants to enumNoel Grandin
Change-Id: I504862618bfeeeed674c1cb816104a167cb2e27e Reviewed-on: https://gerrit.libreoffice.org/11935 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-12runner: code will never be executedRobert Antoni Buj i Gelonch
Change-Id: I0484a11b3511c1d7f70e9ae8407eb7d19bcc852d Reviewed-on: https://gerrit.libreoffice.org/11929 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-12runner: Concatenating null strings in Java (JDK 1.5+)Robert Antoni Buj i Gelonch
JLS, Section 15.18.1.1: If the reference is null, it is converted to the string "null". http://docs.oracle.com/javase/specs/jls/se5.0/html/expressions.html#15.18.1.1 Change-Id: Idae09c02b24da38ec6f3475fd0af35ef48a2405b Reviewed-on: https://gerrit.libreoffice.org/11930 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-12runner: remove import from same packageRobert Antoni Buj i Gelonch
Change-Id: I4aeb7f58034f8808325639d07aa2dc55959d97a8 Reviewed-on: https://gerrit.libreoffice.org/11932 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-12runner: remove import from java.lang PackageRobert Antoni Buj i Gelonch
Change-Id: Iedad24dfbdd60a05a09888f699f2467960f5cbe9 Reviewed-on: https://gerrit.libreoffice.org/11933 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-12runner: 'static final' to declare constants when it isn't an interfaceRobert Antoni Buj i Gelonch
Change-Id: Iea1e672e5468b66fd1ba5389bd781f03d0c7f419 Reviewed-on: https://gerrit.libreoffice.org/11931 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-12coverity#706421 Uncaught exceptionCaolán McNamara
Change-Id: I91a6ac9d9bda0ea25f1f5385bbac71ea9d22d573
2014-10-12coverity#706404 Uncaught exceptionCaolán McNamara
Change-Id: I7717b61e89d95cb6d89bb273c22c0503b0853d96
2014-10-12coverity#706331 Uncaught exceptionCaolán McNamara
Change-Id: I48e11a07924418721d45fcac55bd5aeb68f115a3
2014-10-12coverity#706478 Uncaught exceptionCaolán McNamara
Change-Id: Ie37ebac80afb3e52668ae6ebeeb61eaddc892ef6
2014-10-12coverity#706476 Uncaught exceptionCaolán McNamara
Change-Id: I1461c99fccb57ccf5375e372e50948b0b355d4bb
2014-10-12coverity#706477 Uncaught exceptionCaolán McNamara
Change-Id: If44507458f8473d6fede3e430e69620f8fb1d698
2014-10-12coverity#735337 Unchecked return valueCaolán McNamara
Change-Id: Ib1f27e51934d7deb4f30d74409554dfeb14928ff