summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-06-03-Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann
sLanguage and sTmpStrVal are unused since c9611c5e6465948de029e9c2fbd17e75ee07d31f "loplugin:unusedfields in l10ntools..sax". Simplify the for loop now that it only checks for a single item, and expand the ID macro at its last remaining use. Change-Id: I3cf6692fc5a4efd58d0df1dbc24b3610916b2fd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116665 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-03Change 'Background' -> 'Area' in Insert Section dialogOlivier Hallot
The term background is deprecated in several dialogs, e.g. page style, paragraph and paragraph style in Writer and other modules. This patch changes the term 'Background' to 'Area' in the Insert section dialog. Change-Id: I6424517f8e3c6d8d8975c8dc62f905a3508aba55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116580 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-06-03fix crash in GtkSalData destructorNoel Grandin
which had never been called until.... commit 556243467a0ac3f647de75bf3fb6c9f3b72466a4 Date: Wed Jun 2 13:06:54 2021 +0200 fix shutdown leak in CppunitTest_sw_filters_test Can't call Yield at this point in time, the SalInstance is already gone. Change-Id: Id196d7c2de69121dca447d845ed0aff3d8a7acfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116668 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-03gtk4: get basic menubutton popovers workingCaolán McNamara
Change-Id: Id205761521d9eda50bb858d86e7235e273691568 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116666 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03tdf#142635: skip UITest for nowMike Kaganski
Change-Id: I84f5c8b2dd3f18456e61e8f9de90371d1a7601e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116467 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-03gtk4: get menubutton picture aligned nicelyCaolán McNamara
Change-Id: I4df3bfee7256a92e37d6bc887fa21ed74b615a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116659 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03gtk4: align menubutton label to startCaolán McNamara
Change-Id: I6ea62b3b66ec18d478fcadd132b9b86387c9db48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116658 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03gtk4: use a GtkPicture instead of a GtkImage in MenuButtonsCaolán McNamara
because GtkPicture retains the aspect ratio Change-Id: I8d9383532cacd4711f9452cb8fba0af48d9a3d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116657 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03merge duplicate functionsCaolán McNamara
Change-Id: Icf0633ebfd668d19f5cbba5a07ec24ed5c65decc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116656 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03-Wunused-but-set-{parameter,variable} in CompilerTest_compilerplugins_clangStephan Bergmann
...new with Clang trunk 13. As a rule of thumb, this change adds explicit cast-to-void silencing in those .cxx that already contained other such silencing casts and adds wholesale #pragma clang diagnostic ignored in all others. Change-Id: I1884496ee1aa81aaf3c8b3533534a4b69b185e9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116660 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-03-Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann
> unodevtools/source/skeletonmaker/skeletoncommon.cxx(47,13): error: variable 'shortfilename' set but not used [-Werror,-Wunused-but-set-variable] > OString shortfilename(filename); > ^ Change-Id: I18510a5c2d2ceca4eab3ef93c0a32a1bffafac6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116661 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-03vcl: fix clang7 buildMiklos Vajna
vcl/backendtest/outputdevice/line.cxx:126:17: error: no viable constructor or deduction guide for deduction of template arguments of 'vector' Change-Id: I8009637caaba460f9b5ea256f782517e4f1a4be7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116639 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-03gtk4: GtkMenuButton doesn't inherit from GtkToggleButton anymoreCaolán McNamara
Change-Id: Ia5175502e04d821097c38981e1ea6fabb5673f04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116655 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03gtk4: reenable partial PopoverCaolán McNamara
Change-Id: I51e40842fa2dd614f64cafb12271a41aac8122a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116654 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03use std::make_unique instead of newCaolán McNamara
Change-Id: I267b82dd573fc8bd30e1c5d47e9b1f2e98c2b412 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116645 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03cid#1485165 avoid Missing move assignment operatorCaolán McNamara
Change-Id: I9113e589f74a119fc24e174e7e35036beb0d7acd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116643 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03Simplify some initializations in connectivity (2)Julien Nabet
Change-Id: Iacbd1ccc58ebe6ef0a434e7334bc393d3457f889 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116638 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-06-03fix leak in SwRedlineAcceptDlgNoel Grandin
Change-Id: I9d9f02af7708043fbf80eb04dd12ea57cb4aa628 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-03ofz#33769 Integer-overflowCaolán McNamara
Change-Id: I2f158b1f7c3fdaea00c4334cf3889e0f38674e8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03sw_ww8export: use a template for makefilesXisco Fauli
in order to remove duplicates code Change-Id: Ie107d953d2e7ab4624edccd58fd8637349b9e098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116649 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-03cid#1485166 try and suppress bogus Uninitialized scalar variableCaolán McNamara
Change-Id: I250bb79534610952cc78bb5ab3fc8ab5862723c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03sc: split subsequent modules into smaller partsXisco Fauli
Change-Id: Iee175a064714fa1c7b40c1c450c2fffb59f4fd7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116625 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-03use std::make_unique instead of newCaolán McNamara
Change-Id: Icc5cb2f5fa5720eb9f6e22ec380397bb88542689 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03sw XHTML / reqif export: implement OLE wrapper support for shapesMiklos Vajna
ExportImagesAsOLE=true was only handled for Writer images, not for Draw shapes, fix this. Change-Id: If5018ff4b7c8b303d63a862f7428aa4e8b77d498 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116641 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-06-03vcl: check mpWindowImpl before referencing itGabriel Masei
Fixed some cases generating crashes because mpWindowImpl was not checked for nullptr. Change-Id: I5540f9f21a870b02655b5bf2afdbf3a8153c1519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116330 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-06-03Avoid timeout in bin/oss-fuzz-build.shMarcoFalke
This may fix https://github.com/google/oss-fuzz/issues/5855 A similar recent fix was https://github.com/google/oss-fuzz/pull/5858 It is assumed that the oss-fuzz builder HDD is too slow, leading to a timeout. Fix that by breaking the bash wildcard expansion into a for loop. I did not test this change. Change-Id: I3db367d604c46b3d15c91f530fb103ca005b0bc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116642 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03ofz#34867 TimeoutCaolán McNamara
Change-Id: Ia07b8b4c41233c0f66239d2f37833ddecc0dd278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116640 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03no need to allocate these on the heapNoel Grandin
Change-Id: Ic4b16e776a731e5e9bea61e99acb7257c5220322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116585 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-03external/cairo: Fix previous -fsanitize=alignment fixStephan Bergmann
13f6d80330208eeb45fe9a03bb462941fb4eda2a "external/cairo: Support building with ASan/UBSan" had added the src/cairo-image-source.c blob to external/cairo/cairo/san.patch.0 to fix > > cairo-image-source.c:512:10: runtime error: load of misaligned address 0x6180037aee6f for type 'uint32_t' (aka 'unsigned int'), which requires 4 byte alignment > during UITest_writer_tests7 I had created that patch attempting to do a faithful emulation of the original code (which I had naively assumed to be correct, modulo the alignment issue), reading four consecutive bytes and interpreting them as an uint32_t in the system's byte order. I had not noticed back then that all that CAIRO_FORMAT_RGB24_888 was added by external/cairo/cairo/cairo-1.10.2.patch, introduced with 54596087e57ea533253e19eea594d9b6c06e8d26 "vcl-svp: add 24-bit (3-byte) RGB surface support to Cairo". Its > + * @CAIRO_FORMAT_RGB24_888: each pixel is a 24-bit quantity, > + * with Red, Green, Blue taking 8-bits each, in that order. (Since 1.1x) and > + * Need this until CAIRO_FORMAT_RGB24_888 is in some official release. > + * Otherwise we can't reliably check if this is available or we should > + * convert from 24-bit RGB to 32-bit RGB before passing to Cairo. comments make it sound as if this code might come from some official cairo upstream branch, but I cannot find anything at git.freedesktop.org/git/cairo. I have no idea about the provenance and quality of that code. However, I now (a) from the above comments naively assume that the intent of CAIRO_FORMAT_RGB24_888 is to store R, G, B in that order in three bytes with increasing addresses (i.e., independent of the system's byte order for larger- than-byte words); (b) thus consider the original src/cairo-image-source.c code in external/cairo/cairo/cairo-1.10.2.patch broken (as it attempts to read all three values in one read, in system byte order, which would fail for big endian); and (c) thus consider the faithful emulation code in external/cairo/cairo/san.patch.0 to be broken, too. Based on the above, I here fix at least the external/cairo/cairo/san.patch.0 code (which is applied unconditionally, even for non-ASan/UBSan builds, thus always overriding the original external/cairo/cairo/cairo-1.10.2.patch code). The following line > pixel &= 0x00ffffff; /* ignore next pixel bits */ should no longer be necessary now, and it is probably better to directly fix the original code in external/cairo/cairo/cairo-1.10.2.patch, but I'll leave that for a potential follow-up fix, once the provenance and assumed quality of that original CAIRO_FORMAT_RGB24_888 code is clarified. (I came across this code now with a --without-system-cairo ASan/UBSan Linux build, where JunitTest_toolkit_unoapi_1 failed with > ==1060406==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60300146fb48 at pc 0x7fff9b45b338 bp 0x7ffffffef1d0 sp 0x7ffffffef1c8 > READ of size 1 at 0x60300146fb48 thread T0 > Detaching from process 1060652 > #0 in _pixel_to_solid at workdir/UnpackedTarball/cairo/src/cairo-image-source.c:515:207 > #1 in _pixman_image_for_surface at workdir/UnpackedTarball/cairo/src/cairo-image-source.c:1309:22 > #2 in _pixman_image_for_pattern at workdir/UnpackedTarball/cairo/src/cairo-image-source.c:1574:9 > #3 in _cairo_image_source_create_for_pattern at workdir/UnpackedTarball/cairo/src/cairo-image-source.c:1619:2 > #4 in composite_aligned_boxes at workdir/UnpackedTarball/cairo/src/cairo-spans-compositor.c:678:8 > #5 in clip_and_composite_boxes at workdir/UnpackedTarball/cairo/src/cairo-spans-compositor.c:882:11 > #6 in _cairo_spans_compositor_mask at workdir/UnpackedTarball/cairo/src/cairo-spans-compositor.c:999:14 > #7 in _cairo_compositor_mask at workdir/UnpackedTarball/cairo/src/cairo-compositor.c:106:11 > #8 in _cairo_image_surface_mask at workdir/UnpackedTarball/cairo/src/cairo-image-surface.c:952:12 > #9 in _cairo_surface_mask at workdir/UnpackedTarball/cairo/src/cairo-surface.c:2247:14 > #10 in _cairo_gstate_mask at workdir/UnpackedTarball/cairo/src/cairo-gstate.c:1136:11 > #11 in _cairo_default_context_mask at workdir/UnpackedTarball/cairo/src/cairo-default-context.c:993:12 > #12 in cairo_mask at workdir/UnpackedTarball/cairo/src/cairo.c:2283:14 > #13 in SvpSalGraphics::drawAlphaBitmap(SalTwoRect const&, SalBitmap const&, SalBitmap const&) at vcl/headless/svpgdi.cxx:745:5 > #14 in SalGraphics::DrawAlphaBitmap(SalTwoRect const&, SalBitmap const&, SalBitmap const&, OutputDevice const&) at vcl/source/gdi/salgdilayout.cxx:832:16 > #15 in OutputDevice::DrawDeviceAlphaBitmap(Bitmap const&, AlphaMask const&, Point const&, Size const&, Point const&, Size const&) at vcl/source/outdev/bitmap.cxx:704:29 > #16 in OutputDevice::DrawDeviceBitmap(Point const&, Size const&, Point const&, Size const&, BitmapEx&) at vcl/source/outdev/bitmap.cxx:516:9 > #17 in OutputDevice::DrawBitmapEx(Point const&, Size const&, Point const&, Size const&, BitmapEx const&, MetaActionType) at vcl/source/outdev/bitmap.cxx:391:9 > #18 in OutputDevice::DrawBitmapEx(Point const&, Size const&, BitmapEx const&) at vcl/source/outdev/bitmap.cxx:292:9 > #19 in OutputDevice::DrawTransformedBitmapEx(basegfx::B2DHomMatrix const&, BitmapEx const&, double) at vcl/source/outdev/bitmap.cxx:1315:9 > #20 in drawinglayer::processor2d::VclProcessor2D::RenderBitmapPrimitive2D(drawinglayer::primitive2d::BitmapPrimitive2D const&) at drawinglayer/source/processor2d/vclprocessor2d.cxx:394:21 > #21 in drawinglayer::processor2d::VclPixelProcessor2D::processBitmapPrimitive2D(drawinglayer::primitive2d::BitmapPrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:524:5 > #22 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:252:13 > #23 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:69:25 > #24 in drawinglayer::processor2d::VclProcessor2D::RenderTransformPrimitive2D(drawinglayer::primitive2d::TransformPrimitive2D const&) at drawinglayer/source/processor2d/vclprocessor2d.cxx:912:5 > #25 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:317:13 > #26 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:69:25 > #27 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:46:13 > #28 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:434:13 > #29 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:69:25 > #30 in sdr::contact::ObjectContactOfPageView::DoProcessDisplay(sdr::contact::DisplayInfo&) at svx/source/sdr/contact/objectcontactofpageview.cxx:279:31 > #31 in sdr::contact::ObjectContactOfPageView::ProcessDisplay(sdr::contact::DisplayInfo&) at svx/source/sdr/contact/objectcontactofpageview.cxx:116:21 > #32 in SdrPageWindow::RedrawAll(sdr::contact::ViewObjectContactRedirector*) at svx/source/svdraw/sdrpagewindow.cxx:353:28 > #33 in SdrPageView::CompleteRedraw(SdrPaintWindow&, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at svx/source/svdraw/svdpagv.cxx:239:18 > #34 in SdrPaintView::DoCompleteRedraw(SdrPaintWindow&, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at svx/source/svdraw/svdpntv.cxx:606:21 > #35 in SdrPaintView::CompleteRedraw(OutputDevice*, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at svx/source/svdraw/svdpntv.cxx:519:5 > #36 in sd::View::CompleteRedraw(OutputDevice*, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at sd/source/ui/view/sdview.cxx:475:17 > #37 in sd::DrawView::CompleteRedraw(OutputDevice*, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at sd/source/ui/view/drawview.cxx:520:21 > #38 in sd::DrawViewShell::Paint(tools::Rectangle const&, sd::Window*) at sd/source/ui/view/drviews5.cxx:420:17 > #39 in sd::Window::Paint(OutputDevice&, tools::Rectangle const&) at sd/source/ui/view/sdwindow.cxx:212:22 > #40 in PaintHelper::DoPaint(vcl::Region const*) at vcl/source/window/paint.cxx:313:20 > #41 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) at vcl/source/window/paint.cxx:616:17 > #42 in PaintHelper::~PaintHelper() at vcl/source/window/paint.cxx:552:30 > #43 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) at vcl/source/window/paint.cxx:622:1 > #44 in PaintHelper::~PaintHelper() at vcl/source/window/paint.cxx:552:30 > #45 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) at vcl/source/window/paint.cxx:622:1 > #46 in PaintHelper::~PaintHelper() at vcl/source/window/paint.cxx:552:30 > #47 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) at vcl/source/window/paint.cxx:622:1 > #48 in PaintHelper::~PaintHelper() at vcl/source/window/paint.cxx:552:30 > #49 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) at vcl/source/window/paint.cxx:622:1 > #50 in vcl::Window::PaintImmediately() at vcl/source/window/paint.cxx:1325:24 > #51 in vcl::Window::PaintImmediately() at vcl/source/window/paint.cxx:1269:39 > #52 in SvImpLBox::MyUserEvent(void*) at vcl/source/treelist/svimpbox.cxx:3063:18 > #53 in SvImpLBox::LinkStubMyUserEvent(void*, void*) at vcl/source/treelist/svimpbox.cxx:3057:1 > #54 in Link<void*, void>::Call(void*) const at include/tools/link.hxx:111:45 > #55 in ImplHandleUserEvent(ImplSVEvent*) at vcl/source/window/winproc.cxx:1991:30 > #56 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at vcl/source/window/winproc.cxx:2561:13 > #57 in SalFrame::CallCallback(SalEvent, void const*) const at vcl/inc/salframe.hxx:306:29 > #58 in SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) at vcl/headless/svpinst.cxx:312:22 > #59 in non-virtual thunk to SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) at vcl/headless/svpinst.cxx (instdir/program/libvcllo.so +0xae7a222) > #60 in SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const at vcl/source/app/salusereventlist.cxx:119:58 > #61 in SalUserEventList::DispatchUserEvents(bool) at vcl/source/app/salusereventlist.cxx:120:13 > #62 in SvpSalInstance::DoYield(bool, bool) at vcl/headless/svpinst.cxx:461:19 > #63 in ImplYield(bool, bool) at vcl/source/app/svapp.cxx:465:48 > #64 in Application::Yield() at vcl/source/app/svapp.cxx:532:5 > #65 in Application::Execute() at vcl/source/app/svapp.cxx:444:9 > #66 in desktop::Desktop::Main() at desktop/source/app/app.cxx:1587:13 > #67 in ImplSVMain() at vcl/source/app/svmain.cxx:198:35 > #68 in SVMain() at vcl/source/app/svmain.cxx:230:12 > #69 in soffice_main at desktop/source/app/sofficemain.cxx:98:12 > #70 in sal_main at desktop/source/app/main.c:49:15 > #71 in main at desktop/source/app/main.c:47:1 > #72 in __libc_start_main at /usr/src/debug/glibc-2.33-8.fc34.x86_64/csu/../csu/libc-start.c:332:16 > #73 in _start at <null> (instdir/program/soffice.bin +0x251acd) > > 0x60300146fb48 is located 0 bytes to the right of 24-byte region [0x60300146fb30,0x60300146fb48) > allocated by thread T0 here: > #0 in operator new[](unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:102:3 > #1 in ImplCreateDIB(Size const&, vcl::PixelFormat, BitmapPalette const&) at vcl/headless/svpbmp.cxx:126:24 > #2 in SvpSalBitmap::Create(Size const&, vcl::PixelFormat, BitmapPalette const&) at vcl/headless/svpbmp.cxx:156:13 > #3 in Bitmap::Bitmap(Size const&, vcl::PixelFormat, BitmapPalette const*) at vcl/source/bitmap/bitmap.cxx:135:15 > #4 in Bitmap::Crop(tools::Rectangle const&) at vcl/source/bitmap/bitmap.cxx:489:20 > #5 in BitmapEx::Crop(tools::Rectangle const&) at vcl/source/bitmap/BitmapEx.cxx:360:25 > #6 in drawinglayer::primitive2d::DiscreteShadow::getLeft() const at drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx:148:61 > #7 in drawinglayer::primitive2d::DiscreteShadowPrimitive2D::create2DDecomposition(drawinglayer::primitive2d::Primitive2DContainer&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx:251:72 > #8 in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/baseprimitive2d.cxx:122:9 > #9 in drawinglayer::primitive2d::DiscreteMetricDependentPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/primitivetools2d.cxx:48:47 trying to read the fourth byte of a presumed uint32_t starting at offset 21 of a 24-byte buffer.) Change-Id: Ibe8bc39e3736c64ace61af2217100c9d8bb96d5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116637 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-03sw: rename some variable/method names in html import/exportTomaž Vajngerl
Rename to "default" instead of "dflt", "start" instead of "stt", "content" instead of "cnt",.... The shorter names are a product of utter laziness. Change-Id: I5f5c8f6504e788395db495c000c098401767f8a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116628 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-03Revert "Initialize vector directly with the already known count number"Julien Nabet
This reverts commit da9fe0da11687bfc4c0eff2197286da67d6206c2. Reason for revert: wrong result since there'll be first 4 by default initializations then an extra reserve allocation. Change-Id: If480243e81db405d6a984b8450a219e486f1a1ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116465 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-06-03svx: remove pdfium dependencyMiklos Vajna
This is no longer needed, we only call VCL functions in svx/ today. Change-Id: I741ed9bc4c66067ea423211b8f16305b0e4099fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116622 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-02Initialize vector directly with the already known count numberJulien Nabet
instead of initializing an empty vector then reserve a fixed value Change-Id: Iccddda05b3dd98aa9c25a61637ece7af4d42d72f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116624 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-02Update git submodulesStanislav Horacek
* Update dictionaries from branch 'master' to 29eb2930309a484a6090c474353f99a2c01d1703 - Czech Hunspell: remove confusing surname Change-Id: I5ac78be61cacdf05dd804240355ea828de722f24 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116626 Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com> Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
2021-06-02Update git submodulesStanislav Horacek
* Update dictionaries from branch 'master' to 412f5dd223df85956dc38f429733e7972d496391 - Czech Hunspell: remove rule based on circumfix and make other updates the rule does not produce correctly capitalized results minor updates of word list all changes suggested by Miroslav Pošta Change-Id: I1ecfd7ea6daaf155228bd2405708fb097fa07997 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116281 Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com> Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
2021-06-02Update git submodulesStanislav Horacek
* Update dictionaries from branch 'master' to 5ae65ee9e7f1dac860be57901c62d97d887a9564 - Czech Hunspell: use KEY and update TRY in .aff file for TRY character frequencies were employed Change-Id: I46a1680c10dd49af2f15984bafe686ff69757071 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116280 Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com> Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
2021-06-02Update git submodulesStanislav Horacek
* Update dictionaries from branch 'master' to 27e7425c295cb84a18e4d0d2711ef4f96ee7551f - Czech Hunspell: remove duplicates Change-Id: I90ca35378ad60768d6636193462fa307e9ac91a4 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116279 Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com> Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
2021-06-02Update git submodulesStanislav Horacek
* Update dictionaries from branch 'master' to ab4b942707da889d30cea157838ba90fb114e5f5 - more updates of Czech Hunspell done also by Miroslav Pošta Change-Id: Ie08fb39f7252d1473bd27c55f90c1d765d1abf8e Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116278 Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com> Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
2021-06-02Update git submodulesStanislav Horacek
* Update dictionaries from branch 'master' to cd451382d714a202638fcb9f0687d6d1b52a212d - update Czech Hunspell files both word list and affixes improved significantly by Miroslav Pošta details added to readme this version corresponds with the version published at translatoblog.cz Change-Id: Ie9c137c3c652a29648177ed0d88a918acb2bbad8 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116277 Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com> Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
2021-06-02gtk4: get fancy blue "suggested-action" button for Print in print dialogCaolán McNamara
Change-Id: I60edccc6bb1a5cbbb615ad7be221158ee243f37b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116623 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02Re-enable part of testTdf108963 on WindowsMike Kaganski
This partially reverts a2c665e4dd73007fe7f0eda2de31db8b768f1df9, the expectation is that following pdfium updates have fixed the problem that caused failures workarounded by that commit. Change-Id: Ia2633f966f77c1e9e51f2f8595d7ca62bae78dec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116464 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-02gtk4: supplement GtkEntry width-chars with additional max-width-charsCaolán McNamara
Change-Id: I69b51be8d565636618ab8fb9fd254adb3b4def10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116621 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02gtk4: adjust print dialog to position page navigation buttons as wantedCaolán McNamara
Change-Id: Ifbd69faa0e69831ad93a2393234e2d97bdd6f4e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116620 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02add explicit expandsCaolán McNamara
Change-Id: Ic62c05487bd77831b1a15e8601c6ba5bb1c7e001 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116619 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02fix shutdown leak in CppunitTest_sw_filters_testNoel Grandin
of GenericUnixSalData Change-Id: I4201d617fa4618fc0be58dcf4d1279e0b60e2dcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116582 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-02Merging an unsupported formula grammar is worth a real assert()Eike Rathke
Change-Id: I9bce5bc590e3348d1fb0c81a9ec74cec2944d38a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116617 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-06-02WMF: add more SAL warnings in case record was not implementedBartosz Kosiorek
Change-Id: I1d58c4093817403caa5f1112b5d4d5a4e638b799 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116618 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-06-02fix: extend the primitive dump, with information about line cap and jointBartosz Kosiorek
Change-Id: I5c67d360236ec67c41bc45a9018f0ff0d0ec1d3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116611 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-06-02gtk4: reenable cluster of working printing related dialogCaolán McNamara
Change-Id: I8f6b2403475ada04432f4f6e27fcf537e116033c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116616 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02uniformly remove label-fill from GtkExpandersCaolán McNamara
Change-Id: Ife68cef7eeab0010c4d233c81e3bee808c2c1c28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116615 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-16 06:13:10 +0000