summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-01-18No need to loop twice on the same tokensMatteo Casalin
Change-Id: If1ef69d537c67bf0e6f9f5236ce97b1264e82c51 Reviewed-on: https://gerrit.libreoffice.org/66236 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-18Use indexed getToken, avoid unnecessary OUString copyMatteo Casalin
Change-Id: I2ce2d16c24f7fd90c7ba16175ea99f7e1cb46fc9 Reviewed-on: https://gerrit.libreoffice.org/66233 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-18Avoid getToken index for single call, minor simplificationMatteo Casalin
Change-Id: If9ec36565cf42d11a0e1715f4aac28c365843a56 Reviewed-on: https://gerrit.libreoffice.org/66226 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-18tdf#105225 New background tab page for Search for formatting dialogJim Raykowski
Change-Id: I3642ea9e474c06943ea8bfb88e4209749db1fd83 Reviewed-on: https://gerrit.libreoffice.org/66578 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-18Remove werdly duplicated stringAdolfo Jayme Barrientos
It’s a label for a combo box in the Font Features dialog, so give it appropriate text and a colon. Change-Id: I2403b77283eef118d2e7701dfdcbe190fe504f36
2019-01-18oox smartart, org chart: fix shape type of connectorsMiklos Vajna
PowerPoint renders these as bent connectors, not as arrow shapes. Also add a bit of vertical spacing between the nodes, otherwise the connectors have no way to be visible. Their position is still incorrect, though. Change-Id: I995930c0bbc1bdb1014face2490be392571548a2 Reviewed-on: https://gerrit.libreoffice.org/66627 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-18tdf#122031 Export number format of chart label to OOXML Gülşah Köse
The patch fixes missing numFmt. numFmt element has been added as child under the dLbl element. Change-Id: Ic81ac58c2ea087cd7599351034eb4298ee613843 Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/66493 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2019-01-18tdf#104816 sw: if non-section content, let all sections hide.Justin Luth
If all of the document is contained inside of sections, then at least one section must be visible or writer crashes. The 2012 fix seemed to assume that all content would be in a section, and thus required at least one section be visible. Instead, check for non-section content at the start and end of the document, and for gaps between sections, and count those as "virtual", visible sections, which would allow all real sections to be marked as hidden. The example document HiddenSection.odt in tdf#55814 is a really nice test document. With this patch, that test now works even if you remove the last non-section paragraph. Even nicer is finding that a (very unclear) "did you fix me?" unit test entry gives a unit test for patch. Change-Id: I6cac5e6df8dff7fbb78828ae2521a1b02e305a27 Reviewed-on: https://gerrit.libreoffice.org/66128 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-18tdf#120836 KDE5: allow adding multiple mime types to clipboardAleksei Nikiforov
Also correct processing "text/html" and "image/png" mime types to fix slow select in Calc: if both "text/html" and "image/png" mime types were present, "image/png" data was requested, but it was processed as if it was "text/html" data. Change-Id: Ie192fff06cd9de28f466547dac32343620fe2730 Reviewed-on: https://gerrit.libreoffice.org/66576 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-18oox smartart, org chart: implement support for hierBranch conditionsMiklos Vajna
The relevant part of the layout is the <dgm:layoutNode name="hierChild2"> element that has a <dgm:choose> with two branches: <dgm:if name="Name34" func="var" arg="hierBranch" op="equ" val="std"> <dgm:if name="Name36" func="var" arg="hierBranch" op="equ" val="init"> The connectors were missing as we took the first branch (ConditionAtom::getDecision() returned true if the arg was hierBranch), even hierBranch on the parent layout node was set to "init". With this, the correct number of connectors are created, previously all employee connectors were missing. Their size / position is still incorrect, though. Change-Id: I74a705b13f82a065fc0b9b9d306bfb0dcaf0f7f4 Reviewed-on: https://gerrit.libreoffice.org/66579 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-18Resolves tdf#122118 - Toolbar dropdown button triangles are too largeheiko tietze
Toolbar expander triangles are now scaled depending on the parent size Change-Id: I4974c0976c1591fc09594bf4aeca020a72ebf11a Reviewed-on: https://gerrit.libreoffice.org/66565 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-01-18Ensure itemset ranges are sortedMike Kaganski
What used to create sorted range automatically in FID_SEARCH_SEARCHSET handler in SwView::ExecSearch, over time turned into unsorted. this prevents using MergeRange on the sets created from the range list; see https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/24448/consoleFull > svl/source/items/itemset.cxx:641: > void SfxItemSet::MergeRange(sal_uInt16, sal_uInt16): > Assertion `!pRange[2] || (pRange[2] > pRange[1] && pRange[2] - pRange[1] > 1)' failed. So let's just use MergeRange in the SwView::ExecSearch itself, which would ensure early detection if the initial list gets unsorted. Change-Id: Id0232190f850e3feb463adfcb3153eafbaad7d9b Reviewed-on: https://gerrit.libreoffice.org/66607 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-18tdf#122800 Chart view: Textbreak of X axis labelsBalazs Varga
Do not break the word into individual letters below each other in the X axis labels. Keep the default 45 degree (even if the textbreak is true) rotation if there is no enough space for a single word between two tickmark. Change-Id: I6f11e55b7ee8373210c1c417e64d552a6cd89812 Reviewed-on: https://gerrit.libreoffice.org/66580 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-18tdf#107792 vcl/win: introduce ScopedHBITMAPDmitriy Shilin
Change-Id: I2af507d9b924644d3a0e8a4bf2e92ca4b8a9a1b4 Reviewed-on: https://gerrit.libreoffice.org/65929 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-18lok sw: When inserting shapes, do that in the middle of the visible area.Jan Holesovsky
Instead of in the middle of the entire document, which may be far away. Change-Id: I50a1a5f159b73a3803cd7a549939b73a366e7dc5 Reviewed-on: https://gerrit.libreoffice.org/66584 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-01-18tdf#107792 vcl/win: introduce ScopedSelectedHBRUSHDmitriy Shilin
Change-Id: I39792ce8442f9e7776b44a489b3c15b908e2f773 Reviewed-on: https://gerrit.libreoffice.org/66253 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-18lok: Make the welded Watermark dialog work with dialog tunneling.Mert Tumer
Change-Id: Ib5acd6fe4838aa09b74333c46cf38b9e0a926682 Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/66555 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-01-18Resolves: tdf#120745 - Firefox themes UIheiko tietze
Indent the images of the preinstalled theme Change-Id: I9f4b250ba6eb7663e0631a983244311c08646274 Reviewed-on: https://gerrit.libreoffice.org/66583 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-01-18tdf#107792 vcl/win: introduce ScopedSelectedHFONTDmitriy Shilin
Change-Id: If06ef869fc68976ee3ac6e671edd1bb4f992e716 Reviewed-on: https://gerrit.libreoffice.org/65964 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2019-01-18Update git submodulesRoman Kuznetsov
* Update helpcontent2 from branch 'master' - tdf#122448 Changing of Help for changings in GUI Change-Id: I02175966fc8a964db943585133b2a966d1772ab6 Reviewed-on: https://gerrit.libreoffice.org/66406 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-18use unique_ptr in SwTextNodeNoel Grandin
Change-Id: I4962d3480e9318c02d5cb8f031c0fcb1ab19208d Reviewed-on: https://gerrit.libreoffice.org/66570 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Jenkins
2019-01-18use unique_ptr in SwCursorMoveStateNoel Grandin
Change-Id: I39e67d24a38df71309f5cb4a82165c14e5640556 Reviewed-on: https://gerrit.libreoffice.org/66569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18use unique_ptr in SmXMLExportNoel Grandin
Change-Id: I081ef638f35fb47f1ca2705eff53fc27f1900008 Reviewed-on: https://gerrit.libreoffice.org/66572 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18Related: tdf#122786 update value when spinbutton text explicitly setCaolán McNamara
Change-Id: Idb6fefe08dc7cbf4d0b73485e0b1471fe0494364 Reviewed-on: https://gerrit.libreoffice.org/66544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-18pass SvxMSDffImportRec around using unique_ptrNoel Grandin
Change-Id: Ib2a93682f6d2745489e07cf04e3509146213c7ee Reviewed-on: https://gerrit.libreoffice.org/66571 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18convert MoveDirection to scoped enumNoel Grandin
Change-Id: I077604051af8af05a3a6ea278d7164d39303f09f Reviewed-on: https://gerrit.libreoffice.org/66568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18Resolves tdf#122637 - Disabled controls in Outline & Numbering unclearheiko tietze
Tooltip added Change-Id: I4e92dc1be5bb5e864f5a10f62fd65ba1494cab6c Reviewed-on: https://gerrit.libreoffice.org/66575 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-01-18use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Change-Id: I4c16fd221f7ec3693e37bacf3fdf7026a8c2e8bc Reviewed-on: https://gerrit.libreoffice.org/66574 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18vcl: LOK: notify of dialog creation before size changeAshod Nakashian
Notifying the size change of a non-existing dialog is worse than useless. This also fixes the issue with positioning dialogs in the center of the client window. Change-Id: I2e8163f4c5a0a09f79ea11c704c250b17a158948 Reviewed-on: https://gerrit.libreoffice.org/66511 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-01-18In vcl/unx/generic/print/, use OStringBuffer instead of fixed-size arraysStephan Bergmann
...to avoid potential overflow in psp::appendStr as reported by GCC with --enable-optimized: > vcl/unx/generic/print/psputil.cxx: In function ‘sal_Int32 psp::appendStr(const sal_Char*, sal_Char*)’: > vcl/unx/generic/print/psputil.cxx:127:13: error: ‘char* strncpy(char*, const char*, size_t)’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=] > strncpy (pDst, pSrc, nBytes + 1); > ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ > vcl/unx/generic/print/psputil.cxx:126:31: note: length computed here > sal_Int32 nBytes = strlen (pSrc); > ~~~~~~~^~~~~~ Most of the time the original code wrote at the "end" of its char array, so replacements with functionality based on OStringBuffer::append was straightforward. A few places needed to use OStringBuffer::insert to mimic the original code's writing at somewhat random positions in the char array. The functions now taking an OStringBuffer argument still return the amount of characters written. Even if that information would (indirectly) also be available as part of the OStringBuffer's state, keeping the (somewhat redundant now) counting of positions in the calling code should help avoid regressions. Some of the code may be simplified in follow-up commits, dropping the external counting. The original psp::getValueOfDouble is still used elsewhere, so leave it alone for now and add an OStringBuffer overload. Change-Id: I2bb5d51505ca70cba485e6843183496ea3a4ce18 Reviewed-on: https://gerrit.libreoffice.org/66564 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-18convert StockVariant to scoped enumNoel Grandin
and simplify naming Change-Id: Ieada4e83fcc2eafd03f65b1216bf5ad026ced4c7 Reviewed-on: https://gerrit.libreoffice.org/66567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' - Python Help page for screen IO Change-Id: I0a1fc11a23c6f48eb058d42541e1f22c57ddb26d Reviewed-on: https://gerrit.libreoffice.org/66442 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#121781 Clarify TZ info in Calc functions Notify user that TZ are not considered in date & time functions and in date & time formatted cells. Change-Id: I684039ebcc095fe4eefc2bf573df18679dd7f9f3 Reviewed-on: https://gerrit.libreoffice.org/66468 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#122631 Describe Shift+F5 in Writer Change-Id: I2191fa502c0db26854c10cff4a6e5f2b094a8557 Reviewed-on: https://gerrit.libreoffice.org/66087 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-18Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - minor correction Change-Id: Ia986be35c2805f2ed82f9d148702a87fa5537d20 Reviewed-on: https://gerrit.libreoffice.org/66573 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-18convert some enums to scopedNoel Grandin
Change-Id: Ib381bb24abb4bf09c87d9fa372374ce133cb7848 Reviewed-on: https://gerrit.libreoffice.org/66566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18o3tl::make_unique -> std::make_unique in chart2...cuiGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: I2ba0b9b44971166bd79527b52745f3c40dc14387 Reviewed-on: https://gerrit.libreoffice.org/66490 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18PortionType::Url is unusedNoel Grandin
ever since commit 1b666235f6b0b0f0b13f473bf3b639f4f5f0b12f Date: Wed Jan 3 09:08:52 2018 +0200 loplugin:singlevalfields improve copy constructor check Change-Id: Ic17182c8abc29488ae2e1004d9fb4e8b8b7f623b Reviewed-on: https://gerrit.libreoffice.org/66515 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18tdf#42949 Fix remaining IWYU warnings in include/vcl/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Some new headers were added since I begun the cleanup here Also blacklist the header from commit 403e3c04420c4d20c77427c43df52d554d7329ff Change-Id: Ie2358d5e27297f873aeb4a4dfb2778e6fb95dfa5 Reviewed-on: https://gerrit.libreoffice.org/66255 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-18CppunitTest_xmlsecurity_pdfsigning: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: Ia1ed6989737b765f2e4332f402fb5c11ef7f0f31 Reviewed-on: https://gerrit.libreoffice.org/66553 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-18Add XDDELinks tests to ScDDELinksObjJens Carl
Change-Id: I9e6efbd5a1cd9e4787e8143dd4f8adbe6ab2cae7 Reviewed-on: https://gerrit.libreoffice.org/66561 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-18Add aCalcPageSize and aCalcPagePos properties to ScModelObj::getRendererMuhammet Kara
So that we can adjust page offset when outputting to GDIMetaFiles Change-Id: I1c28440a1ff62a879b6341748a6d3092f2bfda96 Reviewed-on: https://gerrit.libreoffice.org/66526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18update useunique_ptr lopluginNoel Grandin
with more exclusions Change-Id: I95e7376ecf9c479d05b85c71f863d9ba40417538 Reviewed-on: https://gerrit.libreoffice.org/66552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18use unique_ptr in SwAttrSetNoel Grandin
Change-Id: I8b30b76a0c45c8262bf03022c62639be86620bf9 Reviewed-on: https://gerrit.libreoffice.org/66551 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18use unique_ptr in starmathNoel Grandin
Change-Id: Ib9c555507d5271343424686f2321ae13efcbf41a Reviewed-on: https://gerrit.libreoffice.org/66550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18use unique_ptr in scNoel Grandin
Change-Id: I14ccb215e895b607c7244b420ee2cbaea8112b15 Reviewed-on: https://gerrit.libreoffice.org/66549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18convert POR constants to scoped enumNoel Grandin
Change-Id: Ia146f1f932cf4437e2e7e20722b0957a458979fd Reviewed-on: https://gerrit.libreoffice.org/66514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18Fix typoAndrea Gelmini
Change-Id: I80e83c04f3001fefad6cbdffc19ce8e05272dc88 Reviewed-on: https://gerrit.libreoffice.org/66562 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-18Base/Mysqlc: fix schemas retrievingJulien Nabet
Change-Id: Ib0bd600aed3c3394890a199d105aff17cd547200 Reviewed-on: https://gerrit.libreoffice.org/66554 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2019-01-18Add XServiceInfo tests to ScDDELinksObjJens Carl
Change-Id: Iacd44465e4b4b3a1a6657abcf274ffe7f8eb808b Reviewed-on: https://gerrit.libreoffice.org/66560 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
generated by cgit (git 2.34.1) at 2025-02-25 10:00:58 +0000