summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-04-11Get rid of apache-commons-loggingStephan Bergmann
...using Java 1.4 java.util.logging.Logger instead also for the last remaining uses in reportbuilder. (The mention in swext/mediawiki/src/THIRDPARTYLICENSEREADME.html was presumably a leftover from 4b6ceed4a4a9b152905a8b1712ffb9bd61373c16 "swext: Wiki Publisher does not use those apache-commons libraries".) Change-Id: Ia0bc598fe5844ced11cae497548ec7d09453a99d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113939 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-11Sukapura: tdf#141618 fix blured vertical line of Sukapura's anchor markerRizal Muttaqin
Change-Id: I11b3fca85ec00049dfe84df6cfb548a320e255cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113937 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-11Update git submodulesCarmen Bianca Bakker
* Update dictionaries from branch 'master' to 96ecb3d82f441c8ba38e7f773c5941e502acaf1c - Add Esperanto dictionary Signed-off-by: Carmen Bianca Bakker <carmen@carmenbianca.eu> Change-Id: I1852b0eedc9b397c43f213dab60ff08e44b01678 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/110415 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-04-11Fix typoAndrea Gelmini
Change-Id: I197ccc8f24cae23c7056245b009f1aac90895040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113940 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-04-11Apache Commons Codec/HttpClient/Lang are no longer bundledStephan Bergmann
...ever since a41a4a22f1a7e82ab64f28b71f5ce6acc1c04921 "remove now unneeded apache-commons libs" Change-Id: I197063d6a2f34d4800383ead1f55da47054e67af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113831 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-11Colibre: Revise some bullet/numbering iconsRizal Muttaqin
Change-Id: I6ff3e82cc02272e10314cc92e6ee584fcc50724c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113934 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-11tdf#141600 fix blured vertical line of Colibre anchor markerRizal Muttaqin
Change-Id: I5acab0328fd40e7eb4043a77197d78925c38237a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113933 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-10vcl: allow for overriding the default PDF rendering resolutionAshod Nakashian
Change-Id: Ibd75c6dd71d93322bd77995547e735c2d4849602 Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113223 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-04-10Quote literals in {ja-JP} date and time format codesEike Rathke
Because when loading number formats from ODF literal text is enquoted that resulted in duplicated formats that differed only in quoted literals vs unquoted literals with identical functionality, but unnecessarily polluting the number formats list. Since commit 5d1042cbd25b22babaf8b30bc4edff6f70750b5e CommitDate: Sat Apr 10 03:49:37 2021 +0200 ODF load: use AAA/AAAA instead of NN/NNN(N) for implicit secondary calendar these predefined format codes now load actually identical. Change-Id: I02b5367ecd8ddab4419a56ba4d1c3ac4233142b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113925 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-04-10use std lib for sal_Unicode version of indexOfChar_WithLengthNoel Grandin
if possible, which will probably have a better word-at-a-time algorithm. Change-Id: Ia338a0aad81ef450d482701139f131d6d577b737 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113922 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10Related: cid#1474351 Untrusted loop boundCaolán McNamara
we read 6 bytes per loop but the guard is for 2 bytes available (which is the correct amount for for the ImportExcel::Mulblank case but presumably should be 6 for ImportExcel::Mulrk) Change-Id: Iba9c59c042c6fdd9794107e95c024f1763337186 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113928 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-10use std lib for O[U]String indexOfStrNoel Grandin
if possible, which will probably have faster implementations. Change-Id: I403d4c3c0f5407412a2284a90fd5abc083881d18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10speed up XmlReader::handleSkippedTextNoel Grandin
this part of config loading is fairly hot at startup, so inlining this memchr call from rtl_str_indexOfChar_WithLength shaves off 2% of my load time. Change-Id: Ia79f43179475c51d856b685f053f597919cf12af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113924 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10Related tdf#117750: fix "Solarization" and "Aging"Julien Nabet
For solarization, regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=c38485279cd36da96ac81107d567ea4e779b2b96 author Chris Sherlock <chris.sherlock79@gmail.com> 2018-04-20 20:27:41 +1000 committer Tomaž Vajngerl <quikee@gmail.com> 2018-04-22 05:33:11 +0200 commit c38485279cd36da96ac81107d567ea4e779b2b96 (patch) tree ad9843a17f87271f9e0cf89643e2e6c3ee8a8de1 parent bcbf767bcfc024e2be839e0c0886f942dd068e4f (diff) vcl: ImplSolarize() to BitmapSolarizeFilter For aging, regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=1ab12471f3a69c4d502e6271e84ddf8a981f507f author Chris Sherlock <chris.sherlock79@gmail.com> 2018-04-20 20:32:23 +1000 committer Tomaž Vajngerl <quikee@gmail.com> 2018-04-22 05:33:39 +0200 commit 1ab12471f3a69c4d502e6271e84ddf8a981f507f (patch) tree 6652276229ad1c3ffca48f7a31e1b77d2ea04b07 parent c38485279cd36da96ac81107d567ea4e779b2b96 (diff) vcl: ImplSepia -> BitmapSepiaFilter Change-Id: I4f350aa8b494caf55c9c810ac7fa9ed8db349725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113926 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10Related tdf#117750: fix UnsharpenFilterJulien Nabet
Change-Id: I372bb6baae747adb3b2d2a2b8fd39d1631b074ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113927 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10ofz#32973 Integer-overflowCaolán McNamara
Change-Id: Ib290468b4c7388b80da627138435b98feaed354b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-10tdf#120761 doc import: fix z-order background logicJustin Luth
At first I thought I didn't need to jump past the hell layer, but then a good night of sleep told me I better revisit this, and test a few a my assumptions. Unfortunately, I don't know how to design a test document with the specific order I would need to test this. So I had to settle for proving it on paper. I did confirm that BodyText in the background is still higher than header text in the foreground, so indeed the header is always the lowest position. Change-Id: I2054c8fc3ec1e1e7a211397cebe9aff145d701be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113906 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-04-10cid#1476017 Dereference after null checkCaolán McNamara
Change-Id: Icd991bb20dc3aa96041f6a432bddf1bb2775f371 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113907 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-10use systemd-detect-virt to detect building as root in containerCaolán McNamara
Drop the older container detection attempts because they are not reliable to detect being run as root in a container in github actions. <cloph> https://github.com/google/oss-fuzz/issues/4093#issuecomment-656290094 "It appears some GitHub actions are run with docker.service (where docker is in /proc/self/cgroup) while the zstd actions are run with containerd.service where /proc/self/cgroup looks like […]" <cloph> https://github.com/google/oss-fuzz/pull/4101 → probably also just use systemd-detect-virt instead of the grepping ourselves... if we're root and systemd-detect-virt doesn't exist or it claims we're not in a container then continue to abort the build using LIB_FUZZING_ENGINE for the oss-fuzz specific case worked fine, but lets try something a little more generic. Change-Id: I59711b01dfcd052b5af899ad41ae5890f849eacb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113738 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-10tdf#130326 related, speed up drawingNoel Grandin
if we create the list every time we call ViewContact::getViewIndependentPrimitive2DContainer then caching the result is rather worthless. So make the caching worthwhile, which means invalidating it when something changes. Change-Id: I081e9501255ec1c87454bfcc1e0a741109afa99f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113891 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10tdf#130326 speed up XLSX loadNoel Grandin
cuts time from 35s to 25s for me. If the model is locked, we should not be broadcasting events. Change-Id: I4d8ca10c9d2a9862b30f88cc00e65aab1e2fad7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113909 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10ScriptForge - (scriptforge.py) FormControl classJean-Pierre Ledure
New class to manage controls in forms and subforms from Python, essentially thru the use of Properties Required a review of SF_FormControl.Getproperty() Indeed, the IDE debugger computes all the properties of a Basic object when expanded in the watch window. This can cause errors. This class makes use of default values for properties when irrelevant for the actual control type Error were detected on date/time conversions of date/timefield controls and corrected. SF_String etc shortcuts have been removed (see previous commit) because not applicable in every scenario. The only entry point to the API from a user Python script is via CreateScriptService(). Change-Id: Ia87c7281c3fcf39ab0c3528f00114c9b1e067bcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113920 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-04-10cid#1474380 silence Untrusted loop boundCaolán McNamara
Change-Id: Ic162a5aeed4b422a8db5ff1bdd89c4e098ffa248 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113908 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-10tdf#130326 speed up opening XLSXNoel Grandin
SvxShape::Notify is called a lot (26%) of CPU, so re-arrange it to do the cheapest checks first. Change-Id: I0e6c6c976ecfe7670e8d4af175606654f839aa66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10-werror=maybe-uninitializedNoel Grandin
Change-Id: Iaa1905d181bc6dc86988c68a145d5d8fce11cda9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113904 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10tdf#141195:fix button text color with default background colorbykivi
Change-Id: I2f30282e5e1f5e303be2802529f693be4968620d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112989 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-04-10Resolves: tdf#139075 diagonal focus rects contain focus rects of old sizeCaolán McNamara
since... commit 356f6c5d89dd4dd92b2351898e07f99b96cb34cc Date: Tue Jan 15 08:55:00 2013 +0000 teach FrameSelector to be resizable Change-Id: I5ac4d1d12f60086349e7dbb3b78d29977f22c226 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113894 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-10Fix typo in codeAndrea Gelmini
To complete commit: 7c6605bd2c1b Typos in code with variables containing "inital"->"initial" https://gerrit.libreoffice.org/c/core/+/113823 Change-Id: I5874af4c18d460b81f99ecee7034df2d2829bad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113876 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-04-10ODF load: use AAA/AAAA instead of NN/NNN(N) for implicit secondary calendarEike Rathke
For example ja-JP Gengou calendar. NN/NNN always worked because ja-JP Gregorian calendar defines the same day of week names so it never was apparent. Change-Id: Ief0d7ce7532b7ed7d58910bf150b190b7872db28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113900 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-04-09check-missing-unittests: ignore accessibility bugs for nowXisco Fauli
Change-Id: I4fe5ec4a05d841c1c3486d2f80e7220dc0a99c80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113892 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-09sw_layoutwriter: fix assertXisco Fauli
Change-Id: Iddd6271c70bebe0b2b146509f6603e0a43fda4d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113890 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-09remove vcl/waitobj.hxxCaolán McNamara
create vcl/locktoplevels.hxx for the utility to set all toplevel windows modally locked Change-Id: I964484d238852e830e1e5c0b86b3bebb3b41a6b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09Avoid user interaction when determining recent documents' MIME typesStephan Bergmann
After 6fcabbd6199869753fd6a266f23901962a77f556 "tdf#129153: Show MIME type icon in main menu File>Recent documents list", I e.g. got an "Authentication Required" dialog asking for user name and password if there was an sftp URI among my recent documents. Change-Id: Ic772c500f9dd2bc2418ea7dbea966e8478a35729 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113887 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-09external/jfreereport: Get rid of apache-commons-loggingStephan Bergmann
...using Java 1.4 java.util.logging.Logger instead. The two patch files are taken from <https://src.fedoraproject.org/rpms/pentaho-reporting-flow-engine/c/7db2dc0aaa9219edc794b535084a17fb408f284a> "Related: rhbz#1895921 replace apache-commons-logging with java.util.logging" and <https://src.fedoraproject.org/rpms/liblayout/c/675bcd0243d31593d7b047017108b71adfe748c3> "Related: rhbz#1895921 replace apache-commons-logging with java.util.logging", respectively Change-Id: Ie03319568f2cefc8a982c4f9ee9241f8dc0c923e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113850 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-09loplugin:redundantstatic (clang-cl)Stephan Bergmann
Change-Id: If21e0991c483836c2eb9a03396f077111dbec1fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113872 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-09-Werror,-Wreorder-ctor (clang-cl)Stephan Bergmann
Change-Id: I3c5fd8e875c6c0d36e97d76b0c51308799eeb351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113875 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-09enable set_busy_cursor to stack up in the gtk version tooCaolán McNamara
Change-Id: Ib9f8ee5af3e40c7563561d0eebc59f4a4fafcfa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09sw style copy: fix crash when handling a conditional paragraphy styleMiklos Vajna
- "Text body" is normally a conditional style for a full-blown, default SwDoc - SwTransferable::GetData() creates a temporary, stripped down SwDoc, which has a "Text body" style, but it's not conditional - SwDoc::CopyFormatArr() assumes that in case the target already has a style with a given name, then either both the source and destination styles are conditional, or neither - in practice this only causes a crash if the style is customized, as we skip default styles, probably that's why this was not noticed so far The Online case invokes this as part of lok::Document::getSelectionType(), so it was enough to set the paragraph style to Text body and then select some of that text (with a suitable document) to hit this. Based on a patch from Michael Meeks, thanks for that. Change-Id: Ic3c27ec582ae1745469042856254313cbc996ee0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113877 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-09do not #error in clangplugins with --disable-pchLuboš Luňák
I missed that -building-pch-with-obj is checked by configure (and used) only if PCHs are used. So remove the error checking and hope that it gets checked whenever somebody does changes related to the flag. Change-Id: Ibdf991169f023dae48dad0dd2929215fb048d57d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113841 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-09android: Check result for CREATE_NEW_DOCUMENT IntentMichael Weghorn
Only try to retrieve the file URI and load the document if a file was actually selected. Change-Id: Icd47c197b67d593e74874e8136233b6e41a1a68d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113845 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-04-09android: Request PERMISSION_WRITE_EXTERNAL_STORAGE againMichael Weghorn
Requesting the permission on app start had been dropped in commit a23bd42e9b2f6401c710ac95afcc3aa8f360d65c Date: Tue Apr 6 14:26:06 2021 +0200 android: Drop custom file abstraction + UI Since the app now uses the Android Storage Access Framework [1] in order to open or create files from within the app, it not longer needs PERMISSION_WRITE_EXTERNAL_STORAGE for this. However, at least PDF export currently still directly writes to local storage ("Documents" directory), which fails without that permission being granted. In addition, opening files passed with a 'file://' URI in an 'Intent.ACTION_VIEW' also did not work anymore. I'm not sure whether this use case is particularly relevant in practice, though; at least all of the (few) apps I used during testing passed 'content://' URIs in their Intent. In addition, in Android 11 (API level 30) or higher, PERMISSION_WRITE_EXTERNAL_STORAGE no longer has any effect; from [2]: > More recent versions of Android rely more on a file's purpose than its > location for determining an app's ability to access, and write to, a > given file. In particular, if your app targets Android 11 (API level 30) > or higher, the WRITE_EXTERNAL_STORAGE permission doesn't have any > effect on your app's access to storage. This purpose-based storage > model improves user privacy because apps are given access only to > the areas of the device's file system that they actually use. > > Android 11 introduces the MANAGE_EXTERNAL_STORAGE permission, which > provides write access to files outside the app-specific directory and > MediaStore. To learn more about this permission, and why most apps don't > need to declare it to fulfill their use cases, see the guide on how to > manage all files [3] on a storage device. For now, request the permission again, at least as long as PDF export doesn't use the storage framework to ask where to save files. It certainly makes sense to reconsider this in the future (and decide to either drop the permission completely or request MANAGE_EXTERNAL_STORAGE for API level >=30). [1] https://developer.android.com/training/data-storage/shared/documents-files [2] https://developer.android.com/training/data-storage#permissions [3] https://developer.android.com/training/data-storage/manage-all-files Change-Id: Icc4c9c9b7b315d2a0b6a025439ae7e431cdd5b37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113840 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-04-09-Werror,-Wformat (clang-cl)Stephan Bergmann
"format specifies type 'unsigned long' but the argument has type 'sal_uInt16' (aka 'unsigned short')" Change-Id: Ie5397be90ccb5678a97e7a3a0987b60b38ece4e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113874 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-09loplugin:noexceptmove (clang-cl)Stephan Bergmann
Change-Id: I55f5c725ac65058f5424f472cb71a84c9e3322f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113873 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-09expose what sizes are used for theseCaolán McNamara
Change-Id: Ic156ef1dc51e7e7b0773cfbf240b4dfa5ec7640e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113849 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09loplugin:nullptr (clang-cl)Stephan Bergmann
Change-Id: I41a8fa48b762d8f4da1c23785a86d651cfb4aa89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113851 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-09[API-CHANGE] tdf#141543 VBA Range.Formula Range.FormulaR1C1 non-localizedEike Rathke
The VBA compatibility Range.Formula and Range.FormulaR1C1 properties wrongly used localized formula expressions as if they were Range.FormulaLocal and Range.FormulaR1C1Local. That worked in English UI and locales, but not in translated UI or with locale dependent different separators, imported Excel documents using these properties failed there. Instead, use English formula expressions and separators, and additionally implement Range.FormulaLocal and Range.FormulaR1C1Local for localized formula expressions. See https://docs.microsoft.com/en-us/office/vba/api/excel.range.formula https://docs.microsoft.com/en-us/office/vba/api/excel.range.formular1c1 https://docs.microsoft.com/en-us/office/vba/api/excel.range.formulalocal https://docs.microsoft.com/en-us/office/vba/api/excel.range.formular1c1local Unfortunately this change means for macros created in LibreOffice that relied on the erroneous beaviour in a localized environment those macros will cease to work, the remedy in these cases is to replace setting Formula and FormulaR1C1 attributes with FormulaLocal and FormulaR1C1Local instead. Obtaining formulas never worked reliably unless the document's native grammar was very similar to the API grammar (English UI function names, English locale and separators, address convention). For this to work a prerequisite is commit d0b4719ca3d4608bcb7431dbeb097146dd5a5127 CommitDate: Wed Apr 7 02:22:54 2021 +0200 Related: tdf#128334 Make VBA Range getFormula(R1C1) work not only by accident Change-Id: Ifce9ac7557b6a3703d47ee81b57dd8246f3fc3ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113846 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-04-09fix small cairo leak in gen backendNoel Grandin
Change-Id: I57b8cd00d252cef2699d499b9080f829be9098da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09sw doc model xml dump: show if a text format is conditionalMiklos Vajna
Text body is typically conditional, but not always, make it easier to spot this unusual case. Change-Id: I27c63f86c773324b258c6dd7e06097aa857fa9aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113848 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-09tdf#141549 sw: fix ordering of virtual SdrObjects for textboxesMichael Stahl
In header/footer it turns out that not only can the text box be inserted after the shape, it can also be inserted before the shape. This is because SwDrawFrameFormat::MakeFrames() ends up first destroying all the SwDrawVirtObj and then creating them from scratch again, while the SwVirtFlyDrawObj survives. 4 SwDrawContact::DisconnectFromLayout(bool) (this=0x6ed0200, _bMoveMasterToInvisibleLayer=false) at sw/source/core/draw/dcontact.cxx:1664 5 SwDrawContact::ConnectToLayout(SwFormatAnchor const*) (this=0x6ed0200, pAnch=0x0) at sw/source/core/draw/dcontact.cxx:1791 6 SwDrawContact::SwClientNotify(SwModify const&, SfxHint const&) (this=0x6ed0200, rMod=..., rHint=...) at sw/source/core/draw/dcontact.cxx:1521 7 SwModify::CallSwClientNotify(SfxHint const&) const (this=0x6ecfd80, rHint=...) at sw/source/core/attr/calbck.cxx:321 8 sw::BroadcastingModify::CallSwClientNotify(SfxHint const&) const (this=0x6ecfd80, rHint=...) at sw/source/core/attr/calbck.cxx:326 9 SwDrawFrameFormat::MakeFrames() (this=0x6ecfd80) at sw/source/core/layout/atrfrm.cxx:3394 10 AppendAllObjs(SwFrameFormats const*, SwFrame const*) (pTable=0x69c1920, pSib=0x38c6100) at sw/source/core/layout/frmtool.cxx:1349 11 InsertCnt_(SwLayoutFrame*, SwDoc*, unsigned long, bool, unsigned long, SwFrame*, sw::FrameMode) (pLay=0x6be4320, pDoc=0x69af7c0, nIndex=157, bPages=true, nEndIndex=0, pPrv=0x6baedc0, eMode=sw::FrameMode::New) at sw/source/core/layout/frmtool.cxx:1927 Fix this by searching for the existing SwVirtFlyDrawObj in SwDrawVirtObj::AddToDrawingPage(). (regression from 3bc8f90e9693f710f12632f69b9348c1c833c906) Change-Id: Ic00878685ab16018c9331190f1e80f874c1a9a4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113844 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-09Remove duplicating callMike Kaganski
... introduced in 14ee634e9cca474cacccd8872d5fdf46ea53f108 and obsoleted by 8a32a014fbf336ce32e4a1d4b95c4d286029ea4c shortly after. Change-Id: Iae2f4004212ecb2fe9f1ecac94c8d9c520a77000 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113770 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-26 15:18:09 +0000