summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-09-22tdf#102355 Fix disabling entries via dispatch interceptionMaxim Monastirsky
... in ResourceMenuController based top-level menus. MenuBarManager doesn't set frame action listener for top-level. This wasn't an issue when top-level always was the menubar, but now top-level can be a popup menu. Change-Id: Ibc9116389239eb06f84a2e53b31eacc0a09d438e
2016-09-22Fix JunitTest_framework_complex:CheckXTitleLuke Deller
This unit test class relies on calling waitForEventIdle to wait for UI transitions to complete. On Windows this is not reliable, due to VCL's use of PostMessage (Windows message queue) to asynchronously handle some events such as focus changes. This issue causes the test to intermittently fail when the dispatcher for the action the test wants to perform (like closing the print preview) is not available yet. - Change the test code to explicitly wait for the desired dispatcher to be available - Remove the sleep which was added earlier this year to address this symptom in one location Change-Id: Id701209a28cd0c806ab0a548508d31f9f11211f5 Reviewed-on: https://gerrit.libreoffice.org/29167 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22Fix memleak in GtkSalMenu::NativeSetItemCommandMaxim Monastirsky
Change-Id: Id952f3dc236d2dc2c6839ce75943bda162fabf82
2016-09-22Don't unnecessarily activate all menus in gtk2Maxim Monastirsky
Change-Id: I9d4b4e55673f73dd6c518bb169416958fde72a32
2016-09-22desktop: guard against nullptr frame in doc_registerCallback()Miklos Vajna
Change-Id: I96956d6631ed574c06df62e9b633d7e1e4d5a5f2
2016-09-22Notebookbar: separate .ui files settings for each moduleSzymon Kłos
* each module have own list of implementations * deleted placeholder .ui files from Calc and Impress Change-Id: Ib7d4cafbb332447e769ca753003d31e9f3025f0a Reviewed-on: https://gerrit.libreoffice.org/29143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-22Fix sh quoting of ; and \ (the latter in the cygpath -w output)Stephan Bergmann
Change-Id: Iec52b93746b2fd9bbd6ad67667092717f39222d7
2016-09-22tdf#101894 Copying a single sheet with a chart on it garbles the chartNoel Grandin
..on the new sheet Bug introduced with commit 86e9ef21a06a9babefb778dfc3e02118d371d70d Author: Noel Grandin <noelgrandin@gmail.com> Date: Tue Mar 8 20:41:21 2016 +0200 sequence->vector in sc Change-Id: I7a6539005f42c7a7036c60b12a9ff2f77f71ba6b
2016-09-22sc-perf: tdf#87101 add bulk scope for BroadcastRecalcOnRefMove() callsEike Rathke
Bulk scope prevents repeated broadcast/notify/track cycles of identical areas during mass broadcasts. Brings insertion time of tdf#87101 bugdoc from 3min30 down to 2min30 Change-Id: I360fd52b622a8a327cdede47ed398260b7e8b4f6
2016-09-22tdf#87101 Revert "fdo#83067 also volatile cells need to listen to all refe"...Eike Rathke
This reverts commit 0792aef9010007d5738723d8930990028bef2f9e. It created a bottleneck with massive use of OFFSET() functions mixed with other references, see tdf#87101 bugdoc. Will have to come up with a different approach to solve the "broadcast cell move" problem. Additionally, the unit test for tdf#83067 and the original problem still work with the reverted change, so we seem to generally have fixed something else in the meantime.. Conflicts: sc/source/core/data/formulacell.cxx Change-Id: Ida2e26398f99ff5878d43ffb46035bc4441dfff6
2016-09-22Make workdir/UnpackedTarball/langtag/data/.libs/lt-reg2xml find its libsStephan Bergmann
...after ecd5d49dc30d11845ccc1a14e26bf37d73959463 "liblangtag: prevent libtool from adding annoying stuff to RPATH". "Outsmarting" libtool in the way described in 1d028d4783da69c5c0e6e0b59e0f8ac55eb9d2b1 "Fix Linux RPATH of various external modules" only works if there's no utility applications in the outsmarted module, that are run while building the outsmarted module (cf. the redland case in 1d028d4783da69c5c0e6e0b59e0f8ac55eb9d2b1). To work around that, pass in an LD_LIBRARY_PATH (or equivalent) that finds the relevant libs as built in that module. (And gb_Helper_extend_ld_path was until now only available in com_GCC_defs.mk. There, it accepts any number of paths separated by ":". When used in a platform-independend way like it is used here, it will only support a single path.) Change-Id: Ic615e436b19b8b9aa7daa019c8f5287de90c3abc
2016-09-22convert C_ constants to typed_flagsNoel Grandin
Change-Id: Ia80cef26edce3e0a664044f3ca65d33998546d0f
2016-09-22convert SIZING constants to scoped typed_flagsNoel Grandin
Change-Id: Ibd504cd7059bcaae0a37c0df25d805efff573b99
2016-09-22convert CARDINALITY constants to scoped enumNoel Grandin
Change-Id: I35cc98086850e62a2ea8703fc4b086ed2adff66a
2016-09-22convert UPDATE constants to typed_flagsNoel Grandin
Change-Id: If32ec675678acf08febc82a48ae43f2358026f76
2016-09-22convert COLORMODE_RGB constants to scoped enumNoel Grandin
Change-Id: I41d13e08d721402442fe807181bac19f5853debe
2016-09-22tdf#53698: Add a NumberFormatMapper member to SvNumberformatScanMaarten Bosmans
This way the NumberFormatMapper can cache subsequent getFormatCode calls. It improves performance in case LANG=en_US. Change-Id: I81922f219c29a5aa302e5ad3afead107dee463e3 Reviewed-on: https://gerrit.libreoffice.org/29135 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22Remove NumberFormatCodeWrapperMaarten Bosmans
This class only adds a level of indirection, without any useful functionality. Change-Id: I806e1b9241caf025c62c12c93aad3101daac874a Reviewed-on: https://gerrit.libreoffice.org/29134 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22Check harder whether file is really under WORKDIRStephan Bergmann
1977b57bc9aaea71252358fa502110c348153c70 "vcl: loplugin:override" had only hit in out-of-tree builds, where the #include in the generated workdir/CustomTarget/vcl/unx/kde4/tst_exclude_socket_notifiers.moc is an absolute path. For in-tree builds, the generated #include line is "../../../../../vcl/unx/kde4/tst_exclude_socket_notifiers.hxx", so the returned getFileName() is .../workdir/../../../../../vcl/..., so was erroneously considered to be under WORKDIR. Change-Id: I9abef04b90ecb4921087a53ff196b833940085e5
2016-09-21python3: put a RPATH into libpython3.soMichael Stahl
libpython3.so is the "ABI compatible" wrapper library around libpython3.5m.so - it is not actually used by anything in LO right now, but let's ensure it has RPATH $ORIGIN just in case. This revealed that the AIX patch in python3 accidentally changed the SONAME of libpython3.5m.so from upstream's libpython3.5m.so.1.0 on ELF platforms, because the SONAME variable was set in the shell command but read as a make variable in the next line, which is actually evaluated earlier. So rename a few files in packages to use the upstream SONAME. Change-Id: I3611f75eee62b0993b853230521a2fa41ac5cd9c
2016-09-21coinmp: no need for bzip2 libraryMichael Stahl
Change-Id: I1f5115defa3619f13ce00d64d5532d2b08dc2ccb
2016-09-21liblangtag: prevent libtool from adding annoying stuff to RPATHMichael Stahl
Change-Id: I699e84614f09c6e1edad5bcd51eae73d1ab8123f
2016-09-21tdf#101976 related: check for read-only state of all Online Update settingsAndras Timar
Change-Id: I1c14d3fd8fd257f762f136f5b03ac0ec31b44254 Reviewed-on: https://gerrit.libreoffice.org/29109 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-09-21tdf#92266 better language selection in Windows installerAndras Timar
It won't select 'kok' when we have 'ko', 'sid' when we have 'si', but language variants will fall back, e.g. en_ZW -> en. Change-Id: Ie417b6be664d5148829d2f7280e20653f84bc7a3 Reviewed-on: https://gerrit.libreoffice.org/28744 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-09-21tdf#93237 different Windows Uninstall DisplayName for 32-bit and 64-bit buildsAndras Timar
Change-Id: I6c7f9dd6e64a448b60904d8ee57fd45a45153f01 Reviewed-on: https://gerrit.libreoffice.org/29102 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-09-21fix en-US language selection logicAndras Timar
Change-Id: I60a90e310bd60c97f4d135a4740928c6e19d3ebc Reviewed-on: https://gerrit.libreoffice.org/28743 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-09-21fix documentation of $(home) path variable on WindowsAndras Timar
Change-Id: Ie97d7d63f2fde98e51e2210c5ad1063ad7ab07db Reviewed-on: https://gerrit.libreoffice.org/29144 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-09-21Resolves: tdf#101708 only export loext table attributes in 'extended' variantCaolán McNamara
Change-Id: I35f297e94e1eb6ed56020cf69102fad4c4d1e7f4
2016-09-21Resolves: tdf#83037 <--> corrected into ← → instead of ↔Caolán McNamara
don't use - as a word separator except for breaking up a compound word for the purposes of tdf#55693, e.g. TEst-TEst autocorrected to Test-Test) Change-Id: Ie52a16af0b5838d1ba0de9c5f9c30dcab05c3bc7
2016-09-21reorg of code can drop the special msvc warnings handlingCaolán McNamara
no logic change intended Change-Id: I84f7e3fd60a49f7c3b898c7dda37a92701a8ef68 Reviewed-on: https://gerrit.libreoffice.org/29151 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-21lok::Document::getCommandValues: expose sw redline author colorsMiklos Vajna
These colors are used in the tiles, so it's a good idea if the client can use matching colors for cursors and selections. But to be able to do that, we need an API to expose these colors. Change-Id: Ia688c07e6c300fecdf8dc428d5a3f000d1857387
2016-09-21tdf#102233: avoid infinite loop recursion in IsProtect node methodJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=102233#c5 Change-Id: Ic985662011b33d4b20b7c60df33c9ecc97326e85 Reviewed-on: https://gerrit.libreoffice.org/28972 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-21add bin/check-elf-dynamic-objectsMichael Stahl
Change-Id: Ia21375e376c25f9731455ef505422fa9bab884cb
2016-09-21Related: tdf#102308 sw: ignore seconds when combining redlinesMiklos Vajna
The purpose of storing seconds was to get a better timestamp, not to make combining impossible. Also fix two issues with the existing testcase: - read both timestamps, so test doesn't fail if the second is 0 in the first redline - don't fail if minute changes while waiting for a second Change-Id: Ib6c8ecdcf2f0da9191f0b48e6aaefc0b2449583e
2016-09-21Add some missing documentation to idl filesSamuel Mehrbrodt
Change-Id: Id5a3a6d4cc08f55cd7ff31614248ce203b2e4e8d Reviewed-on: https://gerrit.libreoffice.org/29146 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-21sw: apparently CppunitTest_sw_mailmerge needs scfilt libraryMichael Stahl
At least my incremental ASAN build failed because it loaded an outdated libscfiltlo.so that was still linked against outdated liborcus-parser-0.11.so causing an odr-violation. Change-Id: I4a4e134ab14503b15742138e9c4c29cb2b98d655
2016-09-21Related: tdf#102073 survive table in footnotes edgecasesCaolán McNamara
Change-Id: I31339e4adf9bf147cbd788dc1be4088b24d59b74
2016-09-21return early on non-main condition, no logic changeCaolán McNamara
Change-Id: I056ef7100c908cde53794f028a3acef5dcb07779
2016-09-21implement IsTableRightToLeft the same as IsTableVerticalCaolán McNamara
Change-Id: I56ab1e9766f53bf8445f8c0ecab4682fcd24b7ec
2016-09-21return early on non-main condition, no logic changeCaolán McNamara
Change-Id: Ia804e4c6bfb57e0984f3d6e76cd8d27a299cafe3
2016-09-21use #i format for these bug idsCaolán McNamara
Change-Id: I90b6e426718ff11b4dfae00f7ee6b5e1036390f9
2016-09-21remove #defines for HtmlContextFlags masksJochen Nitschke
InsertFlyFrame was always called with CONTEXT_FLAGS_ABSPOS mask. Put the value of CONTEXT_FLAGS_ABSPOS in the function and remove parameter. CONTEXT_FLAGS_MULTICOL is used for headers/footers and footnote contexts. Put the mask in the enum class. Change-Id: I9b1bcd27270ee7fc0eddfaf10afa430a36b2adc9 Reviewed-on: https://gerrit.libreoffice.org/29138 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-09-21tdf#101359 handle less bookmarks then expectedJan-Marek Glogowski
Change-Id: Iaa4a54aecbe894296609f462db451c2ed94b1213
2016-09-21oops /me stupidMichael Stahl
Change-Id: Ic6a3d52f0f5d288858f9164e31997a315993a34a
2016-09-21vcl: loplugin:overrideMichael Stahl
Change-Id: I884e1e53eb26d092e8d75319d331e42dbc320209
2016-09-21Valgrind reports read of uninitialized bCLBoolStephan Bergmann
...during e.g. CppunitTest_sc_subsequent_filters_test, where CL_DEVICE_LINKER_AVAILABLE is apparently a later addition (<https:// www.khronos.org/registry/cl/sdk/1.2/docs/man/xhtml/clGetDeviceInfo.html> mentions it while <https://www.khronos.org/registry/cl/sdk/1.0/docs/man/xhtml/ clGetDeviceInfo.html> doesn't). Change-Id: Icdaeffa4adb0765a6317f443130fa295761eb93f
2016-09-21Fix typoSamuel Mehrbrodt
Change-Id: I3055f06c2b72d651ebf633bc46aaf682716a8fc2 Reviewed-on: https://gerrit.libreoffice.org/29139 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-21ASan/UBSan reports read of uninitialized bHasStandardStylesStephan Bergmann
...during CppunitTest_sc_subsequent_filters_test, where 7911f21cd3e0deb6c1966dc97b8a5e5cf994d3af "Add to a method to check if stlpool already has standard styles" apparently forgot to initialize it Change-Id: I66c6ccb8f3a3ec38ed326ccf35f3a82711c4ef6f
2016-09-21unused headerAndras Timar
Change-Id: I9339f192ae84d46a496ab76cb6430d32a28c7787 Reviewed-on: https://gerrit.libreoffice.org/29108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-09-2164-bit Windows build is not experimental for a whileAndras Timar
Change-Id: I1b973c60a19e59c98c669d08e8472c18c2fc0c58 Reviewed-on: https://gerrit.libreoffice.org/29104 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>