Age | Commit message (Collapse) | Author |
|
AKA the "*nix SalData untangling" commit.
The original plan was to get rid of vcl/inc/saldatabasic.hxx and
even SalData for all the *nix backends. But after many backs and
forths, reinspecting the code and imagining the resulting code, I
decided against that plan. All these variants would have resulted
in reinterpret_cast calls, I wanted to prevent. And they would
have required larger renames for no benefit.
An other, related idea was to include all SalData implementations
in the vcl/inc/svdata.hxx header, but that seemed like an include
explosion, so was also dropped.
I tried to untangling iOS from using GenericUnixSalData, as it
doesn't use any of it's features. The new, minimal SalData should
be sufficient.
I'm leaving the easier drop of mpInstance from the Windows and
MacOSX backend as a minimal interesting EasyHack.
Change-Id: I5be01c1f42131a7e31cb30899392308e1e2de53b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128402
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
but the cursor is at pos 0
Change-Id: I7c94480bffdced23fe89d4e3ba0e729742247130
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128414
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
probably since...
commit bc3f70f220091f09ad02c148a6a49fdccb7b85c5
Date: Thu Jan 13 20:15:39 2022 +0100
VCL move PrinterInfoManager into GenericUnixSalData
... and use a std::unique_ptr.
Change-Id: I07ffed4f722e30269ddf4828ffba3ac34952adb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128417
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1e572bd03387e1708fe75b90c2bce220b41c29e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128409
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Partially revert commit f261fae4af72b1328bc3e93fc52a9a24ce0975b3
to restore deb892628a1501527c8c41b85a65282df95b81b1 because as reported
by jluth the test case testfdo79008 that failed was apparently somewhat
misleading and the test case testTdf134951_duplicates that should test
comments erroneously failed to fail because it is doing a loadAndSave()
instead of a loadAndReload().
Change-Id: I7e788287da3b1742f65697ec350997d175db9e69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128410
Tested-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: I15c0afdcae3e9bc1412e6564c15df2196515052e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128412
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
to limit its error potential by encoding only the category string
Change-Id: Ia3d3bfa6981ec46b71b500980abda9ad7f606cd1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128361
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I6cbbefe1cb16599ae81fc6dcb5a51ef1ca2db6f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128407
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I0af49eef735f5191f956f9ef9ae8e39c1eb7651a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128375
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I203387db47c3b936ec79bbe951f21bec6c7c26ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128408
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
See tdf#42949 for motivation
Change-Id: I916f42c46efa1b6cfd7744a189b79659b2867431
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128196
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I7d41fa2fbfd188c75b690be34f7c9baf6ae20044
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128405
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
And fix the Authorization header redaction, it was assuming there is one
call per header line, but all headers are passed in one call.
Change-Id: Idf86b9e0a4a8f8e9fb39098402a002abc394a589
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128395
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
The wiki page
https://wiki.documentfoundation.org/Development/DispatchCommands
is generated by the execution of the python script:
/bin/list-dispatch-commands.py
Layout and content changes:
- better commands list coverage
Scan of .xcu, .sdi and .hxx files
The list is the "union" of the found commands
=> Base and Charts commands are part of the list
- new classification based in the 1st place on the .xcu files
i.o. the .hxx (or "slots") names
=> Commands are listed only once
- The sources providing the listed info are referenced for
each command with a direct link to the opengrok sources
- New information when available
A subclassification: the group
The potential arguments of the command
Change-Id: I54dd8c219d0e7a00fd346faa7577e181a068bbaa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128254
Tested-by: Jenkins
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
|
|
and popppler-data to 0.4.11
Change-Id: Ibd8c28f36408a670b5853f1b266c6b8c36916a61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128398
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
most of these are never used, so rather store a pointer to a shared
empty vector
Change-Id: If5b8b82235171769420615147a0e0b316c237874
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128404
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Rely on the cached primitives without always rebuilding.
But only enable it for calc and draw right now, by adding a flag
at the SdrModel level.
Change-Id: I295e5a366b1b21d0f1561e6736bac919082afb5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128380
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
when empty, it is only a single pointer big anyway
Change-Id: I3e45dd705c4bef3799435617db1a4192d62860e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128403
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
(*) Firstly, the XWeak machinery in here was never useful. This
class has always used hard references to its listeners. So
just remove all that.
(*) Convert from osl::Mutex to std::mutex and use the latest
utility classes in comphelper with that.
Change-Id: Id129527cf53da6d7a9f6e1c76b556c57fe1a0270
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128393
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
... and use a std::unique_ptr.
PrinterInfoManager::release() was just called from ~SalData(),
so this should make this more clear.
Change-Id: Ic4aade2db3813fdc96ede116a50604692ef3dbec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128399
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
It's always the same code.
Change-Id: I2385d0bda24939b964306e27a3df99ea44356eac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128401
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
aTableNames is not changed till we hold a reference to that name.
Change-Id: I8a06b5bead101cba4e3293f6c29a849e7a9d0f6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128396
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
in this case, ModifyEventForwarder.
Instead of doing UNO_QUERY and implicitly relying on it's
implementation, make it obvious what we are doing
Change-Id: Ie02a11f115da9c8af7d4ca85bda9fb9a69c5d52f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128392
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ib7cb14872f74ef5ab5adeb332fb791b7c98fc63f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128400
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: Id3292de4eca6ab72d5116b967a619f78ab96082b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128391
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I17ddc43c37d806f267f4ca57bb02227bd053d2cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128397
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
paragraph
The to be deleted outline selection may already be to the start of the
following outline paragraph as happens when a table is the last
content of the to be deleted outline. In this case do not extend the
selection right or the first character of the following outline
paragraph will be removed. Also check if no selection was made which
indicates an empty paragraph and the selection right is needed.
Change-Id: I5b2516bd7b1e88ee415986dbe9313f93039dbac0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128264
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
drop GlyphPositioningMode::ClassicInspired as that just demos the
tradeoffs of the original GlyphPositioningMode::Classic vs the chaos of
GlyphPositioningMode::PreferReadability where hinting at small sizes
pushes the text outside its layout bounds.
add GlyphPositioningMode::LayoutAndMatchRender to demo the next
option.
so:
GlyphPositioningMode::Classic This is as it ~always was, using the
technique documented at https://wiki.openoffice.org/wiki/Writer/WYSIWYG
GlyphPositioningMode::Layout This is just taking the high resolution
layout positions, dropping the "Classic" technique and let vcl do its
default scaling and rendering of the glyph positions as happens in
editeng.
GlyphPositioningMode::LayoutAndMatchRender same as Layout, but during
text render preserve the scaled glyph positions as floating point
positions and pass through to the various platform text renderers
configured as best to handle that.
Change-Id: Ic37bb8f3cf4472bdc3c48f02b1f9057a0f80cbd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128360
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6d24be03c6401a815e6f19d79f418fcc90334393
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128387
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I454bff4acfcd85701a7f094a8bd76898825e9ce2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128388
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
I unsure hint_metrics makes any difference to our use case, but probably
won't hurt
Change-Id: I82a4ff0d3a05e50ec30e878363e0c24a438c96cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128389
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to 1d958791300f4cf1eee8f26b46fe888cee3fae2e
- Fix typos
Change-Id: I951914bd28c7cd4f49e2704f3393e91fb18e6cd0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128385
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
The problem is that at the end of the paragraph a second call to
OutFlys() is made in line 2730 and that causes the duplication; for
this call the value FLY_POSTPONED must be returned, not FLY_NONE.
(regression from 3eced2d52415abeac266804ab682bee022322a19)
Also revert commit deb892628a1501527c8c41b85a65282df95b81b1 because its
test fails now as 0 comments are exported; it was apparently another
problem introduced by the above commit, and apparently this fix helps
for duplication of comments too.
Change-Id: Ib9706e4c24db38c15a0170ba2e8f08fba5327f98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128386
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
When rendering in ResolutionIndependentLayout mode keep the scaled
glyph positions as floating point all the way down to the renderer
Change-Id: I02415f18c26737a886751972f472b499a25c776b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128379
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6b8c815fda3a48917467719432071c0716e3e9ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127338
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If75c3448776743f1b9efbf84a487cfc0c75364ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128365
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This is similar to commit fc04a84f297b78a1049182b6d8cf745f863ffe61 (sw:
fix swapped inner vs outer border for Word-style left table borders,
2022-01-11), but that was for vertical borders, this is for horizontal
ones.
The other difference is that Word mirrors vertical lines, but not
horizontal ones. This means that our horizontal line need less
mirroring, while our vertical lines needed more mirroring.
Change-Id: Iff07adac5c53420673139d5c93ce52f6148fb977
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128383
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
* Update helpcontent2 from branch 'master'
to eb1bf86ac137d050daaaed114a70c29002acc4fe
- tdf#123318 Add navigation menu entry LibreOffice for Shared
Change-Id: Ibd46738e03721127e07ee1575e0a925fc36fbe9d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128382
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
to the changes of:
commit 8d2bf9b679dec223a78e1fd8f3684f76c5802bae
Date: Wed Jan 12 13:32:13 2022 +0100
Resolves tdf#145625 - Alignment issue at color options
Change-Id: I66c43e964b19da3bdfd4f13cc343dc399ae9cd5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128378
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
glade tends to clobber the GtkMenuButtons placeholder labels
Change-Id: I2f1e8dd3f9b86e09a9fe7ce311b40a84f298b4a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128377
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to 3c10ab097835514a63c4b0876b0ea5254bed1228
- partially resolves tdf#146733: corrections for template view
- correction to listview icon
- correction to location of listview and thumbnail icons
Change-Id: I5133e88bf2e683bdc6388cacc40a341ee050e714
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128340
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Tested-by: Jenkins
|
|
* Update helpcontent2 from branch 'master'
to cf8ad59654e0f7edff6033d55bf10710f1255b4d
- partially resolves tdf#146733: change "tools" to "manage
- change mention of "Tools" icon to "Manage" widget
- update menu items in Manage dropdown menu, and remove
obselete items
- remove tools icon
Change-Id: I3c68b4686abb10f58cfc8158e95a3eaf51aa9816
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128339
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Tested-by: Jenkins
|
|
Change-Id: I3a8dcf497a236d12eedff9e7b5943e14747cb9bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128374
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
no logic change intended
Change-Id: Id24fb2647e2e6c00a485165edd7fc265ad090c23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128373
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to 2c41ec4fa1f8b000c62c3df3f66e594818f63094
- tdf#146117 Explain that Var/Str are locale-independent
Change-Id: I0a90befe2c63e8f9719ec7179666c9342602d0e2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127782
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
* Update helpcontent2 from branch 'master'
to 5d3d7401d26288e8bc7eb984dcd714590bc72e82
- tdf#91230 Improve description of Conditional Formatting
Change-Id: I536c959bec3ad94deb5e9893b956755d64f438f2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128337
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I51fc0292a3907613391bc8a2a16bac486cdadee6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128366
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to 3cb9f803eae6a60ae6bc8ca35ccd74126f14a871
- tdf#70551 Improve description of the WEEKS add-in function
Change-Id: Ic4e234496a05fb1e88de88f554a2b5ae90244651
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128331
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
...including
<https://github.com/flathub/org.libreoffice.LibreOffice/commit/65437462b575881703146b132d2ae6c7e998c1b6>
"Merge pull request #174 from vroger11/patch-1: Add global-menu support for KDE
and unity"
Change-Id: Id9c9c9d63303fc7de12b47e12b1e32f6556f1f02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128368
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...after 840b4eb2f3443ff883016e6a8a8ae49e9cbd9e4e "Recheck modules [a-c]* with
IWYU" causing
> In file included from workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:8,
> from workdir/UnpackedTarball/cppunit/include/cppunit/TestCase.h:6,
> from workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:5,
> from workdir/UnpackedTarball/cppunit/include/cppunit/extensions/HelperMacros.h:9,
> from cppu/qa/test_any.cxx:26:
> workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h: In instantiation of ‘typename std::enable_if<(! std::is_enum<_Tp>::value), std::__cxx11::basic_string<char> >::type CppUnit::StringHelper::toString(const T&) [with T = char16_t; typename std::enable_if<(! std::is_enum<_Tp>::value), std::__cxx11::basic_string<char> >::type = std::__cxx11::basic_string<char>]’:
> workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:74:50: required from ‘static std::string CppUnit::assertion_traits<T>::toString(const T&) [with T = char16_t; std::string = std::__cxx11::basic_string<char>]’
> workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:168:58: required from ‘void CppUnit::assertEquals(const T&, const T&, SourceLine, const std::string&) [with T = char16_t; std::string = std::__cxx11::basic_string<char>]’
> cppu/qa/test_any.cxx:282:9: required from here
> workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h:25:9: error: use of deleted function ‘std::basic_ostream<char, _Traits>& std::operator<<(basic_ostream<char, _Traits>&, char16_t) [with _Traits = char_traits<char>]’
> 25 | ost << x;
> | ~~~~^~~~
> In file included from ~/gcc/trunk/inst/include/c++/12.0.0/istream:39,
> from ~/gcc/trunk/inst/include/c++/12.0.0/sstream:38,
> from workdir/UnpackedTarball/cppunit/include/cppunit/portability/Stream.h:283,
> from workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:7,
> from workdir/UnpackedTarball/cppunit/include/cppunit/TestCase.h:6,
> from workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:5,
> from workdir/UnpackedTarball/cppunit/include/cppunit/extensions/HelperMacros.h:9,
> from cppu/qa/test_any.cxx:26:
> ~/gcc/trunk/inst/include/c++/12.0.0/ostream:558:5: note: declared here
> 558 | operator<<(basic_ostream<char, _Traits>&, char16_t) = delete;
> | ^~~~~~~~
etc.
Change-Id: I2e6d3591dec9eeb6647738d37296c7d2bfa6a186
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128369
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|