summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-11-19tdf#137438 drawingml: separate outline from text importJustin Luth
By ignoring the a:ln group, the contents in that group (like transparency) were being applied to the text. Well, it should only apply to a line around the text, which LO isn't doing. [Well, LO can do this as Fontwork, but perhaps that doesn't match so well with text in shapes generally?] At any rate, don't allow one group's settings to override the others. Keep them separate and then apply a bit of merging logic to try to achieve the best look. So emulate a little bit. If the outline is not very transparent (less transparent than the main text) then it may (if thick or opaque enough) dominate the text. For simplicity (and because there is no right answer overall) I just compared transparency and used the more opaque colour. Unit tests potentially affected: -export-tests-ooxml1.cxx: tdf100348_FontworkBitmapFill.odp -> PPTX -now imports black instead of yellow (MSO sees gradient colors) -so previously completely wrong, and now perhaps even more wrong? -export-tests-ooxml3.cxx: tdf114848.pptx -shows blue text regardless - defined by area. -can't see where this is set in MSO2016. Perhaps illegal? - : tdf125573_FontWorkScaleX.pptx -no visual difference. Same as tdf100348, but with black outline. - : tdf119087.pptx -should be green, not purple. [Added test for that.] - : tdf143315-WordartWithoutBullet.ppt -no visual difference (COL_AUTO outline?) -import-tests2.cxx: tdf129686.pptx -poor test usage (but also weird transparent default). -no visual change. -ooxmlimport2.cx: tdf143476_lockedCanvas_position.docx -no visual difference. Irrelevant since we can't RT Change-Id: Iff0d95506dd64825444a99e62a6c2bd5e1dc122f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125300 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-19loplugin:stringliteraldefine in vclNoel Grandin
Change-Id: Id14cc8613fdfb67790efd6c33ee243f6bdb522f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125546 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19loplugin:stringliteraldefine in svlNoel Grandin
Change-Id: I49a8062c30bdce5b0d9bd27e421d85ba61d5592e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125544 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19Change About LO dialog to run asyncJan-Marek Glogowski
Change-Id: I7255a8510e4cf983ebab477cbdb7cdcf00dabc98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125512 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-11-19Reuse macros for AbstractDialogFactory_ImplJan-Marek Glogowski
Now that all the abstract dialogs are welded, update and rename the existing boilerplate macros, to cut down the C'n'P code size. Change-Id: Iff8f452ca3dfce9a63c4fb73ab3a5025566810e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125511 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-11-19rtl::Static->thread-safe static in unoxmlNoel Grandin
Change-Id: Icb458f9ba38225aef17a2421533be79c6d9445d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19loplugin:stringliteraldefine in toolsNoel Grandin
Change-Id: I348b9a844c009f9c19301baa76d31b12f67c6130 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19gtk3: take default modality from the popover it replacesCaolán McNamara
Change-Id: I0404dc17bd816a7dd403c50692f4f5325aacaf31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125503 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-19Upgrade to un-deprecated API and fix a crash in the pasteboard.mm helper toolTor Lillqvist
Change-Id: Ic0b839df686fb93c64ef844848028ded39225ced
2021-11-19gtk4: remove constrain-to propertyCaolán McNamara
Change-Id: I18f0b72fff31f555873a0808f171e4c1746a4411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-19loplugin:stringliteraldefine in linguistcNoel Grandin
Change-Id: Id347daab7aa21ce8756dbc2d139ac022fc22be3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125536 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19rtl::Static->thread-safe static in vclNoel Grandin
Change-Id: I748c3b5608b76b4b847273856f6b1c66b53aced1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19loplugin:stringliteraldefine in i18npoolNoel Grandin
Change-Id: I8a56d5d6d201ac5ae65dc46ef4838a0e41af587e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125530 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19Cleanup locally used variables in Calendar_hijriHossein
* Some variables that were only used in the calendar_hijri.cxx are now moved out of the header file, and they are no loner member variables of the the class Calendar_hijri. They are now placed in the the i18npool namespace. * Removed unused variables SynMonth, EveningPeriod and LeapYear * Moved a global variable definition to the member function that was the only place it was used. It is now a local variable. Change-Id: I8a8b25765bd8ed5640b1a0cfa46ec9903b460a53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125433 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-11-19refactor for potential reuse outside MenuButtonCaolán McNamara
Change-Id: I36729364550dc7c505fdc396442f51809fc58073 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125489 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-19crashes seen in WriterInspectorTextPanel ctorCaolán McNamara
null DocSh is likely Change-Id: I5aeb81ef01795b896ad594d7eb7f0cd657f5a690 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-19loplugin:stringliteraldefine in accessibilityNoel Grandin
Change-Id: Ie27c32ea51ebcc9ad0d0d5a1d160d55c23727cd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125274 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19Drop F_2PIMike Kaganski
Change-Id: Ie98606607b2ce262e4eed76bb8cd86fbfe846f76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125506 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-19Use M_PI* instead of F_PI*Mike Kaganski
Change-Id: Ie2b7a1c74fc516781a17a20157b8217bc41e383d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125504 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-19tdf#135906 docxexport: set serializer before writingJustin Luth
This fixes a 6.3 regresssion from commit aafaf1f55fa413ad49d4556cf7c0a713dd206ae4. Change-Id: Ia2d3d26fe2cfa2b213326021f6b97f8d40c6e98c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125441 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-19tdf#137924 qt (>=5.14): Use proper DPI without requiring window handleMichael Weghorn
For Qt >= 5.14, don't require a window handle to retrieve the screen and then the associated DPI value from that one, but directly use 'QWidget::screen' (introduced in QT 5.14) to retrieve the screen. Previously, no DPI values would be set in case there was no window handle. This makes UI scaling work without having to manually set 'SAL_FORCEDPI' on Wayland. While various UI elements (like e.g. the "Help" -> "About LibreOffice" still look quite broken with the qt5 and kf5 VCL plugins in a Plasma Wayland session (at least on my Debian testing with Qt 5.15.2 and Plasma 5.23), they look OK when using the qt6 VCL plugin with a custom build of qtbase and qtwayland from Qt's "dev" git branches. Change-Id: I5feae46ed86a8b7d3cf92d4a973f7a0f9a9f95de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125507 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-11-19rtl::Static->thread-safe static in xmloffNoel Grandin
Change-Id: I5fa1f0a2b5336508841ef841bb56e2edb25e4ef7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19rtl::Static->thread-safe static in swNoel Grandin
Change-Id: Ic69883c66a08654b9c86ca87a640f5070312fa83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19sw: enable warning in XMLRedlineImportHelper::InsertIntoDocument()Miklos Vajna
This one looks useful, so why hide it behind dbglevel=2. Change-Id: I424808ae8ccd2ab7edcd1a75cd7c4479a0ec3b13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125501 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-19rtl::Static->thread-safe static in unotoolsNoel Grandin
Change-Id: I2a8c9ca7c45a8e20f3d114722a0677b856a13d8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125495 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19rtl::Static->thread-safe static in toolsNoel Grandin
Change-Id: I6c45fc533ec6281d011282bf2e8d49f23e2c29e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125494 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19rtl::Static->thread-safe static in svxNoel Grandin
Change-Id: I743d252befd948580a1b3619f51d3f0343cb469d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125493 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-19rtl::Static->thread-safe static in svtoolsNoel Grandin
Change-Id: I437259b4a70ec575e937821b9b1adc001723f29c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125492 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-18uitest: sd: the redo action fails at times ...Xisco Fauli
... to add back the animation to the list in the sidebar, and thus the test fails. Remove it for now. At least the undo part of tdf#135033 is still tested Change-Id: I7dc416645db53ec3f08376d04de9be036ce53fdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125505 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-18Qt implement QtFont::GetGlyphOutlineArmin Le Grand (Allotropia)
Fixes FontWork with QFont based rendering. Change-Id: I294fe89d2753b6e82a559ff847b44126f9ea3bfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125500 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-11-18Drop F_PI180Mike Kaganski
Change-Id: I36783d6fd6f439a71bc46959cd859b48d65ee30f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125449 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-18Drop obsolete commentMike Kaganski
Change-Id: Iee729890771376192c547b96c59f5e0086782219 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125448 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-18tdf#140086 svl: restore PasswordContainer to single-instanceMichael Stahl
(regression from 7256ff08bc46840bb85fa255ace6541dca91329e) Change-Id: Ib640dea001fc787279761ca72bbc3db46d0102c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125485 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-11-18drop unnecessary TODOCaolán McNamara
Change-Id: Id906f7a6bf806d5c102f8653b1174aaa47e8bb7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-18uitest: sc: remove duplicated test with the same nameXisco Fauli
In the file, there are two test_tdf91305_sort_text_cells_rows so this one is never executed. Just remove it because it's quite a basic test Change-Id: I255b4202359e20744845fbdcbf963e74b9ee0710 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125490 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-18loplugin:stringliteraldefine in basctlNoel Grandin
Change-Id: Id9f1d2932b5f602602d0229b8dc9794c01f5cbb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-18SwNavigator: Track drawing objects before other contentJim Raykowski
Do this to prevent other trackable content from being tracked before drawing objects when Navigator is used to go to drawing objects. Change-Id: Ib9d322208a2e358140bfb8c80ad94b4e0084f06a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125437 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-11-18tdf#76836: sc_ucalc: Add unittestXisco Fauli
Change-Id: I62d4325dcaee19188529bb749801dc945c060572 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125487 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 04bef9c48889b4da6f332b1b31a9b45227b52c32 - Refactor database help files Change-Id: Ie8f983d2c49f61084c456f8c7e91b41a6b5ac22a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125491 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-11-18ucb: webdav-curl: don't assert on valid URLMichael Stahl
If you put an URL into the host field of the remote files dialog, it will gladly create silly urls that start with "https://https://" - these are syntactically valid because ":" may occur without port number path segment may be empty, so don't assert. Change-Id: I29b6317daeb76d8f2fd4a22c0908ad2366c36297 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125484 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-18remove some unused definesNoel Grandin
Change-Id: I4424329c1b803ccdd901f1428d332a6c56652100 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125479 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-18when color menu popdowns only popdown the autofilter if something was selectedCaolán McNamara
so the color menu can be dismissed without dismissing the autofilter Change-Id: Idb44f40a599382f86ffa9519910c37e64a56820c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125439 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-18import pptx color schemes as color setsSarper Akdemir
initial import work for color sets. Themes (which we get the color schemes from) in MSO can be different for each master - will need to support that too. [ Miklos: actually added that per-master-page support. ] (cherry picked from commit 3b21d166f585dcdf8d576d166aeff3cfd4694aab, from the feature/themesupport2 branch) Change-Id: Ia06d2645018e6bfa70817bbddba2374641ae13dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125477 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-18make Jenkins dev builds use --enable-dbgutil, not just debugLuboš Luňák
It's the "more debug" option that each developer ideally should use unless binary compatibility is wanted. Jenkins builds done with these settings are reportedly not published, so this is just tinderbox builds, and there's it's better to verify the extra dbgutil stuff too. Change-Id: Ia2f86ff9394e155b247a6e5e1583d0681399b99b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125381 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-18draw symbols using polygons instead of raster of linesLuboš Luňák
On HiDPI those lines become obvious. Change-Id: I2b0cce3950abb4d06a56ba022100bc74026b5de7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125481 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-18add an extra margin to native control drawing on Skia/MacLuboš Luňák
Some controls draw outside of their given area, which would get cropped when first drawing to a temporary context limited to just that size. I haven't managed to find a way to calculate the proper marging, so just add something that's hopefully enough but not too big. Change-Id: I1a15a3ab8cbd26cbe4fb52628b300ee70c8d51ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125469 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-18fix background color of some native controls with Skia/Mac (tdf#145748)Luboš Luňák
Some of the control drawing calls use CGContextFillRect() to draw background for controls, so since we use a temporary context, set up colors for such drawing. Change-Id: I41cfa29e29fcf86598d49fbbed0b159c48c63d6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125468 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-18draw Mac widget controls at proper size when HiDPILuboš Luňák
This code was drawing them at non-HiDPI size and then scaling up. Change-Id: I90abfd36adaff4e7c4929cd28d0aa50d919449a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125467 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-18tdf#145731: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: Id605ebee7145eaeb9ec5a533b7e72a0378d6bb7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125470 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3c580a172f699ab665b609896ac7c12a8990ee5b - Use embeded contents for experimental features. Change-Id: I3a02faeb85a9739a2ea425c8f3c4159b64df0ec0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125478 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-24 16:14:59 +0000