summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-20check for self assignCaolán McNamara
Change-Id: I1d8ae37c3f3fc41d5ec65bb246e891d76f7ff544 Reviewed-on: https://gerrit.libreoffice.org/62006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-20alloc should have been freeCaolán McNamara
Change-Id: I325a815ff17446bc389f889a028f5e2ced57d7e7 Reviewed-on: https://gerrit.libreoffice.org/62008 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-20Upgrade to ICU 63.1Eike Rathke
Change-Id: I3b73fca39f51809f608dd78865c2566357a7b8a1 Reviewed-on: https://gerrit.libreoffice.org/62034 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-20tdf#120703 (PVS)Mike Kaganski
V1023 A pointer without owner is added to the 'm_aSubElements' container by the 'emplace_back' method. A memory leak will occur in case of an exception. V560 A part of conditional expression is always true: !pNum. V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer '* pOutBuf' is lost. Consider assigning realloc() to a temporary pointer. V586 The 'delete' operator is called twice for deallocation of the same memory space. V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 867, 869. Change-Id: I2832bf7228914b48cf2c5178ed9c0719b53c883c Reviewed-on: https://gerrit.libreoffice.org/62040 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-20Fix typosAndrea Gelmini
Change-Id: I57ff252f8326818a57fdf10218210f70b100e088 Reviewed-on: https://gerrit.libreoffice.org/61928 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-10-20Turn LanguageTag::ScriptType into scoped enumStephan Bergmann
...to avoid -Werror,-Wshadow from Clang trunk with <https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators", warning about shadowing of UNKNOWN in e.g. enum ESCHER_BlibType in include/filter/msfilter/escherex.hxx Change-Id: Id6608474e76730be4c439f480c31f661b8b5748e Reviewed-on: https://gerrit.libreoffice.org/62013 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-20tdf#120703 (PVS): compare BSTR to wchar_t[] directlyMike Kaganski
V505 The 'alloca' function is used inside the loop. This can quickly overflow stack. Change-Id: I57773664000df0f5329f957674661a2313205223 Reviewed-on: https://gerrit.libreoffice.org/62038 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-20tdf#120703 (PVS): redundant checkMike Kaganski
V547 Expression 'aData.eType == SbxDECIMAL' is always true Change-Id: I37bf367221ced7bf1c53bcd5138ae7bac656da52 Reviewed-on: https://gerrit.libreoffice.org/62030 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-20return by unique_ptr from CreateFieldControlNoel Grandin
Change-Id: Ic8bf9829c3320aca452fd1a40e9843fdbdbfa219 Reviewed-on: https://gerrit.libreoffice.org/61906 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-20use equal_range instead of lower_bound+upper_boundNoel Grandin
Change-Id: I7cc1c95b3a55630e3571cac5fe22be6c2f3a1bc9 Reviewed-on: https://gerrit.libreoffice.org/62015 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-20when calling std::lower_boundNoel Grandin
it's not enough to compare != end(), you also need to compare the key against the iterator result Change-Id: Ide5f151ba2297a35e5546f47fbc3c53cbe5ab533 Reviewed-on: https://gerrit.libreoffice.org/62014 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-20tdf#120703 (PVS): properly handle BSTR; fix enum comparisonMike Kaganski
V505 The 'alloca' function is used inside the loop. This can quickly overflow stack. V745 A 'wchar_t *' type string is incorrectly converted to 'BSTR' type string. Consider using 'SysAllocString' function. V768 The variable 'mnVersion' is of enum type. It is odd that it is used as a variable of a Boolean-type. Change-Id: If7533483a53467b6901d1f39411a634d77bbd840 Reviewed-on: https://gerrit.libreoffice.org/62033 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-20clang-tidy readability-delete-null-pointerNoel Grandin
Change-Id: Ib47fc58f1cdfdd54adff07687c56198aa6f2091e Reviewed-on: https://gerrit.libreoffice.org/62029 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-20loplugin:staticvar in swNoel Grandin
Change-Id: I73b0fb18febfe1d26bb63e1755b0b8c123aa854f Reviewed-on: https://gerrit.libreoffice.org/62004 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-20elementary: fix for tdf#119073, + 32px chart configuration,3D setting, ↵Rizal Muttaqin
heading style, etc Change-Id: I53c3b4d7dd6a4b47ac2d27b361978faa597386e4 Reviewed-on: https://gerrit.libreoffice.org/61965 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-20uitest for chapter numbering dialogZdeněk Crhonek
Change-Id: Id83c8298618d38d8d6631fabdf8bc1e1326a2d0d Reviewed-on: https://gerrit.libreoffice.org/62032 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-20sw mso export: PROTECT_FORM shouldn't force section to protectedJustin Luth
PROTECT_FORM maps to enforcement = true, not "everything is protected". "The enforcement of this property is determined by the documentProtection element (§17.15.1.29), as it is possible to specify protection without turning it on." So, sections should retain their protected on/off status regardless of the value of PROTECT_FORM. My guess was that this was to offset the fact that DOCX import did not import protected status, so this helped to protect the sections that should not be unprotected. A followup patch will address the import side. patch initially developed to support tdf#120499. Change-Id: I8ff6d31711651a4827cbb8520fd68e88273d6799 Reviewed-on: https://gerrit.libreoffice.org/61905 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-20copy and paste errorCaolán McNamara
Change-Id: If19bd49e14ec5347312949bf4ba4d4c0719e22ef Reviewed-on: https://gerrit.libreoffice.org/61981 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-19Remove / from personas_list.txt installJan-Marek Glogowski
Probably fixes the tinderboxes installer failures Change-Id: Iff84b07e244000e1b0f8d94566bff76918935554
2018-10-19WIN fix CacheGlyphToAtlas resource handlingJan-Marek Glogowski
Use :comphelper::ScopeGuard to handle cleanup. And actually restore the original font on the correct DC. Change-Id: Ib59d430636b470486da2f8e5e34ed8d71b57aac2 Reviewed-on: https://gerrit.libreoffice.org/62010 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-19copy and paste errorCaolán McNamara
Change-Id: Idfb9772912b52fa6cd33546953def4f65ac75e52 Reviewed-on: https://gerrit.libreoffice.org/61983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19copy and paste errorCaolán McNamara
Change-Id: I54a1453b561306dd98cd2193f1a21b80b8b7e1d4 Reviewed-on: https://gerrit.libreoffice.org/61973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19new throws on failureCaolán McNamara
Change-Id: Ida6250fc01e0bf156a81030c2f393838ced423fe Reviewed-on: https://gerrit.libreoffice.org/61998 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19loop run a maximum of onceCaolán McNamara
revealed since... commit f69585c35411ca74e17bb6cd1cf535489472a4c2 Date: Tue Mar 1 20:38:22 2016 +0200 loplugin:unuseddefaultparams in chart2 Change-Id: I805680f7087313b1bb678ab6f6756d7a2ccc3720 Reviewed-on: https://gerrit.libreoffice.org/61991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19expression is excessiveCaolán McNamara
Change-Id: Idb6b2af0a3d37ff9ebf13a0413f9656000296b48 Reviewed-on: https://gerrit.libreoffice.org/61996 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19oox smartart: fix width of shapes with agl=lin, linDir=fromTMiklos Vajna
Smaller width only makes sense in the fromL/fromR cases, I think. Change-Id: I21c643b90556e47593b62abc2466e808d1ef31e5 Reviewed-on: https://gerrit.libreoffice.org/62024 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-19oox WpsContext: bTextFrame is always falseMiklos Vajna
Since commit d379d18666aa42031359ca8eb34b0021960347ae (oox: import WPS shape with text as shape with textbox, 2014-06-18). Change-Id: I5cc1f9938a2c091c868e6e1572e7ae35e87109a7 Reviewed-on: https://gerrit.libreoffice.org/62016 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-19NB fix TextShape with uno:DrawText instead of uno:Textandreas kainz
Change-Id: If213ecdc5dd47f3870a71131d3e634f216b3da98 Reviewed-on: https://gerrit.libreoffice.org/61989 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-19tdf#120706: nullptr dereferenceMike Kaganski
Change-Id: I55814a6b4cdfda93a51621b5b31c166507a7e7a6 Reviewed-on: https://gerrit.libreoffice.org/62005 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-19clarify Calendar_jewish::getDisplayString a littleCaolán McNamara
Change-Id: I7abecaebd296d404e6a095b2befe5da07d346e75 Reviewed-on: https://gerrit.libreoffice.org/62017 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19naming order in header doesn't match order in bodyCaolán McNamara
Change-Id: I0e425788d24bc2fe6ba05b2bdde069b3ae139df4 Reviewed-on: https://gerrit.libreoffice.org/62003 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19simplify comparisonCaolán McNamara
Change-Id: Ia298ee3e315e241ebc1c1664958d5a3a47820f28 Reviewed-on: https://gerrit.libreoffice.org/61999 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19expression is excessiveCaolán McNamara
Change-Id: I9af0de0d0f3aed565ac396b15821812fd9922779 Reviewed-on: https://gerrit.libreoffice.org/61994 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19copy and paste errorCaolán McNamara
Change-Id: I73a617137bf0b3b567181ff817069944076eab0e Reviewed-on: https://gerrit.libreoffice.org/61980 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19keep pyuno script processing below base uriCaolán McNamara
Change-Id: Icc13fb7193fb1e7c50e0df286161a10b4ed636c7 Reviewed-on: https://gerrit.libreoffice.org/61957 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2018-10-19index validity check looks dubiousCaolán McNamara
Change-Id: Iccbbeab3b52d1d7369c19e333756713b42e83830 Reviewed-on: https://gerrit.libreoffice.org/61976 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19tdf#120452: Just enough of SystemEnvData in Qt5ObjectKatarina Behrens
the video in the presentation still doesn't play but at least the crash is gone Change-Id: I78ab4ff9412998f235a4b44a23b0e9d3ef4143e0 Reviewed-on: https://gerrit.libreoffice.org/61944 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-19sw_redlinehide_3: fix some unnecessary loopsMichael Stahl
PVS-Studio complains about the funny code. Change-Id: I58e2ebcca7e13baa78cfbcc4a654d5badab8d037 Reviewed-on: https://gerrit.libreoffice.org/61987 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-19Turn ScStyleSheet::Usage into scoped enumStephan Bergmann
...to avoid -Werror,-Wshadow from Clang trunk with <https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators", warning about shadowing of USAGE in e.g. enum ESCHER_BlibType in include/filter/msfilter/escherex.hxx Change-Id: If492c5086402e46158d3de5d4d6b00b61412c655 Reviewed-on: https://gerrit.libreoffice.org/61985 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-19Introduce UnixErrnoString() and use it in sal/osl/unxTor Lillqvist
The UnixErrnoString() function returns the symbolic name of an errno value, like "ENOENT". For now this is local to sal/osl/unx. If it can't figure out the symbolic name, it returns it as a number followed by the cleartext description (as from strerror()) in parentheses. Rationale why to use this and not strerror(): This is intended to be used in SAL_INFO() and SAL_WARN(). Such messages are intended to be read by developers, not end-users. Developers are (or should be) familiar with symbolic errno names in code anyway. The symbolic names of errno values are (or should be) instantly recognizable as such, they all start with E and are in UPPERCASE. strerror() can be localised although in LibreOffice it apparently isn't as there allegedly aren't setlocale() calls. But, anyway, the error strings might be less familiar to a developer than the symbolc errno names that one uses when coding. When encountering an unfamiliar error string the developer might want to add special handling for that error case in the code. They would need a reverse mapping from error string to errno value, by manually searching <errno.h>, looking at the comments there, hoping the match what strerror() produces, to find the corresponding symbolic errno value. Change-Id: Idc11595d528e8432a32bf474e6791f4ea7262a1e Reviewed-on: https://gerrit.libreoffice.org/61931 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-10-19It seems to work even without calling temporaryHackToInvokeCallbackHandlers()?Tor Lillqvist
But I tested just a few times. If somebody re-starts work on LibreOfficeLight, and encounter hangs, hopefully they notice this commit and try to un-comment-out the line in question. I hadn't noticed that temporaryHackToInvokeCallbackHandlers() thing before, maybe calling it in the iOS app being developed (in the "online" repo) is necessary, and would help avoiding the hangs I occasionally see in it? Change-Id: I0f4d8c800024c43acb512d40efdfad71c229bec2
2018-10-19Personas: add 6 new default themesandreas kainz
design part of the personas patch Change-Id: I53c3b4d7dd6a4b47ac2d27b361978faa597386e6 Reviewed-on: https://gerrit.libreoffice.org/61507 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-19Make repeated drag'n'drop possibleKatarina Behrens
Change-Id: If87ceeb8ddc4b2aada8ea0c963385a291622fef6 Reviewed-on: https://gerrit.libreoffice.org/61932 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-19index validity check looks dubiousCaolán McNamara
Change-Id: Ib57a26e51a69cc48f82b3474d11fe4f8c8398e07 Reviewed-on: https://gerrit.libreoffice.org/61977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19copy and paste errorCaolán McNamara
Change-Id: If352e7a0f6e8dab2a9acc9aa2cde56b40cedb50c Reviewed-on: https://gerrit.libreoffice.org/61974 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19index validity check looks dubiousCaolán McNamara
Change-Id: I0952bbaabeb8353b27b478ad6b17bc9348c6f61a Reviewed-on: https://gerrit.libreoffice.org/61978 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19winaccessibility: IA2 is no longer experimentalMichael Stahl
Change-Id: I1ccaa95678b5ac6e3a25eb7577cb790ab388b73a Reviewed-on: https://gerrit.libreoffice.org/61986 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-19simplify expressionCaolán McNamara
Change-Id: I57c7df50040737656c2a68e5fdc0d069ad21f833 Reviewed-on: https://gerrit.libreoffice.org/61975 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19Now that initiating drag works, let's also accept dropsKatarina Behrens
Change-Id: Iab328edd799dd4ce04312db4e640f86a8f7fda77 Reviewed-on: https://gerrit.libreoffice.org/61897 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-19NB tabbed: update draw tab drop down menu entriesandreas kainz
Change-Id: Id12b92eaa472e59681cf684e6f007476c884cc5a Reviewed-on: https://gerrit.libreoffice.org/61964 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2025-03-01 20:27:18 +0000