summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-20Fix typoAndrea Gelmini
Change-Id: I1032065e6b4dd14ea9aa426375080da416abb180 Reviewed-on: https://gerrit.libreoffice.org/70993 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-20tdf#124810: Roundtrip pivot table style info from XLSX.Mike Kaganski
Also provide a default pivot table style for those tables that don't have a style info. Let's use the style settings that Excel uses. Change-Id: I8006a33a0aa0e92629f7db0a9c24a6ff52d17945 Reviewed-on: https://gerrit.libreoffice.org/70933 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-20Fix typoAndrea Gelmini
Change-Id: Id8422102f776f438e00b40a2ee0ae0b96e4f552a Reviewed-on: https://gerrit.libreoffice.org/70997 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-20Fix typoAndrea Gelmini
Change-Id: I6a22d7b302bd8ef8e06d93f73a13929625a444f7 Reviewed-on: https://gerrit.libreoffice.org/70996 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-20Fix typoAndrea Gelmini
Change-Id: I9040b453bba29c745d74bab54ad982913bdce00a Reviewed-on: https://gerrit.libreoffice.org/70999 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-20Fix typoAndrea Gelmini
Change-Id: I39f878774386c896b842e23b3ad6e6637dc79f64 Reviewed-on: https://gerrit.libreoffice.org/71000 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-20Fix typoAndrea Gelmini
Change-Id: I9f75142304673c7512f92ae82d8d6cfee6f4a8a3 Reviewed-on: https://gerrit.libreoffice.org/70995 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-20tdf#124099 add Chapter Numbering to Home drop down tabandreas kainz
Change-Id: I9f287cd9ded8f2c377cdb7fe6b338f984829d2b6 Reviewed-on: https://gerrit.libreoffice.org/70989 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2019-04-19Fix typoAndrea Gelmini
Change-Id: I1849d00fbccabd4ba39c1c98f0ec3353b2135d41 Reviewed-on: https://gerrit.libreoffice.org/70966 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19Fix typoAndrea Gelmini
Change-Id: I30282339753722d242684b35407577352bbbf771 Reviewed-on: https://gerrit.libreoffice.org/70967 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19Fix typoAndrea Gelmini
Change-Id: I925942a89d7f01c008788aeada8009a37564b02f Reviewed-on: https://gerrit.libreoffice.org/70971 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19Fix typoAndrea Gelmini
Change-Id: Ica38eedeb2733095a1e6d987ad57064cb9be99bd Reviewed-on: https://gerrit.libreoffice.org/70973 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19Fix typoAndrea Gelmini
Change-Id: I84ef63b6c82175132b376122253d3b262a065944 Reviewed-on: https://gerrit.libreoffice.org/70976 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19Fix typoAndrea Gelmini
Change-Id: I10729c848b6b5db0e9880ac2ca27b2d0ef24b5f4 Reviewed-on: https://gerrit.libreoffice.org/70977 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19Further cleanup of FastSerializerHelper's startElement/singleElement[NS]Mike Kaganski
Drop FSEND_t: C-style varargs code was replaced since version 6.0 in commit d43fc40718217d89cc95cc3c0bc0b8e7926abcc0, so it's time to remove the last bits. Drop int-to-string macros that are simple wrappers over OString::number. Avoid unnecessary string type conversions. Change-Id: I86478577b8e469f99b5a90619e5f78a61f4f23fb Reviewed-on: https://gerrit.libreoffice.org/70964 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-19Add XWordBasic.FileSaveAs() and implementTor Lillqvist
Factor out the setFilterPropsFromFormat() also used by SwVbaDocument::SaveAs2000() to a header file of its own. Change-Id: I4bc9e1e420719a115036beb7e82a4ac3feac05f0 Reviewed-on: https://gerrit.libreoffice.org/70980 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-04-19suspicious unbalanced busy/normal cursor settingCaolán McNamara
since initial check-in Change-Id: I0441f3f6d0affa1ccfea57642fc442072111c21b Reviewed-on: https://gerrit.libreoffice.org/70978 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19node.firstChild seen as NoneCaolán McNamara
Change-Id: Ic4d2538f15d6246d81fabe8347a8be157b69deb3 Reviewed-on: https://gerrit.libreoffice.org/70979 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19Change XWordBasic methods to return anyTor Lillqvist
Possibly this is more in line with what callers expect. Change-Id: Ie84b05a0bdb5ef1cb3e1f9fb7df6772831ff4980 Reviewed-on: https://gerrit.libreoffice.org/70975 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-04-19drop some unneeded includesCaolán McNamara
Change-Id: Idde1f747f500d94b3191a97e7d502794cc2b8450 Reviewed-on: https://gerrit.libreoffice.org/70972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19Don't close elements that weren't openMike Kaganski
Found by code reading. Change-Id: I6ebae46e56348d38c595d4c5675f0d3902dee5f7 Reviewed-on: https://gerrit.libreoffice.org/70974 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-19loplugin:sequentialassign in sdNoel Grandin
Change-Id: I7d592b8929ca46c64a622551b039af0d6a7911db Reviewed-on: https://gerrit.libreoffice.org/70716 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-19optimise find/insert patternNoel Grandin
if we're doing a find/insert on a set or a map, it is better to just do a conditional insert/emplace operation than triggering two lookups. Change-Id: I80da5097f5a89fe30fa348ce5b6e747c34287a8d Reviewed-on: https://gerrit.libreoffice.org/70937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-19testAlphaVirtualDevice increase delta to 6Tomaž Vajngerl
Change-Id: Ia771aff267005b32364c441c41be22160009e4e3 Reviewed-on: https://gerrit.libreoffice.org/70970 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-19tdf#42949 Fix IWYU warnings in comphelperGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also re-evaluate some blacklisted headers and recheck include/comphelper/ Change-Id: Ib7eea5951e849c07cea2e2782be4e8945f71ad96 Reviewed-on: https://gerrit.libreoffice.org/70899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19sc: Get rid of the Idle hack in the Special Filter Dialog.Jan Holesovsky
The problem is that with LOK, the creation of Idle here causes a deadlock when the dialog is being opened and its first paint is requested. No real idea what change now causes the problem (this used to work), but given that the use of the Idle is a hack in the first place, let's use the GetFocus/LoseFocus handlers instead, and act accordingly only when the focus of the interesting controls changes. Change-Id: Ib6c0267a064cb31438544e47fe3e0869b575ef7c Reviewed-on: https://gerrit.libreoffice.org/70948 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-04-19drop some includesCaolán McNamara
Change-Id: I6f9765208e807da336146e55f0f1cbcb46316d4c Reviewed-on: https://gerrit.libreoffice.org/70935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19crashtesting: tdf#122599 NSS_CMSMessage_CreateFromDER assertsCaolán McNamara
because NSS_Init wasn't called first Change-Id: Ib1b4c950dc2773af1fea7b64339b86566ee412e7 Reviewed-on: https://gerrit.libreoffice.org/70947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19vcl: Allow for rounding errors on Win32 in testAlphaVirtualDeviceTomaž Vajngerl
Windows Tinerbox fails because of rounding error in blending (but only in some environments), so allow for a small rounding error in colors. Change-Id: If45ae99a445e9d6f795d06d88c902a723913b9a6 Reviewed-on: https://gerrit.libreoffice.org/70932 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-19Remove redundant functions from FastSerializerHelperMike Kaganski
They are identical to what compiler autogenerates from templated overload Change-Id: I0b1361a5dae7e6520a1ec21d735fdebbe0c9a76e Reviewed-on: https://gerrit.libreoffice.org/70959 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-19tdf#45904 Move XChartData Java tests to C++Jens Carl
Fix tdf#43309: Move XChartData Java tests to C++ for ScCellRangeObj. Change-Id: I6b57db53fdddab2ff382354d32809404224a2e1e Reviewed-on: https://gerrit.libreoffice.org/70956 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-19vcl: extend SVM (MetaFile) BitmapEx testsTomaž Vajngerl
Change-Id: I92ce3bbcd7e7d52c53b70a1b9339c2e110c2ccbb Reviewed-on: https://gerrit.libreoffice.org/70926 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-19Further cleanup to not use FSEND and useless string conversionsMike Kaganski
... in XclExpXmlStream::WriteAttributes Change-Id: Ideae6685e7f035970850d86bcaea74c525f1ec81 Reviewed-on: https://gerrit.libreoffice.org/70957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-19SAX_ARGS_ARG macro pack is unusedMike Kaganski
Change-Id: Icb7dca3456b3b355b68e8cb08f91f97b8504575a Reviewed-on: https://gerrit.libreoffice.org/70955 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-19tdf#124649 menubar: show icons for important items breeze, sifrandreas kainz
Change-Id: Ie3209121ade4b12c946dbe878ccc606199d02103 Reviewed-on: https://gerrit.libreoffice.org/70946 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-18tdf#45904 Remove already converted testsJens Carl
Change-Id: I0f7ed57336a4cfa5f143b3c49626dfa8dd590905 Reviewed-on: https://gerrit.libreoffice.org/70953 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-18C++11-ify XclExpXmlStream::WriteAttributesMike Kaganski
This gets rid of some macro mess; and also enables passing OUString as attribute values. Change-Id: I25a8af4adabd905e0016c604d6710c9c5d2f889d Reviewed-on: https://gerrit.libreoffice.org/70952 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-18Resolves: tdf#115964 force password dialog to center on parent size requestCaolán McNamara
this is similar to... commit d17d9500a23705a315992ff42cb7c449894fc2ce Date: Tue Apr 16 14:49:46 2019 +0100 tdf#124597 template select dialog launched before parent gets final size where the dialog is launched before its parent window has got to its final size Change-Id: I0f54a8da482ed75fa939e230b69c0eb918782bf5 Reviewed-on: https://gerrit.libreoffice.org/70943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18Related: tdf#124809 cannot assume that icon size is same as checkbox sizeCaolán McNamara
cause can be using large icon size Change-Id: I4661199b658ff0d2013a7bbd7159b1c134ade043 Reviewed-on: https://gerrit.libreoffice.org/70942 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18Resolves: tdf#124809 spacing ignored unless WB_ITEMBORDER is setCaolán McNamara
Change-Id: I29d63926c605d3f143c242337e31388123f22cff Reviewed-on: https://gerrit.libreoffice.org/70939 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18don't use SwSectionFormats hereNoel Grandin
since SwSectionFormats wants to own the things it points to, and we don't want to own here. The only reason it was working is because we call clear() on the horrible SwVectorModifyBase base class here, which removes the pointers without deleting the pointed-to objects. Change-Id: I8aba61e74ce1463ff4be439c0feb830d1aa8988e Reviewed-on: https://gerrit.libreoffice.org/70940 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18tdf#124822 CRASH: cutting and undoingNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I17312ca978a83a431dfaf6edda2c98e6302eb2d1 Reviewed-on: https://gerrit.libreoffice.org/70938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18forcepoint#80 avoid crashCaolán McNamara
Change-Id: I7a96d2951fbcd5f53a2f7e65e8c07926fc035a11 Reviewed-on: https://gerrit.libreoffice.org/70936 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18forcepoint#79 FindStartEndOfRowSpanCell returning nullCaolán McNamara
Change-Id: I85f5b17b7dc2d3c4dfef92f64451fab451f58112 Reviewed-on: https://gerrit.libreoffice.org/70927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18weld ScOptSolverDlgCaolán McNamara
Change-Id: Ie2b43377f950cb16e143f6e9ef7081bf92277088 Reviewed-on: https://gerrit.libreoffice.org/70903 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18Update git submodulesStephan Bergmann
* Update helpcontent2 from branch 'master' - Don't set LANG env var by accident ...as setting a GNU Make LANG var exports it to recipes as an env var, and see e.g. 56bc0b1a376f62570a7287e9bb4193e00360c978 "Don't set locale env vars on macOS" for potential problems caused by that. This is the help half of a change spanning the core and help repos. Change-Id: Ib5faf612e9030db384f7408ecd4fd03e65120f17 Reviewed-on: https://gerrit.libreoffice.org/70930 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-18Don't set LANG env var by accidentStephan Bergmann
...as setting a GNU Make LANG var exports it to recipes as an env var, and see e.g. 56bc0b1a376f62570a7287e9bb4193e00360c978 "Don't set locale env vars on macOS" for potential problems caused by that. This is the core half of a change spanning the core and help repos. Change-Id: Ib7ae3b6edcef0b70e211a01aad4b3bd5c8905e06 Reviewed-on: https://gerrit.libreoffice.org/70929 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-18Disable OpenCL by default for LO FlatpakStephan Bergmann
...merging <https://github.com/flathub/org.libreoffice.LibreOffice/commit/ 2c72c8b2c9beb4995c5a57b4eedf05f6c7ff248d> "Disable OpenCL by default for LO Flatpak": "This fixes <https://github.com/flathub/org.libreoffice.LibreOffice/issues/82> 'LibreOffice cannot be launched with flatpak in normal mode on ASUS E402YA', where LO was found hanging (for as yet unclear exact reasons) on one machine when OpenCL was enabled. There have been other issues with OpenCL like <https://bugzilla.redhat.com/show_bug.cgi?id=1432468> 'LibreOffice crashes on startup' on Fedora, so for a Flatpak build targeting a wide range of distros, the conservative approach is probably to disable OpenCL by default and have users explicitly enable it instead." Change-Id: I887137d1ceb5d97f007f09cba636c59f197f1bff Reviewed-on: https://gerrit.libreoffice.org/70928 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-18tdf#124818 CRASH selecting all and switching spreadsheetNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I033bcae2bdc97c3aae24557c5949c7759041b3bc Reviewed-on: https://gerrit.libreoffice.org/70925 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18tdf#43157 Clean up OSL_TRACE (replace with SAL_INFO)Jens Carl
Change-Id: Ifa196dec38d1b84ef14e9bb3a6b45d5ead72064a Reviewed-on: https://gerrit.libreoffice.org/70904 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins