summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-20[en_US] Added 13 autocorrect wordsMarco A.G.Pinto
Change-Id: Ie9081b555dba3ebb78889668d9c33ebb89e20028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88958 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2020-02-20[en_GB] Added 13 autocorrect wordsMarco A.G.Pinto
Change-Id: I7648de22f85cb1532c2f02fb355107161cc3484e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88957 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2020-02-19set correct initial drag imageCaolán McNamara
Change-Id: Ic2ec18432de7a73356e12c46b7e70ecae8c0ffb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19related tdf#80194 editeng RTF: set automatic subscript for \subJustin Luth
The RTF specs say that \sub means "Subscripts text and shrinks point size according to font information." while \up is unambiguous with "Subscript position in half-points (the default is 6)." So, \sub leaves it up to the program to set the best values for subscripting or superscripting. That would correspond to the auto values. Previously, this translated into a 26% superscript (close to the default of 33%) and a 26% subscript (which is way too low). For unit tests: although I managed to open an RTF file in draw, it had no text in it, so I couldn't write a test. In the UI, you use the Page menu to "Insert page from file". Change-Id: I06003dbe2177fc87237624438b4daaaaf2482631 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89020 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-02-19sw table cell borders: add optional Word-compatible border collapsingMiklos Vajna
We always compared border width and other aspects only after that, Word works with border weight according to their implementer notes. So extend svx::frame::Style to be able to collapse borders using weights and opt in for that from sw/ in case a compat mode (which is related to tables, off by default and is set by the DOC/DOCX import) is set. Change-Id: I1f682789302c88a0d326c6c0263ad3007441cb24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89052 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-19Proper alignment for labelHeiko Tietze
Amends I321c7e0e3cb2d67a07724523c885d50577a116a5 Change-Id: Ib89bddf36c81dbfaa4c6562a342cf3f8a423eaa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89017 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-19tdf#129553 sw_redlinehide: fix replace of paragraph breaks with $Michael Stahl
The problem is that in the special selections that replace paragraph breaks, the start and end node are actually different, hence have different text frames. (regression from 5e81b966778d82692b4763d892b457186a7f269d) Practically the end content index is going to be 0 typically which doesn't need mapping, but not sure if that's guaranteed anywhere. Change-Id: I77c95c2f3e55edcc7aca6f4540cae90b3be5d79b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89050 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-19start center is too narrowCaolán McNamara
since... commit c214ad383d5e7dc0a18dbe6cbfc1e32fea934fd9 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Feb 18 15:22:23 2020 +0000 support WB_SMALLSTYLE via small-toolbar icon size Change-Id: Iaef2b9485d7bbd0f380be18e40220b5383d03d3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19Related: tdf#130772 Prepare id-ID currency formats to ref-derive fromEike Rathke
Change-Id: I35a5311b9b9b6c5dd76352fdf12d64361bbaa5fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89024 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-19Update the reference rdbs to libreoffice-6.4.0.3-buildfix1Stephan Bergmann
LD_LIBRARY_PATH=.../master/instdir/program \ .../master/workdir/LinkTarget/Executable/unoidl-read --published \ .../libreoffice-6.4.0.3-buildfix1/instdir/program/types.rdb \ >.../master/udkapi/type_reference/udkapi.idl LD_LIBRARY_PATH=.../master/instdir/program \ .../master/workdir/LinkTarget/Executable/unoidl-read --published \ .../libreoffice-6.4.0.3-buildfix1/instdir/program/types.rdb \ .../libreoffice-6.4.0.3-buildfix1/instdir/program/types/offapi.rdb \ >.../master/offapi/type_reference/offapi.idl * no changes Change-Id: Ic6663271acfdf954f51f4bbd4dea20971264c87b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89046 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-19can avoid including svtools/ctrlbox.hxxCaolán McNamara
Change-Id: I953089dd1416cd24721241fff3a6d21354211a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19sw: remove dead code in SwLayHelper::CheckInsertPage()Michael Stahl
If SwFormatPageDesc is inited like that GetNumOffset() cannot have value. Change-Id: I4f303148c82541ef9d8fa6284018cfba35f20524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88980 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-19sw: replace confusing nVirtPageNum that is actually physical pageMichael Stahl
... in SwExtraPainter::SwExtraPainter(). Change-Id: Iac8a849b5fab25c80e81c61b267100a3fc3e2d26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88979 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-19tdf#125682 sw: don't insert empty page before first page with even numberMichael Stahl
This mostly reverts commit 14bb680949b47332d2921cc68f75340b31ad5c32 and replaces it by a hopefully better approach: if the first page in the document has an even number, it will become a right page, and "toggle" the document so that even pages are right pages and odd pages are left pages. This is closer to what Word does; the tests adapted in the above commit were actually regressions. Add a new function IsRightPageByNumber() to determine how the page number offsets should be interpreted. Also make it explicit that even/odd and right/left page are no longer synonymous by renaming various "Odd" variables. Historically documents that start with even page number didn't work well anyway; before the above commit you'd get a left page followed by a left page followed by a right page, which is clearly nonsense if the page style differs between left and right pages - so hopefully we can do without a compat setting for those. There is still one situation where an empty page is inserted before the first page: if the page style is "Left Page"; this appears to be impossible in Word so we'll have issues exporting that to Word formats anyway. Testing: Writer pre-commit; LO 5.4/OOo 3.3: 1.odd -> right, 2.even -> left 1.even -> left, 2.odd -> right + inserts a blank page on the right after reload: 1.even -> left, 2.odd -> left, no empty page Writer w/ commit; LO 6.0+: 1.odd -> right, 2.even -> left 1.even -> left, 2.odd -> right + blank page as first page (right) after reload: 1.even -> left, 2.odd -> right + blank page as first page (right) Word: 1.odd -> right, 2.even -> left 1.even -> right but left style, 2.odd -> left but right style [technically uses terminology even/odd instead of left/right, but if mirrored, the "inner margin" is always the same and leads to interpretation of left/right] Writer and Word appear to agree on inserting empty pages on SwFormatPageDesc items/Word section breaks: both even-ness of an explicit page number and "Left Page" only page style or explicit even/odd section break may insert empty page. A useful improvement would be to detect in Word import filters that the first page is even numbered and then invert the mapping of all of the page styles, i.e. odd header/footer->left instead of right, and if mirrorMargins, pgMar left -> inner instead of outer. Change-Id: Ibed0dbf888c120a3a7d11892f40d07ffb5bc0b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88978 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-19tdf#118812 DOCX import: fix table style preference – part 2László Németh
Apply table styles according to OOXML and – in the case of font sizes – MSO exception "overrideTableStyleFontSizeAndJustification". Fix temporary regression in styles of paragraph portions, table cell regions and nested tables from commit f15d67442972c5f69c71925a6bfa5aa1a39d54eb (tdf#129575 DOCX import: fix table style preference). Unit test document was created by Justin Luth. Change-Id: I7b076ac27f5b44d44934b7efb18ac4a878f8b596 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88869 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-19Resolves: tdf#130400 reserve ctrl+page_up and ctrl+page_down for notebooksCaolán McNamara
Change-Id: I627298cb844967eeb1e166720e3951be732a4dc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89016 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19Resolves: tdf#129446 explicitly pass the mouse event windowCaolán McNamara
instead of letting it pick the main-window as the event window Change-Id: I953968025717ac5ba6f41e8f2db90c9f4d24800f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89015 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19Resolves: tdf#130762 honour "wrap" in FormattedFieldCaolán McNamara
Change-Id: Iefd9a537aa358eab179cf6f0eeb6f80a9a77284a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89011 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19avoid pointless alpha->mask conversionLuboš Luňák
The code is from 2008, so I'm rather sure at least Skia is modern enough to handle alpha at least as well as a mask (if not better). Change-Id: Ic53d5740978bce106506a182100eba927a419257 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89010 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-19BitmapAccessMode::Info does not need bitmap dataLuboš Luňák
This was needlessly bailing out if the bitmap data wasn't ready but it wasn't necessary either. Change-Id: Ia2b78920f614f71630d31c353091c807d1db2af6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89009 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-19Turn SfxGlobalEvents_Impl into an XComponentStephan Bergmann
...so that it can drop all its UNO references during shut down of the service manager (when every XComponent service/singleton will be disposed), and not keep other UNO objects alive until exit as has been discussed in the comments of <https://gerrit.libreoffice.org/c/core/+/85367/2# message-ecbc68109994a471c1033a4e6eab0dfd562dca1c> "Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)". Change-Id: Ife7cdbe5baad9b3eb4d1ab8687d4dd2970200997 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89005 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-19drop newly unused methodsCaolán McNamara
Change-Id: I390134b3cd0187f0adcced3625ad0a3a26f8fe28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89008 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19weld CodeCompleteWindowCaolán McNamara
Change-Id: Ibe620a42592761ee25d6329d26b1b1c452bdfd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89007 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19work around a driver/card(?) problem with Skia and AA-ed polygonsLuboš Luňák
See description in SkiaSalGraphicsImpl::drawPolyPolygon(). Change-Id: I4b2626e26cac6d145b417426fc2575845386db57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88941 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-19tdf#42982 add detail exception reason for UnoControlsnienzu
Change-Id: Ia62a0015d68fe819113322e27b93054d38d98aea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88996 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-19make Mac Jenkins build use --enable-optimizedLuboš Luňák
Since ccache is used, this will hopefully on average improve Jenkins build times by making tests run faster while compilations will usually get cached. Change-Id: I191f826f704001b83130c8baf6889a7a2b33ca7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88919 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-19make Linux Clang Jenkins builds use -OgLuboš Luňák
This should make builds run faster because unittests will run faster, while the compilations shouldn't take longer (primarily because of ccache use). Change-Id: I6ea5d7566397b09339b06a515712a9162df6e9fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88918 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-19add --enable-optimized=debugLuboš Luňák
This will use -Og with GCC/Clang instead of -O0, which should make unittests run faster without (hopefully) breaking anything related to debugging. This is primarily meant to Jenkins builds, where debug info is rarely needed (backtraces for unittest crashes AFAICT). This can be also used to make LO itself run faster when developing, but I personally do not find it worth it (with Clang and full PCH this makes starmath build take about 70% longer, although presumably for non-PCH builds the relative increase will be smaller). Change-Id: I198d0759ebca94c90be662e02e0f1281a24d1d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88917 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2020-02-19tdf#130404 python3: add new windows .pyd modules for 3.7Michael Stahl
Unfortunately forgot that in b10be5d48433076f0b7238d818020f708553e114 Change-Id: I59043a576c45f9329a3fad9a5d50e7fefa901934 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88977 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-19merge common code togetherCaolán McNamara
Change-Id: I1c514c1a83dac4556ad68b44972a97fb4b3384e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19remove and replace newly unused ctorCaolán McNamara
Change-Id: I67e0dc6fe419ad0cac04105cb2e89435dd3fc107 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88990 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19drop some unneeded includesCaolán McNamara
Change-Id: Ia7cd7968346ce724ef763ce9578190ae12bdc5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88932 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19move svtabbx.hxx to vcl/toolkitCaolán McNamara
Change-Id: Id4cf566f896b15b8d4e4cafbb92a990cedb447e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19weld WatchWindow panelCaolán McNamara
Change-Id: Idb43d7bd168ce37fce8694946be6c7de7ca5a2c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88930 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19support WB_SMALLSTYLE via small-toolbar icon sizeCaolán McNamara
Change-Id: I1c232a9e14df8a15142c1670f848c32fc0a245c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19Related tdf#130681: convert number format if model not deletedJulien Nabet
Opening docx from https://bugs.documentfoundation.org/attachment.cgi?id=157891 I noticed this log: warn:legacy.osl:151346:151346:oox/source/drawingml/chart/objectformatter.cxx:1113: ObjectFormatter::convertNumberFormat - cannot create number format '' bt: 0 0x00007fffdb9129f1 in oox::drawingml::chart::ObjectFormatter::convertNumberFormat(oox::PropertySet&, oox::drawingml::chart::NumberFormat const&, bool, bool) (this=0x55555cb5ef10, rPropSet=..., rNumberFormat=..., bAxis=true, bShowPercent=false) at /home/julien/lo/libreoffice/oox/source/drawingml/chart/objectformatter.cxx:1098 1 0x00007fffdb8ede01 in oox::drawingml::chart::AxisConverter::convertFromModel(com::sun::star::uno::Reference<com::sun::star::chart2::XCoordinateSystem> const&, oox::RefVector<oox::drawingml::chart::TypeGroupConverter>&, oox::drawingml::chart::AxisModel const*, int, int) (this=0x7ffffffedb70, rxCoordSystem= uno::Reference to (chart::PolarCoordinateSystem2d *) 0x55555cb5b590, rTypeGroups=..., pCrossingAxis=0x55555d413560, nAxesSetIdx=0, nAxisIdx=1) at /home/julien/lo/libreoffice/oox/source/drawingml/chart/axisconverter.cxx:344 2 0x00007fffdb92b96e in oox::drawingml::chart::(anonymous namespace)::AxesSetConverter::convertFromModel(com::sun::star::uno::Reference<com::sun::star::chart2::XDiagram> const&, oox::drawingml::chart::View3DModel&, sal_Int32, bool) (this=0x7ffffffedd90, rxDiagram=uno::Reference to (chart::Diagram *) 0x55555d905d38, rView3DModel=..., nAxesSetIdx=0, bSupportsVaryColorsByPoint=true) at /home/julien/lo/libreoffice/oox/source/drawingml/chart/plotareaconverter.cxx:167 3 0x00007fffdb92d32d in oox::drawingml::chart::PlotAreaConverter::convertFromModel(oox::drawingml::chart::View3DModel&) (this=0x7ffffffedfb0, rView3DModel=...) at /home/julien/lo/libreoffice/oox/source/drawingml/chart/plotareaconverter.cxx:425 4 0x00007fffdb8fb4b8 in oox::drawingml::chart::ChartSpaceConverter::convertFromModel(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, com::sun::star::awt::Point const&) (this=0x7ffffffee090, rxExternalPage=empty uno::Reference, rChartPos=...) at /home/julien/lo/libreoffice/oox/source/drawingml/chart/chartspaceconverter.cxx:163 5 0x00007fffdb8f3af4 in oox::drawingml::chart::ChartConverter::convertFromModel(oox::core::XmlFilterBase&, oox::drawingml::chart::ChartSpaceModel&, com::sun::star::uno::Reference<com::sun::star::chart2::XChartDocument> const&, com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, com::sun::star::awt::Point const&, com::sun::star::awt::Size const&) (this=0x55555dc08800, rFilter= ..., rChartModel=..., rxChartDoc=uno::Reference to (chart::ChartModel *) 0x55555d4cc190, rxExternalPage=empty uno::Reference, rChartPos=..., rChartSize=...) at /home/julien/lo/libreoffice/oox/source/drawingml/chart/chartconverter.cxx:101 6 0x00007fffdba48a22 in oox::drawingml::Shape::finalizeXShape(oox::core::XmlFilterBase&, com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&) (this=0x55555dbdc450, rFilter=..., rxShapes= uno::Reference to (SwXDrawPage *) 0x55555dbbbfe0) at /home/julien/lo/libreoffice/oox/source/drawingml/shape.cxx:1717 Change-Id: I9196532025eb0b3ff2b73cac2c5bac3726fe0761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88761 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-19use FILE_ATTRIBUTE_TEMPORARY on Windows for temp filesNoel Grandin
which acts as a hint to the OS that these files do not need persistent storage. If there is sufficient system RAM, these files will never even hit disk. Change-Id: I25b83aad67fda58ec39cead8bd1eb038892d3cde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-19uitest: make sure UITEST_TEST_NAME matches exactly one test functionMiklos Vajna
So that something like: make -sr UITest_cui_dialogs UITEST_TEST_NAME="chardlg.Test.testSvxCharEffectsPageWriterAutomatic" Only executes testSvxCharEffectsPageWriterAutomatic, not testSvxCharEffectsPageWriter and testSvxCharEffectsPage as well. Change-Id: I0ed334259634e3b9b0db45d9f8462eb4accc689e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88987 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-19change label in print dialog from "OK" to "Print"Seth Chaiklin
Change-Id: I1d6b04678ab039138908bc9555763bea057fa996 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88212 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-19add some libs to libmergedNoel Grandin
another small chunk of libs shared by calc/write/impress, doing this in stages in case anything goes wrong. Change-Id: I7bb47bf1dfa0cc12cbcb881da8405bdef41cb378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-19Keep focus in Writer Navigator after content deleteJim Raykowski
When deletable content in Writer Navigator is deleted by pressing the delete key, focus remains in the content tree. When the delete menu item is used, focus changes to the document window. This patch changes focus behaviour of menu item use to that of key press. It keeps focus in Writer Navigator after content delete is done from the Writer Navigator. Change-Id: Ie96e3c55f0cd95c6955e65f9de5d38ddd134d30e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87171 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-19add colon to label with buddy control in "Rename object" dialogboxSeth Chaiklin
Change-Id: I93fc87ee8d0d1a4546fbe2e7c9f9adae0e092811 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88792 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-19Fold chapter strings in to one pluralized stringJim Raykowski
Change-Id: I3b1198a4ade99baa84923ff5b628e2c3ef1839be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88906 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-02-18tdf#130648 add colibre 32px protect iconsandreas kainz
Change-Id: I5c1d2a37f88745820cbae693a1e9897c922de13c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88981 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-18Resolves: tdf#130757 Add Minangkabau [min-ID] to language listEike Rathke
Change-Id: I901e64c223723bf2eac908dda80796a7a2799147 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88985 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-18Update git submodulesRoman Kuznetsov
* Update helpcontent2 from branch 'master' to ffa172bf7f370d7450cca3d45c9f8138a7d3c139 - tdf#130402 Wrong explanation to the "Text Orientation" in Calc Help Change-Id: Iee3e9401494608ce79bf6ef82915bef3703d9eac Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88949 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-18Drop obsolete XEventBroadcaster again from XGlobalEventBroadcasterStephan Bergmann
272f0e97b12e634cdf49a1bff45e1b9068af7d9c "Improvements on previous commit" had "[m]ade XGlobalEventBroadcaster inherit document::XDocumentEventBroadcaster/ Listener replacements for obsolete document::XEventBroadcaster/Listener. This means some client sides unfortunately still need to use UNO_QUERY_THROW to obtain the obsolete interfaces; those client sides should be cleaned up to use the replacement interfaces instead." But then 13bedc55b1d533eadcfd4932ef57076e3642caaf "fdo#46808, use service constructor for frame::GlobalEventBroadcaster" unhelpfully added XEventBroadcaster back to XGlobalEventBroadcaster because the AutoRecovery code in framework/source/services/autorecovery.cxx still used the XEventBroadcaster interface via UNO_QUERY (but which was actually as intended). (And 79e0e713f798718902fed9740f147ce143bf7b76 "Update to XDocumentEventBroadcaster et al" meanwhile cleaned up the AutoRecovery code to use XDocumentEventBroadcaster instead of XEventBroadcaster, anyway.) This could be considered an incompatible change to XGlobalEventBroadcaster, but which is an unpublished interface added only in LO times, so lets assume that no 3rd-party code relies on its obsolete XEventBroadcaster interface. SfxGlobalEvents_Impl keeps implementing XEventBroadcaster (as well as XEventListener) for backwards compatibility. Change-Id: I13a5a7fc45d0b79acfdcd3e11bd9b8cc0ece6314 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88986 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-18Revert too aggressive clean-upStephan Bergmann
This part of the code was not meant to be removed by 2ff77d088424bc3f5a8e38ef5c1aa3457d102eca "SfxGlobalEvents_Impl::m_xEvents is never changed and never null". Change-Id: I0947457b9b5b6cd79f9ea0aea63265d656787f47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88984 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-18Remove unused HAVE_FEATURE_LDAPStephan Bergmann
It was introduced with 6776c53b7ce2e431d8636f4e5a755f50f787ec8f "Make LDAP support optional", but it appears that it has been unused right from the start. Change-Id: Ia4afe23433c42e279a36a030bd661b26da72735e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88945 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-18SfxGlobalEvents_Impl::m_xEvents is never changed and never nullStephan Bergmann
It is always set in the SfxGlobalEvents_Impl ctor with m_xEvents = new GlobalEventConfig(); This code added with 3ddbfc311cd4471a6733b2d9dee338d3a80416c7 "INTEGRATION: CWS fwkpostbeta03" appears to be nonsense boilerplate. Change-Id: I6a6a75c619015815a8c6231862cd162de6361ecb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88969 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-28 21:21:08 +0000