summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-12-01Unused codeKhaled Hosny
Change-Id: Idfc964930c242d752a78cd109d75d809bce4de11 Reviewed-on: https://gerrit.libreoffice.org/31470 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-12-01tdf#104126 - comphelper thread-pool, use reliable std::condition_variable.Michael Meeks
The existing osl::Condition is an API and reliability disaster area. Change-Id: I3be84e1c6a83e58c43c40c9c8720790d923a6694 Reviewed-on: https://gerrit.libreoffice.org/31163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-12-01tdf#104310: Accept also x14-style dataValidationsMike Kaganski
See https://msdn.microsoft.com/en-us/library/dd921584 Change-Id: I66c9474cbf83cea10ab0e7c2b44592673c8b683f Reviewed-on: https://gerrit.libreoffice.org/31456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-01Add toolbar button for page orientationMuhammet Kara
Change-Id: Ia9458f8ac32bb8c6da6fc08e5fee527ca6fb8bd5 Reviewed-on: https://gerrit.libreoffice.org/31473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-12-01tdf#102621: import empty chart cells as NaN instead of 0Jean-Tiare Le Bigot
Change-Id: I574c3f719e52bc2244597532783130564621a891 Reviewed-on: https://gerrit.libreoffice.org/31303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-01gbuild: replace -O0 with -Og for GCC --enable-debug/dbgutil buildsMichael Stahl
With Fedora 25 GCC 6.2.1 and my usual config (except without --with-package-format since that is slowest now) on commit 086631af59636cd9a6a45b747a1bc59b4b547794 i get with CCACHE_DISABLE=1: With -O0: "make check" 44490.70user 3127.01system 1:15:23elapsed 1052%CPU (0avgtext+0avgdata 2541312maxresident)k "make check", incremental 7368.19user 153.98system 15:30.06elapsed 808%CPU (0avgtext+0avgdata 510200maxresident)k "make CppunitTest_sc_functions_test" 272.13user 0.65system 4:33.47elapsed 99%CPU (0avgtext+0avgdata 258884maxresident)k With -Og: "make check" 46076.01user 3170.91system 1:16:19elapsed 1075%CPU (0avgtext+0avgdata 2613716maxresident)k "make check", incremental 5478.33user 157.07system 11:50.42elapsed 793%CPU (0avgtext+0avgdata 454980maxresident)k "make CppunitTest_sc_functions_test" 188.48user 0.62system 3:09.59elapsed 99%CPU (0avgtext+0avgdata 259096maxresident)k So we now have so many tests that the time taken by GCC doing optimization is brought back via the tests finishing faster, particularly if we assume a non-negligible ccache hit rate for developers in practice. Add this to gb_DEBUG_CFLAGS instead of gb_COMPILERNOOPTFLAGS because presumably the bridges code that uses gb_COMPILERNOOPTFLAGS really wants -O0; the gb_DEBUG_CFLAGS is added later so -Og overrides -O0. It is an open question how well debugging in gdb actually works with -Og, some experimentation is needed; "man gcc" claims: If you are not using some other optimization option, consider using -Og with -g. With no -O option at all, some compiler passes that collect information useful for debugging do not run at all, so that -Og may result in a better debugging experience. Change-Id: I103499f398b69397cf5aa9993a242680966ce999 Reviewed-on: https://gerrit.libreoffice.org/31334 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-01enable optimization (-Og) with --enable-debugLuke Deller
gcc-4.8 introduced a new optimization level -Og which enables optimizations that do not interfere with debugging. When configured with --enable-debug, use -Og rather than -O0 if available. Change-Id: Iff3f98d736681ae34e49b96510228a14ce456b34 Reviewed-on: https://gerrit.libreoffice.org/31333 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-12-01xmlsecurity PDF verify: handle boolean type as dictionary valueMiklos Vajna
This caused not finding the length of a stream -> could not actually verify signature. Change-Id: I696b6da49525eb53f7575c27f619d2116be51f1d Reviewed-on: https://gerrit.libreoffice.org/31490 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-01tdf#90753: AutoInstall gengal with filelist featureMatúš Kukan
Change-Id: Ic72fb18eccb54b24f4205d997585cee753965b10
2016-12-01tdf#97803: gbuild: Check that resource targets are registeredMatúš Kukan
And replace gb_AllLangResTarget_ALLTARGETS with gb_AllLangResTarget_REGISTERED which should have the same content and is already used. This actually helped to find a problem, fixed in 52d409f0d657f314a53f945c9ffb5b8025bea034 Change-Id: Iae551d7be221c5655dee1bc9ad273c8822d45178
2016-12-01BitmapFilter, BitmapScaleSuper only used within vclStephan Bergmann
Change-Id: Ia8a1207a584b599f01c47b658692d3eeae52cb3a
2016-12-01add MODE test caseZdeněk Crhonek
Change-Id: Ib6aecbcc993f2b8898a2c9855181d3b7db1f9840 Reviewed-on: https://gerrit.libreoffice.org/31444 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-01xmlsecurity PDF verify: CR is also a terminator of a commentMiklos Vajna
If we skip to the first NL, then we start tokenizing some XML as PDF data and soon error out due to an unexpected keyword. Change-Id: I86b540a014e5a92ea4376ed765385a2ee568a3c1 Reviewed-on: https://gerrit.libreoffice.org/31472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-01xmlsecurity PDF verify: tolerate missing %%EOF in incremental updatesMiklos Vajna
This is broken, but work it around to avoid an infinite loop. Change-Id: I132a3c19cfe53e6166bfc1a881d1bfa5071f85d4 Reviewed-on: https://gerrit.libreoffice.org/31471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-01Fix race in ThreadTaskTagStephan Bergmann
Assume T0 calls ThreadPool::pushTask twice, then ThreadPool::waitUntilDone: T0 calls ThreadTaskTag::onTaskPushed: mnTasksWorking = 1, maTasksComplete.reset T1 runs the 1st task to completion and calls ThreadTaskTag::onTaskWorkerDone: mnTasksWorking = 0; suspended... T0 calls ThreadTaskTag::onTaskPushed: mnTaskWorking = 1, maTasksComplete.reset T1 continues in the call to ThreadTaskTag::onTaskWorkerDone: ..., maTasksComplete.set T0 calls ThreadTaskTag::waitUntilDone and immediately returns T2 only now starts to run the 2nd task Change-Id: Ic29101a4791fca2a1a4d54b559f10ff706e8a20d
2016-12-01loplugin:unnecessaryoverride (dtors) in salStephan Bergmann
Change-Id: I498bb634f2a5800f5effab99227aa4699ed91aae
2016-12-01Throw RuntimeException with messageStephan Bergmann
...seen JunitTest_sc_unoapi_4 fail once in sc.ScHeaderFooterTextCursor::com::sun::star::text::XTextRange with an empty RuntimeException when calling some remote getString. Change-Id: Id631feffce810b40825fe0fa49d8f1846f045033
2016-12-01xmlsecurity PDF verify: support non-detached signaturesMiklos Vajna
And a couple of other changes to accept the bugdoc from <https://github.com/esig/dss/ dss-pades/target/test-classes/plugtest/esig2014/ESIG-PAdES/RO/Signature-P-RO-4.pdf>. Change-Id: I0fca9ba0bfe927ef91ae2592a5026b05d19879fd Reviewed-on: https://gerrit.libreoffice.org/31462 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-01xmlsecurity: instantiate SAXEventKeeperImpl directly in XSecControllerMiklos Vajna
Going via UNO for a class in the same module is an overkill. Change-Id: I577660513022fde1576df19b412fcdb1ee2ad041 Reviewed-on: https://gerrit.libreoffice.org/31461 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-01Kill old Windows layout enginesKhaled Hosny
Change-Id: I33f8322a6371150698bf926165fb6dddb9d4092c Reviewed-on: https://gerrit.libreoffice.org/31452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-12-01tdf#103477 Add unit testMuthu Subramanian
Change-Id: Ic960da6a479523a9255357d5f4cede212ff9c6a2 Reviewed-on: https://gerrit.libreoffice.org/30404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-12-01tdf#80196 - another attempt at renaming to tonal.soc and adjusting namesV Stuart Foote
now for 5.4.0 master and dropping abreviations Change-Id: I72dbbab2688709e8266be93b40040c4c6c970d55 Reviewed-on: https://gerrit.libreoffice.org/31217 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-12-01loplugin:unnecessaryoverride (dtors) in testtoolsStephan Bergmann
Change-Id: If004c2c58cb92e211cea34b54c3c38c91ccb6e7d
2016-12-01loplugin:unnecessaryoverride (dtors) in toolkitStephan Bergmann
Change-Id: Id95c044e75eccb0f394fd31e4776eda4c023341d
2016-12-01loplugin:unnecessaryoverride (dtors) in ucbhelperStephan Bergmann
Change-Id: I7d77af190087e5f7190849c1e316c9d4f178a6c2
2016-12-01loplugin:unnecessaryoverride (dtors) in unotestStephan Bergmann
Change-Id: Ib9114cafb3732d11017b98405d1ca60052801675
2016-12-01loplugin:unnecessaryoverride (dtors) in xmloffStephan Bergmann
Change-Id: I351ff5955d766118e3a6b2234181774af0d1f522
2016-12-01tdf#103477 buClrTx => use text color insteadMuthu Subramanian
Change-Id: I82d9231d2d0ea95cadc803f9a8dab9c23b88a677 Reviewed-on: https://gerrit.libreoffice.org/30403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-12-01fix cross-toolset: gb_Helper_optional_for_host can't contain 'newline'Matúš Kukan
Otherwise, the 'newline' is passed as a second parameter to gb_Module_add_moduledir which breaks build. :/ Change-Id: I02eba5ddef9f7a6dccbb7d135a7e8c68629da9c4
2016-11-30add MINA test caseZdeněk Crhonek
Change-Id: I746f85503aef14d3e5730ffcf67689ae00dc8f10 Reviewed-on: https://gerrit.libreoffice.org/31442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-30add MINIFS test caseZdeněk Crhonek
Change-Id: I7b4403dda5e4f06ad51618f3aac50b17103ee265 Reviewed-on: https://gerrit.libreoffice.org/31443 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-30add MODE.SNGL test fileZdeněk Crhonek
Change-Id: I1943547d22df7580467814300e4d372fd20b197f Reviewed-on: https://gerrit.libreoffice.org/31448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-30split the functions test in even more categoriesMarkus Mohrhard
Change-Id: I3ca640a24e95d1e6e0ad66be7bf09c45d63b52bb Reviewed-on: https://gerrit.libreoffice.org/31447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-30better varyColors export for charts, related tdf#103943Markus Mohrhard
Change-Id: I4280e708c854c687b6281c56d5bccdb514afd81e Reviewed-on: https://gerrit.libreoffice.org/31252 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-30start to split the functions test by categoryMarkus Mohrhard
Change-Id: Ib06eaee7cf5eeb3dbe95ad42afc2a17caa0359c2 Reviewed-on: https://gerrit.libreoffice.org/31440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-30Use smart pointers for gdi pdf functionsMark Page
Change-Id: Ia78adfbd0d07449e12a7e0d02acf8a1a1108437c Reviewed-on: https://gerrit.libreoffice.org/31421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-30When overreading gif sub blocks, do not read skipped bytesMark Page
We do not require to read in gif extension data when it is ignored This is used to skip the Adobe XMP gif extension Change-Id: Id64f373a4eae764227c0b7ac6687697666991ec7 Reviewed-on: https://gerrit.libreoffice.org/31410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-30Use smart pointers for allocated objects in the gif loaderMark Page
Change-Id: Ib9d3bc05fbccc882df8913d3ffcb36be6a9f06dd Reviewed-on: https://gerrit.libreoffice.org/31401 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-11-30gbuild: Prevent wrong use of gb_Helper_optional_for_hostMatúš Kukan
It's empty, unless gb_Side=build. This fixes commit 1193443b15b0e38cbfb41573b31acf9a8d90ce2c Change-Id: I83efad36d8f40c460d09ee1bd1addd7fb26c177b Reviewed-on: https://gerrit.libreoffice.org/31419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-30don't hold vector as pointer here ...Jochen Nitschke
and make impl types private Change-Id: I7ead64bac38da3d813e0b47fa124970937c36617 Reviewed-on: https://gerrit.libreoffice.org/31438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-30tdf#90753: AutoInstall more packagesMatúš Kukan
Change-Id: If8a52f652f7ab890826372b6d081ee19c69fb5ec Reviewed-on: https://gerrit.libreoffice.org/31371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-30tdf#90753: Autoinstall sdk packagesMatúš Kukan
Change-Id: I54de722335d443813cb4526716c0101a049db03f Reviewed-on: https://gerrit.libreoffice.org/31370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-30Updated coreGabor Kelemen
Project: help b89f9d02d9b4d562ff3ac7721fa79933773a5d2b tdf#98608 (partial) Elements window is gone Now we have a side pane with a listbox and no icons to select categories Change-Id: Icee8308583acd943083178103c9d5e74420a7e74 Reviewed-on: https://gerrit.libreoffice.org/31402 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-11-30Updated coreGabor Kelemen
Project: help 61bd3800d0ac92780a85475b7a8a36f0078e1c43 tdf#98608 (partial) Remove mentions of the Elements window Change-Id: I37b0a3530b76dada8d48e217da18ba7b0e7b9f32 Reviewed-on: https://gerrit.libreoffice.org/31403 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-11-30Updated coreGabor Kelemen
Project: help b6eb1fca843d6cebf2db98dde302a4ea6c5c364b tdf#98608 (partial) Remove mentions of the Elements window Change-Id: Ie8564d97761ab7163f5ee39b6ba53d662b646e32 Reviewed-on: https://gerrit.libreoffice.org/31404 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-11-30Updated coreGabor Kelemen
Project: help 36b80c0c5b7a8c569e534a5a54ba4a6fc17b14c7 tdf#98608 (partial) Remove mentions of the Elements window From table headers too Change-Id: I2ee638c411c6e144e6d5894a8dc4d00dc42b3f89 Reviewed-on: https://gerrit.libreoffice.org/31405 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-11-30Updated coreGabor Kelemen
Project: help dc58cd4bad6eb4624854f10b4332689f4484f606 tdf#98608 (partial) Remove mentioning the Elements window The keyboard navigation is completely broken here so not touching the main part about that. Change-Id: If66823294224e39a92d30d9a0b66cee872584ff7 Reviewed-on: https://gerrit.libreoffice.org/31406 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-11-30Updated coreGabor Kelemen
Project: help 57fe161436d04e8edddd92b80a5b9409546482dc tdf#98608 (partial) 'Elements window' is now 'Elements pane' Change-Id: If93b10f4761bc34687e3937da7672b858ce9f501 Reviewed-on: https://gerrit.libreoffice.org/31407 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-11-30tdf#104177 Modify helper label to reflect menu changesGabor Kelemen
Change-Id: I4adc48af562b934975b555488758546d2ddc1203 Reviewed-on: https://gerrit.libreoffice.org/31348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-30Resolves: tdf#103313 idles never get to complete postit shell formattingCaolán McNamara
Change-Id: Ic01628bca8c306c48277ffbc84d334d1922a248b Reviewed-on: https://gerrit.libreoffice.org/30864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>