summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-10-19use std::unique_ptr in SwDocUpdateFieldNoel Grandin
Change-Id: I9d6eba5e2714a29fd3a2ad301298ad8590a4af36 Reviewed-on: https://gerrit.libreoffice.org/43549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-19loplugin:includeform: manual changes to idlc/source/parser.yStephan Bergmann
Change-Id: I1f3b08b4af08956aefad12c679cccf7bd5112f8c Reviewed-on: https://gerrit.libreoffice.org/43557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19Move vlc/wrapper include files to common include directoryStephan Bergmann
...that are inclued from both vlc and vlc/wrapper. Change done in preparation of loplugin:inlcudeform. Change-Id: Ic7dc08b93d8a33b21dc64dfc0bfbe3952039f05b Reviewed-on: https://gerrit.libreoffice.org/43556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19loplugin:includeform: manual changes to unoidl/source/sourceprovider-parser.yStephan Bergmann
Change-Id: If3980360b79a7ffcd433055e4ab912301a1bed74 Reviewed-on: https://gerrit.libreoffice.org/43555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19Remove self-includeStephan Bergmann
...that was probably added by accident with 0f58e974a7d6a88491a97ea3d0f30755ec330253 "lokdialog: Better dialog rendering API" Change-Id: Id480e0332da5edf7fc89b685c681bc79b34869f7 Reviewed-on: https://gerrit.libreoffice.org/43554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19Resolves: tdf#113179 merge language attributes early, tdf#108795 follow-upEike Rathke
Merging attributes from table to top EditEngine has to be done before colorizing with the range finder, as the resulting merged default item set *overwrites* the items set. Change-Id: I6561201de11344161f61d7d4cf6a7b79d76ba493
2017-10-19tdf#113268: Pivot table: Missing popup button after opening a ODSTamás Zolnai
Wrong row number was calculated here. This ++nCurRow is usefull only when headerlayout flag is set. It's a MSO compatibility flag so it's not there by default in LO created tables. Change-Id: Id7989d898f2647f1ba45ed95e0aa615e3b4fa311 Reviewed-on: https://gerrit.libreoffice.org/43552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-19It's a simple assignmentTamás Zolnai
Change-Id: I7b85a5ce93685013c28c9cb8047093fe7403da53 Reviewed-on: https://gerrit.libreoffice.org/43553 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-19Updated coreChristian Lohmaier
Project: translations 0703aea9337413756face54c3d7a89cc4a539a33 make msgfmt happy re 'msgid' and 'msgstr' entries do not both end with '\n' Change-Id: Ib323bb112dac8da86f9ca062c1376f8f7d34e608
2017-10-19shrink ww2 fuzzerCaolán McNamara
Change-Id: Id30693b2e0cd260bf5ee7d22e8c701b4566e54d6
2017-10-19ofz+ubsan: signed integer overflowCaolán McNamara
Change-Id: Ie75f4ff4c0efe1a1fb67b8d2edf86af9a962110f Reviewed-on: https://gerrit.libreoffice.org/43543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-19bump product version to 6.0.0.0.alpha1+Xisco Fauli
Change-Id: Ic7c4f406e60774c435f8d41aaf54bc56126193f3
2017-10-19Again, no -fstack-protector-strong for gcc3_linux_aarch64/cpp2uno.cxxStephan Bergmann
8d12e4ec8b843d59661a12a7a92bfec7e4473e0f "No -fstack-protect-strong for gcc3_linux_aarch64/cpp2uno.cxx vtableSlotCall" had done that in the past (so that setting up the x0/x1 return registers in vtableSlotCall is not clobbered by the stack protector code), but gbuild details have apparently changed in the meantime, so that gb_CXXFLAGS_COMMON's -fstack-protector-strong now ends up on the compiler command line before what is covered by gb_Library_add_cxxobjects's argument, so didn't get subst'ed to -fstack-protector. That caused Flathub aarch64 builds to fail in CustomTarget_testtools/uno_test. However, if both -fstack-protector-strong and -fstack-protector are present on the command line, the second apparently wins, so use that hack for now. (-fstack-protector-strong is only available since GCC 4.9, but -fstack-protector is already available in our current baseline GCC 4.8.1, and even for a build on that baseline it wouldn't hurt if cpp2uno.cxx was explicitly built with -fstack-protector even if none of the other files were built with -fstack-protector-strong.) Change-Id: I9d78d2e5b08b7c0a4adb1531b482cd43617886f7
2017-10-19ofz+ubsan: signed integer overflowCaolán McNamara
Change-Id: I9ff2a9402b4dd1ed5458ea935a7ceedd525a3397 Reviewed-on: https://gerrit.libreoffice.org/43533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-19tdf#113225 - reset framebuffer count when resetting OpenGLContextMichael Meeks
Otherwise we can fail to allocate a new one when we need it post reset. http://crashreport.libreoffice.org/stats/crash_details/e4f26191-15d5-441a-868f-9ada21ef4424 Change-Id: Icc5ec6c51338e18a0a1bc890f56670e8fe9c73ea Reviewed-on: https://gerrit.libreoffice.org/43508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-10-19tdf#113159: Pivot table: tabular mode is converted to oultine modeTamás Zolnai
... after RT XLSX in Calc Change-Id: I9725ca55aed973133db1d5fe47463575148e00b8 Reviewed-on: https://gerrit.libreoffice.org/43537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-19sw: fix odd condition in SwpHints::MergePortions()Michael Stahl
All of the RES_CHRATR_* items are poolable, hence we have (pItem1 != pItem2) == (pItem1->Which() != pItem2->Which() || *pItem1 != *pItem2) Move the redundant check to an assert() so we notice in case somebody adds a new non-poolable RES_CHRATR. Thanks to ccsheller for pointing me to this condition. Change-Id: I9e0634946b8bede3f483bb8997f69de05beae64c
2017-10-19Updated coreChristian Lohmaier
Project: translations dedc237384aa088b21796e0eb6d23501e00aaf89 update templates for 6.0.0 alpha1 Change-Id: Ie5bf8ab575cb94b341c277daa0cd9f6f2f6871f0
2017-10-19offapi: clarify TextFitToSizeType documentation some moreMichael Stahl
Change-Id: I1912676423c0e85fa21f87bf28c2a4f6a13c5565
2017-10-19ofz+ubsan: signed integer overflowCaolán McNamara
Change-Id: I950fb60f9bc7d86a2fe6c64a3d8e62d29ab29817 Reviewed-on: https://gerrit.libreoffice.org/43538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-19tdf#112830 measure test with ApplySettings appliedCaolán McNamara
and don't invalidate on first view Change-Id: I1156c83c0365ef27946cc414cad8dfa07206e5af Reviewed-on: https://gerrit.libreoffice.org/43498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-19Let's have this additional info also for WIN buildsTamás Zolnai
Change-Id: Ie641f7005980585501f2de1ed83f1cd27549b2bb Reviewed-on: https://gerrit.libreoffice.org/43536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-19CppunitTest_vcl_pdfexport: now we can assert the path segmentsMiklos Vajna
Instead of the bounding box workaround before commit 5352dfbbe22b59983e1b91366908724138b9783a (pdfium: update to 3235, 2017-10-12). Also stop using the deprecated FPDFPage_CountObject(). Change-Id: Iff04b5d5af492b564d7e4e918fb69aa881791b88 Reviewed-on: https://gerrit.libreoffice.org/43523 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-19use std::unique_ptr in hwpfilterNoel Grandin
Change-Id: I3aa6e1342f975420b19e9e21058a0331ed2d71e0 Reviewed-on: https://gerrit.libreoffice.org/43525 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-19use std::unique_ptr in SvxUnoPropertyMapProviderNoel Grandin
Change-Id: I774718e74bdf2e022a01188a05c8928813ad653f Reviewed-on: https://gerrit.libreoffice.org/43524 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-19Fix assertion to check the right thingTor Lillqvist
We want to assert that the token separator character is not one of the quote pair characters. Change-Id: Ic6114238f4a45a4f1ed7d255e7e9da3519479148
2017-10-19use std::unique_ptr in lotuswordproNoel Grandin
Change-Id: I9f3e8de3284899376c7db55c3ea6f16023acc40f Reviewed-on: https://gerrit.libreoffice.org/43526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-19ofz+ubsan: signed integer overflowCaolán McNamara
Change-Id: I1484897d5c14cc35165b7bec0b840c03024a34e9 Reviewed-on: https://gerrit.libreoffice.org/43519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-19ofz+ubsan: downcast does not point to SwTextFormatCollCaolán McNamara
sw/source/filter/ww8/ww8par.cxx:1654:20: runtime error: downcast of address 0x000012e4a730 which does not point to an object of type 'const SwTextFormatColl' 0x000012e4a730: note: object is of type 'SwCharFormat' Change-Id: Idc44902b0602af13fbc021c8f40a0c0dca0e46b3 Reviewed-on: https://gerrit.libreoffice.org/43514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-19Fix typosAndrea Gelmini
Change-Id: I101357736813bfd47fb15d347fd2c0a33133de56 Reviewed-on: https://gerrit.libreoffice.org/43506 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-19Replace list by vector in Metadatable (sfx2)Julien Nabet
Change-Id: I707dd27be91711e4f80d39c620a3b9784b5ef122 Reviewed-on: https://gerrit.libreoffice.org/43376 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-19dyncolcontainer: convert nRight to std::vectorNoel Grandin
Change-Id: Ie1c081250b22d80ece3c8f5a21e9728c14d7bdb1 Reviewed-on: https://gerrit.libreoffice.org/43516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-19use std::unique_ptr in TrieNodeNoel Grandin
Change-Id: I1482f846370e0b8e6f76d46fc5020e2dcb152223 Reviewed-on: https://gerrit.libreoffice.org/43495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-19fix build with system gpgmeDavid Tardon
Change-Id: I00e6d6ce476adbd22bcfb4eb55d4db4194f4bc92
2017-10-19tdf#112817 Fix the sidebar underline dropdownMaxim Monastirsky
Regression of commit 03041e0f8d8385847c2e77fcaf08c1d33cad938f ("tdf#112817 editeng,svx: fix SvxUnderlineItem/SvxOverlineItem SDI") Change-Id: I68a19a47c5e9511b5d8ce0d6c312c814490bc044
2017-10-19Avoid throwing C++ exception across libjpeg C framesStephan Bergmann
It causes trouble at least for (non-debug) 32-bit ARM Flatpak builds, where CppunitTest_vcl_filters_test aborts with an uncaught css::uno::RuntimeException. This is a partial revert of 6889fa826eef6bd1074d77507818e71dfe8ba152 "rework jpeg error handling to throw rather than setjmp to avoid leaks", switching back to setjmp/longjmp but trying to keep the leaks fixed by introducing any relevant local variables before the setjmps. Change-Id: Ia5984528ea98be1c89a21aee800b247120f88a89 Reviewed-on: https://gerrit.libreoffice.org/43494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-18Updated coreAdolfo Jayme Barrientos
Project: help ebb762cd6a29589089646670eb6eeb0b80b493d7 The seemingly automated mass replacement produced this ridiculous sentence Change-Id: Ib2898b93377af7ef8290c5d7740d150f0b5285f5
2017-10-18set parent of extension file dialogCaolán McNamara
Change-Id: I9791fceb975ca9d0a0ca0ae61c0890826d06c564 Reviewed-on: https://gerrit.libreoffice.org/43510 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18ofz+ubsan: signed integer overflowCaolán McNamara
sw/source/filter/ww8/ww8scan.cxx:1816:15: runtime error: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int' Change-Id: I8dc79794c94c512ed1f73ea3f0e251cf2dc960bc Reviewed-on: https://gerrit.libreoffice.org/43505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18Resolves: tdf#112891 give restart dialog a parentCaolán McNamara
Change-Id: Iaeb0060f390035bb214b9d1d8d090e7b933c9f77 Reviewed-on: https://gerrit.libreoffice.org/43509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18Resolves: tdf#113214 change back to previous entry after 'more' is dispatcherCaolán McNamara
Change-Id: Ic5bd5f9182e47c6dfdab8fcd6399ffc482a4fb6a Reviewed-on: https://gerrit.libreoffice.org/43512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18EPUB export: better handling of tabsMiklos Vajna
Mapping ODF/librevenge tab to \t in HTML is not a great idea, as it's ignorable whitespace. Go with NBSPs and a breakable space instead, that is much closer visually (15 is just an arbitrary number, it's what MS Word uses in its HTML export, LO Writer HTML export doesn't handle this). Adapt the empty paragraph case to also use NBSP for consistency. Change-Id: I131802416499eb4f3a83a333b37ca20b59fcd56a
2017-10-18tdf#107224 use correct bg for notebookbarSzymon Kłos
Change-Id: I26093cb9cf0170aa9ba4ccfc8c8556c2e78086b3 Reviewed-on: https://gerrit.libreoffice.org/43515 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-18Fix spacingMuhammet Kara
and use the hungarian prefix 's' for the string. Inconsistent spacing introduced with: 2b5b8fd39c93166d9e6e696c010482413b155f78 Change-Id: Ieee55f51ec6c87b087365f7460097d5cc997a261 Reviewed-on: https://gerrit.libreoffice.org/43405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-10-18return early on failureCaolán McNamara
Change-Id: Id96ba954d3056cf982701090cf84ab4b1793b40b Reviewed-on: https://gerrit.libreoffice.org/43489 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18ofz+ubsan: signed integer overflow in unused variableCaolán McNamara
Change-Id: Ie95ddfdb002fdb5b6670bb155d2dd0089b719fca
2017-10-18Fix typoAndrea Gelmini
Change-Id: Ie29a05fec90c0d81b4a0399505b0a6761dfdef69 Reviewed-on: https://gerrit.libreoffice.org/43463 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-18rename some fieldsNoel Grandin
in preparation for const-method detection Change-Id: Iecf7102892d664ded799615ce1a848a538dcfcef
2017-10-18loplugin:manualrefcountNoel Grandin
this is the code I used to find naked acquire/release stuff No need to run it all the time, so leave it in store Change-Id: I9ac4a6f5db7cd4cbb1b63698340425eed7cb8713
2017-10-18use rtl::Reference in formsNoel Grandin
instead of manual reference counting Change-Id: I5bad5b7b83049f5c018a1f2d5bbc37f03727c3ce Reviewed-on: https://gerrit.libreoffice.org/43497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>