summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-21tdf#96505 - Get rid of cargo cult long integer literalsudaycoder
Change-Id: I56fbc7cd9c879b18ac65c5e6adf80f01c6b95b84 Reviewed-on: https://gerrit.libreoffice.org/35176 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-03-21Bin noise commentTor Lillqvist
Change-Id: I7367d494143901c9b78349682f07cc292d1d64ea
2017-03-21Make PDFDocument::ReadKeyword work at end of fileStephan Bergmann
If the first ReadChar fails due to EOF, ch would be used uninitialized. If the second ReadChar fails due to EOF, the SeekRel(-1) shouldn't be executed. Change-Id: Ibf99539a3a8880a77653bd7576721104f9782e36 Reviewed-on: https://gerrit.libreoffice.org/35504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-03-21tdf#96505 Get rid of cargo cult long integer literalsdilekuzulmez
Change-Id: I6bda2915547980b33d059257c8dbd65f181f9f16 Reviewed-on: https://gerrit.libreoffice.org/35291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-21ofz#923 don't crash on missing shell storageCaolán McNamara
Change-Id: I689fcf6b82d5df8121c1bb4ca1a92bf0f145d7f5
2017-03-21fix indentCaolán McNamara
Change-Id: I6facc99a16c29275771f46d397162bcd4f4a27b0
2017-03-21cppcheck: alloca (vcl/i18n_status)Julien Nabet
Change-Id: Ib36fc229ab4d4a349f11abe0fc7b6d02163d7f14 Reviewed-on: https://gerrit.libreoffice.org/35409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-21duplicate rational::operator*= into toolsCaolán McNamara
for modification, no logic changed intended in this step Change-Id: Ib41051a83bc9e37677d765e51e9f56cede0efb3e
2017-03-21tdf#105686 - fixed wrongly imported named expressions:Mohammed Abdul Azeem
It is necessary to extract and set ODF version for fast events also. While debugging I found a couple of tokens which were not in the list, and added them (not needed for bug fix). Change-Id: I7aaab99688a067ee2fd2c9814deec1a359a758ab Reviewed-on: https://gerrit.libreoffice.org/35410 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-03-21ios LibreOfficeLight FileManager actionsjan Iversen
Adding dialogue handling for filemanager Change-Id: I9db782e04f80f18421be23e158034a80497d8b12 Reviewed-on: https://gerrit.libreoffice.org/35489 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@libreoffice.org>
2017-03-21add icon for uno.signature and uno.MergeDocumentsandreas kainz
Change-Id: I1bc2bb232f9b1d7724b55a9e388150ea83af49f3 Reviewed-on: https://gerrit.libreoffice.org/35330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-03-21tdf#106382 - Fix incorrectly shown change tracking comments in dialogPranav Kant
First item in the array is treated as the number of fields followed by their widths. There are only 4 such fields in case of writer, not 5. Change-Id: Iff6f21b54b73d4395d64d83f2acf1de2a19a251e Reviewed-on: https://gerrit.libreoffice.org/35484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-03-21Add script to list dispatch commandsPhilippe Jung
from https://wiki.documentfoundation.org/Development/DispatchCommands Change-Id: I996f3585bbbb18eb4b425cdd807f15d848cced36 Reviewed-on: https://gerrit.libreoffice.org/35337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-21lok: Fix crash in paintPartTile() when the current view was destroyed.Jan Holesovsky
Change-Id: I59b71ee6815cbcfa4c8b5f68ae6dc9299856d49e Reviewed-on: https://gerrit.libreoffice.org/35494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-03-21tdf#106492 DOCX export: fix duplicated section break at doc endMiklos Vajna
There is always a section break at the end of a DOCX document, so in the rare case when there is no text node between the end of a Writer section and the end of the document make sure no duplicated section break is written. Change-Id: I3fcd852c1a63e2d707822ad08603e2d37386e439 Reviewed-on: https://gerrit.libreoffice.org/35499 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-21tdf#106377 sw: fix Undo of delete of ToXMark from dialogMichael Stahl
The problem is that SwUndoResetAttr and the SwHistorySetTOXMark by design only insert the SwTextAttr, they don't insert the dummy char of a SwTextAttr that needs one, like the ToXMark does if it marks a point. So just change SwDoc::DeleteTOXMark to create SwUndoDelete instead. Change-Id: Ic1eebac4cf859771a6032bffb2fd8e198aa08084
2017-03-21ofz#908 faster to scale a monochrome bitmap than a non-monochrome oneCaolán McNamara
so if both are wrong, correct depth before scale Change-Id: Ia0b6a194e14072a6f73f23e16ec640e0e1d34cf0
2017-03-21ofz#891 catch exceptions harderCaolán McNamara
Change-Id: Ieec895533c8220bb03164489a3e268defb4a8899
2017-03-21ofz#922 support avoiding configCaolán McNamara
Change-Id: I133b3881ea0b21fdb972342e8107e28bbf1727dd
2017-03-21fix and enable testDavid Tardon
Change-Id: I309b74c19ea076157d1c0b9c0c817ab4055512c3
2017-03-21valgrind: uninitialized readsCaolán McNamara
Change-Id: Ia1e821d1e323d85c65484c980be09f015af6517b
2017-03-21Old-to-new mapping of attributes is moved into a Module:Mohammed Abdul Azeem
This should make it easy to reuse the mapping code wherever necessary and restores the loading of writerperfect documents. Change-Id: I505bffa47fe37270b0430d9ae5afec5072762b4c Reviewed-on: https://gerrit.libreoffice.org/35263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-03-21ofz: leaks in animation nodesCaolán McNamara
there's no dispose option to deal with circular references Change-Id: I11ad081ab7c98648b7ab87e138f54add04ab07fe Reviewed-on: https://gerrit.libreoffice.org/35488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-21Does this actually want to check for alphabetic characters?Stephan Bergmann
...instead of for non-alphabetic ones, as it does ever since 14620c3b33cf0315a9b746a0a2418b78d6154821 "support import of key shortcut for macro ( Excel only )"? Things that suggest that that was a typo: * The preceding comment. * The fact that ooo::vba::parseKeyEvent will throw an exception for most input of the form '^' followed by a non-alphabetic character (see parseChar in filter/source/msfilter/msvbahelper.cxx). (Found when auditing uses of <ctype.h> is* functions. See d8ce3f60bad3ebaa0888b35f85ab1a211714bb14 "Fix ooo::vba::parseKeyEvent" for replacing isalpha with rtl::isAsciiAlpha here.) Change-Id: I6b133c51da64192ec6aef712579ad6f55aae3b1a
2017-03-21New loplugin:unicodetocharStephan Bergmann
Change-Id: I279fe1dec196b6e1e551b4f6aba77f24e3f76ab7
2017-03-21Fix ooo::vba::parseKeyEventStephan Bergmann
Use rtl::isAscii* functions (correctly operating on OUString elements) instead of truncating OUString elements to char and then using <ctype.h> is* functions (which, in addition, for one can cause UB for char arguments when char is singed, and for another can be locale-dependent). (Found when auditing uses of <ctype.h> is* functions.) Change-Id: I826aec92b18bd5dba72ceb69ff88c477d6ebd44c
2017-03-21Only need an OStringBuffer in number2PolyPolygonStephan Bergmann
...so that later passing the OStringBuffer's aNum[i] to createSevenSegmentPolyPolygon (taking a first parameter of type char) doesn't need to implicitly convert from sal_Unicode to char. Requires addition of some missing OStringBuffer-related function variants in rtl/math.hxx and rtl/strbuf.hxx. Change-Id: I79e6b2a791abc62b6556a6668e4411cced490c11
2017-03-21Notebookbar: correct initial icon sizeSzymon Kłos
Before this patch initial icon size in the NotebookbarToolBox was determined by Sidebar settings not Notebookbar Change-Id: I66ac709c606ef60fb3505bbbe51dfebbcc81d20c Reviewed-on: https://gerrit.libreoffice.org/35493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-20tdf#106284 Sifr icon accidentally included an opaque backgroundAdolfo Jayme Barrientos
Change-Id: I0c101765eb3a8bde3cf63e8d9653143e56786063
2017-03-21uitest: log when we execute a dialogMarkus Mohrhard
Change-Id: Ibf3e739ce096dd7326325eb2010bf89630993dbd Reviewed-on: https://gerrit.libreoffice.org/35496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-21uitest: only log actions for elements with the focusMarkus Mohrhard
Change-Id: Ic480f0d2c5749f3b32a873fc7695394becbebfcc Reviewed-on: https://gerrit.libreoffice.org/35495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-20tdf#99617 convert powerpoint angle to degreeRegina Henschel
1 powerpoint angle unit = 1/60000 degree Roundtrip test not yet possible because of tdf#106002. Change-Id: I5854c4f9f013f1a2db7e9536fc9cf5198c7a02ed Reviewed-on: https://gerrit.libreoffice.org/34279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-20uitest: start to log key inputMarkus Mohrhard
We need to disable this part in release builds. Change-Id: Ica57f8aca1ffb5f7938ab82ef8b888a8d6d6101a Reviewed-on: https://gerrit.libreoffice.org/35450 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-20Adapt README to MD5SUM -> SHA256SUM changeStephan Bergmann
Change-Id: Icd7d15c342de28b664295916a92023feca9f219c
2017-03-20desktop: fix Android -Werror=unused-functionMiklos Vajna
Change-Id: Ic10dbd44e13df8e79d6b64c14291a40238c14a4e
2017-03-20tdf#75256 Sifr icon updateMatthias Freund
new icons Change-Id: I966c962f56608371d8b8127f60e2526d4ea626a9 Reviewed-on: https://gerrit.libreoffice.org/35444 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-20These files are called unorc on all platformsStephan Bergmann
Change-Id: I49f4f8361dfd93a788faa7c0de88bf954d3d3574 Reviewed-on: https://gerrit.libreoffice.org/35485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-20download.lst: remove orphan JPEG_SHA256SUMMichael Stahl
Change-Id: I1cf0c0a3097a146e7dcf731cd52686fd68e3782c
2017-03-20reject more invalid mapmodesCaolán McNamara
Change-Id: I068968028b3ed27dc6220bfd335e322ede74454d
2017-03-20Resolves: ofz#820 an exception is an acceptable outcomeCaolán McNamara
Change-Id: Ifc5be483387202c371596fd52f1e2ce682151ca8
2017-03-20ofz: reduce jpeg mem limit by 1/4Caolán McNamara
Change-Id: I136cca9465debc4bc26e2173f050eb253de1a698
2017-03-20BitmapEx::Convert testing has served its purposeCaolán McNamara
Change-Id: Ib4bce41b07dd1bbf97a7cd9b0a64132b915998ab
2017-03-20ofz#918 invalid mapmodeCaolán McNamara
Change-Id: I9512bc482242f03590c92c4286947e3ab824b8a2
2017-03-20ios retired TiledLibreOffice.jan Iversen
Retired TiledLibreOffice, replaced by the prototype. Newer development takes place in LibreOfficeLight Change-Id: I170ea49086f860bda9c86aaa8ca7de00907dad67 Reviewed-on: https://gerrit.libreoffice.org/35483 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-03-20Related: tdf#106577 extend damage rect a little for TrackFrameCaolán McNamara
Change-Id: I007ab53ba841c7c4a0f13bc9e7e306e88303191f
2017-03-20tdf#106577 cairo_mask pattern affects more surface than expectedCaolán McNamara
Change-Id: I7f967c401f7b84fd696fa4cf8a944f7a5730917c
2017-03-20Fix CurDir on WindowsStephan Bergmann
* Allow lowercase argument. (And properly check the sal_Unicode value with rtl::isAsciiUpperCase instead of with isalpha, which would cause UB for values outside of unsigned char + EOF). * Use _wgetdcwd to get a UTF-16 path in the first place (instead of erroneously converting via createFromAscii and assuming the path only contains 7-bit ASCII characters). * At least with a MSVC 2015 Update 3 --enable-dbgutil build, a call like CurDir("A") for a non-existent drive A will cause a failure message box Microsoft Visual C++ Runtime Library Debug Assertion Failed! Program: ...\instdir\program\soffice.bin File: minkernel\crts\ucrt\src\desktopcrt\misc\getcwd.cpp Line: 225 Expression: ("Invalid Drive", 0) though, which appears it can't be intercepted---trying with a _set_thread_local_invalid_parameter_handler around the call to _wgetdcwd didn't have any effect. Change-Id: I666f84b0695152c0f2c25de3bae100e58929594a
2017-03-20LibreOfficeKitInit.h modified to avoid ODR.jan Iversen
As discussed in IRC, the prev. version would cause an ODR the use of _cplusplus have been changed to IOS_SWIFTCBRIDGE Change-Id: If18610858cb56780347bb28f909619db4aac85b0
2017-03-20ubsan fix after "drop GetId() from SfxUndoAction"Noel Grandin
bug introduced by commit 64ea8306b0ceb001132ac9cbc945a12afc01b8cd drop GetId() from SfxUndoAction Change-Id: I75b23650c7dc15fc76fe1b9118129ff8ead35315 Reviewed-on: https://gerrit.libreoffice.org/35333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-20Fix version number in scp2-generated version ini-file UpdateID variableStephan Bergmann
USERDIRPRODUCTVERSION is stuck at 4 now (as its main use is for the version number of the UserInstallation directory), so use LIBO_VERSION_MAJOR instead (like generation of the version ini-file counterpart for instdir/ does in instsetoo_native/CustomTarget_setup.mk). Change-Id: Ib87536d335487383940cff2f69c864a33f05bbee Reviewed-on: https://gerrit.libreoffice.org/35301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>