summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-16tdf#131812: fix exporting to html doesn't preserve RTL propertyJulien Nabet
Change-Id: I227e304c6868afe7a98dbd8e96487270d06ce1eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92067 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 95460224f4f8443547dbf5cedbea008ea2639337) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92019 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-16Resolves: tdf#131996 set_sensitive should be set_activeCaolán McNamara
search and replace went wrong in: commit b94214350e6e3d0252c09f203a3ce7807a179f90 Date: Thu Jul 25 14:09:09 2019 +0100 weld SdPublishingDlg Change-Id: I10af85633758a6e4c354f6fc957624122dd01f3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91901 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-16tdf#126828 don't crash fetching cmis properties from disposed SfxBaseModelCaolán McNamara
Change-Id: Ie064632667b40201e0d266c64e3068c4d1983c7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit db677c854a37031235b0f42b4f4f48560149754f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92289 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-15sw: fix fly at-char deletion API behaviour changeMichael Stahl
28b77c89dfcafae82cf2a6d85731b643ff9290e5 changed at-char anchored fly selection. WollMux calls setString("") to remove one character in the first paragraph and a fly anchored at the start of the body text is deleted due to the new IsAtStartOfSection() check. It would be possible to treat deletion via API differently than via UI, as there is already a flag ExcludeFlyAtStartEnd but it would require passing the flag through 10 functions and also to store it in SwUndoDelete... The main intent of the IsAtStartOfSection() check was that Ctrl+A should delete every fly; this can be achieved by checking that everything was selected, so that selections only inside the first/last paragraph don't delete the flys at the edges. Change-Id: Id62e7d99a10b42eaecea5564372d29b6c43e3f7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91993 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 971205dc2110c1c23ff1db1fc4041e2babf6fa9f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92169 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-15Breeze: Add support for Korean UI tdf#128689Rizal Muttaqin
Change-Id: Idbe742cdedc497ed9e0aec72cc69842b12d94aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92182 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-15Sifr: Add Korean UI tdf#128689Rizal Muttaqin
Change-Id: I8016e4c0ad97bf13934540d14697967d93e6d07e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92164 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 5431e8e25c6668480ebac11248f2aecbc0bda431) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92167
2020-04-15"General Internet Error" dialog appearing on gio mountCaolán McNamara
we get a GError of G_IO_ERROR_FAILED_HANDLED which is documented as "Operation failed and a helper program has already interacted with the user. Do not display any error dialog." PENDING seems to describe this state better than a generic error case and results in no error dialog. Change-Id: Iee382e49edaa0a734526659971e0339991e2c03e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92171 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-14tdf#132001 DOCX import: fix crash: redline in floating tableLászló Németh
Copying redlines to frame text was failed in tables inside frames. Skip these redlines temporarily. Regression from commit e8bae67b3dbcc90ace8264b6b1aefaf0ce459aba (tdf#125894: DOCX: import tracked changes in frames). Change-Id: I4f3ca2e95fb2e7637f8cf8dca1088a7727bcf98d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91985 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 1350832be533ce6627607b1aaabd2b3565e6e7b3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92015 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-14tdf#131907 Crash: reject/clear formattingNoel Grandin
regression from commit 0ef5c47547bec6319b853326603f3b807407fe78 sc: rowcol: tdf#50916 convert core/tool Change-Id: Ib8207f60d34e4257fc9a854f4e4d358951e24718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit c076b99dd21edae0364cf9319a221a1d6a4bd487) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92170 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-14tdf#104565 DOCX drawing object export: fix arrow positionsSzabolcs
Saving some arrows from ODT to DOCX scattered them around their correct position. This happened because of a function that recalculates the position of drawing objects when they are rotated, according to the rotation. It turns out we don't have to do this with lines and such. Co-Author: Balázs Regényi Change-Id: Iea6a34d15003cacc27a8030cb73511aba39225f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90989 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 08a11f8fe19560b000c62da00d7425b4f500d605) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92166 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-14elementary: Fix for tdf#132080 Wrong Glyphs with Korean UIRizal Muttaqin
- Update line icons - Update Font Color icons Change-Id: I2bd9970c62669dc97a528c61df10566e83edb39a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92140 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit b8c2e08b68722972d65f08107d74ba4a10f713df) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92024
2020-04-12Resolves: tdf#132038 missing adjustment for rotationCaolán McNamara
Change-Id: Ib4702627578e06f209c9c58021971eb4e1ed39a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92082 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-11Sifr: Add more Korean UI icons: tdf#128689Rizal Muttaqin
Change-Id: I71a532667d4ef6b2db223fddc8afcf7384bfe7fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92018 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-10Breeze,elementary,KJ,Sifr:+ DB Record support 4 RTL UIRizal Muttaqin
Change-Id: I292350c4f6cb886bb21404744a73dfd904aa9fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92040 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit b332452f01f19ca1065a2bef0b390ad5e92f4105) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92016
2020-04-10tdf#131966: chart legend attribs width and height unknown for ODF 1.2 (strict)Julien Nabet
Change-Id: Ie4cb7d2c9e5fb7bca88287fcaff03d5c9ca04b8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91899 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-10Colibre: Fix for tdf#131974 & tdf#131975Rizal Muttaqin
- tdf#131974: Flipped Undo & Redo button in RTL UI - tdf#131975: Wrong icons for "Undo: Data Input" (.uno:RecUndo) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91944 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 5b56db7dcf471dc837fc05e92636579ef80a205c) Change-Id: I7c6e667df20cbe125da020f246d264626c48528c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91896 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-09Breeze, elementary, KJ, Sifr: Update localization supportRizal Muttaqin
- elementary: Update Chapter Numbering icons - elementary, KJ, Sifr: Revert Good, Neutral and Bad Cell Styles icons Change-Id: I610b17896841d84b964afbde994590633312e0f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91959 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 1bc3f2660d1df6aedb0560f5ff8cff2624ce9fe6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91903
2020-04-09sw: crashtesting: fix assert on ooo95711-1.odtMichael Stahl
Document is special and contains deletion that contains only a table, no paragraphs before or after it. The assertion is wrong in this case. It doesn't matter if the atParaEndNode is incremented because it's going to be on an end node either way. (regression from 91b2325808a75174f284c48c8b8afc118fad74e4) Change-Id: I3fe82f0ed0b7b213df036bb8026dc209c00123de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91873 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 6b2e925aa0dd389a613e182545de6550057374d4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91890 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-09tdf#131684 sw_redlinehide: fix SwUndoDelete for entire doc in sectionMichael Stahl
The problem is that in SwUndoDelete::UndoImpl(), at the start there is only one content node with a frame in the layout, and there is a special case with m_nReplaceDummy being set so this SwTextFrame gets deleted by the MoveNodes() call in line 969 that moves it into the newly inserted section. As a result of that, MakeFrames() won't do anything because it can't find an existing frame in the same section. In this case, MoveNodes() should leave the frame alone, as it is beyond the end of the deletion and excluded from MakeFrames() - if it wasn't merged before then it doesn't need action, if it was merged before (in a different document maybe) the RecreateStartTextFrames() ought to fix it. (regression from 723728cd358693b8f4bc9d913541aa4479f2bd48 which disabled immediate creation of frames in Copy_()) Change-Id: Iabe2fb1810b0df898b1f57b3d850c3503c79c5d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91842 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 6c7245e789f973cf6dad03f7008ab3f9d12d350c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91886 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-09tdf#129372: PPTX: error at SfxBaseModel::storeToStorage: 0x20d(row,col)Julien Nabet
Teach starmath how to deal with surrogate pairs see https://en.wikipedia.org/wiki/Universal_Character_Set_characters#Surrogates + comments from: https://bugs.documentfoundation.org/show_bug.cgi?id=129372#c6 Here's the culprit character: 𝜕 %uD835%uDF15 I didn't dig why these 2 (found in reduced example attached to the bugtracker) didn't need this patch 𝑋 %uD835%uDC4B 𝑢 %uD835%uDC62 Change-Id: I3bf2322a9e7f1974aa8622a91812aeb11e613ace Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91941 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 11b57129b53e1e2d71a5f969e2417226b4e2ddd9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91900 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-09tdf#131969: Fix reading SHORT Orientation valueStephan Bergmann
<http://www.cipa.jp/std/documents/e/DC-008-2012_E.pdf> "CIPA DC- 008-Translation- 2012: Exchangeable image file format for digital still cameras: Exif Version 2.3" documents that the Orientation tag 0x0112 expects a count of 1 values of type SHORT (16 bit), and details that values <= 4 bytes are stored in the Value Offset field always using bytes starting from the left of the field. This is a regression introduced with 42c0e433aca68c669bc0f55af404b6bae1655fba "Avoid -fsanitize=misaligned-pointer-use". That commit had wondered why the original code had used OSL_SWAPWORD instead of OSL_SWAPDWORD when reading and writing such orientation values. It turns out that that original code had happened to work correctly when processing either little or big endian data on a little endian machine. (Though it would have worked incorrectly when processing either little or big endian data on a big endian machine.) And with 42c0e433aca68c669bc0f55af404b6bae1655fba, the code worked when processing little endian data on a little endian machine, but failed when processing big endian data on a little endian machine, as is the case for tdf#131669 on e.g. x86_64. (read32 has become unused and is thus removed.) Change-Id: I7992629048ac44c00ee703c75164f3d094773244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91881 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit fd5961cb0e2ebc2f5797f76a2b1f9fd52ca4b3ab) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91889 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-09All icons: fix for tdf#131975, Breeze, Sifr fix for tdf#131974Rizal Muttaqin
Change-Id: If39b5034896998a3137b913afadd05e6f4173331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91882 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit ab751b456d334464b01ae6a6b25ebfd1f8e2fc91) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91891
2020-04-09Breeze: Fix for tdf#131984: missing icons for Writer's Data SourceRizal Muttaqin
Change-Id: I3516d55f08c3bdd857994db7704c2af0a20cc260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91924 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 6209ac8094e3578bb2dfcbf5f7e2f302bd760926) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91895
2020-04-08Resolves tdf#127782 - New Print dialog is too highHeiko Tietze
Expander added Change-Id: Iea41f9cf335b75210de0acf5688fddd5e3dd3dbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86478 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 96b4bf352b1dc43637080719c91eef61fef74bf8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91725
2020-04-08tdf#131594: switch line numbering off if w:countBy="0"Xisco Fauli
See https://bugs.documentfoundation.org/show_bug.cgi?id=131594#c0 for more info Change-Id: Ic57826eb5a440e83cea1d9bde5e9144727e3b6df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91141 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 910197b8cf9b653c1b39b35b73424a36b7c1d1ae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91512 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-08Resolves: tdf#131715 don't keep trying the same page if we're already on itCaolán McNamara
return of false means we didn't change page for some reason, the idea is that it might be blocked to go to another page, in which case sync with what page we ended up on, but don't bother with that if the dest page would be the same as the current page Change-Id: I280128240601413fb6d027d001b2ecc9a4efa76f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91718 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-08tdf#131490 sw btlr: fix handling of vertical textMiklos Vajna
Latin text goes from l->r, then t->b. If we rotate to the right, then we get t->b, then r->l. Vertical text in vcl's Font means the individual glyphs are painted in a way that looks "non-rotated" in the tbrl case. btlr is not symmetric to this: if you rotate to the left, then Latin and vertical text is handled the same way, i.e. there is no compensation at a glyph level. This means that as far as vcl is concerned, the Font's vertical flag has to be true in the tbrl case, but no in the btlr one. Fix SwFont::SetVertical() to do this, which means that rotating at a character level or using the btlr text direction will result in the same rendering for a one-liner text. Regression from commit 89e5b431d468745da3a1eff14d48296107b9101b (sw btlr writing mode: implement DOC filter, 2019-03-28). (cherry picked from commit a8d26a0bb40c101394ded8061d1b58048153631b) Change-Id: I2619c77a3b2597dbf9feab6c7042e8d8c7454197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91820 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-08elementary: Update Gallery folders and DB record iconsRizal Muttaqin
Change-Id: I2c0e9c70d9b25d8e7cabaf890cd6107dcdd7834d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91863 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 3168a1d790323c51765655d9da273d51db94b707) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91724
2020-04-07tdf#131190 Make custom page styles deletable again in CalcJim Raykowski
This is a combination of 2 commits. tdf#131190 Make custom page styles deletable again in Calc Here is a patch to return the ability to delete custom page styles in Calc. This was lost in commit 30c9bc76d0718f0c01d34f81845d88413645b42c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90547 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit bb844eb299b614c1fa56e140630db070cf709a02) tdf#131190 Make custom page styles deletable again in Calc Return the ability to delete custom page styles in Calc. This was lost in commit 30c9bc76d0718f0c01d34f81845d88413645b42c ae402cc048fde7ffd3ca2696c08d5e54cc30d1be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91672 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Change-Id: I18936585cfbe45e0254beb882adc8709781f57e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91404 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-04-07Resolves: tdf#131170 columns tagged as delimiter not columnCaolán McNamara
Change-Id: I889c3ba38776a63587a68c7827956b6747c08e38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91715 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-07update creditsChristian Lohmaier
Change-Id: I54aa5f399f8c1a7117d0f206752a25a02bb3819a (cherry picked from commit 990a9bbc3121a12c7300955e9b7566f6065bd434)
2020-04-07Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-4' to d9d8ae075592448276e014cfcab9864b570c0c5d - update translations for 6.4.3 rc2 and force-fix errors using pocheck Change-Id: I21921dd81e58fbd2c0f8ce1fd44cdd0ea27d7b58
2020-04-07tdf#131849 Handle changed doc print options when printer changedMichael Weghorn
Previously, the SfxPrinterChangeFlags::OPTIONS flag was only set for the case that the printer itself was considered unchanged ('else' case below). However, this also needs to be done when the printer is considered to have changed, so the flag is properly passed in the call to 'SetPrinter' below, to make sure that changes in document-specific options are properly propagated. Change-Id: Id91ebbbf40888e52149b40ac25f188af4be425f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91626 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 21fc54777d5dedc33d6bfa23b9f1072a6667eebe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91519 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-06(related: tdf#130685) sw_redlinehide: fix update of pLastNode/pParaPropsNodeMichael Stahl
If you Select All, Cut then move the cursor around a bit then paste, then this happens: sw/source/core/text/txtfrm.cxx:3461: void SwTextFrame::CalcAdditionalFirstLineOffset(): Assertion `pTextNode->IsNumbered(getRootFrame()) == pTextNode->IsNumbered(nullptr)' failed. The reason is this borked MergedPara, which really only has 1 node it's listening on, but pLastNode and pParaPropsNode point to a node that is actually part of a different MergedPara now. $6 = { listener = { m_rToTell = @0x6c02700, m_vDepends = std::__debug::vector of length 1, capacity 256 = {{ <SwClient> = { m_pRegisteredIn = 0x6af5f20 }, }} }, extents = std::__debug::vector of length 0, capacity 0, mergedText = "", pParaPropsNode = 0x6d1c390, pFirstNode = 0x6af5f20, pLastNode = 0x6d1c390 } The reason is that SwContentNode::DelFrames() doesn't update these members properly; at the time when it's called for the previous pLastNode, the offending node has Merge::NonFirst set already in the call of CheckParaRedlineMerge() so it sets the wrong new pLastNode. Fix this by iterating DelFrames() loop backward. (regression from sw_redlinehide) Change-Id: I508fd25af385a25ba9ed78d71aa3d1f02a7ac7a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91597 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 520b0e1679d7a97aa3d91cfc95ca647339da7e84) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91524 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-06attempt to deref end() iteratorCaolán McNamara
seen when dragging last animation in animation pane up one position Change-Id: I2c5163a58bb67fc7982c41546559207977e8b7c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91714 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-06rhbz#1820868 deref of null xLayoutManagerCaolán McNamara
Change-Id: Ib396ef9f5b019b08a181eeb5a8eb983bdb401db4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91710 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-05(related: tdf#130685) sw: adapt definition of sw_redlinehide index 0Michael Stahl
... to the change to use the last node - not the first node - for paragraph properties. The problem is that if you move the cursor around at some step of reproducing the bug, this happens: sw/source/core/crsr/crsrsh.cxx:544: bool SwCursorShell::LRMargin(bool, bool): Assertion `sw::GetParaPropsNode(*GetLayout(), GetCursor_()->GetPoint()->nNode) == pTextNd' failed. For a fully deleted range, it looks more plausible to map index 0 to the end of the last node instead of the start of the first node now. This means that text will be inserted at the end of the last node too. (regression from fa5eb82b398e29ae033f7b7c8c8195dfc10cf5b0) Change-Id: Ica891aea658b85211397320a44c9c10b48ca2659 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91598 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 58353884dc86bdb3c1464f8bbf8c3e131584b78a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91525 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-05tdf#131004 fix unstable paint of writer consecutive section framesSerge Krot
Change-Id: I565129dcd077ddbfccedb37dfbf1b9e1acf4eb95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91532 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 8666dfecbaac69b9dc9a9c23a05654d847608907) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91521
2020-04-05tdf#130685 sw_redlinehide: fix copying to position following redlineMichael Stahl
In DocumentContentOperationsManager::CopyWithFlyInFly(), first CopyNodes() also creates all layout frames, then SaveRedlEndPosForRestore fixes the end position of all redlines that were moved by CopyNodes() (they were moved not by changing their position but by inserting new nodes before their end position). Of course this means that the layout frames are created with redlines that have only a temporary end position, and then things go wrong when the end positions are adjusted, so add something similar to SwUndoDelete::UndoImpl() to recreate the frames in CopyWithFlyInFly(). This hit the assert: sw/source/core/text/redlnitr.cxx:94: std::unique_ptr<sw::MergedPara> sw::CheckParaRedlineMerge(SwTextFrame&, SwTextNode&, sw::FrameMode): Assertion `pNode != &rTextNode || &pStart->nNode.GetNode() == &rTextNode' failed. (regression from ... sw_redlinehide) Change-Id: I82e0f5b320cab201e762f58800f83e08f4f01048 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91596 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 166b5010b402a41b192b1659093a25acf9065fd9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91523 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-05(related: tdf#130685) sw: fix ~SwIndexReg asserts from ...Michael Stahl
... lcl_DeleteRedlines(), if there are redlines immediately consecutive that get deleted; merge the SwPaM ring in that case which should help. Change-Id: I07b67413ad6ee52bc81b89facc40202d0ca75e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91595 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 27aa4b16bf704d0246595750daf57b57ff2577b3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91522 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-03use mdds position hint (tdf#131716)Luboš Luňák
Otherwise this is the usual case of possible quadratic mdds slowness. Change-Id: I5b33df65e127702c011517d79b9cd41a7e820ca0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91553 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 55220e7bc6576a7575c675ba425e757a3aefa243) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91517 Reviewed-by: Eike Rathke <erack@redhat.com>
2020-04-03Resolves: tdf#131829 [vi-VN] set currency VND decimals to 0Eike Rathke
Change-Id: I865d6b3dcb7f3bff037a4015aa98db2fa2578672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91593 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 28ccea8b7feed20d33e2ca7d6197d947dbbad848) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91516 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-02tdf#131399 Update java settings after slight java version changeilhan
Under linux, the version is now also checked for changes at startup of libreoffice. Change-Id: I572f718cf5afc83a70d98a6897f1d3d6877644f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91037 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 6b6af620ff53209487a146aa3977db328c3a6300) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91405 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-02tdf#131554 placeholder iteration fails to stop when a match is foundnd101
Wrong placeholder is returned due to iteration not stopping when a match is found. It causes a text element position to be incorrectly set. Change-Id: I58be6825cec7a61f48b46418bdf28964c1afe4ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91023 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91472 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-02Resolves: tdf#131767 explicitly get the odt filterCaolán McNamara
instead of using CXML which might return either the desired writer8 odt filter or the StarOffice_XML__Writer filter which both have CXML set as userdata Change-Id: I3da7e7ee9a0069642c09766e8778bcaf247a4575 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91509 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-04-01sw: DOCX export: avoid section breaks in text framesMichael Stahl
The problem is that if Word reads a w:sectPr that is inside a w:textbox and has a w:headerReference, then Word throws a confusing error reporting a location inside the headerN.xml file and refuses to open the file. It looks like Word doesn't actually support sections inside text frames, although it doesn't complain if the section break doesn't contain a header/footer reference. The WW8 export appears to avoid this by checking that TXT_MAINTEXT == m_nTextTyp and skipping sections otherwise, but the m_nTextTyp doesn't change when exporting a text frame in DOCX case, so let's change that. Possibly this makes m_bFlyFrameGraphic variable redundant, not sure about that. Change-Id: If862b226254983bb608bbce180f4aa2f41721273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91421 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 0dd48d1a9a716456ff1ebe67e19881ad2f56939b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91397 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-01sw: DOCX export: avoid section breaks in text frames harderMichael Stahl
Follow-up to 0dd48d1a9a716456ff1ebe67e19881ad2f56939b - in another document, the sectPr is written from DocxAttributeOutput::StartParagraphProperties(), which lacks a check that it's in the body text. Change-Id: Ia3b56f40a7457f072735a0e09205089a0c5f4584 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91429 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 38be440dbe8a706052182d06bb1ae95abdd06fcc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91399 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-01tdf#100751 DOCX VML shape import: fix arrow directionSzabolcs Toth
Flips along both the y- and x-axis weren't imported, resulting wrong direction of arrow and other shapes. Co-Author: Balázs Regényi Change-Id: Iac222ac2a6a6110289969c32b40828b83da0aefd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90646 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> (cherry picked from commit cb441c4d0adf698e6af9073c6c3285a66b76871e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91391 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-01tdf#131571: fix crash when clicking the "Text direction from top to bottom"Julien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=159006 cause of invalidation of pOLV here: https://bugs.documentfoundation.org/show_bug.cgi?id=131571#c4 Change-Id: Ibf79e1fa4ebe94470afb2042cdc007bc05010b28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 83ae778d2e7350a15db2f8fbfde7521ab905d0aa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91115 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-31tdf#131576 Fields not displayed as expected in Base's Table WizardCaolán McNamara
this is similar to the problem of tdf#130623 "Base: Empty Field Properties" so take that solution and move it down the the shared component includes: tdf#131576 overlapping windows, move bottom one down a little Change-Id: I567c5a2519edd5921984a27405cddd6a4904fbba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91370 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-08-19 00:50:27 +0000