summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-03loplugin:useuniqueptr in SdrLayerAdminNoel Grandin
Change-Id: I0f9c5b471b6db799b2194096f5d40c8adeb027d7 Reviewed-on: https://gerrit.libreoffice.org/61119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03tdf#76683 writerfilter: TwipMeasure must be positiveJustin Luth
...and the column width must not be negative. The previous column logic ensured that the total width was larger than the reference by adding a fake buffer and then subtracted the difference from the final column. In the case of a zero-width final column, it could become negative. The current logic ensures that the total width is less than the reference width, and then adds the difference (which should be a smaller difference now) to the final column. Regression potential - early columns that need every single twip of bonus space might not fit anymore. On the other hand, ending columns might be fixed... Change-Id: Ie75d455e8ed62dbec5a1b9c901417df8d842ace8 Reviewed-on: https://gerrit.libreoffice.org/59400 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-03tdf#120245: Accept to insert empty field with 'not null' database constraintJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=120245#c4 Change-Id: I9ac852a83e0a57c34ef3640bf0fb0e6a3394db63 Reviewed-on: https://gerrit.libreoffice.org/61268 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-03Fix some drivers xcu (connectivity/registry)Julien Nabet
1) Revert partly 568778874429595855b435792e5ebecd52956dae UseKeywordAsBeforeAlias should be put to true in Features section (see https://gerrit.libreoffice.org/#/c/61144/) 2) Fix BooleanComparisonMode Use xs:int for Properties part but stay with xs:boolean in Features (see https://gerrit.libreoffice.org/#/c/61144/ again) Change-Id: I4397327ceef408be9ee0563f25fe700c1bfd82d3 TODO: add README in connectivity/registry to provide some info Reviewed-on: https://gerrit.libreoffice.org/61271 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-03paintfrm white-spacing adjust: remove obsolete bracketsJustin Luth
doing this in a separate patch to avoid obscuring the changes inside of the other cleanup patch. This simply removes one layer of indenting. Change-Id: I295b2ef59fb8c62db14d18d2e529da6c4c578665 Reviewed-on: https://gerrit.libreoffice.org/61273 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-03tdf#41542 sw cleanup: m_bBorderDist was always trueJustin Luth
This was forced to True in LO 5.4, leaving the variable intact in case any problems arose that would make it easier to revert. But now it is time to clean it up and remove the unnecessary logic. I didn't change the indenting because I don't like obscuring the significant changes. I can do that in a followup commit. Change-Id: Iab04a6a8f4ba8ff7151cf7941f655173136258eb Reviewed-on: https://gerrit.libreoffice.org/61270 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-03Add README for xcu drivers in connectivity/registryJulien Nabet
I used comments from https://bugs.documentfoundation.org/show_bug.cgi?id=119743 + https://gerrit.libreoffice.org/#/c/61144/ Thank you to Lionel and Stephan Change-Id: I956b0c2009e3fa1169ba57a059dde0016375def5 Reviewed-on: https://gerrit.libreoffice.org/61272 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-02-Werror,-Wunused-private-fieldStephan Bergmann
...ever since the code's introduction in 278b1de21f8395ab2a6c49377cf4aec4c16f05c6 "Added base as a data provider" Change-Id: I3ccd1d699e0888cb010e46735f8816eea8b41e34 Reviewed-on: https://gerrit.libreoffice.org/61250 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-02Silence new Clang trunk -Wdefaulted-function-deletedStephan Bergmann
This mostly affects explicitly defaulted functions that had recently been user- declared to silence new GCC trunk -Wdeprecated-copy. It is not entirely clear to me what the best approach is overall, see my mail <http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20181001/245321.html> "Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only", but lets just explicitly delete those functions for now. Change-Id: If8c72f612f67a8feb8b03c2fb988c807e704ef03 Reviewed-on: https://gerrit.libreoffice.org/61259 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-02Fix typoAndrea Gelmini
Change-Id: I34e0e97b165b8335e58bcc5713d2140b31ee94ed Reviewed-on: https://gerrit.libreoffice.org/61225 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-10-02tdf#120234 ignore all proxy windowsJan-Marek Glogowski
I thought just border windows can act as proxies, but this bug proves me wrong; also floating windows set mpClientWindow and may have an additional nested proxy border window. Interestingly proxies can have multiple children, which I tested with a temporary assertion I added!? So just ignore all proxy windows until we find a real one, And drop the assertion as it doesn't make sense any more. I'm just wondering why I always read Child instead of Client... Change-Id: I83a1a5743b434399aae361cb14058993ba60c83c Reviewed-on: https://gerrit.libreoffice.org/61196 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02We shouldn't call DrawTextLayout() without a context on iOSTor Lillqvist
Change-Id: I3e72909ca1aa9f97721d982f16624f496152ae2d
2018-10-02LibreOfficeKit wants the tile pixmap bytes to be in BGRA order in memoryTor Lillqvist
To get that with CoreGraphics on iOS we need to use also kCGImageByteOrder32Little in the CGBitmapContextCreate() call, otherwise the bytes will be in ARGB order in memory. (Not touching the macOS code here.) Change-Id: I3c2dd94feb1c6bf46c5b335f5901b29e5fe1e7fb
2018-10-02More hacking on the tilebench part of the UnitTest appTor Lillqvist
On iOS, don't attempt to write the tile dump ppm file to /tmp, but use the app-specific directory so that it can be copied for inspection using iTunes. (Of course, even better would be to simply paint it to the app's view. Later) Change-Id: I8dd60d04adc61de6594099f5c358a9b6220522da Reviewed-on: https://gerrit.libreoffice.org/61255 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-10-02weld SvxNumOptionsTabPageCaolán McNamara
Change-Id: Ie2ae18b1722e91996887162b4a8ff02d2d812341 Reviewed-on: https://gerrit.libreoffice.org/61228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Fix typos Change-Id: Ic23908f65b62064ae99fa337a4f269d1b1ea1c09 Reviewed-on: https://gerrit.libreoffice.org/61254 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-02Add some colour to a sample odt fileTor Lillqvist
Change-Id: If4dc6458d9c5fb3b574c1bb55196a5086aff3365
2018-10-02filename may be nullCaolán McNamara
Change-Id: I373886d3613607b8ee8e96d8c0314865f3991a92 Reviewed-on: https://gerrit.libreoffice.org/61241 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02tdf#120174 : Always copy mbValueCached flag in Assign()Dennis Francis
so that fast result return maintains correctness. Although not necessary for fixing this bug, lets take advantage of fast result return in the case of empty result token by setting mfValue to 0.0 and setting mbValueCached flag. The fast result return was implemented in :- <commit-header> commit 77f7b4768a79e5a8489b163670e0ce10fbd07c49 Author: Dennis Francis <dennis.francis@collabora.co.uk> Date: Wed Jul 11 17:19:28 2018 +0530 Allow fast result return for formula-cells with... "double" result which is a very frequent use-case. This improves overall running times in most cases, not just for the threaded path. Change-Id: I18d10ee3cea613923e2057e746a6a8187bb18647 Reviewed-on: https://gerrit.libreoffice.org/59395 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> </commit-header> Also added a ui-test for the fix. A normal unit test would have sufficed, but I could not get it to reproduce the issue from a ucalc environment somehow. Change-Id: I9b95b571b596a7bb68768ea0de8ee4334448b540 Reviewed-on: https://gerrit.libreoffice.org/61140 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-10-02tdf#120227 'standard' button missing from .uiCaolán McNamara
and 'standard' just has to exist, doesn't need to be translatable Change-Id: I1e5157781ea81c40952c462253a2e3d53557aecb Reviewed-on: https://gerrit.libreoffice.org/61229 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02Implement filter for Qt5AccessibleWidget::relationsSamuel Mehrbrodt
Change-Id: I1859d612e13b2f0d837aa65012552c441346cb1a Reviewed-on: https://gerrit.libreoffice.org/61236 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-02Implement Qt5AccessibleWidget::relationsSamuel Mehrbrodt
without considering 'match' parameter for now Change-Id: I03ec7017fdaae8c8e20f19e6c827aafb093e8a53 Reviewed-on: https://gerrit.libreoffice.org/61231 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-02sw: new unit test for XControlShapeVasily Melenchuk
Change-Id: Ic7b56da1f48760770ca5617cea6c91e10ff0dcee Reviewed-on: https://gerrit.libreoffice.org/61100 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-02sw: new unit test for XRefreshableSerge Krot
Change-Id: Idaea2e46451ee80b82764e573fdea1c7bf0c86ef Reviewed-on: https://gerrit.libreoffice.org/61213 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-02printdialog: Use labelling a11y relation instead of static roleSamuel Thibault
The field names are arguably rather labels for the static-role widgets providing the status. Change-Id: Ic3407adf84d7399696e51de712635a986fa0c190 Reviewed-on: https://gerrit.libreoffice.org/60142 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-02sw: new unit test for XModifiable2Serge Krot
Change-Id: I30c4db19db068ff73f34236776cb511280acbbd7 Reviewed-on: https://gerrit.libreoffice.org/61096 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-02fix bug in SvtListener copy constructorNoel Grandin
it was copying maBroadcasters, without actually starting to listen to those broadcasters, which means if we __did__ call StartListening, that method would have just returned early. Since nothing seems to need this functionality, and it's not obvious what the correct behaviour would be, just don't do the copy. Change-Id: If5865fa3449839758a43ac537475e0a474f39078 Reviewed-on: https://gerrit.libreoffice.org/61239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-02Qt5AccessibleWidget: Implement keyBindingsForActionSamuel Mehrbrodt
Change-Id: I53d6d36374fc35eb8370ad6d83723aafb01fb8b4 Reviewed-on: https://gerrit.libreoffice.org/61199 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-02Qt5AccessibleWidget: Implement QAccessibleActionInterfaceSamuel Mehrbrodt
shows available action and allows to execute them Change-Id: I944e4eccaac7c458af77b471c1d6e10650b1e798 Reviewed-on: https://gerrit.libreoffice.org/61183 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-02sd a11y: fix dozen of missing mnemonicsKatarina Behrens
Change-Id: Ie0a7f85624da2ef2cd60fe7e074fa98cf64e779e Reviewed-on: https://gerrit.libreoffice.org/61179 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-02loplugin:useuniqueptr in SdrPageViewNoel Grandin
Change-Id: I85aaf0f28c30055003b48209d15b1b496c234e4b Reviewed-on: https://gerrit.libreoffice.org/61120 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-02Related: tdf#120028 PPTX import: fix font color of multi-col shape textMiklos Vajna
Not just font color, anything defined via list styles were not imported. Change-Id: I95e6fc52e30a09ff93fb55d0836e45e177a7b099 Reviewed-on: https://gerrit.libreoffice.org/61230 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-02parse-perfcheck: fix parsing of previous CSV dataNoel Grandin
Change-Id: I46db49472dcaa80b54a937f03bf03b06a2d8a87c Reviewed-on: https://gerrit.libreoffice.org/61240 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-02SvtBroadcaster unify the normal and PrepareForDestruction pathsNoel Grandin
since this approach is better in that it avoids O(n^2) behaviour of lots of listeners deleting from a std::vector, lets just always use this approach. Change-Id: I9204996ee8c9379ac71dfc168a6c1fc653e63a8e Reviewed-on: https://gerrit.libreoffice.org/61204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-02Move GetkeyBindingStrByXkeyBinding to comphelperSamuel Mehrbrodt
So that it is available to other a11y implementations as well Change-Id: Ib82c4861cf9e0e90c64703b13c46548a080ffd10 Reviewed-on: https://gerrit.libreoffice.org/61198 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-02minor optimisation to SvtBroadcaster::AddNoel Grandin
Change-Id: I5ab173cb2517602abc42e715375157fd05fdd55f Reviewed-on: https://gerrit.libreoffice.org/61203 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-02Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#115254 Some branch bookmarks are'nt working 32 Module basctl Change-Id: I0206a66346e76e71f6fc14cd92257b2415968741 Reviewed-on: https://gerrit.libreoffice.org/61235 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-10-02Cater for --without-java in CppunitTest_sc_dataproviderStephan Bergmann
...which appears to still work if you just disable the components that are not present because they require Java. Found by <https://ci.libreoffice.org/job/lo_tb_random_config_linux/1514/>. Change-Id: I1a7f27a9f44d2a82953e4230c974f19e98127550 Reviewed-on: https://gerrit.libreoffice.org/61226 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-02tdf#120055 line dialog notebook should be can-focusCaolán McNamara
Change-Id: I3993f726f433503173c27c68be40936bc03aaf6e Reviewed-on: https://gerrit.libreoffice.org/61227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02Unify sal plugin loadersJan-Marek Glogowski
Change-Id: Ic099761eaff80349e985ccf62e3f4aa6b2e98022 Reviewed-on: https://gerrit.libreoffice.org/61103 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02Implement MacOSX VCL backend as pluginJan-Marek Glogowski
Change-Id: Ie90af62eff146064c3b066a8f7ca1c3a69f44c39 Reviewed-on: https://gerrit.libreoffice.org/61102 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02Implement Windows VCL backend as pluginJan-Marek Glogowski
Change-Id: If9c7c67f48311ac68ecc9f8e3a07f9bb7c73d962 Reviewed-on: https://gerrit.libreoffice.org/61101 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02coverity#1439597 it's not possible for SwPaM::End to return nullMichael Stahl
Change-Id: I1289721e2e62e258237096d79182779ca3f15bdb Reviewed-on: https://gerrit.libreoffice.org/61205 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-02rename PresetListBox back to SvxPresetListBoxCaolán McNamara
Change-Id: If65c3a9b529d2173f9795c038c877d4e4423a883 Reviewed-on: https://gerrit.libreoffice.org/61217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02drop unused SvxPresetListBoxCaolán McNamara
Change-Id: I9efd96e42c7c1a7e8f9f08ddf1edf7c74b30c7ca Reviewed-on: https://gerrit.libreoffice.org/61216 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02consistent 3.18 version require in .uisCaolán McNamara
Change-Id: I5102c218c969cf9302405e4146f92e187c1998ce Reviewed-on: https://gerrit.libreoffice.org/61215 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02make all notebooks scrollable and enable_popupCaolán McNamara
Change-Id: I16a6d556ca4c6b3f876dc0c8380d01fe3022209e Reviewed-on: https://gerrit.libreoffice.org/61195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02weld SvxLineTabDialogCaolán McNamara
Change-Id: Icb13a6eb2e8c6f6dbd3cf477051bc0bd682e2e7a Reviewed-on: https://gerrit.libreoffice.org/61193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02tdf#115262 sc: fix cumulative placement error of imagesMiklos Vajna
Commit 708d1c5ab242b545ced598879233fc662d7e6cc0 (sc lok: emit RowColumnHeader info in twips, 2015-11-02) improved precision of the twip -> pixel conversion ratio, but ignored the detail that limited precision used to silence cumulative errors that appear with larger precision. The original use-case was better precision of row/column headers for the LOK API, so keep that as-is, but go back to the original behavior on the desktop. Change-Id: Ide169ab1745a9a9299caf3334559884ff7223cbe Reviewed-on: https://gerrit.libreoffice.org/61219 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-02Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Reduce L10N workload for repetitive strings Change 'Syntax' and 'Examples' heading into an embedded string translated only once. Change-Id: Iac2eef8fedbaa4461aa2f941af7f065a3b16fb2d Reviewed-on: https://gerrit.libreoffice.org/61143 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-26 17:42:49 +0000