summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-03unweld HeaderEditPage for nowCaolán McNamara
not ready yet Change-Id: I022b47c521a63fb18052274aa8e2020dc6210d9c Reviewed-on: https://gerrit.libreoffice.org/61289 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03set modal in .uiCaolán McNamara
Change-Id: I3a428f0104c030f7c5d3954387d84cb2a5351483 Reviewed-on: https://gerrit.libreoffice.org/61288 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03loplugin:unusedmethodsNoel Grandin
Change-Id: I9e583df920657ab401162db79decb192c4f69f90 Reviewed-on: https://gerrit.libreoffice.org/61283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03Related: tdf#119613 tdf#118127 suppress duplicated builtins, rework All catEike Rathke
In number formatter dialog: Some locales may define duplicated formats, specifically date formats, for all builtin formats <50 must be present and default formats may be equal to other formats. Try to suppress duplicated formats, preferring those that are essential (i.e. used as current, default or edit formats). This is done only per category, not in the All category. Example is [en-ZA] English (South Africa) that now has ISO 8601 also as default date+time format, though there only the date+time format is suppressed because for date we want to keep both the locale's default and the fixed ISO format pickable. The All category still listed the since long deprecated old currency formats including the worrying CCC format that follows the current default currency. Eliminate that crap, unless one matches the current format. Also, additional formats defined in locale data and user defined formats were never listed in the All category, do that. Change-Id: I6e6b9bfecc34d51e89930f348f7afbe5e3c41738 Reviewed-on: https://gerrit.libreoffice.org/61275 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-10-03crash in calc page dialogCaolán McNamara
Change-Id: I06072af58b0e302930a8d305f2b667843c42cd03 Reviewed-on: https://gerrit.libreoffice.org/61284 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03loplugin:constfields in swNoel Grandin
Change-Id: I1eb6583bb9ec815bc0564b0d7c676f5b1fb9045f Reviewed-on: https://gerrit.libreoffice.org/61177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03tdf#108064 OOXML export: keep preset dashes with mso preset linewidthsAdam Kovacs
Change-Id: Ie87544850c494d946ea43b984aeff8666e08d738 Reviewed-on: https://gerrit.libreoffice.org/60874 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-10-03loplugin:unusedfieldsNoel Grandin
Change-Id: I3d2cdd80b542dbdbd29971ef837111191809f081 Reviewed-on: https://gerrit.libreoffice.org/61282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03sw: new unit test for XAutoTextContainerSerge Krot
Change-Id: I8c4fba4d576256c4ca3870b521aec999407af4e5 Reviewed-on: https://gerrit.libreoffice.org/60945 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-03We need to include <o3tl/make_unique.hxx> hereTor Lillqvist
Change-Id: I9670407cd9e848d208f844f6d0879a5a19b86f4c
2018-10-03Add Python files to pre-commit hook checksThorsten Behrens
Change-Id: Ie5a631abe25a25bab9e74b353994f0788fe3dd06 Reviewed-on: https://gerrit.libreoffice.org/61279 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-03tdf#72987 split firebird test into a regression test and a "new" testRene Engelhard
former with endianness and latter with the new fbk format. Add new endianness-independent firebird test odbs Change-Id: I29be2e6916fcca74744211dba04463376fb6b8d5 Reviewed-on: https://gerrit.libreoffice.org/60917 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-10-03tdf#72987 run firebird test for little endian only for nowRene Engelhard
since those old(er) files still use the endianness-depending format. And remove x64 from the filename... Change-Id: I24e56cd8561c2ec6a1f77a66907c14cdea8248b6 Reviewed-on: https://gerrit.libreoffice.org/60916 Tested-by: Jenkins Reviewed-by: Rene Engelhard <rene@debian.org>
2018-10-03Related: tdf#93372 fix up extensions character dialogCaolán McNamara
Change-Id: I3609f8bd6a23e6f419bba88c17bc7d82a5d3b993 Reviewed-on: https://gerrit.libreoffice.org/61266 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Related: tdf#93372 pass in parent to base's table format dialogCaolán McNamara
Change-Id: I06a39b6517aabac321c45b1a3ab92f13903b9daa Reviewed-on: https://gerrit.libreoffice.org/61265 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03rename cui::NumberingPreview back to SvxNumberingPreviewCaolán McNamara
Change-Id: I5c8b9ac10babd0535fa55f490a5478f88fc76222 Reviewed-on: https://gerrit.libreoffice.org/61264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03keep reset/standard orderCaolán McNamara
Change-Id: Idc047faf8ade81b3e6fce382b188ccfa97004b12 Reviewed-on: https://gerrit.libreoffice.org/61263 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03when gtk3 >= 3.22.0 set natural size propagateCaolán McNamara
so 1-10 in format numbering etc isn't slightly clipped with a scrollbar on top of it Change-Id: I55909993d4b4c846ca0aeff2f2cd458dfa59d860 Reviewed-on: https://gerrit.libreoffice.org/61262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03weld SwSvxNumBulletTabDialogCaolán McNamara
Change-Id: I8ea74dc15bba04c0615e61c069407160a7b95c4c Reviewed-on: https://gerrit.libreoffice.org/61242 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03writerfilter: pass these by value and use std::move()Miklos Vajna
Change-Id: I9a763eacf8887230ba5d88ac69cb13d0cfb1a7ee Reviewed-on: https://gerrit.libreoffice.org/61274 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-03loplugin:unusedmethodsNoel Grandin
Change-Id: I7db0c27ff2213210ed4b46ebbadc1a2f74a18257 Reviewed-on: https://gerrit.libreoffice.org/61249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:mergeclass merge ScFullMatrix into ScMatrixNoel Grandin
ever since commit b26f83b1cc184a79caa9e9c0ae15717ef61dde4a Date: Fri Aug 10 21:43:32 2018 +0200 loplugin:unusedmethods mostly this seems to be fallout from commit 089a4f245325a5be5cd5951d85305d791b4d9cb6 Date: Mon Aug 6 14:55:04 2018 +0200 remove Calc's software interpreter Change-Id: Id1cb89bb3d95521b7ddf7d072ee9392053e5a52b Reviewed-on: https://gerrit.libreoffice.org/61257 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:unusedfieldsNoel Grandin
Change-Id: Idf6f7f2946eecada64d2a586194533840ec8cc63 Reviewed-on: https://gerrit.libreoffice.org/61248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:constfields in svtoolsNoel Grandin
Change-Id: I91553f89d8f5ee42afa52d196bf86f8a92011850 Reviewed-on: https://gerrit.libreoffice.org/61186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:useuniqueptr in SdrLayerAdminNoel Grandin
Change-Id: I0f9c5b471b6db799b2194096f5d40c8adeb027d7 Reviewed-on: https://gerrit.libreoffice.org/61119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03tdf#76683 writerfilter: TwipMeasure must be positiveJustin Luth
...and the column width must not be negative. The previous column logic ensured that the total width was larger than the reference by adding a fake buffer and then subtracted the difference from the final column. In the case of a zero-width final column, it could become negative. The current logic ensures that the total width is less than the reference width, and then adds the difference (which should be a smaller difference now) to the final column. Regression potential - early columns that need every single twip of bonus space might not fit anymore. On the other hand, ending columns might be fixed... Change-Id: Ie75d455e8ed62dbec5a1b9c901417df8d842ace8 Reviewed-on: https://gerrit.libreoffice.org/59400 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-03tdf#120245: Accept to insert empty field with 'not null' database constraintJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=120245#c4 Change-Id: I9ac852a83e0a57c34ef3640bf0fb0e6a3394db63 Reviewed-on: https://gerrit.libreoffice.org/61268 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-03Fix some drivers xcu (connectivity/registry)Julien Nabet
1) Revert partly 568778874429595855b435792e5ebecd52956dae UseKeywordAsBeforeAlias should be put to true in Features section (see https://gerrit.libreoffice.org/#/c/61144/) 2) Fix BooleanComparisonMode Use xs:int for Properties part but stay with xs:boolean in Features (see https://gerrit.libreoffice.org/#/c/61144/ again) Change-Id: I4397327ceef408be9ee0563f25fe700c1bfd82d3 TODO: add README in connectivity/registry to provide some info Reviewed-on: https://gerrit.libreoffice.org/61271 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-03paintfrm white-spacing adjust: remove obsolete bracketsJustin Luth
doing this in a separate patch to avoid obscuring the changes inside of the other cleanup patch. This simply removes one layer of indenting. Change-Id: I295b2ef59fb8c62db14d18d2e529da6c4c578665 Reviewed-on: https://gerrit.libreoffice.org/61273 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-03tdf#41542 sw cleanup: m_bBorderDist was always trueJustin Luth
This was forced to True in LO 5.4, leaving the variable intact in case any problems arose that would make it easier to revert. But now it is time to clean it up and remove the unnecessary logic. I didn't change the indenting because I don't like obscuring the significant changes. I can do that in a followup commit. Change-Id: Iab04a6a8f4ba8ff7151cf7941f655173136258eb Reviewed-on: https://gerrit.libreoffice.org/61270 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-03Add README for xcu drivers in connectivity/registryJulien Nabet
I used comments from https://bugs.documentfoundation.org/show_bug.cgi?id=119743 + https://gerrit.libreoffice.org/#/c/61144/ Thank you to Lionel and Stephan Change-Id: I956b0c2009e3fa1169ba57a059dde0016375def5 Reviewed-on: https://gerrit.libreoffice.org/61272 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-02-Werror,-Wunused-private-fieldStephan Bergmann
...ever since the code's introduction in 278b1de21f8395ab2a6c49377cf4aec4c16f05c6 "Added base as a data provider" Change-Id: I3ccd1d699e0888cb010e46735f8816eea8b41e34 Reviewed-on: https://gerrit.libreoffice.org/61250 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-02Silence new Clang trunk -Wdefaulted-function-deletedStephan Bergmann
This mostly affects explicitly defaulted functions that had recently been user- declared to silence new GCC trunk -Wdeprecated-copy. It is not entirely clear to me what the best approach is overall, see my mail <http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20181001/245321.html> "Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only", but lets just explicitly delete those functions for now. Change-Id: If8c72f612f67a8feb8b03c2fb988c807e704ef03 Reviewed-on: https://gerrit.libreoffice.org/61259 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-02Fix typoAndrea Gelmini
Change-Id: I34e0e97b165b8335e58bcc5713d2140b31ee94ed Reviewed-on: https://gerrit.libreoffice.org/61225 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-10-02tdf#120234 ignore all proxy windowsJan-Marek Glogowski
I thought just border windows can act as proxies, but this bug proves me wrong; also floating windows set mpClientWindow and may have an additional nested proxy border window. Interestingly proxies can have multiple children, which I tested with a temporary assertion I added!? So just ignore all proxy windows until we find a real one, And drop the assertion as it doesn't make sense any more. I'm just wondering why I always read Child instead of Client... Change-Id: I83a1a5743b434399aae361cb14058993ba60c83c Reviewed-on: https://gerrit.libreoffice.org/61196 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02We shouldn't call DrawTextLayout() without a context on iOSTor Lillqvist
Change-Id: I3e72909ca1aa9f97721d982f16624f496152ae2d
2018-10-02LibreOfficeKit wants the tile pixmap bytes to be in BGRA order in memoryTor Lillqvist
To get that with CoreGraphics on iOS we need to use also kCGImageByteOrder32Little in the CGBitmapContextCreate() call, otherwise the bytes will be in ARGB order in memory. (Not touching the macOS code here.) Change-Id: I3c2dd94feb1c6bf46c5b335f5901b29e5fe1e7fb
2018-10-02More hacking on the tilebench part of the UnitTest appTor Lillqvist
On iOS, don't attempt to write the tile dump ppm file to /tmp, but use the app-specific directory so that it can be copied for inspection using iTunes. (Of course, even better would be to simply paint it to the app's view. Later) Change-Id: I8dd60d04adc61de6594099f5c358a9b6220522da Reviewed-on: https://gerrit.libreoffice.org/61255 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-10-02weld SvxNumOptionsTabPageCaolán McNamara
Change-Id: Ie2ae18b1722e91996887162b4a8ff02d2d812341 Reviewed-on: https://gerrit.libreoffice.org/61228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Fix typos Change-Id: Ic23908f65b62064ae99fa337a4f269d1b1ea1c09 Reviewed-on: https://gerrit.libreoffice.org/61254 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-02Add some colour to a sample odt fileTor Lillqvist
Change-Id: If4dc6458d9c5fb3b574c1bb55196a5086aff3365
2018-10-02filename may be nullCaolán McNamara
Change-Id: I373886d3613607b8ee8e96d8c0314865f3991a92 Reviewed-on: https://gerrit.libreoffice.org/61241 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02tdf#120174 : Always copy mbValueCached flag in Assign()Dennis Francis
so that fast result return maintains correctness. Although not necessary for fixing this bug, lets take advantage of fast result return in the case of empty result token by setting mfValue to 0.0 and setting mbValueCached flag. The fast result return was implemented in :- <commit-header> commit 77f7b4768a79e5a8489b163670e0ce10fbd07c49 Author: Dennis Francis <dennis.francis@collabora.co.uk> Date: Wed Jul 11 17:19:28 2018 +0530 Allow fast result return for formula-cells with... "double" result which is a very frequent use-case. This improves overall running times in most cases, not just for the threaded path. Change-Id: I18d10ee3cea613923e2057e746a6a8187bb18647 Reviewed-on: https://gerrit.libreoffice.org/59395 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> </commit-header> Also added a ui-test for the fix. A normal unit test would have sufficed, but I could not get it to reproduce the issue from a ucalc environment somehow. Change-Id: I9b95b571b596a7bb68768ea0de8ee4334448b540 Reviewed-on: https://gerrit.libreoffice.org/61140 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-10-02tdf#120227 'standard' button missing from .uiCaolán McNamara
and 'standard' just has to exist, doesn't need to be translatable Change-Id: I1e5157781ea81c40952c462253a2e3d53557aecb Reviewed-on: https://gerrit.libreoffice.org/61229 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02Implement filter for Qt5AccessibleWidget::relationsSamuel Mehrbrodt
Change-Id: I1859d612e13b2f0d837aa65012552c441346cb1a Reviewed-on: https://gerrit.libreoffice.org/61236 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-02Implement Qt5AccessibleWidget::relationsSamuel Mehrbrodt
without considering 'match' parameter for now Change-Id: I03ec7017fdaae8c8e20f19e6c827aafb093e8a53 Reviewed-on: https://gerrit.libreoffice.org/61231 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-02sw: new unit test for XControlShapeVasily Melenchuk
Change-Id: Ic7b56da1f48760770ca5617cea6c91e10ff0dcee Reviewed-on: https://gerrit.libreoffice.org/61100 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-02sw: new unit test for XRefreshableSerge Krot
Change-Id: Idaea2e46451ee80b82764e573fdea1c7bf0c86ef Reviewed-on: https://gerrit.libreoffice.org/61213 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-02printdialog: Use labelling a11y relation instead of static roleSamuel Thibault
The field names are arguably rather labels for the static-role widgets providing the status. Change-Id: Ic3407adf84d7399696e51de712635a986fa0c190 Reviewed-on: https://gerrit.libreoffice.org/60142 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-02sw: new unit test for XModifiable2Serge Krot
Change-Id: I30c4db19db068ff73f34236776cb511280acbbd7 Reviewed-on: https://gerrit.libreoffice.org/61096 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit (git 2.34.1) at 2025-02-25 19:17:39 +0000