summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-11tdf#130494: DOCX import: limit paragraph-level character propertyLászló Németh
expansion for the whole table paragraph based on the last character context. regression from 2ab481b038b62b1ff576ac4d49d03c1798cd7f84 (tdf#90069 DOCX: fix character style of new table rows) Change-Id: I49da23c268436488ff1537771869c38108113c12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88199 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-11Fix typoAndrea Gelmini
Change-Id: I57990148b75dc00ab7725e6917bc7971f5dde2d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88445 Tested-by: Jenkins Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-11tdf#126744 Transfer paper size and orientation to new printerKelemen Gábor
when selected from the Printer dropdown list Change-Id: Iedd53575c2e9146b663cf21b42b495473abe5165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88373 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2020-02-11android: Actually let's avoid the exceptions via bridges only on aarch4.Jan Holesovsky
Change-Id: Id2830f09ca6afd11f6f866565f37bdb7ba45bfb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84205 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-11tdf#129346: Add UItestXisco Fauli
Change-Id: I491659d3bc5657c4eda2d88849acb0c4972b0c60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88429 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-11Related: tdf#130161 invalid iterator used in BrowseMode::Subs caseCaolán McNamara
xTreeIter is invalid here before AddEntry, afterwards it will remain invalid unless it was passed in to AddEntry to be updated to the newly inserted location, and we need it to be valid in the BrowseMode::Subs case Change-Id: I4831b7713bdb67889604fd4f8a7cd1644fd81a10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11add some more libs to libmergedNoel Grandin
and fix a consequent symbol name clash in basctl Change-Id: Idc836fcbb379e1046a60008391635eb6241b27c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88188 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-11DOCX import: fix margins of inline shapes with effects, imported as Draw shapesMiklos Vajna
Effects have an extent, and unhandled effects (like this blurred shadow) need to take space in the margin of the shape to make sure they use the correct amount of space in the layout. This was working in general, but not in case the importer decided to import the shape as Draw shape + the shape was inline. (And also disable a new CppunitTest_sw_uibase_shells test on Windows, which is only stable on Linux, it seems.) Change-Id: I9d0531d9393d8c2cd274e6f54bbbfe8024bf270f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88427 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-11update creditsChristian Lohmaier
Change-Id: I21a49cb649ebdc6b8af50f0b92decb77887e721c
2020-02-11Writer Sidebar Wrap section update for better alignment and fitandreas kainz
Change-Id: I9bb3054f5e55346f09828e5ce7220445794c5880 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88411 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-11weld FillControl item windowCaolán McNamara
Change-Id: I5f943a9cf881494fe8a9fecea6a957a7085a5582 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88378 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11cypress: mobile: Font size combobox is broken on core/master.Caolán McNamara
so https://cgit.freedesktop.org/libreoffice/online/commit/?id=08d6c3fdf9bac4ad8318151ab1402690eb950f52 isn't needed Change-Id: I8836969ae064342835287a63065e591f083f2220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11tdf#124176: Use pragma once instead of include guardsFurkan Ahmet Kara
Change-Id: I4f0ff5864f343c016ae88477e064b0c643cd0d9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88268 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-11Drop some static_cast from long to sal_Int32Stephan Bergmann
...that would just silently hide overflow in the unexpected case that the given long values do not fit into sal_Int32. (These casts had been carried over in 3270fc628b2e6a8f73ff0d1e4389d9c7595e0a50 "use OUString(Buffer) in class Edit" from the casts to xub_StrLen, aka sal_uInt16, that were present ever since 8ab086b6cc054501bfbf7ef6fa509c393691e860 "initial import".) Change-Id: I1775f44d386389f00051f11cc9d1911b10feb427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88432 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-11related: tdf#106742 sw: DOCX import/export: fix default of table indentMichael Stahl
There's a compatibilityMode in word/settings.xml in DOCX files: https://docs.microsoft.com/en-us/openspecs/office_standards/ms-docx/90138c4d-eb18-4edc-aa6c-dfb799cb1d0d If a document doesn't contain compatibilityMode, then the default is 12, but the code for table indent import/export assumed that the default is 15, so loading an ODF document and exporting as DOCX results in wrong table indent when loaded in Word. (regression from 9a31d1c83e08600507689dc18f6f0973bc7e4389) Change-Id: I3ce32286473640e5b7e12b487aef5f123bfb8d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88408 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-11tdf#42949 Fix IWYU warnings in writerperfect/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia1ac2b3d254487f6b4e85b52eead13635d30a5af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88416 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-11android hunspell: All languages we pack are the supported ones.Jan Holesovsky
Without this, we disable all the languages, because the env. variable is not set. Change-Id: If8f6a9ec6270391d1f8c2bf225c8ea4bb1aae688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88220 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88367 Tested-by: Jenkins
2020-02-11on main window getting focus gtk is destroying the popup windows itselfCaolán McNamara
so copy the data we need before it can do that Change-Id: If35d7ba0f272475e82f969bd80c6ff44131a3d2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88376 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11surface attribute disappearedCaolán McNamara
Change-Id: I195fc92ff6fea962ceca06df5e5e562d729bcc5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88374 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11SplitWindow::ImplDrawBack is effectively unusedNoel Grandin
ever since commit facc94bb0aef58353d54e14f948790643ccbec32 Date: Thu Jan 30 14:36:57 2020 +0200 loplugin:unusedfields Change-Id: Idb09424a09074abe77d6d5b63ea4a526a3bb7ed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-11Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to e6e4a01c2ae198bde731045f4451ba345877cadb - update Online Update help page - add headings - correct outline level - add control - align help page with dialog box - added "online update" icon - updated "note" about installation of Update module, a common intro, with sys-specific details. Change-Id: Id237acbb93ec90a6d7622135e5bdc212f28ca1a4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87810 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-11Avoid needless ListenerList temporaryStephan Bergmann
Change-Id: I0670a013136c8d8d7e7fb5caca54812f4fa490e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88422 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-11tdf#129221 DOCX import: fix missing restart of numberingMiklos Vajna
Regression from e49d2b31fb2020d065b4ad940d1031d07b10f32b (fdo#78939 [DOCX] Hang while opening due to incorrect modification of Style, 2014-06-06), the problem was that the 2nd sub-list of the bugdoc was not restarted in Writer, while it was in Word. The PR2 paragraph style inherits from the PR1 one and only that sets the numId; tweaking the bugdoc to state the numId directly in PR2 would work around the problem. Fix the issue by improving DomainMapper_Impl::finishParagraph(), so that it uses lcl_getListId() rather than calling pStyleSheetProperties->GetListId() directly; since the previous knows how to walk up the parent chain if needed. Change-Id: I1c460919b0389d5b053b4ca1c9210279d6cd183c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88413 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 66d9968bba9fe381183387089509ed928ee8a6d9 - tdf#129554 keyboard shortcuts for Pivot dialog Change-Id: I95abc0b5f2ba6447c8d034f12a9babebbc5a2db1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88419 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-11Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 68ea04c5012484b5ca30a87a5b8f326e5f9708f2 - tdf#130064 adjustments in legacy positioning help page - remove unnoticed empty paragraph and add bookmark branch - double appearance in "apply" label, and change to "List" style - add missing word - improve "Load/Save" explanation (appears also for "Position" and "Chapter Numbering" - added related topic link to "Indenting Paragraphs" for both "Position" pages Change-Id: I8da3e6b5e70c37606eaa79850cde0d9c4b3d5db1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88390 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-02-11cui: Compare by full module idMaxim Monastirsky
Otherwise Master Document is detected as Writer, causing crash when opening the customization dialog, as the notebookbar tab isn't prepared to handle the Master Document variant. Change-Id: I872255c42517b4223fb31e2074e4d5d083c76e93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88344 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-10lok: calc: zoomed text entry not renderedMarco Cecchetti
Change-Id: I829966d81bd68571a0651feb458a817587e4d88e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84992 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-10operate on the text renderer cell, not the first cellCaolán McNamara
Change-Id: Id208150e45a4a5724f1e001522ee8fd94a64a91a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88375 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10reportdesign: Hide some internal commands from customizationMaxim Monastirsky
In addition: - .uno:BackColor was unused, and internally mapped to the same id as .uno:DBBackgroundColor which is used and has a label. So remove the former, and make the latter visible in the customization dialog instead. - .uno:DSBEditDoc is mapped to SID_EDITDOC, and handled by the code, but has no label. On the other hand, the toolbar has an .uno:EditDoc item, which has no mapping in reportdesign, but happens to be mapped to SID_EDITDOC elsewhere. So assume this was a mistake, and .uno:DSBEditDoc should be used instead of .uno:EditDoc. Change-Id: I9da2ed36167571627b32a4055b734847c3ea1e64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88342 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-10Always checking for Master document command labels makes no senseMaxim Monastirsky
Change-Id: I33d04da63c5e30d166bd22f9fc7ffb5aa4da5c6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88343 Tested-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-10Add case table for Warang CitiAlex Henrie
Change-Id: Idc42ffe7d68f612da759146079fa900b559b1def Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87317 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-02-10Resolves: tdf#130550 Add Ligurian [lij-IT] to language listEike Rathke
Change-Id: I6a83bd754ebebf877d6638d5672194aefcf179bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88372 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-10tdf#129346 only select first page fallback if seting to current page failedCaolán McNamara
Change-Id: Iee4f9cef9659837e9ce131e3bfc8da3e8d87bf84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 6f892e6e9b43209dad3ee82ddd7bd4ea0d3b129f - updating help for "Page number" on "Status Bar" help page - changed section id from "seitennummer" to "pagenumber" - single click opens "Go to Page" - removed "link" in "pagenumber" section - because it simply goes from the Status bar page to the page where the embed is coming from. Change-Id: I23387937aea57811f85a9a9cf4a4f3a80932b4ac Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88150 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-10Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to 377542bfda4f697cc0f50ac90e8ed40e98db0bd2 - Index entry addition Change-Id: I291bff961d6772bf72ca5fc1d23b6584a32b0a4d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88186 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-10Resolves: tdf#130541 null-deref on detaching already-detached pageCaolán McNamara
Change-Id: Ib48ab91232b8ff624a1387ab82701938eef58ded Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88380 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10Resolves: tdf#130548 click is sent to the other member of the groupCaolán McNamara
when toggling one the other gets a click signal, but its too early and the page size isn't set yet, making the dialog thing the margins won't fit in the page Change-Id: I5b51f2d91c69558d47f43b3f05eca3fd87a24125 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10Remove redundant ScTabView::GetSdrViewStephan Bergmann
See the comments at <https://gerrit.libreoffice.org/c/core/+/87872> "Removed old comment" how it was presumably used in the distant past to address <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/ fatal-error-c1055?view=vs-2019> "compiler limit : out of keys". Change-Id: I168532403fe04111ce1af08d43924a426c09c42d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88379 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-10refactor PostIt access to SwFormatFields in ...Bjoern Michaelsen
- SwTextShell::ExecField() - PostItManager Change-Id: I7eabf0a7d8170d0dacf3069925abfe1a91a4a9f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88334 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-02-10android hunspell: Hardcode the ReferenceOOoMajorMinor for version check.Jan Holesovsky
From some reason it fails to be read from the versionrc; and I'm not really eager to debug why... Without this, only the dictionaries that do not mention the OpenOffice.org-minimal-version are registered; which would be just 2 of them. Change-Id: I9fe0bc138eadbdcbe5e0d8231e7e90ef268163bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88219 Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88366 Tested-by: Jenkins
2020-02-10android hunspell: Don't explicitly disable extensions on Android.Jan Holesovsky
We need the bundled extensions for hunspell. Change-Id: I423d71376652b7d54dfdcc81462a19db9dc785bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88218 Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88365
2020-02-10android hunspell: Turn on the hunspell build on Android...Jan Holesovsky
...and try to register it for use - it's a bundled extension. The attempt to use the Android's native spell checking failed because the combination of gboard + google's spell checker makes every word in the app appear as if spelled correctly. I haven't found any easy way around that, so let's use hunspell instead; but for that, we need to make the bundled extensions work on Android. Change-Id: If6563e497f1d3085c26eda571567242b2c1f6181 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88217 Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88364 Tested-by: Jenkins
2020-02-10set a narrow width so it takes the width of its fellow panel membersCaolán McNamara
Change-Id: I846d1918fbd470439ea1efe591ff8eb392464bce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88377 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10[en_GB] 6 new autocorrect wordsMarco A.G.Pinto
Change-Id: I15a3626a79cb4944a56a86c95cfcb1aa587999fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88292 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-10[en_US] 6 new autocorrect wordsMarco A.G.Pinto
Change-Id: Ibeb66ea402c0800d321ed7f03bed5741c04fec1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88294 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-10Avoid additional search in case of insertionMuhammet Kara
Change-Id: If53add597daea0dc6ba77d92297d0dd0303c3500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-10weld SvxFmAbsRecWin item windowCaolán McNamara
Change-Id: I6a11d8ba226b28447e2ab04925090491d6953132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10weld SvxFmTbxCtlRecTotal label item windowCaolán McNamara
and SvxFmTbxCtlRecText label item window and SvxFmTbxCtlRecFromText label item window Change-Id: I5c5bbdacfe7e69abd44b9a548deadbf6c4d2a7d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10elementary: Fix for tdf#130533; list in Impress Sidebarrizmut
- Update also to icons in Bullets and Numbering toolbar Change-Id: Ifbd28ae3e1842047c39a9349d670b6e954dd2d62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88356 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-02-10ignore -DGLM_FORCE_CTOR_INIT for shared PCHLuboš Luňák
It's not used by the PCH, so it's safe. Change-Id: Ia86bf0ff31bc40b81b10517f8abd33e9170dba2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88362 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>