summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-04-26tdf#107392 ODF import: fix z-order sorting of SVG imagesMiklos Vajna
The problem was that in case the document has shapes where the order does not match the z-index order, so sorting is needed, then sorting failed to take the multi-image feature into account. E.g. SVG images have a PNG fallback, but at the end of the shape import the PNG fallback is removed, which means the "actual" (not the "wished") z-index of the shapes after the SVG image has to be adjusted. Without this happening SvxDrawPage::getByIndex() (or in case of Writer, SwTextBoxHelper::getByIndex()) will throw when the importer calls getByIndex(3) but we only have 3 shapes. This results in not honoring the z-index request of the remaining shapes. Regression from commit 44cfc7cb6533d827fd2d6e586d92c61d7d7f7a70 (re-base on ALv2 code. Includes (at least) relevant parts of:, 2012-10-09), from the Svg: Reintegrated Svg replacement from /branches/alg/svgreplavement http://svn.apache.org/viewvc?view=revision&revision=1220836 part. Change-Id: Ibe880e5c6c74b728b4a760498720ee31f052b726 Reviewed-on: https://gerrit.libreoffice.org/36998 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-26WaE: -Wsometimes-uninitializedCaolán McNamara
Change-Id: Ia46d44e45a30761cc366273cda4fa62b83a79430
2017-04-26check all ParaPortionList::SafeGetObject() return values for nullptrEike Rathke
Change-Id: I46fdd613c9ad3762f045f984caff2a8dbef9bf16
2017-04-26Hack-around an unclear Windows problem in the test.Jan Holesovsky
Change-Id: I5194c6a20953eb66745539493a8782f089e25e2a Reviewed-on: https://gerrit.libreoffice.org/36985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-26Clean up uses of SAL_U/SAL_W: comphelperStephan Bergmann
Change-Id: I56976f91647c3969d5709e5f691f860bb97ed548
2017-04-26loplugin:useuniqueptr (clang-cl)Stephan Bergmann
Change-Id: Ie541ecc3ec8d7032666b09aaec7d216a43ae44f1
2017-04-26loplugin:redundantcast (clang-cl)Stephan Bergmann
Change-Id: I4370a16ae9652d4f1e5aa3ed472cd88ad6d210c7
2017-04-26loplugin:redundantcast (clang-cl)Stephan Bergmann
Change-Id: I5164bc1bfa1aaae0f648e0384227d92c8b2ff7a3
2017-04-26loplugin:useuniqueptr (clang-cl)Stephan Bergmann
Change-Id: I491fb1fdcc3f5f64e4adb7276217bbdc13a1fa19
2017-04-26-Werror,-Wunused-macros (clang-cl)Stephan Bergmann
Change-Id: I64fa44caecd3f86bd23dc625e72c134659610b1a
2017-04-26sw: convert some OSL_ENSURE to assert in ftnfrm.cxxMichael Stahl
Change-Id: I1e37606a767a6399965ede05beb14abffd07be89
2017-04-26tdf#107398 sw: do not leave empty footnote container in layoutMichael Stahl
... when applying loop control in SwFlowFrame::MoveBwd(). The SwFootnoteContFrame is newly created in MoveBwd(), line 2062: pNewUpper = m_rThis.GetLeaf( MAKEPAGE_FTN, false ); If it stays empty, that is not a valid layout so delete it again. Since the idle/timer refactoring in VCL the invalid layout stays until the document is closed; presumably before LO 5.0 the timer based layout would reformat things again. (regression from af41b7f91f22052d49654d41ae9916d6981db3f6) Change-Id: I841f42b465f8123f9246f1fa70d1417ffdd57700
2017-04-26loplugin:useuniqueptr (clang-cl)Stephan Bergmann
Change-Id: I5ed7a980da0d8f6d320db306fcfca969ae700c4f
2017-04-26loplugin:useuniqueptr (clang-cl)Stephan Bergmann
Change-Id: I08c2c3557b4cb1804446d5a65e8e0499b27a3329
2017-04-26external: update pdfium to 3064Miklos Vajna
This contains the new FPDFPath_GetFillColor / FPDFPageObj_GetType APIs I want to use in CppunitTest_vcl_pdfexport. Change-Id: I275ff761188c07dbbab27a1e0715ac250cd306c9 Reviewed-on: https://gerrit.libreoffice.org/36974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-26vcl: refactor ErrorHandler functionsChris Sherlock
Current, HandleError_Impl is called on by GetErrorString, and HandleError_Impl also creates the error string. However, when you look at what each function does, HandleError_Impl has been imbued with some extraneous parameters: 1. bJustCreateString, and 2. rError bJustCreateString is unnecessary, in fact it just mutates HandleError to create the string, which is not really the core purpose of this function. In fact, the string should be created when we get the string from the error ID (GetErrorString), and in fact the error handler function should call on GetErrorString and not the other way around! This has the happy side effect of vastly simplifying this code, and allows each of the functions only do the thing they are meant to do, and we no longer need these extraneous parameters which just cause problems for code readibility. On to of this, by simplifying the HandleError_Impl function, we just move the code into the public HandleError function because these parameters aren't necessary any more. Change-Id: I4a727b5bbc6d3cdb0519f49b48dc52f8a8976629 Reviewed-on: https://gerrit.libreoffice.org/36849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26remove sc bitmaps from .src filesCaolán McNamara
Change-Id: I351b67616b240e3c0c91ea31d8f14ecfa6de8b4a Reviewed-on: https://gerrit.libreoffice.org/36991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-26ParaPortionList::SafeGetObject: SAL_WARN_IF nPos out of boundsEike Rathke
Change-Id: Id21e86a0db5be9f12c377d5bb48265dd2e12b9bb
2017-04-26tdf#107427 sw: fix crash when deleting header with selected tableMichael Stahl
Restore resetting of the table cursor point position in SwCursorShell::ParkCursor(), which somehow prevents the crash. (regression from efc5995170f2ffe98374acb16a4f851bede6842d) Change-Id: Ia7ec2967c84cfcffe1718e9604d6b8506c3839a4
2017-04-26check for nullptr, tdf#104265Eike Rathke
Crash not reproduced, but a nullptr is believed to be the cause as ParaPortionList::SafeGetObject() may return nullptr if a stray EditPaM was passed to ImpEditEngine::GetI18NScriptType() At least this matches http://cgit.freedesktop.org/libreoffice/core/tree/editeng/source/editeng/impedit2.cxx?h=libreoffice-5-2-4#n1756 given in http://crashreport.libreoffice.org/stats/crash_details/725e8295-6dc0-4b0c-aff3-57c6c95930f2 and http://crashreport.libreoffice.org/stats/crash_details/e2570ac8-6137-4b67-91b2-6cc871f8cb69 Change-Id: Id01983a31145442016da527a57024dc060060b1a
2017-04-26sw: fix loplugin:override warningMiklos Vajna
Change-Id: I3c8847400adbfb9a843b1a47ec86c28c54c41b95
2017-04-26Change "check amout" -> "checksum"Olivier Hallot
Unit #126486444 Change-Id: Id40b26a022b21f379677de41b55603fff7cd862a Reviewed-on: https://gerrit.libreoffice.org/36823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-04-26CppunitTest_vcl_errorhandler: fix loplugin:simplifybool warningsMiklos Vajna
Change-Id: If2af785961b06efa56c2a55bef6b3b364bf91d57
2017-04-26loplugin:unusedmethodsNoel Grandin
Change-Id: If2e1241bbe8a3d17859e3ca076b0f55f25c48ea5 Reviewed-on: https://gerrit.libreoffice.org/36983 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-26last private:resource ... bitmap user is goneCaolán McNamara
so drop private:resource ... bitmap example and remove bitmap case, bitmapex case persists Change-Id: Iabf7c48517c17e3117f88daa80a258b7303b85dd
2017-04-26remove sfx2 bitmaps from .src filesCaolán McNamara
Change-Id: Ibc4261af5f479badd281211e467d2c7b524af3f3
2017-04-26tdf#107427 sw: fix crash with stale entries in SwNavigationMgrMichael Stahl
When deleting a header, the sw::UnoCursorPointer of SwNavigationMgr spontaneously self-destructs, but SwNavigationMgr expects its cursors to always be alive, so add another SfxListener to remove dying cursors. (probably regression from a2c467a58ade9f55e0154b2935c747bb283ebd45) Change-Id: I1055ea3cfc47114dc36002198f1ddffea87d2d85
2017-04-26clang-tidy readability-simplify-boolean-expr in svxNoel Grandin
Change-Id: I5190e453edd9fc2eda57f730834567e8e214ff16 Reviewed-on: https://gerrit.libreoffice.org/36931 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-26Updated coreAdolfo Jayme Barrientos
Project: help f986a76171ac9fcd45f5996dc9fc3ac31f46dd31 tdf#107193 tdf#107436 Increase body size to 11 pt Change-Id: I2504884668815682a6f3487c49ed994d5cbff253
2017-04-26Translate German comments (leftovers in include/svx/)Johnny_M
Change-Id: I1f4238525962d57956fd08c93e7c4d3bc52e4dc5 Reviewed-on: https://gerrit.libreoffice.org/36808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-26tdf#84323: Make osl::Condition::wait more readabledilekuzulmez
Change-Id: I9fabc88aac40f4c14bc6fe5b26d4a49de33aef75 Reviewed-on: https://gerrit.libreoffice.org/36576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-26remove sfx2 bitmaps from .src filesCaolán McNamara
Change-Id: I54448567db051f4446c36b16acdda2288b391537
2017-04-26remove svtools bitmaps from .src filesCaolán McNamara
Change-Id: I13280315c2af2277d5c8d31c079075337b2c8f82
2017-04-26tdf#84323: Make osl::Condition::wait more readabledilekuzulmez
Change-Id: Icb7d1fc92296dddb2a5f3c1517af0ce237e0f8a0 Reviewed-on: https://gerrit.libreoffice.org/36567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-26Revert the wrong "cleanup" change.Kohei Yoshida
Introduced by 63df0796f5ec500f3b6fb34510d4bc79c009e76d. Change-Id: I2481bcef144bd30571e69130d22f6d313dbddfea Reviewed-on: https://gerrit.libreoffice.org/36968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-26remove xmlsecurity bitmaps from .src filesCaolán McNamara
Change-Id: I4a1e272f26711e2c3a3860f3b2553467b979405c
2017-04-26loplugin:staticmethodsStephan Bergmann
Change-Id: Ib8a5e36dda6e953529d27233a65469e46f035292
2017-04-26Fix MSVC buildStephan Bergmann
Change-Id: I6c13e9699a7ebc7cd3855242bd2bbab5f08b382b
2017-04-26tdf#39674: Rename Fehler to ErrorJens Carl
Change-Id: Ib8288db4ddde159f274a0ca251230c7d721e0079 Reviewed-on: https://gerrit.libreoffice.org/36972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-04-26remove reportdesign bitmaps from .src filesCaolán McNamara
Change-Id: I9dfea090c130962591762cba88fcd69bbacf05fe
2017-04-26remove framework bitmaps from .src filesCaolán McNamara
Change-Id: Iea85517a60874d49cdf60860071f0924b96cbf62 Reviewed-on: https://gerrit.libreoffice.org/36966 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-26remove fpicker bitmaps from .src filesCaolán McNamara
Change-Id: Ice75bf15e509869bb7e8344381595838918acd81 Reviewed-on: https://gerrit.libreoffice.org/36965 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-26remove formula bitmaps from .src filesCaolán McNamara
Change-Id: If1f43c9ff969c12b87999424b6e4be8390307c8f Reviewed-on: https://gerrit.libreoffice.org/36964 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-26remove filter bitmaps from .src filesCaolán McNamara
Change-Id: I3e1ee8ab50426cdeaf455e59179fb6d34c97d4a3 Reviewed-on: https://gerrit.libreoffice.org/36963 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-26remove extensions bitmaps from .src filesCaolán McNamara
resulting in the removal of a updchk .res file Change-Id: I7a6f3601f25763253ba34590a1970ca8a042db23
2017-04-26Resolves: tdf#107372 set opengl context when using opengl functionsCaolán McNamara
even if they are teardown ones Change-Id: Ie222d3ffb2b555c0013d7346552d3fc76ec87d9b Reviewed-on: https://gerrit.libreoffice.org/36948 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-26remove this whole "kill SwFlyDrawContact with last frame" nonsenseBjoern Michaelsen
- first of all, SwFlyDrawContact is part of the document state/model, not the layout. - SwWW8ImplReader::CreateContactObject() and SwXFrame::GetOrCreateSdrObject() seem to agree as they create SwFlyDrawContacts without caring for frames using them being around. This was inherently fragile as FinitDrawObj would mercilessly kill the SwFlyDrawContact in that case (and thus also modify document state). - SwFlyDrawContact is now entirely owned by SwFlyFrameFormat. Change-Id: I70b716fef63279552b39a18ac143024a460ba785 Reviewed-on: https://gerrit.libreoffice.org/36899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-04-26vcl: add ErrorHandler unit testsChris Sherlock
Change-Id: I62f7d948522676ae2bed1a425c2f038929fb00b8 Reviewed-on: https://gerrit.libreoffice.org/36848 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26extend unit test for INetMIME::scanContentTypeJochen Nitschke
This reverts parts of commit 631b67952909a73ba1851417bd2edbe02ad7be5a and commit abc6071b7a8af354a56c91e4caecd8afc79f55cc. some of the removed fields are usefull, m_bConverted should be checked by callers fixed 2 bugs and added test cases: * extended attributes with more than 2 sections were not parsed * extended attributes with more than 1 section were not parsed if there was an other attribute Change-Id: I61ab2af7c5151ef1bcd80cc159fa2b99559374a8 Reviewed-on: https://gerrit.libreoffice.org/36913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-26remove dead "chained editeng recursive overflow" codeNoel Grandin
been this way since original commit in commit 5b04c453cc03c0d2c6067625242f07deb8f78ba0 Author: matteocam <matteo.campanelli@gmail.com> Date: Mon Sep 7 12:44:37 2015 +0200 chained editeng: Change EndTextEdit behavior to support recursive overflow Change-Id: Id71db878b80457683f49349170e85bbabbd753f6 Reviewed-on: https://gerrit.libreoffice.org/36940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-15 01:53:30 +0000