summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-15Simplify containers iterations in unotools, unoxml, uui, vbahelperArkadiy Illarionov
Use range-based loop or replace with STL functions. Change-Id: I5a43f6fc62c81453dcef3820bb715f4da76915af Reviewed-on: https://gerrit.libreoffice.org/61762 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15add SvStream::TellEndNoel Grandin
and simplify callsites to use it instead of the current "seek to end, find pos, seek back to original pos" pattern Change-Id: Ib5828868f73c341891efc759af8bd4695ae2f33c Reviewed-on: https://gerrit.libreoffice.org/61738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15loplugin:constfields in ooxNoel Grandin
Change-Id: I1e110d193ebfa30ab1ab0d85bfb6dc409e341439 Reviewed-on: https://gerrit.libreoffice.org/61728 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15loplugin:constfields in scNoel Grandin
Change-Id: If326175d571d15752efd1b63df45b2bc785f7541 Reviewed-on: https://gerrit.libreoffice.org/61653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15use range based loops over B2DPolyPolygon in svxJochen Nitschke
avoid copy when adapting polygon in SdrPathObj::ImpForceKind() Change-Id: Ifd830ecd181563102ee269c6a609ef8ebeab670c Reviewed-on: https://gerrit.libreoffice.org/61767 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15tdf#120593: properly handle tab pos identical to right indentMike Kaganski
... otherwise it's counted without taking into account current column, as well as TabsRelativeToIndent mode. Change-Id: I7442f63d9d5c51c5a4d82094b49b8028f2b42b41 Reviewed-on: https://gerrit.libreoffice.org/61768 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-15Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - One of the first things LibreOffice did was remove registration Change-Id: I9463222744eee12c24157fc33c133f15be898f6a
2018-10-15The code doesn’t check for glyphs, but for code points (i.e., characters)Adolfo Jayme Barrientos
This string was a little misleading. A typical pair of OS-provided fonts can encode glyphs at different code points (e.g., the f+i ligature is encoded at U+F001 (legacy position) in Arial Black but at U+FB01 in Comic Sans MS. Change-Id: I6ca93e9ad247f62e1674a03d6ab1bc0800df3612 Reviewed-on: https://gerrit.libreoffice.org/60419 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-14MoreButton is solely used by toolkitCaolán McNamara
Change-Id: Ieb436b49be3598e316d59a6d89cb211879d061c1 Reviewed-on: https://gerrit.libreoffice.org/61766 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14only vcl and toolkit need to use [G|S]etUnoWrapperCaolán McNamara
Change-Id: I47cdb47cceda32f0871fd2f713ea565852383ca7 Reviewed-on: https://gerrit.libreoffice.org/61765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14unowrap.hxx is also exposed for toolkit onlyCaolán McNamara
Change-Id: Ife3648c8ca84c942f02fb6eab2990ec3eb3eb3f9 Reviewed-on: https://gerrit.libreoffice.org/61764 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14split out vcl stuff used solely by toolkit moduleCaolán McNamara
Change-Id: Idb1dfcdaaefefa9a8d97ecdd22e39377cb31bc62 Reviewed-on: https://gerrit.libreoffice.org/61763 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14Revert removal of mysql jdbc connectorTamas Bunth
And also make some minor fixes so it cooperates with the new mysqlc library. Change-Id: I866add99a699150c6550ee7f7ff2ee947e07117c Reviewed-on: https://gerrit.libreoffice.org/61648 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-10-14drop unnecessary vcl/group.hxx includesCaolán McNamara
Change-Id: I09d86ee7e156ac71d7c1f9fd58d43751037d2629 Reviewed-on: https://gerrit.libreoffice.org/61761 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14weld SwFrameAddPageCaolán McNamara
Change-Id: Ia63e22d01c6bcc08f50d3e1b12943094660c7fd0 Reviewed-on: https://gerrit.libreoffice.org/61758 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14Simplify containers iterations in vclArkadiy Illarionov
Use range-based loop or replace with STL functions. Change-Id: Ide2f89194238ae6a1f21e8132e2297710d9e6dcd Reviewed-on: https://gerrit.libreoffice.org/61756 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-14Remove useless constructor and destructorArnaud Versini
Change-Id: I3130ffb7e3ec1c39965ddbc921e5b3ef8303fa31 Reviewed-on: https://gerrit.libreoffice.org/61755 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-14rename SchTextDirectionListBox back to TextDirectionListBoxCaolán McNamara
Change-Id: Ic2369630e66fa26e189fbbc374c5a60ce7fb8173 Reviewed-on: https://gerrit.libreoffice.org/61754 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14TextDirectionListBox is gone nowCaolán McNamara
Change-Id: If71c156164b51362754b6996f46917e30aee5b87 Reviewed-on: https://gerrit.libreoffice.org/61753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14weld SchLegendPosTabPageCaolán McNamara
Change-Id: Iee0b2a028119d3d65eb613ce65f05c9ab3f778fc Reviewed-on: https://gerrit.libreoffice.org/61752 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14drop now unused orienthelperCaolán McNamara
Change-Id: I6a33104002ecb304a65e930320595a082049faa9 Reviewed-on: https://gerrit.libreoffice.org/61750 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14svxlo-DialControl gone from .uis nowCaolán McNamara
Change-Id: I70c83a0c87b49048d0bb7c85a287f23d2c45b868 Reviewed-on: https://gerrit.libreoffice.org/61749 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14weld PolarOptionsTabPageCaolán McNamara
Change-Id: I7e0c9bcd940a5f1816e3e18077be4373644ce760 Reviewed-on: https://gerrit.libreoffice.org/61748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14weld SchAxisLabelTabPageCaolán McNamara
Change-Id: I499162c6c2327a6c0d635382defea7e0bae068cd Reviewed-on: https://gerrit.libreoffice.org/61747 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14loplugin:redundantinlineNoel Grandin
Change-Id: I67ee39655193517a7d79eeb7d686cbd564fff7a1
2018-10-14Add some additional verification for LXQt as the desktop environment.Simon Quigley
ac9c14dbbd3a4341de0aa1b1dbc37ad2ce69398c added initial support for LXQt as a desktop environment under Linux, but this only works where a pure LXQt session is started and not when an LXQt distributor's session has been started. In upstream LXQt, $XDG_CURRENT_DESKTOP is always set to LXQt, so check that first. Change-Id: Ifaa1f85192dc7a943911846e1cb39cf49be03baf Reviewed-on: https://gerrit.libreoffice.org/61751 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-13weld SchAlignmentTabPageCaolán McNamara
Change-Id: I9b67720b087d2d89dd1a64933b0e073132e601b7 Reviewed-on: https://gerrit.libreoffice.org/61745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-13remove unneeded variableJochen Nitschke
Change-Id: I5e988effa02891661fb92074db605744fb407261 Reviewed-on: https://gerrit.libreoffice.org/61746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-13weld SwGrfExtPageCaolán McNamara
Change-Id: Iffcefbcef92d278803112635b0d3e98606c820b9 Reviewed-on: https://gerrit.libreoffice.org/61744 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-13move fallback image out of .uiCaolán McNamara
Change-Id: Id46f1c2a06e6c32b60e6308a01dc4ee5e75e20ba Reviewed-on: https://gerrit.libreoffice.org/61743 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-13find-unneeded-includes: do not propose css/uno .hxx to .h replacementsGabor Kelemen
Better to not replace stable API headers with implementation details Change-Id: I66c7a237b1df13b7aa2523eba87d45d123621a95 Reviewed-on: https://gerrit.libreoffice.org/61742 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-13Fix 00e10ae3189a4407ffb1a48f836cd52dc9a1b6dfJulien Nabet
Sorry my fault since my review was wrong Change-Id: I8bac7232434b0b4ea808176df9cde33f06bfbc6e Reviewed-on: https://gerrit.libreoffice.org/61741 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-13use range based loops over B2DPolyPolygon in vclJochen Nitschke
Change-Id: I98f17311822ba50b0c8eaa50fbdef088c76168d4 Reviewed-on: https://gerrit.libreoffice.org/61730 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-13Fix a weird checkbox label in Calc’s recalculation promptAdolfo Jayme Barrientos
GTK+’s dumb defaults strike again! Similar to 7da61ec6d8ab6312b45ef7d683f3ec24e6b2b570. Found while triaging tdf#120513. Change-Id: I9ade695184cbcc9f1de9f11b20aa751754263586
2018-10-13loplugin:constfields in package..registryNoel Grandin
Change-Id: Ie139490f2b008bf294910d002af711f8f41fe76d Reviewed-on: https://gerrit.libreoffice.org/61727 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-13KJ: Change close doc icon, change some graphic iconsRizal Muttaqin
Change-Id: Ie6545844546dc78d14e1fabdf28f4e1938cf2dd6 Reviewed-on: https://gerrit.libreoffice.org/61420 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-13weld DataLabelsDialog and DataLabelsTabPageCaolán McNamara
Change-Id: I509d58b2677b5e8f0db476e2650661cb128a5279 Reviewed-on: https://gerrit.libreoffice.org/61723 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-13Ditch now unused class UserInformation and userinformation.?xxEike Rathke
... one class with one member variable holding one string for one instantiation ... Change-Id: I033312ed1c05c181e7077b4b1a0d988cfb80eb33 Reviewed-on: https://gerrit.libreoffice.org/61734 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-13Extract the one getUserLanguage() call from UserInformationEike Rathke
After which we can ditch that. Change-Id: I6027327b41d98bffd47324b4c6145c1eddca632a Reviewed-on: https://gerrit.libreoffice.org/61733 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-12SvNumberFormatsSupplierServiceObject: default to LANGUAGE_SYSTEMEike Rathke
... instead of LANGUAGE_ENGLISH_US that will be ultimate fall-back anyway if no match is found. Change-Id: Ice6495e54fa0a1e275769fcfdf1e0e932e22944e Reviewed-on: https://gerrit.libreoffice.org/61729 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-10-12Resolves: tdf#119739 switch date field input to NF_EVALDATEFORMAT_FORMAT_INTLEike Rathke
To evaluate date input against date acceptance patterns in the order first format locale, if any, then formatter (system) locale. The slight drawback is when the field has no content there is no indication of that the format's locale's patterns would be preferred, whereas the old NF_EVALDATEFORMAT_INTL_FORMAT preferred the default locale's patterns. The big advantage is that editing a date actually uses the patterns associated with the presented display string. Change-Id: Id3f11e26a0e32b95f26b69a681433deb87b7c6b0 Reviewed-on: https://gerrit.libreoffice.org/61726 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-12tdf#119992 sw: compare sub-strings in SwTextGlyphsKey comparisonMiklos Vajna
Time till the layout reaches idle, before: 77.412 seconds After: 26.221 seconds (33% of baseline) for me. Change-Id: Idd0c5255070c836fde2fb048b02c851f5f2321e4 Reviewed-on: https://gerrit.libreoffice.org/61724 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-12tdf#119739 split ConfigManager::getLocale(), getUILocale(), getWorkLocale()Eike Rathke
To prevent further confusion which is which, dbaccess UserInformation already got that wrong since ever. /org.openoffice.Setup/L10N/ooLocale is the UI locale. /org.openoffice.Setup/L10N/ooSetupSystemLocale is the work locale. Confusingly due to legacy when the setup program was a separate binary that picked the UI ooLocale and later set up the default (system) work locale as well. Change-Id: I9a05ad39f5fb65c54076ff5789ba7a2cc06ad23a Reviewed-on: https://gerrit.libreoffice.org/61725 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-12tdf#118572 dispose instead of LazyDeletorCaolán McNamara
Change-Id: Ib52a1d6ffee0354cc7749f2535a05821d73149c5 Reviewed-on: https://gerrit.libreoffice.org/61716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12coverity#1440239 Uncaught exceptionCaolán McNamara
Change-Id: I2b744d70ab426fbf26bcb3762aafaa569d0aafc7 Reviewed-on: https://gerrit.libreoffice.org/61675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12HTML and image copy into qt5 clipboardKatarina Behrens
Change-Id: I1c26db35b801694fcc3935baab842027eac1e561 Reviewed-on: https://gerrit.libreoffice.org/61611 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-12Simple translation passing by...Andrea Gelmini
Change-Id: I643e8bdf6b88d53f41008e41ac04fbf49696c3a2 Reviewed-on: https://gerrit.libreoffice.org/61707 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-12Fix typoAndrea Gelmini
Change-Id: I89ce64cfb8ea6777ac70583942d76dbc59eaf65b Reviewed-on: https://gerrit.libreoffice.org/61717 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-12Fix typosAndrea Gelmini
Change-Id: I678b545f2a266365fb700b3f75b3d939d28348d6 Reviewed-on: https://gerrit.libreoffice.org/61603 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-12clarify when XInitThreads is calledCaolán McNamara
and make the minor version checks more sensible Change-Id: Ieee6750e4e8dd79213a0befb040ce7b8a815e357 Reviewed-on: https://gerrit.libreoffice.org/61713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>