summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-16clang-tidy readability-simplify-subscript-exprNoel Grandin
error: accessing an element of the container does not require a call to 'data()'; did you mean to use 'operator[]'? Change-Id: I022745aa84b80124f342ce6c596d51b4d904f012 Reviewed-on: https://gerrit.libreoffice.org/61820 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16pep8 -> pycodestyleMiklos Vajna
To silence this warning: /usr/lib/python3.6/site-packages/pycodestyle.py:2190: UserWarning: [pep8] section is deprecated. Use [pycodestyle]. warnings.warn('[pep8] section is deprecated. Use [pycodestyle].') Change-Id: I0a2f9b266562a797d1625b3c50261e7e43315fb7 Reviewed-on: https://gerrit.libreoffice.org/61827 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-16Notebookbar: update tabbed toolbar for calcandreas kainz
remove separator in other tabbedbars Change-Id: I99c83cd09e5fa8bde2809680d5ef138c4ef499de Reviewed-on: https://gerrit.libreoffice.org/61803 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-16tdf#120610 add title to DDE Link dialogCaolán McNamara
Change-Id: I33ee263f8321f66fc7c26854e02cb031ffbff956 Reviewed-on: https://gerrit.libreoffice.org/61823 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#120612 (related) update DDE link Help page Change-Id: Ib4d29a35a87954fe2985d8445eb8b1aaede780c7 Reviewed-on: https://gerrit.libreoffice.org/61829 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-10-16Unit test deleting shared formula group top cell, tdf#119623Eike Rathke
Change-Id: I9a497b9d9ae09c8764f62549a60c8a2a952bc9e9 Reviewed-on: https://gerrit.libreoffice.org/61822 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-16Resolves: tdf#120612 help response missingCaolán McNamara
Change-Id: I096bdcc93899dfd41d88cb9d00d54c51cebeca92 Reviewed-on: https://gerrit.libreoffice.org/61824 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16loplugin:singlevalfields in vclNoel Grandin
Change-Id: I159f94fba64acc0e0599b64be02c7864b1ed02c3 Reviewed-on: https://gerrit.libreoffice.org/61813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16loplugin:singlevalfields in lotuswordproNoel Grandin
Change-Id: Iac507cb050c93367a8d5dd4cc33106f54c5d462f Reviewed-on: https://gerrit.libreoffice.org/61816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16ofz#10994 move the reset of trailing fly paras to before redline processingCaolán McNamara
Change-Id: I906c29848acc3917f76cb8c21e0bd581e0ded421 Reviewed-on: https://gerrit.libreoffice.org/61819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16sw: merge test suites sw_unoapi and sw_unowriterVasily Melenchuk
Both test suites have the same propose "Test to assert UNO API call results of Writer" so better to keep them together. Change-Id: I0ef7c28856a374dca3edcec73fd98a96c5067527 Reviewed-on: https://gerrit.libreoffice.org/61794 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16tdf#120626 'rewind' doesn't stick when effect duration is changedCaolán McNamara
Change-Id: I1c65168b68bba2928030f89836d2b127655d6066 Reviewed-on: https://gerrit.libreoffice.org/61814 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16Resolves: tdf#119623 record group positions also for top cellsEike Rathke
So listeners can be re-established for remaining grouped cells if top cell is deleted (which ends listening and probably was the cause to exclude them here). Change-Id: Ic91b74c65013452d56b5cfbc132722c4314743c8 Reviewed-on: https://gerrit.libreoffice.org/61808 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-16tdf#113241 better default for number recognition options in Writer tablesCor Nouws
Change-Id: Ibcaa185dc16953302ed04fab65153e4275709ad9 Reviewed-on: https://gerrit.libreoffice.org/61065 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-16loplugin:singlevalfields in sfx2Noel Grandin
pParent in SfxDispatch_Impl was always nullptr, which led to a bunch of dead code similarly with pParent in SfxWorkWindow Change-Id: I964a43fe094409ab4b6d1eda7225af997092e81c Reviewed-on: https://gerrit.libreoffice.org/61811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16tdf#120626 unable to set direction in custom animation dialogCaolán McNamara
Change-Id: I8487381af648e562e2c11adda2e2c48557b12b41 Reviewed-on: https://gerrit.libreoffice.org/61806 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16drop LazyDeletorCaolán McNamara
Change-Id: I7d2e00466f321994a46b0529d645e342f229c929 Reviewed-on: https://gerrit.libreoffice.org/61718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16tdf#42949 Fix IWYU warnings in sc/source/ui/inc/[a-e]*Gabor Kelemen
Also files starting with capital letters. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia79de45524315e2aaa1283ee6e42c54c9e14a31e Reviewed-on: https://gerrit.libreoffice.org/61735 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-16tdf#112520 RTF export: write ZOrder only for toplevel shapesMiklos Vajna
RTF export at the moment exports children of group shapes as a flat shape list. This means that the order inside the group shape is not relevant for the toplevel ZOrder, so just don't write it. Change-Id: I870707cb28c2f177c0e5d9cf5328260e76b661f3 Reviewed-on: https://gerrit.libreoffice.org/61805 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-15Introduce and use ScConditionalFormatList::empty() instead of size()Eike Rathke
Change-Id: If42fdfbcac74ef2a04bd5d006272a5c1a4f510e2 Reviewed-on: https://gerrit.libreoffice.org/61804 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-15tdf#118049 tdf#118833 tdf#118725: Fix some SwDepend regressionsBjoern Michaelsen
(partial revert/fix of 83243003b46dfb258c2b41049b0e1cb82a2d7ddb) Change-Id: I96213a41b026ee6496516ad1d0a416c5708a2300 Reviewed-on: https://gerrit.libreoffice.org/61769 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-10-15weld RangeChooserTabPageCaolán McNamara
Change-Id: I3006d215cc734d28b208c0c4e8b9c719b70d4954 Reviewed-on: https://gerrit.libreoffice.org/61799 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15weld TitlesAndObjectsTabPageCaolán McNamara
Change-Id: I071ddf117e44fab3b5f712198973c86a0fd8d206 Reviewed-on: https://gerrit.libreoffice.org/61798 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15weld ChartTypeDialog and SchLayoutTabPageCaolán McNamara
Change-Id: I101c56b855d0bdc43559ca4561d298fa4ad92572 Reviewed-on: https://gerrit.libreoffice.org/61797 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15m_pLine is always unsetCaolán McNamara
Change-Id: I269081ed0abcad09b66331d7fc1589e16556bd27 Reviewed-on: https://gerrit.libreoffice.org/61801 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15Avoid useless copy of vectorsMike Kaganski
Change-Id: Iadab935efff35e1e8e5d70878414da1ed2f0fbf9 Reviewed-on: https://gerrit.libreoffice.org/61795 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-15tdf#120087 Disable unuseable items in Manage DialogAbhyudaya Sharma
Fix behaviour for 'Remove' and 'Edit' buttons for the Manage Conditional Formatting dialog in Calc Change-Id: Id8fc37262464232ab8fbb76c5a9609af5982e222 Reviewed-on: https://gerrit.libreoffice.org/61475 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-10-15Fix typosAndrea Gelmini
Change-Id: Iffa6d87339f7ba338e74b2b9d061dd2815b19408 Reviewed-on: https://gerrit.libreoffice.org/61790 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-15loplugin:staticconstfield improvementsNoel Grandin
And fix ScXMLCachedRowAttrAccess::Cache which was never setting its mnTab field, and hence would never be hit. And fix oox::xls::CellBlockBuffer, which was never setting mnCurrRow. Change-Id: I2c46aa050b9ebe3c2dc2e52579555f97945dd61c Reviewed-on: https://gerrit.libreoffice.org/61772 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15restore RemoveItem mnHighItemId handlingCaolán McNamara
Change-Id: I9aa094d50f7bc52fd379fa2e315037b81bb53df2 Reviewed-on: https://gerrit.libreoffice.org/61796 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15Update git submodulesIlhan Yesil
* Update helpcontent2 from branch 'master' - In the "Edit Links" dialog, help topic "Source file" is extended to inform the user, how a relative path can be defined. Change-Id: I7ab9633f2f9894d27d819bfd8d57b4fb797e2b5e Reviewed-on: https://gerrit.libreoffice.org/61647 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-10-15weld InsertErrorBarsDialog and ErrorBarsTabPageCaolán McNamara
Change-Id: I3fb2fb4d8010e43e59b4de5c488f137960bc6417 Reviewed-on: https://gerrit.libreoffice.org/61760 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15Notebookbar: sync draw and impress context tabsandreas kainz
Change-Id: Ic1d87412821c6ce2103664eab56883e5e4033818 Reviewed-on: https://gerrit.libreoffice.org/61771 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-15Notebookbar: update writer context tabsandreas kainz
Change-Id: I0806c86b8dc98aac6211cac09a7f4c25eb716007 Reviewed-on: https://gerrit.libreoffice.org/61770 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-15Update git submodulesEike Rathke
* Update helpcontent2 from branch 'master' - Related: tdf#102257 adjust Help, RANDBETWEEN() volatile like RAND() Change-Id: Id200bd4886ccc6e5f932d2872d5969f0196b7332
2018-10-15Resolves: tdf#102257 RANDBETWEEN() volatile like RAND(), ScRecalcMode::ALWAYSEike Rathke
Change-Id: I01698e6b9981d7dd15bf42fcb69a7bd4778d1798 Reviewed-on: https://gerrit.libreoffice.org/61792 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-15Conditional formatting: Use the nElements from g_IconSetMap.Jan Holesovsky
And also kill some copy'n'paste when at that. Change-Id: Ice38b738f31e486008fdae450c9534306f3a9613 Reviewed-on: https://gerrit.libreoffice.org/61705 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-10-15Relicense LoopVarTooSmall plugin to use LLVM licenseTamás Zolnai
Change-Id: I9e8cf6d7c2474f8c4c624dd9040890997c43f788 Reviewed-on: https://gerrit.libreoffice.org/61789 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-10-15Add the already referenced LICENSE.TXT with the LLVM licenseTamás Zolnai
From: https://opensource.org/licenses/UoI-NCSA.php Change-Id: I81dc98ec532e3cd6787abc491d81346fae87c087 Reviewed-on: https://gerrit.libreoffice.org/61793 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-10-15clang-tidy bugprone-copy-constructor-initNoel Grandin
message is "calling a base constructor other than the copy constructor" these constructors are not in use, so just remove them Change-Id: Ic8cede1eb153a6ae97fd1ca9c96ca8c1f43e3399 Reviewed-on: https://gerrit.libreoffice.org/61784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15sc: Let SKEW/SKEWP raise #!DIV/0 when < 3 numbers are givenTakeshi Abe
as ODF 1.2 mentions such constaints of these functions, and Excel's documentation also admits it with more specific remark: <https://support.office.com/en-us/article/skew-function-bdf49d86-b1ef-4804-a046-28eaea69c9fa> <https://support.office.com/en-us/article/skew-p-function-76530a5c-99b9-48a1-8392-26632d542fcb> Change-Id: If19350997ddcb6f0fb36e29e090e260c3ae3d262 Reviewed-on: https://gerrit.libreoffice.org/61130 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-15sc: Make KURT() return #DIV/0! when <4 arguments are givenTakeshi Abe
as Excel does: <https://support.office.com/en-us/article/kurt-function-bc3a265c-5da4-4dcb-b7fd-c237789095ab> Change-Id: I1059e6e5dd9f01688219492e76af6dbbe97be41a Reviewed-on: https://gerrit.libreoffice.org/61286 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-15drop some unnecessary headersCaolán McNamara
Change-Id: I203824738f3e3eb5ff21b9099c731e7026e644f6 Reviewed-on: https://gerrit.libreoffice.org/61785 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15Redundant variableMike Kaganski
Change-Id: I0ceeea25b35b144e2cb4567939a7e9b01a723320 Reviewed-on: https://gerrit.libreoffice.org/61569 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-15loplugin:constantparamNoel Grandin
Change-Id: I895ceffa468d84d22e4a81b7a6b06eaed0bd839d Reviewed-on: https://gerrit.libreoffice.org/61776 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15clang-tidy misc-redundant-expressionNoel Grandin
Change-Id: I708b0b486a233071f95592ccdb97f27fc35a23c4 Reviewed-on: https://gerrit.libreoffice.org/61783 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15loplugin:unusedfieldsNoel Grandin
Change-Id: I4ebd1e89daf7ba5e6ab709f56c0fec5b49f50dd0 Reviewed-on: https://gerrit.libreoffice.org/61774 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15loplugin:unusedmethodsNoel Grandin
Change-Id: I0226d33cbe224519cf2ed9ea5143ffe68fdbc884 Reviewed-on: https://gerrit.libreoffice.org/61775 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15tdf#120429 - Functions Insert Columns Exist Two Timesheiko tietze
Legacy UNO commands InsertRows and InsertCols hidden from customization Commands are still accessible via macro Also fixed terminology in Draw/Impress for Insert Columns from Left/Right to Before/After Change-Id: I29a6b2fdb7481db43ad1a8ad25be5e9107558bd6 Reviewed-on: https://gerrit.libreoffice.org/61579 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-15sw: prefix members of SwTableRepMiklos Vajna
Change-Id: Ib5c35ba6e53f70df8fe6dbcaf189590c754bb3cb Reviewed-on: https://gerrit.libreoffice.org/61773 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-31 05:56:30 +0000