summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-01-28coverity#440504 Dereference before null checkCaolán McNamara
Change-Id: Ia7c817ca0b002279bee8699e4940c57937657ad4
2014-01-28coverity#440338 Dereference null return valueCaolán McNamara
Change-Id: I5da7c1d8fe7f4632b386a02dd54f4b203a00fc25
2014-01-28coverity#440064 Logically dead codeCaolán McNamara
Change-Id: I52c9e37ca4d3238b9018264b6542a9dcebca13f6
2014-01-28coverity#1130485 Uninitialized scalar fieldCaolán McNamara
Change-Id: I18e90afe2c2425a0b6b65fdf46497aac8c755fcf
2014-01-28coverity#1132708 Unintended sign extensionCaolán McNamara
Change-Id: Iaf73bf619c6dfa8c29b02c35410aadf972a71448
2014-01-28coverity#704212 Logically dead codeCaolán McNamara
Change-Id: I1f915b4419ae754a3827c2c662e5799bade66835
2014-01-28coverity#440938 Logically dead codeCaolán McNamara
Change-Id: I33f895ab913eee0dd6a5df05cd2f4cffb88cc1ef
2014-01-28coverity#440882 Logically dead codeCaolán McNamara
Change-Id: Ia54cffe6368d320c717b941b4f3df036f924c343
2014-01-28coverity#440030 Logically dead codeCaolán McNamara
Change-Id: I77428c6cf1f79dcc0e2c5e1d52f9b4b8c88130e3
2014-01-28coverity#440029 Logically dead codeCaolán McNamara
Change-Id: Id071c8658b473b9d393a32e1da2c2474bb7361d3
2014-01-28coverity#440026 Logically dead codeCaolán McNamara
Change-Id: Ib269314be090d2d65b593b1c47fea1e10ef2582b
2014-01-28coverity#738565 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ie969773240bd7ecdcf56d7c533010d0aa32872c8
2014-01-28coverity#983594 Uncaught exceptionCaolán McNamara
Change-Id: Ic49f88b44216a24df8a236b755d22b2537245c5f
2014-01-28coverity#706219 Uncaught exceptionCaolán McNamara
Change-Id: I1c2566337347679453bee46a78a4a0ecd7fdd2fb
2014-01-28Document Application classChris Sherlock
Documented more of the VCL Application class's public functions via Doxygen markup. Also, change from global groups to member groups. Change-Id: I5e80e707874db99c60e899d078f41c7817e2b6c3 Reviewed-on: https://gerrit.libreoffice.org/7664 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-28ooxml: Preserve shape style and theme attributes for lineJacobo Aragunde Pérez
Line style and color can be defined by the shape style attributes or can be directly assigned by the user (and even using a theme color in the case of color attribute). This patch aims to preserve the relevant attributes of this feature after a roundtrip. For style attributes (wps:style/a:lnRef), they are kept and preserved in the "StyleLnRef" property of the shape InteropGrabBag. To be able to access to some of them, the methods getLineStyle, getLineJoint and getLineWidth were added to LineProperties object. For the line theme color (a:ln/a:solidFill/a:schemeClr), the original line color and the theme color name are preserved in the properties "OriginalLnSolidFillClr" and "SpPrLnSolidFillSchemeClr"of the Shape InteropGrabBag. On export time, we must check if the user has changed any properties of the shape line, this is done comparing the new shape attributes with the original values coming from the style and theme definitions. In case some of the attributes is different, the new attribute must be saved overwriting the old one. The data files for some /sd/qa/ unit tests were updated to reflect the new properties inside the Shape InteropGrabBag. Besides, an existing unit test in ooxmlexport was modified to include checks for the preservation of line style, line theme color and custom line style that override the style attributes. Change-Id: Iabb0cef9e3cc433676c201bc296fb7b373839a3f
2014-01-28ooxml: Preserve color transformations in shape style definitionsJacobo Aragunde Pérez
Color tags like <a:schemeClr> can have children tags that modify the specified color. These modifications were applied on import time in the Color object, but they were not preserved. We added a member to Color object to preserve the unaltered list of transformations. The method getTransformations() returns that member, and the methods getColorTransformationName and getColorTransformationToken were added to transform the tokens into strings that can be added to an InteropGrabBag and viceversa. The transformations are added to the Shape InteropGrabBag in the method Shape::createAndInsert, and they are written back on export time at DrawingML::WriteStyleProperties. The data files for some /sd/qa/ unit tests were updated to reflect the new properties inside the Shape InteropGrabBag. Change-Id: Ieb164268c3b79f2d9b7ed3a4954b5de3b7a5811c
2014-01-28DOCX import: handle wp14:sizeRelV and wp14:pctHeight for Writer TextFramesMiklos Vajna
Change-Id: I1744cabf426af36483280df9ca5c09e7783fe210
2014-01-28sd/qa: Remove InteropGrabBag property from XML dumpsJacobo Aragunde Pérez
The InteropGrabBag property adds a lot of noise to this tests and it doesn't actually have any purpose, because we are building their own tests for InteropGrabBag-supported document attributes. We have removed this property by default but we left a flag to enable it when it's convenient for debugging. Change-Id: I97cc7ba171783222a57ab5a96e5755070b949505
2014-01-28fdo#73545 Shape position is wrongPriyankaGaikwad
Issue: The <wp:align> is missing after roundtrip XML Difference: Original: <wp:positionH relativeFrom="page"> <wp:align> center </wp:align> </wp:positionH> Roundtrip: <wp:positionH relativeFrom="page"> <wp:posOffset> 0 </wp:posOffset> </wp:positionH> Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx Reviewed on: https://gerrit.libreoffice.org/7571 Change-Id: I3c8ef2f0ee3dd84a23fab197ab95f152b850067e
2014-01-28fdo#39468 Translate German comments (sc/source/ui/pagedlg/tptable.cxx)Sven Wehner
Also remove some ASCII art. Change-Id: I8d440a05626c4db3ff63108a7e92ba54615ea24b Reviewed-on: https://gerrit.libreoffice.org/7712 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-28Revert "Fix commit 4959f369d9bdcc"Norbert Thiebaud
This reverts commit d6d5f6803e7433c5b7bb75e982fa066be908af4a.
2014-01-28Fix commit 4959f369d9bdccChris Sherlock
Application::InitSettings should only assert when pSVData->msAppData.mpSettings is already set. There is an errant not symbol. Change-Id: Id18848774f3f3a1b37969f057eaf8685231ad291 Reviewed-on: https://gerrit.libreoffice.org/7711 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-28Deleting NULL is safeTakeshi Abe
Change-Id: I673fd307d3f5f8c5c27b5dd6968775f81c0af8a0
2014-01-27fdo#74014: Broadcast cells on undoing of "cut".Kohei Yoshida
Change-Id: I0fdf518078c86f259e72307f8011a988555a9235
2014-01-27fdo#74014: Write unit test for this first.Kohei Yoshida
Change-Id: I59fb04e2d7dc8148064564b900680e1b6e1b5e43
2014-01-27fdo#69244: Avoid putting these cells in formula tree prematurely.Kohei Yoshida
Marking the cell dirty alone appears to be sufficient to trigger resetting of number format. SetDirty() would mark it dirty *and* put the cell into formula tree, which would prevent proper value propagation as seen in the bug report. Change-Id: Ie68f996112938fe286a9bd50c38404f9df6f4ca1
2014-01-27fdo#69244: Write unit test for this.Kohei Yoshida
Change-Id: I5bfc8ad1566dbfc2813aadc8f08ba1eccca608ca
2014-01-28Converted Calc paste special dialog to .uiKatarina Behrens
Change-Id: Ibe782ed765a20adb34bb6ddd226c3d5ed328e810
2014-01-27Don't use OSL_LOG_PREFIX when throwing exceptions in non-debug builds.Jan Holesovsky
Using OSL_LOG_PREFIX in the exceptions is not a good idea; it blows the size of the string literals tremendously - full build path for every line that uses that, including the line. Let's not remove it for good, but hide it for non-debug builds (OSL_DEBUG_LEVEL == 0) so that anybody who would like to use this during debugging could still do (but I doubt it has any value for anybody). Change-Id: Icc8db95ae0862671a206e681f92c60cdf51ffc32
2014-01-27Typo decendant => descendant in winaccessibility/MAccessibleJulien Nabet
Change-Id: I2e49ab149b2bbdad623f8694221b6169cdfd2d9a
2014-01-27fdo#74119 fix unlocalized redline menuAndras Timar
Change-Id: Ia4836a69ddd8bebe8cc21cea67be96b029388cb1
2014-01-27We want to read DOCX in TiledLibreOffice.Jan Holesovsky
Change-Id: If1abbd654c407458a2a7947d6a2df07470417a38
2014-01-27fdo#74124: Scale the pictures before calling ImplDrawAlpha().Jan Holesovsky
When the source and destination bitmap do not have the same size, ImplDrawAlpha() does not use direct paint, but instead it gets the image from the screen, blends it with the provided bitmap, and again draws it. Unfortunately, the blending uses the most trivial (and ugly) way of scaling; so to produce much better results, let's scale to the destination size before even calling ImplDrawAlpha(). The sideeffect is that we use the direct paint in most cases now; so hopefully it pays off to do the (a bit more expensive) scale first. Change-Id: I3b6b275710220910709ae4345ad6be3d6e4bf79c
2014-01-27Handle note instances during copy-n-pasting of single cell.Kohei Yoshida
Change-Id: Ib258556414fd94b5156b65777478a8fd37abfd9e
2014-01-27remove script that parsed no longer available WRITERFILTERSTATUS commentsMiklos Vajna
Change-Id: I137d2a9e4c0edda3e2509696ba4b0f5f4913bbc3
2014-01-27filter: add sprmids headerMiklos Vajna
This was generated previously in writerfilter, but keeping around an XML file of 8000+ lines just to generate these constants is an overkill. Additionally, these constants are hardwired in all available WW8 files, so they won't change. By copying it here, it's possible to incrementally remove what's still remaining from writerfilter's not used doctok. Change-Id: I1d30da1f635946b15a37de68080fd9eebc2ad88e
2014-01-27writerfilter: drop unused WW8TableHandler classMiklos Vajna
Change-Id: Ib74ac172088e7ad906fb3a28652948e2476a4cb2
2014-01-27writerfilter: drop unused WW8StreamHandler classMiklos Vajna
Change-Id: I79ea120223094f52996b52020fb86ddf9a919688
2014-01-27writerfilter: unused WW8PropertiesHandler classMiklos Vajna
Change-Id: Ie6a6d47241cdf0f4986aee9b2f30ecae55e6518c
2014-01-27fdo#73464 - get relation BSTR allocation right.Michael Meeks
Change-Id: I270bc9c8e0507f44d2c27639e86002c60f4e2e6d
2014-01-27add test for structured contentDavid Tardon
Change-Id: I039e5ccfd6946f3f16505b6265e248fbead37a64
2014-01-27css::io::XInputStream _is_ allowedDavid Tardon
Change-Id: Ib72c02a329bbc9a26390a16e115fd8ae94343263
2014-01-27coverity#704393 Logically dead codeCaolán McNamara
Change-Id: Id46cdef80e3e8d4b56c22e8efc72aca885e0f406
2014-01-27coverity#1000521 Logically dead codeCaolán McNamara
Change-Id: I9cf7d002de2bf8b33f17bd24403b8e77fe471a68
2014-01-27coverity#738968 Unused pointer valueCaolán McNamara
Change-Id: I0fabc525f5c052823946da93587ff1caaada9ab1
2014-01-27coverity#735559 Logically dead codeCaolán McNamara
Change-Id: I75205d46243c18bbd63532aea1965a0e058ef739
2014-01-27coverity#708315 Uninitialized scalar fieldCaolán McNamara
Change-Id: I1a93fcb6107bdce10b1f967337e75c525ab24640
2014-01-27coverity#708316 Uninitialized scalar fieldCaolán McNamara
Change-Id: I506ee57c59255494bbde91762da43c8b04b0f086
2014-01-27coverity#440937 Logically dead codeCaolán McNamara
Change-Id: If388006a7f53aee5ffe42a152ab917ca5aca2072