summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-08-25parameter names are useless in DECL_LINK declarationsNoel Grandin
Change-Id: I77f7b528ed97964bdc153f820f6f96977ddb9254
2015-08-25misplaced braceCaolán McNamara
Change-Id: I6e43fd4a4b45f0217de8b6d93ef2403e46e39489
2015-08-25vcl: disable randomly failing timer unit testsThorsten Behrens
Change-Id: Iab26a2b55586fc824c5edbea519c4f68ba4a548f
2015-08-25Turn on glyph caching by default when using OpenGLTor Lillqvist
Can now be turned off with a SAL_DISABLE_GLYPH_CACHING environment variable. Change-Id: I7ac14d72dc0f85c0682d92492eb96bec1d207609
2015-08-25disable test case pending index assert fixCaolán McNamara
Change-Id: Ic48e22169dff2ed06b75af519ca39addef7d07de
2015-08-25upload libmwaw 0.3.6David Tardon
Change-Id: I09249673d42d36bf72ee1ffbf8f3f37734bd8bae
2015-08-25astyleDavid Tardon
Change-Id: I597c007e4636f6b05873f24ef3e89c0a7c2c3670
2015-08-25simplify some declarationsNoel Grandin
Change-Id: I348e7f984e5e8b4b915d11de8182da07a6356f8d
2015-08-25SvResizeHelper::ValidateRect, simplify logicNoel Grandin
Change-Id: Ie1c9891e8095172f53efc027eec9a68bde39ed1f
2015-08-25remove useless commentNoel Grandin
Change-Id: Id253acad170e3d8f7a1278a10c731c6bd1927b92
2015-08-25using RECT_EMPTY here is very dodgyNoel Grandin
lets rather use something smaller, so as not too potentially bump into the RECT_EMPTY checks in the Rectange code Change-Id: Ief8200763cac29e3099a2717f20c6f10cbc7d579
2015-08-25simplify, IsEmpty() checks both Right and Bottom alreadyNoel Grandin
Change-Id: I81fa9f80593bdea5098215f71c44b35e0087a6fc
2015-08-25add some comments to Rectangle mutation methodsNoel Grandin
Change-Id: I7e1d737fc1e7a431afd3cde74c2c974e0cbef9ef
2015-08-25there may be no storage available in older formatsCaolán McNamara
Change-Id: I23cbaf7fc1320168eb75ca33fd6d704125508785
2015-08-25Nitpick: Follow our header guard naming conventionTor Lillqvist
Change-Id: I939d36dbb0a298f8181367f74001115ef89d5bc2
2015-08-25make pWindow private in SfxChildWindowNoel Grandin
Change-Id: I585d4e8f0a53f46b6fbcef9e4d26f88b57569684
2015-08-25make eChildAlignment private in SfxChildWindowNoel Grandin
Change-Id: I68a4c3324736e111a2c88e3edb9df506c33042b7
2015-08-25clean up whitespace in childwin.hxx a littleNoel Grandin
Change-Id: Iefebe6b254f2c01b46b48ebaf7a6242e1bf80b62
2015-08-25the implementation pointer of SfxChildWindow can be privateNoel Grandin
Change-Id: I79366fe5abc98924e174dcbac83bbb8c053d59ce
2015-08-25sc: fix number format button highlighting in sidebarTomaž Vajngerl
When a number format for a cell (for example percent) is applied it is highlighted in the toolbar but not the equal button in the sidebar. This patch fixes this issue. Change-Id: I7f33ab1e989f8a8e3c49468aae2042621d088798
2015-08-24slideshow: replace for_each with range-based loopDaniel Robertson
Replace ::std::for_each for a more readable range-based for loop in cases in which the function object to be applied by for_each is more readable as the body of a for loop. Change-Id: Ib0b488b36ed58c65c56357e04391b85096d043aa Reviewed-on: https://gerrit.libreoffice.org/17930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-24in reality we are limited to max sal_Int32 hereCaolán McNamara
so accept that and test if the values were accepted or limited Change-Id: Iaed5ebc2f12b52055506147c71117a2ad88d28ac
2015-08-24consider validity of m_nDrawCpOCaolán McNamara
Change-Id: Ifbd131440bad6d840d369c99628cb8904697ad96
2015-08-24Handle GetBaseCp overflowStephan Bergmann
...as found by UBSan in CppunitTest_sw_filters_test (see below); note the TODOs how best to report the errors up the call stack. > Testing file:///.../sw/qa/core/data/ww6/pass/crash-3.doc: > sw/source/filter/ww8/ww8scan.cxx:5240:63: runtime error: signed integer overflow: 1766665948 + 1768712052 cannot be represented in type 'int' > WW8Fib::GetBaseCp(ManTypes) const sw/source/filter/ww8/ww8scan.cxx:5240:63 > SwWW8ImplReader::Read_GrafLayer(long) sw/source/filter/ww8/ww8graf.cxx:2393:18 > SwWW8ImplReader::ReadChar(long, long) sw/source/filter/ww8/ww8par.cxx:3630:17 > SwWW8ImplReader::ReadChars(int&, int, long, long) sw/source/filter/ww8/ww8par.cxx:3432:27 > SwWW8ImplReader::ReadText(int, int, ManTypes) sw/source/filter/ww8/ww8par.cxx:3970:22 > SwWW8ImplReader::CoreLoad(WW8Glossary*, SwPosition const&) sw/source/filter/ww8/ww8par.cxx:5169:9 > SwWW8ImplReader::LoadThroughDecryption(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5767:19 > SwWW8ImplReader::LoadDoc(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6039:19 > WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6157:20 > SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18 > SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22 > SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23 > SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20 > SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sw/qa/core/filters-test.cxx:71:12 > test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:129:20 > test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:154:5 > SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:154:5 Change-Id: I0b14f5c1e025565eb131e64590b7d5ff0135e767 Reviewed-on: https://gerrit.libreoffice.org/17965 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-24Handle zero nPLCFStephan Bergmann
...as found by ASan in CppunitTest_sw_filters_test: > Testing file:///.../sw/qa/core/data/ww6/pass/crash-1.doc: > ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020009382b0 at pc 0x2b1dcb5eabac bp 0x7fffe8ccbdb0 sp 0x7fffe8ccbda8 > READ of size 4 at 0x6020009382b0 thread T0 > WW8PLCF::SeekPos(int) sw/source/filter/ww8/ww8scan.cxx:2219:14 > WW8PLCF::WW8PLCF(SvStream&, int, int, int, int, int, int) sw/source/filter/ww8/ww8scan.cxx:2080:9 > WW8PLCFx_Fc_FKP::WW8PLCFx_Fc_FKP(SvStream*, SvStream*, SvStream*, WW8Fib const&, ePLCFT, int) sw/source/filter/ww8/ww8scan.cxx:2883:21 > WW8PLCFx_Cp_FKP::WW8PLCFx_Cp_FKP(SvStream*, SvStream*, SvStream*, WW8ScannerBase const&, ePLCFT) sw/source/filter/ww8/ww8scan.cxx:3088:7 > WW8ScannerBase::WW8ScannerBase(SvStream*, SvStream*, SvStream*, WW8Fib*) sw/source/filter/ww8/ww8scan.cxx:1588:20 > SwWW8ImplReader::CoreLoad(WW8Glossary*, SwPosition const&) sw/source/filter/ww8/ww8par.cxx:5022:20 > SwWW8ImplReader::LoadThroughDecryption(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5767:19 > SwWW8ImplReader::LoadDoc(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6039:19 > WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6157:20 > SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18 > SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22 > SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23 > SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20 > SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sw/qa/core/filters-test.cxx:71:12 > test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:129:20 > test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:154:5 > SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:154:5 > 0x6020009382b1 is located 0 bytes to the right of 1-byte region [0x6020009382b0,0x6020009382b1) > allocated by thread T0 here: > operator new[](unsigned long) /home/sbergman/clang/trunk/src/projects/compiler-rt/lib/asan/asan_new_delete.cc:64 > WW8PLCF::ReadPLCF(SvStream&, int, unsigned int) sw/source/filter/ww8/ww8scan.cxx:2091:26 > WW8PLCF::WW8PLCF(SvStream&, int, int, int, int, int, int) sw/source/filter/ww8/ww8scan.cxx:2075:9 > WW8PLCFx_Fc_FKP::WW8PLCFx_Fc_FKP(SvStream*, SvStream*, SvStream*, WW8Fib const&, ePLCFT, int) sw/source/filter/ww8/ww8scan.cxx:2883:21 > WW8PLCFx_Cp_FKP::WW8PLCFx_Cp_FKP(SvStream*, SvStream*, SvStream*, WW8ScannerBase const&, ePLCFT) sw/source/filter/ww8/ww8scan.cxx:3088:7 > WW8ScannerBase::WW8ScannerBase(SvStream*, SvStream*, SvStream*, WW8Fib*) sw/source/filter/ww8/ww8scan.cxx:1588:20 > SwWW8ImplReader::CoreLoad(WW8Glossary*, SwPosition const&) sw/source/filter/ww8/ww8par.cxx:5022:20 > SwWW8ImplReader::LoadThroughDecryption(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5767:19 > SwWW8ImplReader::LoadDoc(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6039:19 > WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6157:20 > SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18 > SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22 > SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23 > SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20 > SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sw/qa/core/filters-test.cxx:71:12 > test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:129:20 > test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:154:5 > SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:154:5 Change-Id: I97d995aad621b829b6fb6ee4622d386fec0bedea Reviewed-on: https://gerrit.libreoffice.org/17963 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-24Don't attempt to cache glyphs that are vertical but the text direction isn'tTor Lillqvist
That is a too complex and rare case to bother with, I think. Change-Id: Ica6ef7fa05314d2367dcff32627c1aec6ba8f8df
2015-08-24Clean up outputStephan Bergmann
Change-Id: I4fbcd03e4af82ba8e3697651ddce92ba0ba450a6
2015-08-24Make test order deterministicStephan Bergmann
Change-Id: I9980034f0cb948acd6bb20aaf0fc27928ac68913
2015-08-24loop over successfully read bookmarksCaolán McNamara
not over the amount that should be there Change-Id: Ia2c353f9d7e274a5bebf405e1743ef1d1872b4de
2015-08-24detect and reject loop in tifCaolán McNamara
Change-Id: I77d315fa432a3eb1a65539489a2ba6da8508b283
2015-08-24-Werror,-Wpessimizing-move ("moving a temporary object prevents copy elision")Stephan Bergmann
Change-Id: I9e5b74e5ff0348f0880972a82726178354ab7d0f
2015-08-24allow avoiding config for CustomToolBarImportHelperCaolán McNamara
Change-Id: Iff0dd632f8c6b187d3515f542cc9fe2ca59088e5
2015-08-24limit seeks to valid areaCaolán McNamara
Change-Id: I401d93491999a3fc3db4f597eea9c4fe5b9bc926
2015-08-24coverity#1317300 Untrusted array index readCaolán McNamara
Change-Id: Ia9fe42974ffe24f6a679396b5d7ca672c0459f4b
2015-08-24tdf#93437: release reference held by ScFormulaReferenceHelperKatarina Behrens
This does two things: reverts a revert of 087f7fe50b03307e2d9202365886e8c37bd7e6e3 -- turns out it was innocent. Plus, it actually releases the reference that prevents destructor from being called. It was actually ScFormulaDlg's own m_aHelper member variable holding reference to 'this' (extra-wicked, through SetWindow(this)), never releasing it. Change-Id: I258a280e09674d1a2f1ddebea19ea1b42dcdc777 Reviewed-on: https://gerrit.libreoffice.org/17949 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-08-24tdf#89381 Revert "vcl: SalGraphics::mirror() - always use GetGraphicsWidth()"Maxim Monastirsky
This reverts commit 28effca640fff262866d1d3ada6e51a3821a6725. Change-Id: Ie21ae1ef969b2cfdce81a152c195a69ad3c27f65 Reviewed-on: https://gerrit.libreoffice.org/17937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-24guard against hangs with bogus unsorted plcfsCaolán McNamara
This reverts commit 6d21cbd1238556535ec1bb1adf35b25bc8eb898b. Change-Id: I309302ab5357b8404ee4c75bd0bfcb4f816e0588
2015-08-24Revert "guard against hangs with bogus unsorted plcfs"Caolán McNamara
This reverts commit f3db01f313ac06f70bec7584f48a380ab832ca75. <= maybe, need to double check
2015-08-24include vectorCaolán McNamara
Change-Id: I84f571c0564b33a5b647a270c567959b415b3747
2015-08-24guard against hangs with bogus unsorted plcfsCaolán McNamara
Change-Id: I91caff583617435add76503498ca4ed361eb5d2e
2015-08-24opengl: push mask coords to the shaders along the image coordsTomaž Vajngerl
If using the same texture to store the image and mask data (for example when using texture atlas) the mask and image (RGB) coords aren't the same anymore. With this commit we always define the mask coords separately. Change-Id: Ie33f87a6e9ab398972c6a3d5938e5f1364c82d36
2015-08-24Fixed (fixed size) texture atlas for "caching" OpenGL texuresTomaž Vajngerl
Change-Id: I7fe90c0a0033b4d9a341a4f0b8356d7f7133e93e
2015-08-24save texture to file as a PNG imageTomaž Vajngerl
Change-Id: I5605b80f95d89599efe58cf65e1ce3f3581d401f
2015-08-24dismiss bad seek offsets earlyCaolán McNamara
Change-Id: Ia88bc1833d362547f45e073028203a4de581f3e2
2015-08-24fix crash with empty booknamesCaolán McNamara
Change-Id: Ifadb2129be53530720cb2023cdc0782b6e737f18
2015-08-24loplugin:staticcallStephan Bergmann
Change-Id: I05dbd27bbb50d46fd2acce0b407201d36dd41c34
2015-08-24Revert "mysqlc: tdf#88206 replace cppu::WeakImplHelper* etc."Stephan Bergmann
This reverts commit 7fa5f876fddfd4baeff01d74d26cbf1dc4607d18, which uses LIBO_INTERNAL_ONLY features in external code.
2015-08-23vcl: unittests for Timer and AutoTimer.Ashod Nakashian
Enabled VCL Timer unittests on Windows builds and added two unittests to detect misfiring of timer events. Due to the nature of timer events having virtually no guarantees on non-realtime operating systems, the tests may fail randomly under different system loads. The tests repeat a few times in such cases, but still there are no guarantees. These tests are added to detect gross breaks in the timer algorithms and to improve certain corner cases. They are designed to minimize any random failures. Posterity might hate me for committing such unittests, so I added TEST_TIMERPRECISION directive to include/exclude the tests at compile time. It should be enabled if it causes more harm than good. Change-Id: If2856f194cb4732c84900113bdb969f397f67d5a Reviewed-on: https://gerrit.libreoffice.org/17906 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-23loplugin:defaultparamsStephan Bergmann
Change-Id: I0db404b84f62db9636fa30f9af1b9cc0d70a2624
2015-08-23Fix GTK3 right-to-left rendering of spin buttonsKhaled Hosny
The button were not drawn at all Change-Id: I51dfa30a6daa1034b5e978b09bcdfcc83e859f3d Reviewed-on: https://gerrit.libreoffice.org/17790 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-28 11:53:20 +0000