Age | Commit message (Collapse) | Author |
|
This reverts commit 2cb90a5c87fe46737c8d840967d8836284f92ffd.
Revert the change to EscherPropertyContainer, which was completely
bogus, based on pre-existing bogus code in VMLExport::Commit().
The problem is that ESCHER_Wrap values are for wrapping text *inside* a
text box, which is "mso-wrap-style" in VML, whereas VML's w10:wrap
element defines how text wraps *around* a shape, doesn't exist as an
ESCHER property and is specific to Word formats.
Instead, export the w10:wrap element in VMLExport::EndShape().
This has 2 callers, WriteActiveXControl() and writeVMLDrawing().
Furthermore the value "none" wasn't written for WrapTextMode_THROUGH,
which caused the wrap element to be omitted in that case.
Change-Id: Id4a01fcb2ea73fa9bef4ee8769b5e0680e059f15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103009
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
The problem is that one of the annotations is inside a table that
happens to start with a covered cell (vertically merged).
The table row is buffered, but the annotation is not, so it is inserted
before any of the text of the table cells is inserted, so it ends up in
the covered cell.
The strucuture of annotations is a bit icky; to fix this, buffer both the
\annotation destination and \atrfstart \atrfend start and end
destinations.
Change-Id: Ie955a75a2d254f8d7e965259698b688eece7cbd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103016
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
(regression from cb5d18871b46ef4f7bc47eb4d71df5374d712575)
Change-Id: Ic8c66504a760ef26fbf95a5a1a13b37346982024
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103015
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
After commit 456d61ec526e250fd1af894e109d5914ac9c9e6e
Change-Id: Ie9984d9d7d182d54317deb85efe1c83661f97b20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100412
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I0fb84ed3660f9a153ad89126a927299954360c2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99228
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102987
Tested-by: Jenkins
|
|
... and SwTextAPIEditSource
See tdf#94879 for motivation.
Change-Id: If9af8e5fb5d750547a1be9229f69bb79ae4bb0e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103080
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Reference OOXML (Appendix B.5.1, line 248)
Change-Id: Idf5c2546b4ad65c8e78ca03e18ecfa575ef17fe8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103005
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
|
|
Change-Id: I175e6c6f5f6b3edf338763af4d195414dcb54fbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103078
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
See
<https://gerrit.libreoffice.org/c/core/+/102996/4#message-618e5bb042a0214caa4492971f0a3cfc8441cfa1>
for motivation.
Change-Id: Id3074642064454b15dd56a504cf7e312b8ec7522
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103082
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Id1a63d6b7fde3f911625573ffce1bed5d2b322df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102971
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The user now has the possibility to sort the entries in various macro
dialogs either alphabetically or in document order using a context menu.
Change-Id: I064947daa9f9bca05cb28e4b2f65ff1c92689ae9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98783
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Change-Id: Iebe86f54a8aa30de87db80f55ae201ec02ffb80c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103076
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
get benefits of tdf#136559 for the autocorrect tdf#109158 case.
(which is not referenced in the commit summary for fear of awakening dragons)
Change-Id: I560ad5ff3c1cd4857d038d6b235db87056ed582c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103039
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
instead of a TreeStore if we only need a list
see: https://gitlab.gnome.org/GNOME/gtk/-/issues/2693
Change-Id: I03d03f2364ccc75b87d3f7c31d21ac9993fb384b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103036
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
since...
commit d39651a69d789522b2faffd01879db25354b9a22
Date: Thu Aug 27 15:13:08 2020 +0300
sw: additional asserts/warns to diagnose empty style names
though the triggering of undo/redo during layout looks super dubious to me
Change-Id: Ie03fc7c1660a3c4fb77bfc0abb8373a5d5822378
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103073
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
add a check for classes which have been partly converted to fastparser,
but not completedly.
This is to help me when I convert stuff.
and it uncovers a bug introduced with
commit 998308c363dfad03143591aa18256d2669b4da11
use more FastParser in SvXMLStylesContext
Change-Id: Ib50e7136da10a1a7a346102aa47efef2f543e2ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102669
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iacccc3a444da7cdbf84f8c96406918a56fd57247
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103072
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
|
|
argument of type "const sal_Int8 *" is incompatible with parameter of type
"void *"
Change-Id: I0f1dba700516043d54c4e46edae9753312b5ad2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103071
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I35fe1f3890200728af6dcd7d030f5e1169e9fe4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103070
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I5d8ef4a52f0aeef9012445a382aa472bd69ec925
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103069
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6208d2d6e6592db89223c8a8705f7f1ba066f16e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103068
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
- unify NotifyClient call at the end of function
- avoid copy and Differentiate on old set, if not needed
Change-Id: I7265b3985a2a44f80f7508cd41505601f92b19db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103042
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
Change-Id: Idc8fd27820cd807db81a89856f9aef567decc206
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103044
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
This enhancement selects outline headings in the Writer Navigator
content tree according to 'Find All' search results. It does this when
the content navigation view is set to show headings content only.
Change-Id: I77dabcdd38c8877b7f8a177689da094638d5fe00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92886
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: I80c6df216c5a6725f57c16fc134c3124ead76dfd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103035
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I2300dadeb87870fe800d533d80ec4bbf5211b894
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103028
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ic1e30a412927748ba58a21cf2ee922cd1a490aa4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103040
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I4fc230216cb739f03e20cb6ab4ec2c53c6ad48c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103037
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Not $LIBO_VERSION_SUFFIX_SUFFIX. Follow-up to
271297d4fa4a8e045b6dc04942966a1058bed45c.
Change-Id: I6356c84355e0ceac6e0ff492596e30a641935633
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102283
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
LibreOffice has line and fill properties of data labels in charts
as loext attributes in the style of the <chart:series> or
<chart:data-point> element. For ODF there has to be a
<chart:data-label> element with line and fill properties in its
style.
This patch adds the needed <chart:data-label> elements and their
associated <style:style> elements.
The element <chart:data-lable> exists in ODF since version 1.2.
The solution requires no extended namespace. The check is adapted
in lcl_getCustomLabelField.
Import was already done in commit
87d1ebeb11a00301745ee3c3c03fffb7033ab59d
Change-Id: I829dae5433e8257c775aa4f08e511d514df4e936
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102381
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
|
|
ParseCMAP crashes on a broken CMAP subtable of a font used by the
bugdoc of tdf#119074, which returns a negative offset (technically
it's large positive offset turning into a wrong negative integer,
which is still out of bounds of the CMAP overall size - you get
the point). This simply ignores that broken subtable, checking for
other existing ones.
Regressed-by: c7482bc2904401e7d975b5721ec861b8589253f9
Change-Id: I95820fe3bb6bd2fe2e0cf9d4c3536abce31fd497
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103033
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iff1c72b0b0f9835414b6a44b08d1da4306162e11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103030
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
doesn't do much for the gtk case due to
https://gitlab.gnome.org/GNOME/gtk/-/issues/2693
but has an impact on the vcl case
CheckAllChildren is then never called with a null pParent
so simplify it based on that
Change-Id: I3ae639aa70c7fca5eae9d2a7257cf39e7ce79e72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103018
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
so its natural height has no influence on the overall dialog height
and it will take whatever height the dialog ends up at
Change-Id: I98d6b2483f01ac2006dcc9d2ffa91824611a6d71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102976
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Code commented since initial adding of the test:
author Muthu Subramanian <sumuthu@suse.com> 2012-08-14 17:04:40 +0530
committer Muthu Subramanian <sumuthu@suse.com> 2012-08-14 17:04:40 +0530
commit 3ccb8dac1405dc4ffa0ca3c45bd0724cc339d8ad (patch)
tree 1fe5ae808b41458624624a9cd29502aa5bb290ad
parent e3acf19c0502b0758359b56abda81e504d167630 (diff)
Adding unit test case for n#759180
Change-Id: I85d58e7e0d1a595e2780612808bb8c51c1fb880e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103032
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
No need for the older second copies in solenv/gbuild.
Change-Id: I088f7d06b0727d1b336e3ba314b5c874d8ce3776
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103027
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Switch Idle to 100ms Timer for fixing the bug
Change-Id: I85a9bdcb173edd28d952d8e91c1b93d748e69206
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102984
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic68fadd3d63631cbccda76e7679d95bb89452d25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103017
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If42d57cb88119cc4cfc8266ec17c91d1d880fab4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103008
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The bugdoc has a shape, its bitmap fill is an EMF, which is actually a
PDF. The PDF is has a height of 5cm, but the shape has a height of 14
cm.
Inform vcl::RenderPDFBitmaps() about the size of the shape, so the
result won't be blurry. This approach makes sure that we don't
unconditionally render at higher resolution, i.e. the "load a PDF of 100
pages into Online" use-case won't use more memory than before.
API CHANGE, because the EMF reader is only available via UNO, though
it's likely that no actual external code would ever invoke it directly.
Change-Id: If1d8def0136d408a31a0cc54777a7f26430a0ff3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102996
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
...which is known to cause test processes to crash during exit. (Also see
5cd04405c6b2d1ee46294ce0696d89d2edc97d16 "Disable automatic onFirstVisibleTask
UpdateCheck during CppunitTests", so this commit now covers tests like
JunitTests and UITests that start a full soffice process.)
The relevant code is already rather complex and incomprehensible; it handles the
automatic update check triggered by the onFirstVisibleTask UpdateCheckJob,
manually triggered update checks, and downloading of new versions. To avoid
regressions in all those various scenarios, I tried to add very targeted code
that should only wait for a still running UpdateCheckThread triggered by the
automatic onFirstVisibleTask UpdateCheckJob---which is the scenario that caused
issues during `make check`. (For a manually triggered update check or download
it is probably both less likely that related threads would still run during
exit, as the user would likely wait for a response before closing LibreOffice,
and less severe if threads would still run during exit, as any resulting crashes
would likely be "harmless" and might not even be noticed by the user.) However,
I note that this targeted fix does increase the complexity and inscrutability of
this code even further...
The new code does not actually try to join the UpdateCheckJob---see
UpdateCheckThread::join referencing
<https://bz.apache.org/ooo/show_bug.cgi?id=73893> "webdav ucp does not implement
XCommandProcessor::abort". Rather, it waits for UpdateCheckJob::run to finish
(after unblocking at least any m_aCondition.wait calls). This, however, can
take a while if the update check's HTTP request is in progress.
To be able to use a std::condition_variable (with sane semantics compared to
osl::ConditionVariable) in UpdateCheck::waitForUpdateCheckFinished, the
corresponding UpdateCheck::m_aMutex had to be changed from a (recursive)
osl::Mutex to a std::recursive_mutex one (sticking to a recursive one just to be
on the safe side, whether or not the code actually makes use of that).
Change-Id: I2726acd33b884b807d840cfee2786fcf45815ad7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103013
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Table formula import worked only in the first table,
because of using bad fallback table for cell references
without table names during formula conversion to internal
formula.
Set table of the text field as the correct fallback table.
Follow-up of commit 68e74bdf63e992666016c790e8e4cfd5b28d6abe
(tdf133647 tdf123386 tdf123389 Improved .docx table formula import).
Change-Id: Ib080f12426c57c8c74fe919eb45637a655875d1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102989
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Regression from commit 89f0af144c18efafe2573801641689a1432c0cae (tdf#113198 set
default shape paragraph alignment.., 2019-11-19), the old bugdoc had this
markup:
<a:bodyPr ... anchor="ctr"/> (centered)
The new bugdoc has 2 shapes with text:
<a:bodyPr .../> (aligned to left)
<a:bodyPr ... anchorCtr="1"/> (should be centered)
"anchor" is about vertical, "anchorCtr" is about horizontal centering of text.
Checking what the binary filter does, it maps horizontal centering to
TextHorizontalAdjust, so fix the original bug differently, by leaving
ParaAdjust alone, and tweaking TextHorizontalAdjust intead: this keeps the old
bugdoc working but fixes the new one.
This caused a number of "change detector" XML-based tests to fail: all of them
are unchanged visually, so the XML files are adapted to the new state.
The tdf#113198 fix itself was fixing a regression from tdf#104722, and that
commit had no testcase, I tested that we don't regress there, manually.
Change-Id: I81a7b3e8c76bfbce5c5569d16d5238958ac20f75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103012
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
So the various fallback null checks are shown to be
redundant and can be removed.
Change-Id: I93b3c3a9b124b7de48acebcb348a1261c1b0037c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102978
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Idff982e715b012e35e0abd0b904f4b83d7f6f51a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103007
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I5d8ea1533fe861cf969c2999343da217c82d54e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103006
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia21f8fecdf8a6aea7ea9c6ea4d579c5e53882bbd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102982
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
e.g. launching the floating navigator before a document has been
loaded.
probably a problem since...
commit 94512c499d678e9eeca05e84361d846bbd3b6950
Date: Tue May 26 21:03:25 2020 +0200
sc: rowcol: convert more use of MAXROWCOUNT
Change-Id: I9f987c66b5a89f23e0ca02775d3bdb7b4dbf553a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103002
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
For certain PPTXs, Impress fails to import
the document with correct group shape positions.
More specifically, chExt (Child Extents) calculation
should take the values from group shape when 0 is given.
Change-Id: I1f8e89dcfe61ab2071ad00850ff99aecb7218067
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102895
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ie3e00e8195239e6570bfe76c2451bae11c209145
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102999
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
|