summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-16tdf#122444 Use fontwork name for object nameJim Raykowski
Change-Id: Icdbde958f2e89e669a9399479e0059095a6d8a3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92333 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-16sw: handle DisableOffPagePositioning when replacing compat optionsMiklos Vajna
This was added in commit 8d62b79f168180c6992eb483ec864d473050635f (tdf#112443 disable off-page content positioning, 2017-11-29), it's off by default and on for DOCX files. Change-Id: Ic42d652fd92931b98979defd5060bf6e8f7c47d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92320 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-16Resolves: tdf#122491 ClassificationDialog::run() is not calledCaolán McNamara
when using DialogController::runAsync so the custom override isn't called so the special setup and save-on-ok aren't called. move the setup into the ctor seeing as the dialog is only run once after ctoring and add a OK handling that does the on-ok setting save and have setupValues call readIn on "m_aInitialValues" because that gets called after the ctor Change-Id: I8183fc4b0f5de2844562c971c86d655f2d4920ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-16fix compile: missing semi-colon in < gtk 3.22 blockJustin Luth
compile error message: vcl/unx/gtk3/gtk3gtkframe.cxx:2930:1: error: new types may not be defined in a return type enum GdkAnchorHints ^~~~ vcl/unx/gtk3/gtk3gtkframe.cxx:2930:1: note: (perhaps a semicolon is missing after the definition of ‘GdkAnchorHints’) It passes Jenkins tests since they ignore this block. Change-Id: I3da71d114ac4cd82ac4644f3b6cc1f7142810f44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92334 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-16fixes for code creating reversed RectanglesNoel Grandin
ie. where left > right or top > bottom These are all places where the code is self-evidently doing the wrong thing. Found by adding asserts to tools::Rectangle. In theory, this is legit, and code that wants a proper Rectangle is supposed to be first call Justify on a Rectangle, but lots of places don't do that, and that seems very dodgy to me. So lets work towards Rectangles always being in a valid state. Change-Id: I03296a624bd9b5b193e6aa8778addfb09708cdc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92310 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-16tdf#132097: fix Find Previous with direction columns crashes in specific caseJulien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=159553 nBlockPos vector is created with nLastCol + 1 elements, so if we click on a cell in a column which is after last value, the search will crash Change-Id: I9de688a8a80a45c3e5ddea6d2f461926e9777052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-16loplugin:buriedassign in svtools..svxNoel Grandin
Change-Id: I04bc97effddb213e9c1ac613b61d3a0bc38522ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-16loplugin:buriedassign in starmath..svlNoel Grandin
Change-Id: I979faf4c476a7de91a0b6e06dd8717cee25525f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-16Drop redundant member functionMike Kaganski
SvImpLBox::GetCurrentEntry was identical to GetCurEntry Change-Id: I2ede6ecd8516a2a76fe504e30b5195f3950b340e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92294 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-15Fix typoAndrea Gelmini
Change-Id: I78fad18e12254cd3c3bb3f49b5898e09bb7b6c6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92318 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-04-15Fix typoAndrea Gelmini
Change-Id: I9ca8ee1e281c6c3f73b004eae11dd49c3b4e5861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92319 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-04-15send state changes of .uno:NumberFormatDecimal command to LOKMert Tumer
Change-Id: I7872c0a0c123865c77d3aa8937775116368f1ffa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92203 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 2f6cbb67099edde535a81e7b0a32c1418805d6d6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92290 Tested-by: Jenkins
2020-04-15GdkAnchorHints isn't available < gtk 3.22Caolán McNamara
Change-Id: Icabab4695d75c9067c6a4cff9fbcacaf1474afee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92316 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-15loplugin:buriedassign in scNoel Grandin
Change-Id: I9b4146c4e8814a36c7bfcd4c31f913c8412320e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15loplugin:buriedassign in scaddins..sdextNoel Grandin
Change-Id: I72acfdac5879aa251a1074ea850758f66072b46e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92311 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15loplugin:buriedassign in sfx2..sotNoel Grandin
Change-Id: I917752edb50020f9acb203038ce65f1ea25afa64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15tdf#126828 hide macro organize dialog before launching macro editingCaolán McNamara
so the macro editor isn't forced behind the window with an active dialog Change-Id: Iae89f6910a8183bcf01872eef71c04bc993f1550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92307 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-15tdf#126828 skip "on-demand" entriesCaolán McNamara
Change-Id: I5a1b20ce2e6c1d228760fc39e7770e1b497bd9ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92306 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-15mobile: fix double tap on chart doesn't get into editmodeMert Tumer
Sometimes double tapping on a chart when it is not selected in the beginning, starts the input mode instead of chart editing. Change-Id: Iee2a01c1ac909ac4060e91cdacfa9161dc4f1c3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91992 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit d09a35bc10251ef0b66e06c6ffbb2d16332b318b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92291 Tested-by: Jenkins
2020-04-15tdf#132091 sw: fix fieldmark mess in SwCursor::SelectWordWT()Michael Stahl
The problem is that it selects both the field instruction and the field result; in the typical case where the instruction is empty, the separator won't be deleted (due to CalcBreaks) but the problem is that the cursor ends up before the separator, not after it. Also remove some silly defensive programming. (regression from ffb26b81e1c7ff1d64959200247bb2edd5a569da) Change-Id: I80b6cb1790b7102828f12b680631f928734ffa7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92284 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-15Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to 82bb6643f1050a9ec83e39150a54e98d9ce81433 - Basic Table of content alphebetical ordering Change-Id: I5e0d46bbbf64fe1b9296fc912e2492a7acd73af7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92180 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 9426fd84810a8d785d896f008be8515ed94c7028 - Typos and correction in page Change-Id: I1382ca7a49475d11c3cf424bea9c2146e0d4466e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92292 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-15loplugin:buriedassign in l,o,p*Noel Grandin
Change-Id: Ib2dd157d43c4387eda009475311761fe2eb627cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15loplugin:buriedassign in f,h,i*Noel Grandin
Change-Id: Iac753e528e13cb2565832a484e87f88061bbc91e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15Fix typoAndrea Gelmini
Change-Id: I4ddc0ea4dea4b374104e2a3100858c225409e2e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91929 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Eike Rathke <erack@redhat.com>
2020-04-15tdf#126828 don't crash fetching cmis properties from disposed SfxBaseModelCaolán McNamara
Change-Id: Ie064632667b40201e0d266c64e3068c4d1983c7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-15set cursor after thawedCaolán McNamara
Change-Id: I3e9ebee84c8a65b7231b0947e1044445b656780c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92282 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-15navigator pane is grabbing focus away from document when its createdCaolán McNamara
so only grab that focus when its a floating navigator Change-Id: I52e0840e74c3e8058aee3702df52137dfdd3dc9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92279 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-15bin: Add script to find missing unittests based on git logXisco Fauli
First iteration: look for docx, xlsx and pptx export commits print to wiki format Change-Id: I05770b096c55b6faa39d34a8fd39768a4d7fe5b1 Change-Id: I0f19a73183b482bf0e19af0314c72f2ea9f25544 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91910 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-15Related tdf#130778: New About dialogHeiko Tietze
More flexible dialog logo & about images as SVGs Change-Id: Icefa035893e241a7dee6aa28236e6b89b38477de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91908 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-15Related tdf#130778: New images for splash screenHeiko Tietze
Taken from the proposal at the BZ ticket; hires missing Change-Id: I95e19d5acb6c1b580c51e2af8dac272b459cf20c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92263 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-15xmloff: turn this warning into an infoMiklos Vajna
<vmiklos> noelgrandin: is there some way i can silence this "warn:xmloff.core:30241:30241:xmloff/source/core/xmlimp.cxx:739: SvXMLImport::startElement: missing context for element draw:color" warning? i get it 120 times when i do a hello-world odg->pdf conversion :) <noelgrandin> vmiklos, hmmm. I think just turn it off for now. Change-Id: Ib1fcb1a20d51547536a8c5cce0dc16547d34f325 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92273 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-04-15tdf#91565: Report builder, missing insert field iconJulien Nabet
in Add Field dialog. Since https://cgit.freedesktop.org/libreoffice/core/commit/?id=50cacaea4d8f2a27ea4d9e626dbb518a57eb9ffc, author Caolán McNamara <caolanm@redhat.com> 2016-09-27 09:47:00 +0100 committer Caolán McNamara <caolanm@redhat.com> 2016-09-27 10:43:36 +0100 commit 50cacaea4d8f2a27ea4d9e626dbb518a57eb9ffc (patch) tree a2cf1d1fb28231a6594e03e17c5e9ffe8748a655 parent e6fc195ae8a59d665395149ea5f06749c4c6a596 (diff) convert floating add field to .ui format Change-Id: Ica9adc19f370d6340d2f5fac552cf1b995b390e0 it was easier to analyze the problem. Change-Id: I2c7dda5969d4018689446725dc3e179c6ddc74c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92228 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-15add an IsEmpty method to tools::Size and use itNoel Grandin
Change-Id: I7f5201e2ea6c74329336e16bf219630e38ff92cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15tdf#131193: MSO PP complains about an ODP saved as PPTAron Budea
pPara was supposed to be the first paragraph, as before the below commit. Regression from d458adeed0c34fae26fe7f3d6ecc9b75b431922f Change-Id: I50b993ff8f37fd5572d60fe5d103c3cf5e636a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92105 Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-04-15fix Skia glyph orientation with DirectWrite (tdf#132084)Luboš Luňák
LOGFONT includes info about whether a glyph should be rotated, so we don't need to do it explicitly, but with DirectWrite apparently this information doesn't carry over. Change-Id: I4530511c4de7b64a6488629b380be34d4a42b3d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92260 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-15keep old contents of resized windows with Skia (tdf#131952)Luboš Luňák
It seems this is necessary in rare cases. Change-Id: Id7557a069bc0adf61b34068f00761e16b961fbc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92258 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-15Breeze: Add support for Korean UI tdf#128689Rizal Muttaqin
Change-Id: Idbe742cdedc497ed9e0aec72cc69842b12d94aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92248 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-15uitest: wrong filenameXisco Fauli
Change-Id: I06b3586519b8b58410ffb4e08822af53e252ecbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92262 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-15Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 1cf550347fdb87391903b533dd1c47135875a9d7 - update translations for master and force-fix errors using pocheck Change-Id: I9f37f1bad2c1005d8b63991fb1a66cd2f14e259b
2020-04-15tdf#131170: Add UItestXisco Fauli
Change-Id: I3d881803014d80cd3e8b3ed2f3cc2e84fdc1b3b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92261 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-15loplugin:buriedassign in e*Noel Grandin
Change-Id: Ibbf5b576296bb73e7066f2426bf2fa28739bb761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15sw: avoid calling SwView::GetWrtShell() unconditionally from the SwView ctorMiklos Vajna
Regression from commit dfcfdf47b5da6a11b2c3118a0f63cc48c10c2cd7 (lok: get spelling context menu on long press, 2019-10-20), the problem was that GetWrtShell() returns a reference, and the underlying pointer can be nullptr till the SwView ctor is in progress. Fix the problem by not caring about spelling till the initial view is ready, that still provides the cursor position. Change-Id: I5580a1b36b83e0a4cb8495f41e7087c784f6c83c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92256 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-04-15ofz#21701 fix DISABLE_DYNLOADING caseCaolán McNamara
Change-Id: I8b63c032e8421d3001bb318ddbdc8cffcfa5212b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92253 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-15Handle desktop files with multiline entries.Jussi Pakkanen
This fixes a regression mentioned e.g. here: https://bugs.documentfoundation.org/show_bug.cgi?id=130911#c6 Change-Id: Ic1a826ba933b8387d39aa25245095f27b0237801 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92050 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-04-15writerfilter: DOCX import: import w:noLeading as AddExternalLeadingMichael Stahl
Change-Id: I3d7fa2984975205d284575c60c6c47284b00c4a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92209 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-15sw: DOCX export: export AddExternalLeading as w:noLeadingMichael Stahl
For 11pt Arial, can fit 59 paragraphs on a page vs. 57... This is annoyingly complicated by the fact that Word 2013 ignores w:noLeading element if compatibilityMode is 15. Change-Id: Ie3093eabba45cdf6e7903ed860f5bad24dcc0323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92208 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-15explicitly set the correct index if the font is in the listCaolán McNamara
Change-Id: I212a97007b5e69e6a2a6e10c76afe50c45ec283e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92229 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-15loplugin:buriedassign in reportdesignNoel Grandin
Change-Id: I1caeeb8e0a6f02f1dd37f7399702af1b2a400b28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92242 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15loplugin:buriedassign in salNoel Grandin
Change-Id: I5a7bc9378ceacb9116c03e3a9fc01c5675c40908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92243 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-22 21:37:17 +0000