summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-01-06tdf#129798: store SwWrtShell when it's availableMike Kaganski
GetActiveWrtShell may return nullptr when attaching a new component to current frame, e.g. destroying on print preview. OTOH SwWrtShell is passed to SwFieldDBPage::SetWrtShell on creation, so store it to own base class then. Possibly that would be enough, and we could remove all the checks in other methods - but I don't know the code well enough to be sure that SwFieldDlg::PageCreated and SwFieldEditDlg::CreatePage will always set SwWrtShell; to be on the safe side, I kept the checks where SwWrtShell is used, and stored it in those places if not yet stored. Regression after commit 39ba5e3bde93358af1b363da8f850bdc96806cfa. Change-Id: I21f3c8ef24764e98b1bc287db3c6485ce0b3ab48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86253 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-05tdf#129596 Distinguish between integer and long while loading immediate valuesU-DESKTOP-8OSNV7R\DrRobotto
During the generation of CONST_ expressions, distinguish between integer and long and load the correct value in the immediate load step. Change-Id: Ib4eb65d7fae3163043899ad8234816b1ebd7316b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85779 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-05Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to f0321cbc4c5f8611b6d75b1312c9d198c1fad4cf - updating help for Writer variables - remove duplication - aligned capitalization in help with capitalization in dialog box - corrected labels to match dialog box - move embedded parts to correct place in structure Change-Id: I04cf1a2736cb3b4f4fa61fcd11cb5ee6f0f6c816 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86171 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-01-04ofz#19766 fix Build-FailureCaolán McNamara
Change-Id: I4df1dec271980a8a9eab9c2ee2c687ef938082d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86225 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-04ofz#19796 Indirect-leakCaolán McNamara
Change-Id: I144a1dd7901c90a979a018576404b84ece36a79b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-04allow root under podmanCaolán McNamara
Change-Id: I66dc674aab8dc86c95495754400c5e64b2583599 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-04pdf: set the UniversalAccessibilityCompliance from the dialogTomaž Vajngerl
Change-Id: I380b760a39bcdbef271c948690b1c9a95c769b4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86213 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-04pdf: Only add role map when alias isn't the same as structure tagTomaž Vajngerl
It is not allowed in PDF/UA to override a structure tag. This also true when you have an alias with the same name as a structure tage. For example to define a "H1" that is an alias for the "H1" structure tage. This is probably done in LO "just in case". With this change, if the structure tag and alias are the same, it will not get added to the role map, but this only happens when PDF/UA is enabled. Change-Id: Iff37c31ad31e5a01d7847ddb57f9b0e4c7b247db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86212 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-04ofz#19790 Invalid-enum-valueCaolán McNamara
Change-Id: Ifca6b26b39d873f67d6161d19354be4bd6462953 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-04tdf#129522 ww8import/export: allow char shadow_NONE overridesJustin Luth
An earlier patch did this for paragraphs. The same is needed for character properties. This also applies to borders - where a non-border needs to be processed in order to override a style-defined border. This export change doesn't affect DOCX immediately, because DOCX will do nothing with a NONE-border/shadow until style information is provided to it. So this change is safe to make on it's own as far as DOCX is concerned. RTF just exports the border, but since it doesn't do any of this well, add in the logic so that RTF is unaffected... Change-Id: Ia857dc0db7d7efc83145a14e4fe4052d32b539ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85760 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-01-04cid#1456609 Operands don't affect resultCaolán McNamara
2.2.2.37 EmfPlusPointR Object has... "X (variable) This value MUST be specified by either an EmfPlusInteger7 object or an EmfPlusInteger15 object." and the same for Y. where variable is variable length. I think ReadInt32 isn't the right choice here and we need to read either one or two bytes, using the highbit of the first byte to determine if we need to read another byte. Change-Id: I60c0687403ff58dc393bd55a22f37c89357f60c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86207 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-04Update git submodulesAndrea Gelmini
* Update dictionaries from branch 'master' to 612bdcc5364508e3fb7795c9b95559ca6e328570 - Fix typo Languange->Language Change-Id: I5f961c9a1751145b26a5f69eded6302926560074 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/86203 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-04Fix typoAndrea Gelmini
Change-Id: Ie930c3d80a57d2c10473d21e47c97339f6ffbf03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86209 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-04drawinglayer: extract classes from baseprimitive2d.hxx to own filesTomaž Vajngerl
This extracts Primitive2DContainer class to its own file, common typedefs for PrimitiveReference, Primitive2DSequence to own file CommonTypes.hxx, some commonly used and independent functions to Tools.hxx. But for not BufferedDecompositionPrimitive2D class is left as it is. Change-Id: Ia55bafd32fb95eba945d091e2c2ae89b160140d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86086 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-04tdf#129475 DOCX: fix gridAfter with shape-only cellsLászló Németh
and in last row of tables, i.e. regressions caused by the following commit. This reverts commit b2c6d2d961a6113d0f111fab45ae12a40d389a23 (fdo#38414 tdf#44986: DOCX table import: handle gridBefore/After), except some unit testing. Change-Id: Icb2d65b7a0766cf8dd00511cde500af3f94d2a94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86125 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-04VBA: don't SAL_WARN on value-to-number conversion errorMike Kaganski
Error to convert a value to number is signalled to user normally as a standard Basic error; it's nothing a developer should worry about. Change-Id: Ia6ca316f374ffe392eb1a7b4ffac52fd53ba2fb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86210 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-04tdf#125662: disable parallel-zip if the memory...Dennis Francis
required to carry it out will cause a breach of addressable memory limit. This can happen in 32bit OSes, where the physical memory limit is more than the process addressable memory limit. For example in Win32, a process can address only upto 2GB. More specifically, avoid using ZipOutputEntryParallel which rougly needs twice the memory compared to its counterparts. Change-Id: I4d1abbf75e928188bcf806fcf1e5872b1e51b502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84394 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-01-04tdf#93389: keep encryption information for autorecovered MS formatsMike Kaganski
The autorecovery data is stored in ODF, regardless of the original document format. When restoring, type detection generates ODF data, which is stored in the media descriptor attached to document, even after real filter was restored (see AutoRecovery::implts_openDocs). If real filter is not ODF, then at the save time, it doesn't find necessary information in encryption data, and makes not encrypted package. This patch adds both MS binary data, and OOXML data, to existing ODF data for recovered password-protected documents (regardless of their real filter). TODO: only add required information to encryption data: pass real filter name to DocPasswordHelper::requestAndVerifyDocPassword from AutoRecovery::implts_openDocs. Change-Id: I4749c5ec028ca61bddf7cd77bc5969a97b1de199 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86201 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-04sc/qa: revert locale change in the scope guard.Mark Hung
ScExportTest::testTdf112567() and ScExportTest::testTdf112567b() change the locale config to "hu-HU" and revert to "" at the end, the resulted locale is the system one instead of English, and breaks testTdf128976 under a zh-TW build environment because testTdf128976 relies on some font/loclae dependent metric data. Change-Id: Iec8a0771a726133dfd30d5e5e254d9b678d44d72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86191 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-04tdf#129708 speed-up: reuse enumeration for each effectSerge Krot
Change-Id: I336278c5a9eec75a2a71fe4d04d2029a5a08e6a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86102 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-03UBSan now needs RTTI of some Library_sc types in Library_scfiltStephan Bergmann
...after 4992d61600536fe14b97b718dbb11f00e936c6a9 "tdf#129228 speedup opening of xlsx file with lots of comments" added > ScTableSheetObj* pAnnosSupp = static_cast<ScTableSheetObj*>(getSheet().get()); > rtl::Reference<ScAnnotationsObj> xAnnos = static_cast<ScAnnotationsObj*>(pAnnosSupp->getAnnotations().get()); to Comment::finalizeImport in sc/source/filter/oox/commentsbuffer.cxx. (See <https://ci.libreoffice.org/job/lo_ubsan/1493/>). Change-Id: Ia8a99297151abfe4f052fbf46504795db1ba87b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86192 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-03cid#1456605 Dereference after null checkCaolán McNamara
Change-Id: Idee4d1e45eac46faa6c2a2e3b68700950abfe4e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86190 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03cid#1401342 Uncaught exceptionCaolán McNamara
Change-Id: Ia8746219c483a92977fa87993cb9a97189d52783 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86188 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03ofz#19786 Invalid-enum-valueCaolán McNamara
Change-Id: I9bca61f728877b6f7a741e9d89ad2f7f5ae0eb61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03Make variable const, and drop a bogus assert after checkMike Kaganski
Change-Id: I5160618a6af171e8ce048959bc4152f09d1754b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86195 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-03Fix typoAndrea Gelmini
Change-Id: I1755566fe28b3a79d7f97875d8986b6f37a0979d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86202 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-03cid#1456608 Dereference after null checkCaolán McNamara
Change-Id: I47f41b1eae327a0140f4e59184db7a0d7f5b0f67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03Elaborate comment what happens, tdf#78840 follow-upEike Rathke
Change-Id: I30bfc2891e422e8cfcb83f01136c654e3a1b03f5
2020-01-03tdf#78840: disable case-insensitive transliteration for regex searchMike Kaganski
Allow regex engine use its own case-insensitive search instead. We already set UREGEX_CASE_INSENSITIVE ICU flag when case-insensitive search is requested in TextSearch::RESrchPrepare. Case-insensitive transliteration used when preparing the string for passing to regex engine creates a lowercase string, where case-sensitive search is impossible, even when regex includes explicit flags for that. This change allows to honor (?-i)/(?i) flags in the regex if present. It removes case-sensitive flag from consideration for creation of transliteration service if regex search is requested. Change-Id: I0d8960670c1681f7c6bc162a4f858006596c7c36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85650 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-01-03cid#1456607 Uncaught exceptionCaolán McNamara
Change-Id: Idc15fe4049dc6669b9e25cd1a8fb187e10df2b6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03cid#1456611 Uncaught exceptionCaolán McNamara
Change-Id: Ice8dcd4ed069bb4fc971d487b706bedc6b02012b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03cid#1401474 Uncaught exceptionCaolán McNamara
Change-Id: I983b0106da9e41cd923603aa8bba685f61963abf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86184 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03cid#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I5ee29d9b9c6511aa71d592d6f85a724200645df8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03cid#1456612 Dereference null return valueCaolán McNamara
Change-Id: I0160fe9f31dc0716bd862014ca1e8eb7bae7c1ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86182 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03cid#1456606 Dereference after null checkCaolán McNamara
Change-Id: Ic1467982a7366db6266eaab3e08ca52f2785bac4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86181 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03cid#1456603 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ic4d93a07bb42bbbf3370bd13e3425b0ecbb46e5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86179 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03cid#1456610 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ibd0d2e9f8a8ca778e68b6f4e5d93c1cc2536f032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86178 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03cid#1456604 Uninitialized scalar variableCaolán McNamara
Change-Id: If9e9392cb35e21a45130ec3d7863cc721e1c5e84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86180 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03Avoid -Werror,-Wdeprecated-enum-float-conversionStephan Bergmann
...with Clang 10 trunk: > vcl/quartz/ctfonts.cxx:414:35: error: arithmetic between enumeration type 'FontWeight' and floating-point type 'double' is deprecated [-Werror,-Wdeprecated-enum-float-conversion] > nInt = rint(WEIGHT_NORMAL + fWeight * ((WEIGHT_BLACK - WEIGHT_NORMAL)/0.68)); > ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ etc. These computations had been introduced with ea8422d42e838e7ddfeb8d9f77f3ecedecb29ce8 "Cherry-pick Core Text port from AOO", and it looks like they indeed want to compute a suitable value in the WEIGHT_THIN (=1), ..., WEIGHT_BLACK (=10) range of enum FontWeight, resp. the WIDTH_ULRA_CONDENSED (=1), ..., WIDTH_ULTRA_EXPANDED (=9) range of enum FontWidth (rather than, say, float values in the THIN = 50.0, ..., BLACK = 200.0 constants range of css.awt.FontWeight, resp. the ULTRACONDENSED = 50.0, ..., ULTRAEXPANDED = 200.0 constants range of css.awt.FontWidth). Change-Id: I054e4e215331f84cea03de681aa4b0fb7c12eef5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86176 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-03android: file-cache to improve performance.Michael Meeks
The transition to java - interestingly to free the passed buffer was showing on profiles. Also cleanup the /assets// handling a little. Change-Id: Id1f4f6e60896c3f42fcbf761e535b68318e0a0a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86169 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-03svx: fix heap-use-after-free in PosSizePropertyPanelMiklos Vajna
How to reproduce: start Draw, add a shape, expand the "position and size" property panel on the sidebar, quit -> boom Asan reports: ==27725==ERROR: AddressSanitizer: heap-use-after-free on address 0x616000aa60c0 at pc 0x0000004a5d34 bp 0x7ffd28584a30 sp 0x7ffd285841e0 WRITE of size 40 at 0x616000aa60c0 thread T0 #0 0x4a5d33 in __asan_memcpy lode/packages/llvm-472c6ef8b0f53061b049039f9775ab127beafbe4.src/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cc:22 #1 0x7f18a3b304c7 in weld::Toolbar::connect_clicked(Link<rtl::OString const&, void> const&) /include/vcl/weld.hxx:1990:81 #2 0x7f18a3b2fece in ToolbarUnoDispatcher::dispose() /sfx2/source/toolbox/weldutils.cxx:129:17 #3 0x7f18a3b30144 in ToolbarUnoDispatcher::~ToolbarUnoDispatcher() /sfx2/source/toolbox/weldutils.cxx:133:49 #4 0x7f189b921f95 in std::default_delete<ToolbarUnoDispatcher>::operator()(ToolbarUnoDispatcher*) const lode/opt_private/gcc-7.3.0/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:78:2 #5 0x7f189b91adf9 in std::unique_ptr<ToolbarUnoDispatcher, std::default_delete<ToolbarUnoDispatcher> >::reset(ToolbarUnoDispatcher*) lode/opt_private/gcc-7.3.0/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:376:4 #6 0x7f189b8ef552 in svx::sidebar::PosSizePropertyPanel::dispose() /svx/source/sidebar/possize/PosSizePropertyPanel.cxx:149:23 ... freed by thread T0 here: #0 0x4eb440 in operator delete(void*) lode/packages/llvm-472c6ef8b0f53061b049039f9775ab127beafbe4.src/compiler-rt/lib/asan/asan_new_delete.cc:166 #1 0x7f18806064f0 in (anonymous namespace)::SalInstanceToolbar::~SalInstanceToolbar() /vcl/source/app/salvtables.cxx:1123:5 #2 0x7f189ac45321 in std::default_delete<weld::Toolbar>::operator()(weld::Toolbar*) const lode/opt_private/gcc-7.3.0/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:78:2 #3 0x7f189b91b0e9 in std::unique_ptr<weld::Toolbar, std::default_delete<weld::Toolbar> >::reset(weld::Toolbar*) lode/opt_private/gcc-7.3.0/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:376:4 #4 0x7f189b8ef46d in svx::sidebar::PosSizePropertyPanel::dispose() /svx/source/sidebar/possize/PosSizePropertyPanel.cxx:148:18 I.e. it's important to delete mxArrangeDispatch before mxArrangeTbx, since the dispatch has a reference to the toolbox. Change-Id: Ief294b492bc3778b0d39650a5642d21fa1db66f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86177 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-03Avoid -Werror,-Wdeprecated-anon-enum-enum-conversionStephan Bergmann
...with Clang 10 trunk: > vcl/quartz/salgdicommon.cxx:1299:59: error: bitwise operation between different enumeration types ('CGImageAlphaInfo' and '(anonymous enum at /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGImage.h:51:9)') is deprecated [-Werror,-Wdeprecated-anon-enum-enum-conversion] > kCGImageAlphaNoneSkipFirst | kCGBitmapByteOrder32Big ); > ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~ <https://developer.apple.com/documentation/coregraphics/ 1455939-cgbitmapcontextcreate> documents the "uint32_t bitmapInfo" parameter of CGBitmapContextCreate as: "The constants for specifying the alpha channel information are declared with the CGImageAlphaInfo type but can be passed to this parameter safely. You can also pass the other constants associated with the CGBitmapInfo type." Change-Id: Idee410c65bd022a125a2f5a34cda007a8ca07580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86175 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-03Use only the 'MacOSXSpell' component on iOS, not the 'spell' oneTor Lillqvist
Using only the system spell checker (through MacOSXSpell) is what we have been doing anyway. Do not build the hunspell or mythes externals for iOS. Do not build the lnth or spell components for iOS. Change-Id: I2e2abc268d7719e540072e5daff3f7960e04ed27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86172 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86174 Tested-by: Jenkins
2020-01-03android: don't try to copy the apk if it does not existMiklos Vajna
Linking obj/local/armeabi-v7a/liblo-native-code.so cp: cannot stat 'android/source/build/outputs/apk/strippedUI/release/*-release-unsigned.apk': No such file or directory make[1]: *** [android/CustomTarget_lo_android.mk:19: workdir/CustomTarget/android/source/done] Error 1 Change-Id: I90818d432cab0ef8ef7049b6be175db9e9028261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86170 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-03tdf#129743 follow-up: implement the other variant of the fixMike Kaganski
Reimplement commit d8a188d8d59ae51621a0540fe931e1c70db285fe Seems that I was overly optimistic. The behaviour of CreateCursor affects many places; first of them is CreateNewShellCursor, which would start returning cursors with selection after the fix from commit d8a188d8d59ae51621a0540fe931e1c70db285fe. Or if we change which cursor is returned from that method, then the order of the chain would reverse. And there are many such places. So just make it like before, and do the conservative fix. Change-Id: Ib6bf414f0e91d6fb59f73fbfc0fbd799457d49c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86151 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-03tdf#129522 SvxShadowItem/writerfilter: allow shadow_NONE overridesJustin Luth
Both editeng and writerfilter were ignoring the case where NONE should override an inherited shadow location. Of course, this situation is very rare. Nearly all unit tests ran when asserting that eLocation is already NONE. The same is true for DOC, except that it is not affected by SvxShadowItem's PutValue problem (and neither is ODT). RTF is not even removing the borderlines themselves, so no point in worrying about the shadow for RTF. Change-Id: I7c1ae67270dde81915daee2f0282aa2074d2ec8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85658 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-03drawinglayer: simplify namespaces in BasePrimitive filesTomaž Vajngerl
Non-functional change Change-Id: I2ef0012274a0ad3b6e576eeab1fa923ef7bd8b6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86079 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-03Fix typosAndrea Gelmini
Change-Id: I17b7881a28dc5b17d4051fe54cada2681e182873 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86159 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-03tdf#42949 Fix IWYU warnings in slideshow/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id1c207705b7aa9b057fb8207d735e376675c91d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86069 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-03sw: add UNO API for semi-transparent textMiklos Vajna
This makes the ODF filter work out of the box, since the same property was provided by Draw/Impress in the past already. Change-Id: Ie6a053864c9fa41fad6ca4571d7d04a3756b7591 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86147 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-03-21 20:03:49 +0000