Age | Commit message (Collapse) | Author |
|
I was too positive thinking that SalBitmap would be fine,
but it's locked to vcl. To be able to add system-dependent
BitmapBuffering I move the access to Bitmap now. This is
no functional change, but offers the same access as e.g.
B2DPolygon/B2DPolyPolygon offer already.
Also cleaned up usage/access to SystemDependentDataManager
which removes quite some code in constructors and makes
things easier in general.
Change-Id: I2baa40a12479fab0fe66063a018f058c6b8f5597
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141507
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|
|
That check had been added with 32bc8ddbf335dd26019edcf12758643b4cff9913
"tdf#94716 allow Oracle's JDK to be used on OS X 10.10 and 10.11", back at a
time when there was substantial trouble with installations of Apple's own Java
and Oracle JREs. One consequence of that commit and its
JvmfwkUtil_isLoadableJVM check was that on macOS we only supported JDKs (with a
surrounding Contents directory containing an appropriate Info.plist files), not
plain JREs (cf. <https://wiki.documentfoundation.org/ReleaseNotes/5.1#macOS>
"Prior work arounds of having both an Apple JRE 6 and an Oracle JRE 8 are no
longer sufficient. Use of the JDK is now hard coded, see tdf#74877, tdf#94716
and core commit 32bc8ddbf335dd26019edcf12758643b4cff9913.")
However, Apple's own Java is long since deprecated (cf.
<https://support.apple.com/en-us/HT204036> "You can also download legacy Java SE
6 from Apple if you’re using an app that specifically requires this unsupported,
out-of-date version."), and presumably of no practical concern at least on
contemporary Aarch64-based macOS.
And there is e.g. SDKMAN! (<https://sdkman.io/>), which installs JDKs in a way
that they are not surrounded by Contents directories containing appropriate
Info.plist files, so JvmfwkUtil_isLoadableJVM returned false for them and you
couldn't add them on the LibreOffice Advanced Options tab.
So at least for Aarch64-based macOS, drop that presumably-legacy
JvmfwkUtil_isLoadableJVM check (but keep it for x86-64--based macOS at least for
now, just to be safe). (That implies that for Aarch64-based macOS, it should
now work again to also use plain JREs.)
Change-Id: I3bcbb3c14e3a9e9dde39fd6f4572b632e05df9e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141508
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
the chart2 module likes cloning ScChart2DataSequence, which can take a
long time if we have lots of data, so share the data via shared_ptr
Change-Id: I4b0948610810c41a8569b97c58b2b52e8e3190f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141501
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I62be40614baf489433a53f19397737031d1f217b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141509
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
The fix for tdf#148321 has introduced tweaks to the upper and lower
text distances for the case, that their sum is larger than the text
area height. That works well in import from PowerPoint but conflicts
with import of SmartArt shapes from Word.
Reason of the problem is not only the missing Twip to Hmm conversion in
TextBodyProperties::readjustTextDistances(). But I have not found which
detail in the tweak produces the wrong text location. For now I have
disabled the tweak for import from Word. Maybe someone finds a better
solution in future.
Because the user cannot insert such large distances in Word and SmartArt
shapes do not use such distances anyway, I think it does not harm to
disable the method for text documents.
Import from Excel cannot be tested because of tdf#83671.
Change-Id: I2e133f6864bba4419ad96e94d88aec86fe97d0fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141414
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
|
|
...following up on 7b63242ea72885d05faa5f0879395fa93a3446d1 "tdf#145538 - Use
range based for loops"
Change-Id: Ice88c86e01e69e49b9fca920d61fe6d56763f134
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141498
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I35c883a1b05a797e83a41698fa205796e681d7c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141482
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
There was no way to use only a keyboard to access
dropdown formfields. (This should also work for LO's
unique DateFieldMark - however you get one of those.)
Change-Id: I2b0b2bd38a43817bbbf1801910815ebe87614f94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141488
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
Map the Alias/Tag UNO properties to:
<loext:content-control loext:alias="..." loext:tag="...">
on export, and do the opposite on import.
Change-Id: Icecbe9037ede0bf8d72d52f2db44328a8db1d83a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141492
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Idfa3dc085a944fb8ffe5819b08ba9a264d58900b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141490
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...so that the Python script provider, based on those DateModified values, will
reload a script embedded in a document after that script has (programmatically)
been modified.
As long as a stream content in a tdoc document has not been modified, it will
report a default-initialized (all zero) DateModified. Only when the stream has
been modified will that be changed to the current date. While that might not be
the most beautiful implementation, it at least gets the job done of fixing
tdf#105609 "Python script provider does not reload modified embedded scripts".
(The DateModified values cannot be stored directly in the tdoc_ucp::Content
instances, as those are thrown away and recreated on demand. So they needed to
be stored more persistently at the tdoc_ucp::OfficeDocumentsManager.)
Change-Id: Iee809960e1a1bc40961f0df2b3729e58b75e6028
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141491
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This was already aded for TextFieldmark in 2018 via tdf#120225.
(A unique name is created if that mark already exists.)
Added it to the other formfield items.
This is needed for DOC/DOCX import,
and is critical for connecting macros to the control.
mstahl said that DateFieldmark is not a valid MS formfield,
and miklosv indicated no likely value in preserving a name there.
There is also NonTextFieldmark and FieldmarkWithDropDownButton,
but they just look like implementation gadgets to me
so I didn't give them the same treatment.
No need for a unit test here. This is super foundational - anything
else building on it will be the unit test.
Change-Id: Ide49d6efb8391fea17e7a61c9e99b30532bb2014
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141423
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
it was sill visible in other views
Change-Id: I75ce566a17fa1080d6e3008b964e367825225a09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140086
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141478
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
The document had a registered selection listener that created UNO
cursors (bookmarks) in its selectionChanged() callback. Once an UNO API
user tried to delete a bookmark, Writer crashed.
What happens is that sw::mark::MarkManager::deleteMark() created an
iterator pointing to an element of m_vAllMarks, then called
sw::mark::Bookmark::DeregisterFromDoc(), which indirectly calls
SwXTextView::NotifySelChanged(), which invokes UNO selection listeners,
which are allowed to create UNO cursors, which modify m_vAllMarks,
invalidating the iterator.
Fix the problem by first creating a non-const iterator based on ppMark,
then conditionally invoke DeregisterFromDoc(). If DeregisterFromDoc() is
called, then update the iterator based on pMark, so it is valid by the
time we erase the bookmark from m_vAllMarks.
This was not the problem when erasing the same mark from m_vBookmarks,
as in that case the iterator creation and the erase() both happen before
the de-registration.
Change-Id: Iaae95ec9c3038e8ee3b84408094844d0ff678213
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141489
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
This happens, for unknown reason, when buttons that indicate outline
content is folded are near the current cursor position when the
options dialog is used to turn outline-folding off. This patch takes a
new approach to handle outline-folding options, that doesn't exhibit
this anomaly, by using the ShowOutlineContentVisibilityButton UNO
function. For the purpose of sanity and to aid understandability of
what is going on here, extra effort has been made to provide useful
comments and descriptive variable naming.
Change-Id: I8c3d4c207791f0ba151d799af22e1998aa7c3768
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141353
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
This takes the time to apply the formating from "who knows how long" to about 500ms on my machine.
Change-Id: I202d023c58ea191bf080ef3a85068e8acab52dec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141463
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
It's never included.
It passed "make check" on Linux.
Change-Id: Ia341d898aa64d9dd88f96a2a1c61ae5e873bdb5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141480
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
It's never included.
It passed "make check" on Linux.
Change-Id: I1a58f36b081d85ad18c2794120f3a343b30f0ac8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141476
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
It's never included.
It passed "make check" on Linux.
Change-Id: Iadcc59130374ae318fff5dd1674d59c2906cedd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141477
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ie725e9eb523097ee6a5e159e45c29e0f16a72fcf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141474
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Unlike in Impress, horizontal position is not just an integer, but it's
3 numbers: 2 for the anchor and the 3rd for the relative position.
Change-Id: Ibcfed3dff480934659bffa6471e09dfa992fe2bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141472
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
If the index lies within a special section, the position of the anchor of the corresponding section will used to search the node of the paragraph. This patch searches for the outline node of the found paragraph in order to find all the corresponding sub indexes.
Change-Id: I9be4bdc0768d5d0d5987d47d37e41acc5009cca8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141344
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
...which was missing in ::create2DDecomposition.
Change-Id: I585aa884e4d19bf6f34783d254f502a4c3dd6733
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141470
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
<https://github.com/llvm/llvm-project/commit/bcd9ba2b7e64f6ce54defd2fa73fc8e0fee5707c>
"[clang] Track the templated entity in type substitution."
Change-Id: I314d1567512dc0332b3c61c95978b0230f52b274
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141462
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ifc8cda54bfb817f30aa7a44dda4fb8574d2fe698
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141487
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
Change-Id: I4719b58d7a3978e850cce29b9ca9c99035cb5e55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141486
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
Change-Id: Idebd2eef29230056caa605c79028e46d34891c44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141485
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Apparently not there in basic from prior to its open-sourcing.
Change-Id: I9b2da35abfc9971ee380c68f33e239fe63b381c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141483
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
When walking through a form, the current formfield is highlighted,
and pressing space should toggle a checkmarkField. Well, GetPoint
was pointing at the end of the selection, and so we were getting
a "sw/source/uibase/docvw/edtwin.cxx:2499: Where is my FieldMark??".
My attempt at a unit test caused random crashing (I assume it was
the protection-editing dialog box) and I never did succeed
in getting the checkbox to report an unchecked status anyway.
Change-Id: I0f28fb117a84cb5e56463a65d5bb72bbac174865
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141424
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
|
|
Change-Id: Ia4f795dc9bb59b6d1ee54daae49ac195bbc92a0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141434
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change-Id: Idf8d83bbbcf8f802743f760dcca2476b0e3e8836
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141450
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: Icc505f61f3df0736d33ffe7d5702dffc42dd1d79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141475
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ib1549e14b849786abe3a038ac8542c6a8ec1f11b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141473
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I3dbced70b7341807451d66d8e70ed61edb44592b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141464
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ia5139f7255ba0e78f7089a4313a41d583ae62961
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141275
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
To be able to buffer BitmapData which is created based on
Bitmap class data, move the access to
basegfx::SystemDependentDataHolder from classes where it
was used until now (WinSalBitmap and SvpSalBitmap) up to
SalBitmap which is accessible outside vcl.
This is a reorder plus a virtual access method to
detect/access that helper layer, no functional change.
It will be needed for system-dependent renderers when
they want to use that standard buffering e.g. already
used in the headless & windows backends.
Change-Id: Ib30e7b98e722b977bb0c87ad253e3ffc1841e87e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141456
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|
|
Change-Id: I18ccdda2e4106897b412ec73fbd4521ede8f0545
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141460
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
no need to inherit from ScBootstrapFixture, this class doesn't
use anything from there
Change-Id: Ib3d2bfa2161c05a838d1c7a554a3d3e670e9c4a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141465
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
to follow what the rest of ScBootstrapFixture tests do
Change-Id: I9e3df8a53ee2b2d56dcc822a783a9f19a531b791
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141461
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Because it sometimes hangs, see https://gerrit.libreoffice.org/c/core/+/140985
Change-Id: Iee0d4584256441dff77b0548827fafbd0b559aa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141400
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Fixes CVE-2022-40304 and CVE-2022-40303.
Change-Id: I5be3fd20ccf57596808a26b742aca325ac16f29b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141448
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Add accessibility check and relevant test for a document that uses
multiple spaces for spacing
Change-Id: Ib92471c50a25ead28f2b6c7d5e00ed222d4b429e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141267
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Add accessibility check and relevant test for a document that uses
newlines for spacing
Change-Id: I14f14db5c51cbad1ee184e58eec8ff28563ba92a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141252
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I485f8ab3d8039cd1e05e3af1beb002ec63d9eb32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141458
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
Change-Id: I983713fa415b82dc4f526fd28e4e8f179f0f06d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141451
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
no need to inherit from ScBootstrapFixture, this class doesn't
use anything from there
Change-Id: Id3cf385c6ff1d94bfe93b855780e70a4d8e8d0a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141453
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...during CppunitTest_sw_uiwriter5,
> DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter5.so
> workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter5.so: undefined symbol: _ZTI10SwTabFrame"
apparently since c809867f3ee92a8eb36cbab840bd6d6c5b3b1c26 "tdf#150976 sw: fix
tracked deletion of row with nested table"
Change-Id: I2a2d5ff53a0e58da9373096ac6a9592410663b5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141449
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
it helps to reduce duplicated code
Change-Id: Ia6769d6fc91bc2315903e2cce69e7187ee362f5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141454
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Iae1ae76c1903ff3155da2dd407f1237c29f91840
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141375
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The unit test just consists of adding a
"WordBasic.MsgBox()" to the vba code in testVBA.docm.
make CppunitTest_sw_macros_test
or just open the file manually for an easy-to-run experience.
Change-Id: I38edfee42649fcc85f0f535a2c9861c45038fa0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141347
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|