summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-22Revert "tdf114724: uitest: make test less time.sleep dependent"Xisco Faulí
This reverts commit 634ce6f2d87a30b8abd2e8c67668e3bb5d87406b. See https://gerrit.libreoffice.org/c/core/+/92616 Change-Id: I642843ab16450d1a6b15d5e955495efbbfa7822a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92539 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-22Include <deque>Mike Kaganski
Change-Id: I0d2536038782f0ab6436a6527f24a2e0e737e409 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92677 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-22missing separatorCaolán McNamara
Change-Id: Ie0a7b54ef06e7f318f730a151c3dd58f6d2e0a30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92683 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22update creditsChristian Lohmaier
Change-Id: Ic21818bfa1b45f06344cbe92c5d57324654a5e04
2020-04-22tdf#42949 Fix IWYU warnings in reportdesign/*/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If8549e62de1007fccf9a5becac356f8d1ffc5090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92513 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-22use without-latest-c++ in coverity confCaolán McNamara
Change-Id: Ie72fb05ef0d687c3f442f6372f591f94815cf9d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92674 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22tdf#132242: add "None" entry for "frac" OpenTypeFeature (vcl)Julien Nabet
Change-Id: I260b37a847887c79645db8015938f8bbbe6772d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92591 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-22some of these need to be GtkToggleToolButtonCaolán McNamara
Change-Id: I1ebfac22b006de560c5208906b4d2a1efc011f8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92654 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22uiobject.hxx only needs forward declaresCaolán McNamara
and update pches accordingly Change-Id: I411712532fd85961bffe6678416fcdc1d9c7f53d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22seems a poor idea to increment a vector iter by COMBOBOX_APPENDCaolán McNamara
which is SAL_MAX_INT32, in the (presumably never happens) fallback case Change-Id: If425c6ce1bd9937ba2b26f6c68231640a2f13273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22Make hide lok dialog test reliableSzymon Kłos
On slower machines actions were reported in different order Change-Id: I8effea3a9d114ffb0e9ebed2c18fde046490fe07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92615 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-22Add include needed for std::minMike Kaganski
Change-Id: Ia7bb9a99c029d9ad47371b5ae999fd9808c4cbac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92537 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-22typeinfo for VclGrid still needed with --enable-mergelibsStephan Bergmann
...for the dynamic_casts in SAL_WARN_IF and assertin VclBuilder::get, > LNK] Library/libbiblo.so > include/vcl/builder.hxx:430: error: undefined reference to 'typeinfo for VclGrid' > include/vcl/builder.hxx:430: error: undefined reference to 'typeinfo for VclGrid' > include/vcl/builder.hxx:433: error: undefined reference to 'typeinfo for VclGrid' > collect2: error: ld returned 1 exit status > make[1]: *** [extensions/Library_bib.mk:12: instdir/program/libbiblo.so] Error 1 (see e.g., <https://ci.libreoffice.org/job/lo_tb_random_config_linux/2358/>). Broken with 01159643623de55f9e1de84d568032ca919dbd8f "make more classes private in mergedlibs mode". Change-Id: Ic20abe22b52026907a5624993008e497b173d14c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92613 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-22Partial revert "make more classes private in mergedlibs"Thorsten Behrens
Turns out x86 linux needs some item vtables in cui, which does not get linked into mergedlib. This reverts bits of commit 01159643623de55f9e1de84d568032ca919dbd8f Change-Id: I442aa2efca9941e9c5bf656c73cc5a5577db8781 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92658 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-22Resolves build error from I4c2107b8120797a7cd532b59ca5ccb58ab61a2aeHeiko Tietze
Change-Id: I2791a51104d73daae5f140ee5b396aa2a64857ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92656 Tested-by: Rene Engelhard <rene@debian.org> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-21Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 51d027d333bc4e92612f62e55ac2ac22cdedf7b8 - Fix typo Change-Id: I09335c448cb058fec91cb6caf33c503c9a6e971d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92642 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-21tdf#128049: sd: Add unittestXisco Fauli
Change-Id: Ic33aa2c023c9c5e8b5a67273674579ac7673a2b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92637 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-21Fix warning when compiling for iOS: unused parameter 'bCreateParentDirs'Tor Lillqvist
Change-Id: I3d27837ea49ad964a40f53083d90f2a287bae8a0
2020-04-21drop unneeded includeCaolán McNamara
Change-Id: I38a3ab4db7f74277074ed87410d14e2e9b3a5ea7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92621 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-21Relates tdf#130778 - Branding for 7.0Heiko Tietze
Better splash screen images Start center image depending on initial size Change-Id: I18823e04537bb217eaa7610c71c8021907dbbb94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92583 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-21uitest: no need to use time.sleep hereXisco Fauli
Change-Id: I58b1fa80b6a570f8214255398f3b91f62590fd6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92629 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-21tdf114724: uitest: make test less time.sleep dependentXisco Fauli
Instead, check the focus moved to the bottom and back to the first element Execution times goes 17.232 from to 5.521 for me Change-Id: I816c197f44b68a1b9ab8686de191a743cbc78eb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92616 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-21uitest: remove unneeded time.sleepXisco Fauli
Change-Id: I618a17fb8347d1f935caaef54738299863ddbb49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92612 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-21uitest: use while loop instead of time.sleepXisco Fauli
Execution times goes from 3.807 to 2.718 for me Change-Id: I9c93417d2678c64a8d9a90b0a18b4d1210c8fdd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92624 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-21tdf#42949 Fix IWYU warnings in lotuswordpro/source/filter/*hxxGabor Kelemen
Also drop the now unused pass-through header lotuswordpro/inc/lwpheader.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I3e2b9c4b5d91651dbefb83d13006f72eb54e62bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92498 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-21Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to 1ce06d6f5faef38ef11d937a0a447784aa526c8c - fragment heading insertions Change-Id: Id619066cf1d40ed760ff774003991d0f16343a99 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92441 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-21CLANG_C -> CLANG_CCLuboš Luňák
Change-Id: I50ed05116df3f295af6406f0ee45610d9e1e031e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92619 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-21better handling of SSEx,AVX intrinsics for ClangLuboš Luňák
Clang-cl interprets MSVC's -arch option a bit differently (for MSVC -arch:SSE2 seems to mean SSE2+, but SSE2-only for Clang). So use Clang's -mxxx options when using clang-cl as CC/CXX. Also check intrinsics once again if using CLANG_CC/CXX to compile Skia. Change-Id: I64cd368ef4e5f4fcf1dbe877a1129f418d273a47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92618 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-21tdf#127109 Writer: fix Undo entry "Delete $1"László Németh
Regression from commit b69c518df68ce673b28d589da6626bd3d860f309 (tdf#54819 keep style & numbering at tracked deletion) Change-Id: I3041cc5a70d00bea14d7be1c275bb7d2a22e768a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92614 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-21don't try to use -fno-enforce-eh-specs with ClangLuboš Luňák
The use can be triggered when using gb_LinkTarget_use_clang, but Clang unlike GCC doesn't know the option. Change-Id: Idd109a09127061a72940de9229f0dd34b221375d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92611 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-21uitest: re-enable test using sleepXisco Fauli
and instead of sleep(3) use timeout = time.time() + 3 while condition != True and time.time() < timeout: sleep(0.1) execution time of this particular test goes from 7.785 seconds to 3.343 for me Change-Id: I7c99385ccd858dfbb77cfc6e53a0b3f1a8b57c73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92588 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-21weld sidebar text panelCaolán McNamara
includes weld SvxFontNameToolBoxControl Change-Id: Ie48338243600c07f9f8c609701c137175133f8e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92585 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-21ofz#21701 Fuzzing build failureCaolán McNamara
Change-Id: I4a8042f4f3c117a2268b06789a99cf0ba6dbc3f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92608 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-21use better number sof LOK fields in ScTabViewNoel Grandin
LOK is (a)busing tools::Rectangle to calculate coverage, which triggers my new asserts because the existing numbers turn into RECT_EMPTY. Change-Id: Ib3cd6a63ebaad7dc9887567dd2463a0ef5cfc900 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-21return shared_ptr from createDocumentElementNoel Grandin
which is what the only callsite wants Change-Id: Ica83e7de89ec56c9b4f742f3da19d295a3250a9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92610 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-21use weak_ptr properlyNoel Grandin
just call lock() instead of manually calling expired() Change-Id: If76826fb62092b00fce25c53cf6be89b72d40c4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92609 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-04-21vcl: cleanup swaths of commented codeThorsten Behrens
Change-Id: I7acff3d136794dcb0f044bb3922fafeb13b6fa5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92600 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-21return shared_ptr from AnyWidget::CloneNoel Grandin
which is what the only call-site wants Change-Id: I74aa7b9ce059890eb1bdd84d7a0a331ecf227be3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92606 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-21don't add maUserItemSize to text width, just use it as-isCaolán McNamara
which means we don't need the reverse calculation in the style dropdown to force that result Change-Id: I3c8421e964af4339abfacb455b75db5ad75456fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-21weld FontNameBoxCaolán McNamara
with custom row rendering Change-Id: Ia909b5b9ad56b6ea4611e9ea0a1e2cb0064a8cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-21work around copy-to-self SkSurface::draw() being buggy (tdf#132051)Luboš Luňák
This may become the actual fix or may be removed later depending on the outcome of https://groups.google.com/d/msgid/skia-discuss/202004151937.05051.l.lunak%40collabora.com . Change-Id: I709f3e7bffbe86ddb2f6d75724bf30e4b0f0116e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92587 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-21tdf#131775 DOCX DrawingML shape import: fix missing spacingTibor Nagy
Character spacing of grouped shapes wasn't imported. Co-Author: Balazs Regenyi, Szabolcs Toth Change-Id: I9c4f204a5ab7c7e55e26968a71b315d84e5d8515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91490 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-21tdf#131446 DOCX import: restrict IncreasedAnchoredObjectSpacing furtherMiklos Vajna
Regression from commit 8b73bafbc18acb4dd8911d2f2de8158d98eb6144 (tdf#115719 DOCX import: increase paragraph spacing for anchored objects, 2018-02-14), this is another case where the workaround for the Word layout bug is not needed. tdf115719.docx and tdf115719b.docx are tweaked to have <wp:anchor ... behindDoc="1"> for 1 shape, as the original bugdoc has it. This allows us to render both the tdf#115719 and tdf#131446 bug documents the same way as Word does. Change-Id: I0c3f197c3360882cd64f8dcf286c6051dc11d674 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92599 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-21tdf#132039 Image Dialog: The field file name is to shortandreas kainz
Change-Id: I758a43b207186e98501eb8c58d3e6435463a451c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92576 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-21Fix storage access after savingSamuel Mehrbrodt
Change-Id: I2cd664ac2ca5e80c566efee35bd34e7223501d75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92605 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-04-21Sukapura: Update indentation iconsRizal Muttaqin
Change-Id: I9d676e6b554e96b0422c1b0e7c9e59087db5482b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92604 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-21tdf#42982: Improve UNO API error reportingIan Barkley-Yeung
Add more info to the exception in AccessibleIconChoiceCtrl::getAccessibleChild() Change-Id: Ie6e778f76719eb463508647f0367e089ab0ae8ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-21CreateDocumentInfoDialog should return shared_ptrNoel Grandin
which is what it's only call site wants Change-Id: I1c2c2ed3a91a3376af142ac9a5d6993a2186d660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92590 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 8bc7adda21caae983a74b72dbbc23bc805de0580 - tdf#132227 Add MySQL direct connection help page Change-Id: Icc0393d89799349701136d6b8e98519732ec0fa5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92601 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-21Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to 4780abb01dd5fa2356f64bb096d99288b019160a - tdf129366 add Resume in 'Error handling' funcs Change-Id: I48557474f6cedd357f03e767eabd09b6df8cd5b1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92440 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>